r314056 - Promote storage-only __fp16 vector operands to float vectors.

Author: ahatanak Date: Fri Sep 22 22:02:02 2017 New Revision: 314056 URL: http://llvm.org/viewvc/llvm-project?rev=314056=rev Log: Promote storage-only __fp16 vector operands to float vectors. This commit fixes a bug in the handling of storage-only __fp16 vectors where clang didn't promote __fp16

r314054 - Correctly compute linkage for members of internal linkage classes.

Author: rsmith Date: Fri Sep 22 21:02:17 2017 New Revision: 314054 URL: http://llvm.org/viewvc/llvm-project?rev=314054=rev Log: Correctly compute linkage for members of internal linkage classes. We used to give such members no linkage instead of giving them the linkage of the class. Modified:

r314051 - Commit missing fixes for tool_file_rename

Author: rnk Date: Fri Sep 22 18:04:42 2017 New Revision: 314051 URL: http://llvm.org/viewvc/llvm-project?rev=314051=rev Log: Commit missing fixes for tool_file_rename Modified: cfe/trunk/unittests/CrossTU/CrossTranslationUnitTest.cpp cfe/trunk/unittests/Frontend/ASTUnitTest.cpp

[libclc] r314050 - [Support] Rename tool_output_file to ToolOutputFile, NFC

Author: rnk Date: Fri Sep 22 18:03:17 2017 New Revision: 314050 URL: http://llvm.org/viewvc/llvm-project?rev=314050=rev Log: [Support] Rename tool_output_file to ToolOutputFile, NFC This class isn't similar to anything from the STL, so it shouldn't use the STL naming conventions. Modified:

r314050 - [Support] Rename tool_output_file to ToolOutputFile, NFC

Author: rnk Date: Fri Sep 22 18:03:17 2017 New Revision: 314050 URL: http://llvm.org/viewvc/llvm-project?rev=314050=rev Log: [Support] Rename tool_output_file to ToolOutputFile, NFC This class isn't similar to anything from the STL, so it shouldn't use the STL naming conventions. Modified:

[clang-tools-extra] r314050 - [Support] Rename tool_output_file to ToolOutputFile, NFC

Author: rnk Date: Fri Sep 22 18:03:17 2017 New Revision: 314050 URL: http://llvm.org/viewvc/llvm-project?rev=314050=rev Log: [Support] Rename tool_output_file to ToolOutputFile, NFC This class isn't similar to anything from the STL, so it shouldn't use the STL naming conventions. Modified:

Re: r313386 - [Sema] Error out early for tags defined inside an enumeration.

> On Sep 21, 2017, at 15:17, Richard Smith wrote: > > On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits > > wrote: > Author: vsapsai > Date: Fri Sep 15 12:51:42 2017 > New Revision: 313386 > >

Re: r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

r314047. On 22 September 2017 at 16:36, Richard Smith wrote: > Investigating... > > > On 22 September 2017 at 15:58, Vitaly Buka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> This breaks check-clang-tools >>

[clang-tools-extra] r314047 - Fix up clang-tidy after clang r314037.

Author: rsmith Date: Fri Sep 22 16:47:20 2017 New Revision: 314047 URL: http://llvm.org/viewvc/llvm-project?rev=314047=rev Log: Fix up clang-tidy after clang r314037. Modified: clang-tools-extra/trunk/clang-tidy/misc/DefinitionsInHeadersCheck.cpp

Re: r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

Investigating... On 22 September 2017 at 15:58, Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This breaks check-clang-tools > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ > 64-scei-ps4-windows10pro-fast/builds/12310/steps/test/logs/stdio > > On Fri, Sep 22, 2017 at

r314042 - [Analyzer] Fix minor errors in python scripts.

Author: george.karpenkov Date: Fri Sep 22 15:58:46 2017 New Revision: 314042 URL: http://llvm.org/viewvc/llvm-project?rev=314042=rev Log: [Analyzer] Fix minor errors in python scripts. Modified: cfe/trunk/utils/analyzer/SATestBuild.py cfe/trunk/utils/analyzer/SATestUpdateDiffs.py

Re: r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

This breaks check-clang-tools http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12310/steps/test/logs/stdio On Fri, Sep 22, 2017 at 3:21 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Sep 22 15:21:44

r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

Author: rsmith Date: Fri Sep 22 15:21:44 2017 New Revision: 314037 URL: http://llvm.org/viewvc/llvm-project?rev=314037=rev Log: DR1113: anonymous namespaces formally give their contents internal linkage. This doesn't affect our code generation in any material way -- we already give such

r314036 - [test] Enable clang-func-mapping as a test dep with the analyzer

Author: vedantk Date: Fri Sep 22 15:17:10 2017 New Revision: 314036 URL: http://llvm.org/viewvc/llvm-project?rev=314036=rev Log: [test] Enable clang-func-mapping as a test dep with the analyzer clang-func-mapping should not be a test dependency when the static analyzer isn't being built.

r314035 - Fix unused variable warning in non-debug builds.

Author: rtrieu Date: Fri Sep 22 15:16:13 2017 New Revision: 314035 URL: http://llvm.org/viewvc/llvm-project?rev=314035=rev Log: Fix unused variable warning in non-debug builds. Modified: cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp Modified: cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp

r314033 - clang-format plugin: Add missing NL (new line) at EOF (end of file)

Author: hans Date: Fri Sep 22 14:47:39 2017 New Revision: 314033 URL: http://llvm.org/viewvc/llvm-project?rev=314033=rev Log: clang-format plugin: Add missing NL (new line) at EOF (end of file) clang-format.exe removes trailing new lines at end of file. However, if no NL is found at EOF one

r314029 - [CodeGen][ObjC] Build the global block structure before emitting the

Author: ahatanak Date: Fri Sep 22 14:32:06 2017 New Revision: 314029 URL: http://llvm.org/viewvc/llvm-project?rev=314029=rev Log: [CodeGen][ObjC] Build the global block structure before emitting the body of global block invoke functions. This commit fixes an infinite loop in IRGen that occurs

[PATCH] D38151: [clang] Fix isExternC matcher docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL314022: [clang] Fix isExternC matcher docs (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D38151?vs=116251=116386#toc Repository: rL LLVM https://reviews.llvm.org/D38151

[PATCH] D38186: Add the new -Wnull-pointer-arithmetic warnings to the release notes

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang. https://reviews.llvm.org/D38186 Files: ReleaseNotes.rst Index: ReleaseNotes.rst === --- ReleaseNotes.rst +++ ReleaseNotes.rst @@ -78,6 +78,12 @@

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth updated this revision to Diff 116387. Nebiroth marked 2 inline comments as done. Nebiroth added a comment. Rebased on latest version. Corrected code style issues in test file. https://reviews.llvm.org/D36150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

r314022 - [clang] Fix isExternC matcher docs

Author: alexshap Date: Fri Sep 22 12:29:38 2017 New Revision: 314022 URL: http://llvm.org/viewvc/llvm-project?rev=314022=rev Log: [clang] Fix isExternC matcher docs The wording in the documentation for the matcher isExternC appears to be misleading since this matcher is applicable to functions

[clang-tools-extra] r314020 - [clangd] Updated gold for completion tests after cfe changes.

Author: ibiryukov Date: Fri Sep 22 12:07:45 2017 New Revision: 314020 URL: http://llvm.org/viewvc/llvm-project?rev=314020=rev Log: [clangd] Updated gold for completion tests after cfe changes. Modified: clang-tools-extra/trunk/test/clangd/completion-snippet.test

[PATCH] D38081: Set completion priority of destructors and operators to CCP_Unlikely.

This revision was automatically updated to reflect the committed changes. Closed by commit rL314019: Set completion priority of destructors and operators to CCP_Unlikely. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38081 Files:

r314019 - Set completion priority of destructors and operators to CCP_Unlikely.

Author: ibiryukov Date: Fri Sep 22 12:07:37 2017 New Revision: 314019 URL: http://llvm.org/viewvc/llvm-project?rev=314019=rev Log: Set completion priority of destructors and operators to CCP_Unlikely. Summary: It will move destructors and operators to the end of completion list. Destructors and

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: test/Sema/inline-asm-validate-amdgpu.cl:74 +__asm("v_add_f64_e64 v[1:2], v[3:4], v[5:6]" : "=v[1:2]"(ci) : "v[3:4]"(ai), "v[5:6]"(bi) : ); //expected-error {{invalid output constraint

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

yaxunl updated this revision to Diff 116383. yaxunl marked 4 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Fix typo. https://reviews.llvm.org/D37568 Files: lib/Basic/Targets/AMDGPU.h test/CodeGenOpenCL/amdgcn-inline-asm.cl

Re: D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

On 09/22/2017 01:45 PM, Sylvestre Ledru wrote: On 22/09/2017 20:27, Hal Finkel wrote: On 09/22/2017 01:09 PM, Kaylor, Andrew wrote: The reason I introduced this patch to begin with is that there are circumstances under which the optimizer will eliminate loads from addresses that were

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

bruno added a comment. Hi Boris, This is a handy option, very nice. Can you also add testcases? Comment at: lib/Frontend/CompilerInvocation.cpp:1561 + + auto Buf = FileMgr.getBufferForFile(File); + if (!Buf) { `auto Buf` -> `auto *Buf`

[PATCH] D38081: Set completion priority of destructors and operators to CCP_Unlikely.

ilya-biryukov added a comment. Thanks for the review! Sorry for inappropriate ping, I'll make sure to stick to the policy. https://reviews.llvm.org/D38081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

On 22/09/2017 20:27, Hal Finkel wrote: > > > On 09/22/2017 01:09 PM, Kaylor, Andrew wrote: >> The reason I introduced this patch to begin with is that there are >> circumstances under which the optimizer will eliminate loads from addresses >> that were generated based on the null pointer

[PATCH] D38159: [clang] Fix printf fixit for objc specific types

This revision was automatically updated to reflect the committed changes. Closed by commit rL314011: [clang] Fix printf fixit for objc specific types (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D38159?vs=116288=116380#toc Repository: rL LLVM

[PATCH] D38081: Set completion priority of destructors and operators to CCP_Unlikely.

ilya-biryukov updated this revision to Diff 116381. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Removed redundant NameKind:: qualifiers. https://reviews.llvm.org/D38081 Files: lib/Sema/SemaCodeComplete.cpp test/Index/complete-access-checks.cpp

r314013 - [lit.cfg] Avoid concatenating which(clang-func-mapping) if it's missing

Author: vedantk Date: Fri Sep 22 11:42:28 2017 New Revision: 314013 URL: http://llvm.org/viewvc/llvm-project?rev=314013=rev Log: [lit.cfg] Avoid concatenating which(clang-func-mapping) if it's missing This un-breaks a lit workflow where you run lit tests from a test sub-directory within clang

r314011 - [clang] Fix printf fixit for objc specific types

Author: alexshap Date: Fri Sep 22 11:36:06 2017 New Revision: 314011 URL: http://llvm.org/viewvc/llvm-project?rev=314011=rev Log: [clang] Fix printf fixit for objc specific types For the triple thumbv7-apple-ios8.0.0 ssize_t is long and size_t is unsigned long, while NSInteger is int and

[PATCH] D37573: [bindings] add Cursor.linkage

compnerd closed this revision. compnerd added a comment. SVN r314009 https://reviews.llvm.org/D37573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r314009 - bindings: expose Linkage to the python bindings

Author: compnerd Date: Fri Sep 22 11:35:09 2017 New Revision: 314009 URL: http://llvm.org/viewvc/llvm-project?rev=314009=rev Log: bindings: expose Linkage to the python bindings Add Python bindings for the 'clang_getCursorLinkage', and tests to validate the functionality. Patch by Masud Rahman!

Re: D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

On 09/22/2017 01:09 PM, Kaylor, Andrew wrote: The reason I introduced this patch to begin with is that there are circumstances under which the optimizer will eliminate loads from addresses that were generated based on the null pointer arithmetic (because clang previously emitted a null-based

r314002 - [Coverage] Add an option to emit limited coverage info

Author: vedantk Date: Fri Sep 22 11:23:04 2017 New Revision: 314002 URL: http://llvm.org/viewvc/llvm-project?rev=314002=rev Log: [Coverage] Add an option to emit limited coverage info Add an option to emit limited coverage info for unused decls. It's just a cl::opt for now to allow us to

[PATCH] D37544: [ubsan] Skip alignment checks which are folded away

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38081: Set completion priority of destructors and operators to CCP_Unlikely.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Nice, LGTM Please keep in mind that LLVM follows a weekly ping rate: https://llvm.org/docs/DeveloperPolicy.html#code-reviews . Comment at:

RE: D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

The reason I introduced this patch to begin with is that there are circumstances under which the optimizer will eliminate loads from addresses that were generated based on the null pointer arithmetic (because clang previously emitted a null-based GEP and still will in the Firefox case because

[PATCH] D32520: Support __fp16 vectors

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks Akira. https://reviews.llvm.org/D32520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

bader added inline comments. Comment at: test/CodeGenOpenCL/vectorLoadStore.cl:7 +typedef float float4 __attribute((ext_vector_type(4))); +; Can we remove this line? Comment at: test/CodeGenOpenCL/vectorLoadStore.cl:15 + +// CHECK: define

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl marked 10 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:113 + +llvm::Value *CGOpenCLRuntime::emitOpenCLEnqueuedBlock(CodeGenFunction , + const Expr *E) {

[PATCH] D37544: [ubsan] Skip alignment checks which are folded away

vsk updated this revision to Diff 116374. vsk added a comment. - Tighten up lit test. https://reviews.llvm.org/D37544 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/ubsan-suppress-checks.cpp Index: test/CodeGenCXX/ubsan-suppress-checks.cpp

[PATCH] D37544: [ubsan] Skip alignment checks which are folded away

vsk added a comment. Sorry, I see the issue now. The pre-patch IR looked like "br i1 true, label %continue, label %diagnose", so there was no alignment check, per-se. https://reviews.llvm.org/D37544 ___ cfe-commits mailing list

[PATCH] D37573: [bindings] add Cursor.linkage

compnerd added a comment. Sure, Ill get this merged shortly. https://reviews.llvm.org/D37573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D37804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37544: [ubsan] Skip alignment checks which are folded away

arphaman added a comment. This one passes for me too without the code change. https://reviews.llvm.org/D37544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38074: Fix TBAA information for reference accesses

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure, that's fine. LGTM. https://reviews.llvm.org/D38074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r313997 - [index] Generate class & metaclass manglings for objc

Author: kastiglione Date: Fri Sep 22 09:58:57 2017 New Revision: 313997 URL: http://llvm.org/viewvc/llvm-project?rev=313997=rev Log: [index] Generate class & metaclass manglings for objc Summary: ObjC classes have two associated symbols, one for the class and one for the metaclass. This change

r313995 - [OPENMP] Handle re-declaration of captured variables in CodeGen.

Author: abataev Date: Fri Sep 22 09:56:13 2017 New Revision: 313995 URL: http://llvm.org/viewvc/llvm-project?rev=313995=rev Log: [OPENMP] Handle re-declaration of captured variables in CodeGen. If the captured variable has re-declaration we may end up with the situation where the captured

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl updated this revision to Diff 116363. yaxunl edited the summary of this revision. yaxunl added a comment. Add custom fields to block and target hooks to fill them. https://reviews.llvm.org/D37822 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGOpenCLRuntime.cpp

[PATCH] D38046: [Atomic][X8664] set max atomic inline/promote width according to the target

This revision was automatically updated to reflect the committed changes. Closed by commit rL313992: [Atomic][X8664] set max atomic inline width according to the target (authored by wmi). Changed prior to commit: https://reviews.llvm.org/D38046?vs=116107=116362#toc Repository: rL LLVM

r313992 - [Atomic][X8664] set max atomic inline width according to the target

Author: wmi Date: Fri Sep 22 09:30:00 2017 New Revision: 313992 URL: http://llvm.org/viewvc/llvm-project?rev=313992=rev Log: [Atomic][X8664] set max atomic inline width according to the target This is to fix PR31620. MaxAtomicInlineWidth is set to 128 for x86_64. However for target without cx16

r313991 - Fix unused variable warning. NFCI.

Author: rksimon Date: Fri Sep 22 09:26:17 2017 New Revision: 313991 URL: http://llvm.org/viewvc/llvm-project?rev=313991=rev Log: Fix unused variable warning. NFCI. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp URL:

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

sylvestre.ledru added a comment. For the record, Firefox was using this trick. This patch is breaking a ci build (clang trunk + warning as errors) More information here: https://bugzilla.mozilla.org/show_bug.cgi?id=1402362 Repository: rL LLVM https://reviews.llvm.org/D37042

[PATCH] D38113: OpenCL: Assume functions are convergent

hfinkel added a comment. In https://reviews.llvm.org/D38113#877874, @Anastasia wrote: > The problem of adding this attribute conservatively for all functions is that > it prevents some optimizations to happen. I agree to commit this as a > temporary fix to guarantee correctness of generated

[PATCH] D38179: [clang-tidy] Handle unions in modernize-use-equals-default check

malcolm.parsons created this revision. Herald added subscribers: xazax.hun, JDevlieghere. Do not replace the constructor or destructor of a union with =default if it would be implicitly deleted. Fixes: PR27926 https://reviews.llvm.org/D38179 Files:

[PATCH] D38113: OpenCL: Assume functions are convergent

jlebar added a comment. > Yes, that's why if it would be responsibility of the kernel developer to > specify this explicitly we could avoid this complications in the compiler. > But if we add it into the language now we still need to support the > correctness for the code written with the

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

r.stahl added a comment. In a similar case, static inline functions are an issue. inc.h void foo(); static inline void wow() { int a = *(int*)0; } main.c #include "inc.h" void moo() { foo(); wow(); } other.c #include "inc.h" void foo() { wow();

[PATCH] D38171: Implement clang-tidy check aliases.

lebedev.ri added a comment. On a somewhat related note, since this is already talking about aliases I feel like the current handling of the clang-tidy check aliases needs adjusting. If one enables all the checks (`Checks: '*'`), and then disables some of them on check-by-check basis, if the

[PATCH] D38171: Implement clang-tidy check aliases.

alexfh added a comment. András, that's definitely an interesting idea. However, it might be interesting to explore a more principled approach: 1. Make `clang-diagnostic-*` checks first-class citizens and take full control of all diagnostics, i.e. disable all Clang diagnostics by default, and

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

barancsuk added a comment. I attached the results of the tests. The warnings are categorized into false positives and renaming opportunities. F5376033: PostgreSQL F5376032: FFmpeg F5376031: LLVM

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

Anastasia updated this revision to Diff 116345. Anastasia added a comment. Created BitCast or AddrSpaceCast conditionally. https://reviews.llvm.org/D37804 Files: lib/CodeGen/CGBuilder.h lib/CodeGen/CGExpr.cpp test/CodeGenOpenCL/vectorLoadStore.cl Index:

[PATCH] D38040: [OpenMP] Add an additional test for D34888

Hahnfeld added a comment. In https://reviews.llvm.org/D38040#878441, @gtbercea wrote: > The test is verifying whether the parameter is passed to the kernel > correctly. I believe it was not passed as a reference before the patch. Ah, right: This isn't checked anywhere before. Maybe add a

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi added a comment. Yes, please do the commit, thank you. In https://reviews.llvm.org/D37861#878194, @efriedma wrote: > LGTM. > > Do you want me to commit this for you? https://reviews.llvm.org/D37861 ___ cfe-commits mailing list

[PATCH] D38159: [clang] Fix printf fixit for objc specific types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a few minor nits, LGTM! Comment at: test/FixIt/fixit-format-ios.m:2 +// RUN: cp %s %t +// RUN: %clang_cc1 -triple thumbv7-apple-ios8.0.0

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

klimek added a comment. The run on llvm indicates that we don't want this to trigger if the base class doesn't have anything to copy (that is, no fields & a defaulted copy-ctor, or an empty copy-ctor). https://reviews.llvm.org/D33722 ___

[PATCH] D38171: Implement clang-tidy check aliases.

aaron.ballman added a comment. Thank you for working on this -- it's very nice functionality! Comment at: clang-tidy/cert/CERTTidyModule.cpp:79 + void addWarningCheckAliases( + llvm::DenseMap ) { +WarningCheckAliases.insert(

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

r.stahl added a comment. While testing this I stumbled upon a crash with the following test case: inc.h #define BASE ((int*)0) void foo(); main.c: #include "inc.h" void moo() { int a = BASE[0]; foo(); } other.c #include "inc.h" void foo() { int a =

[PATCH] D38151: [clang] Fix isExternC matcher docs

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D38151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38113: OpenCL: Assume functions are convergent

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/convergent.cl:130 +// CHECK: attributes #0 = { noinline norecurse nounwind " +// CHECK: attributes #1 = { {{[^}]*}}convergent{{[^}]*}} } +// CHECK: attributes #2 = { {{[^}]*}}convergent{{[^}]*}} }

[PATCH] D38113: OpenCL: Assume functions are convergent

Anastasia added a comment. In https://reviews.llvm.org/D38113#877906, @jlebar wrote: > > The problem of adding this attribute conservatively for all functions is > > that it prevents some optimizations to happen. > > function-attrs removes the convergent attribute from anything it can prove >

[PATCH] D34512: Add preliminary Cross Translation Unit support library

This revision was automatically updated to reflect the committed changes. Closed by commit rL313975: Add Cross Translation Unit support library (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D34512?vs=116195=116327#toc Repository: rL LLVM

[PATCH] D38074: Fix TBAA information for reference accesses

kosarev updated this revision to Diff 116326. kosarev added a comment. Refined the TODO wording. https://reviews.llvm.org/D38074 Files: lib/CodeGen/CodeGenTBAA.cpp test/CodeGen/tbaa-reference.cpp Index: test/CodeGen/tbaa-reference.cpp

r313975 - Add Cross Translation Unit support library

Author: xazax Date: Fri Sep 22 04:11:01 2017 New Revision: 313975 URL: http://llvm.org/viewvc/llvm-project?rev=313975=rev Log: Add Cross Translation Unit support library This patch introduces a class that can help to build tools that require cross translation unit facilities. This class allows

[PATCH] D38074: Fix TBAA information for reference accesses

kosarev updated this revision to Diff 116325. kosarev added a comment. Added a check for the initialization of the reference member in B::B(S&). (That in fact was my original intent; thanks for catching it.) As to reference loads, we generate them with CodeGenFunction::EmitLoadOfReference()

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

Anastasia added a comment. >> I feel it would be much simpler if we could always generate the kernel >> metadata for blocks. A lot of special case code would be removed if we do >> this. OpenCL doesn't prevent kernel functions to be used just as normal >> functions (6.7.1) so it should be a

[PATCH] D38171: Implement clang-tidy check aliases.

leanil created this revision. Herald added a subscriber: JDevlieghere. Clang warnings can be mapped to virtual check names as aliases. The mappings can be set in the appropriate ClangTidyModules. If the virtual check is enabled, then - the corresponding warning options get passed to clang, and

r313973 - [analyzer] Add new delete with non-virtual destructor check

Author: xazax Date: Fri Sep 22 03:16:33 2017 New Revision: 313973 URL: http://llvm.org/viewvc/llvm-project?rev=313973=rev Log: [analyzer] Add new delete with non-virtual destructor check Patch by: Reka Nikolett Kovacs Differential Revision: https://reviews.llvm.org/D35796 Added:

[PATCH] D35796: [analyzer] Delete with non-virtual destructor check

This revision was automatically updated to reflect the committed changes. Closed by commit rL313973: [analyzer] Add new delete with non-virtual destructor check (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D35796?vs=116060=116319#toc Repository: rL LLVM

[PATCH] D38168: [mips] Accept but ignore -m(no-)branch-likely

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38168: [mips] Accept but ignore -m(no-)branch-likely

sdardis created this revision. Herald added a subscriber: arichardson. -mbranch-likely and -mno-branch-likely are used in some build systems for some MIPS targets. Accept these options but ignore them as they are an (de)optimiztion hint, and that branch likely instructions were deprecated but not

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev added a comment. Sure, will do. Just added it to https://reviews.llvm.org/D38074. Thanks. https://reviews.llvm.org/D38126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35796: [analyzer] Delete with non-virtual destructor check

rnkovacs added a comment. In https://reviews.llvm.org/D35796#878200, @dcoughlin wrote: > This looks good to me! Do you have commit access, or do you need someone to > commit it for you? Thanks! I don't, so it would be nice if someone committed it for me. https://reviews.llvm.org/D35796