[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

martell added a comment. In https://reviews.llvm.org/D38290#882911, @ruiu wrote: > Is this for cross-compilation? It is mostly for native compilation on mac but this will work for cross compiling also. > If you invoke lld on macOS, it should act as ld64. That is if the file name is `ld` or i

[PATCH] D37905: [libclang, bindings]: add spelling location

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. If I'm not mistaken, the change just means that the python bindings need a "newer" libclang, libclang's interfaces don't really change. I think that is acceptable. ==

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: clangd/tool/ClangdMain.cpp:20 #include +#include William, did you perhaps miss this comment? I don't think unistd.h make

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

ruiu added a comment. Is this for cross-compilation? If you invoke lld on macOS, it should act as ld64. macOS lld is not actively maintained, so I wouldn't make it available more widely. Repository: rL LLVM https://reviews.llvm.org/D38290 ___

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

malaperle added a comment. I submitted the patch. Thanks a lot William and Ilya! Repository: rL LLVM https://reviews.llvm.org/D36150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] r314377 - [clangd] LSP extension to switch between source/header file

Author: malaperle Date: Wed Sep 27 20:14:40 2017 New Revision: 314377 URL: http://llvm.org/viewvc/llvm-project?rev=314377&view=rev Log: [clangd] LSP extension to switch between source/header file Summary: Small extension to LSP to allow clients to use clangd to switch between C header files and

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

This revision was automatically updated to reflect the committed changes. Closed by commit rL314377: [clangd] LSP extension to switch between source/header file (authored by malaperle). Changed prior to commit: https://reviews.llvm.org/D36150?vs=116387&id=116919#toc Repository: rL LLVM http

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

Rakete created this revision. Rakete added a project: clang. Parsers a postfix expression after a boolean literal: This fixes PR34273 . https://reviews.llvm.org/D38342 Files: lib/Parse/ParseExpr.cpp test/CXX/expr/expr.post/expr.sub/p1.cp

Re: r314373 - [NFC] Don't use C++17 standard lib variable template helper traits, instead use ::value.

This still doesn't work on some compilers, because std::is_trivially_copyable isn't available: http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/265/steps/build/logs/stdio On Wed, Sep 27, 2017 at 10:00 PM, Faisal Vali via cfe-commits < cfe-commits@lists.llvm.org

[PATCH] D38277: [compiler-rt}[CMake] Fix configuration on PowerPC with sanitizers

alekseyshl added a comment. I wonder what's the error message? Comment at: cmake/base-config-ix.cmake:153 + # will fail with this option when building with a sanitizer. + set(OLD_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS}) + string(REPLACE "-nodefaultlibs" "" C

r314373 - [NFC] Don't use C++17 standard lib variable template helper traits, instead use ::value.

Author: faisalv Date: Wed Sep 27 19:00:40 2017 New Revision: 314373 URL: http://llvm.org/viewvc/llvm-project?rev=314373&view=rev Log: [NFC] Don't use C++17 standard lib variable template helper traits, instead use ::value. Modified: cfe/trunk/lib/Lex/MacroArgs.cpp Modified: cfe/trunk/lib/Le

r314372 - [NFC] Modernize MacroArgs using TrailingObjects

Author: faisalv Date: Wed Sep 27 18:50:23 2017 New Revision: 314372 URL: http://llvm.org/viewvc/llvm-project?rev=314372&view=rev Log: [NFC] Modernize MacroArgs using TrailingObjects Refactor MacroArgs to use TrailingObjects when creating a variably sized object on the heap to store the unexpande

r314370 - Look through parentheses.

Author: ahatanak Date: Wed Sep 27 18:31:17 2017 New Revision: 314370 URL: http://llvm.org/viewvc/llvm-project?rev=314370&view=rev Log: Look through parentheses. This fixes a bug where clang would emit instructions to reclaim a value that's going to be __bridge-casted to CF. rdar://problem/346875

r314367 - [Targets/X86] Remove unneded `return` in setMaxAtomicWidth(). NFCI.

Author: davide Date: Wed Sep 27 17:24:20 2017 New Revision: 314367 URL: http://llvm.org/viewvc/llvm-project?rev=314367&view=rev Log: [Targets/X86] Remove unneded `return` in setMaxAtomicWidth(). NFCI. Modified: cfe/trunk/lib/Basic/Targets/X86.h Modified: cfe/trunk/lib/Basic/Targets/X86.h URL

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

This revision was automatically updated to reflect the committed changes. Closed by commit rL314364: [Preprocessor] Preserve #pragma clang assume_nonnull in preprocessed output (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D37861?vs=115838&id=116903#toc Repository:

r314364 - [Preprocessor] Preserve #pragma clang assume_nonnull in preprocessed output

Author: efriedma Date: Wed Sep 27 16:29:37 2017 New Revision: 314364 URL: http://llvm.org/viewvc/llvm-project?rev=314364&view=rev Log: [Preprocessor] Preserve #pragma clang assume_nonnull in preprocessed output Patch by Zbigniew Sarbinowski! Differential Revision: https://reviews.llvm.org/D37861

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

wmi updated this revision to Diff 116896. wmi added a comment. Address Hal's comment. Separate bitfields to shards separated by the naturally-sized-and-aligned fields. Repository: rL LLVM https://reviews.llvm.org/D36562 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/D

[PATCH] D38270: [clang] Add getUnsignedPointerDiffType method

alexshap updated this revision to Diff 116894. alexshap added a comment. Address the comments Repository: rL LLVM https://reviews.llvm.org/D38270 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp lib/Analysis/PrintfFormatString.cpp lib/An

[PATCH] D38205: [Sema] Warn on attribute nothrow conflicting with language specifiers

erichkeane updated this revision to Diff 116892. erichkeane marked 2 inline comments as done. erichkeane added a comment. changes that were suggested by @aaron.ballman It DOES warn on the template correctly, however I'm not thrilled that it misses the 'warning' info. Any idea how I can get that

r314354 - [AVR] Update data layout to match current LLVM trunk

Author: dylanmckay Date: Wed Sep 27 15:09:01 2017 New Revision: 314354 URL: http://llvm.org/viewvc/llvm-project?rev=314354&view=rev Log: [AVR] Update data layout to match current LLVM trunk The data layout was changed in r314179 to fix atomic loads and stores. Modified: cfe/trunk/lib/Basic/T

[PATCH] D37905: [libclang, bindings]: add spelling location

frutiger added a comment. //Friendly poke!// https://reviews.llvm.org/D37905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37855: [bindings] allow null strings in Python 3

frutiger added a comment. //Friendly poke!// https://reviews.llvm.org/D37855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Sep 27, 2017 at 1:58 PM Paul Robinson via Phabricator < revi...@reviews.llvm.org> wrote: > probinson added a reviewer: rnk. > probinson added a comment. > > +rnk for the CodeView question. > > > > > Comment at: include/clang/Frontend/CodeGenOptions.def:222 >

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

probinson added a reviewer: rnk. probinson added a comment. +rnk for the CodeView question. Comment at: include/clang/Frontend/CodeGenOptions.def:222 ///< of inline stack frames without .dwo files. +CODEGENOPT(DebugFwdTemplateParams, 1, 0)

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl updated this revision to Diff 116877. yaxunl marked 4 inline comments as done. yaxunl added a comment. Rebased to ToT and revised by Anastasia's comments. https://reviews.llvm.org/D37822 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/CGOpenCLRuntime.h

[PATCH] D38303: [Sema] Correct IUnknown to support Unknwnbase.h Header.

erichkeane updated this revision to Diff 116876. erichkeane added a comment. As @rnk suggested, pull my condition out into a static function. https://reviews.llvm.org/D38303 Files: lib/AST/DeclCXX.cpp test/SemaCXX/ms-iunknown-template-function.cpp test/SemaCXX/ms-iunknown.cpp Index: lib/

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks OK to me - couple of minor questions. Comment at: include/clang/Frontend/CodeGenOptions.def:222 ///< of inline stack frames wit

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:311 +// The header is basically 'struct { int; int; generic void *; +// custom_fields; }'. Assert that that struct is packed. +auto GenPtrAlign = CharUnits::fro

[PATCH] D38208: Add support for remembering origins to ExternalASTMerger

This revision was automatically updated to reflect the committed changes. Closed by commit rL314336: Add support for remembering origins to ExternalASTMerger (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D38208?vs=116680&id=116868#toc Repository: rL LLVM https://re

r314336 - Add support for remembering origins to ExternalASTMerger

Author: spyffe Date: Wed Sep 27 12:57:58 2017 New Revision: 314336 URL: http://llvm.org/viewvc/llvm-project?rev=314336&view=rev Log: Add support for remembering origins to ExternalASTMerger ExternalASTMerger has hitherto relied on being able to look up any Decl through its named DeclContext chai

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

danielmarjamaki updated this revision to Diff 116865. danielmarjamaki added a comment. fixed review comments Repository: rL LLVM https://reviews.llvm.org/D30295 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h lib/StaticAnalyzer/Checkers/ConversionChecker.cpp lib

[PATCH] D38186: Add the new -Wnull-pointer-arithmetic warnings to the release notes

hfinkel added inline comments. Comment at: ReleaseNotes.rst:82 +- ``-Wnull-pointer-arithmetic`` now warns about performing pointer arithmetic + on a null pointer. It has an undefined behavior if the offset is nonzero. + We can probably just make this one entry:

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

(though perhaps we had some position that debugger tuning wouldn't ever be the only way to access functionality, only change defaults) That's correct. Tuning must unpack to other settings that can be set separately. That was very strong feedback from when we introduced the tuning concept. --p

[PATCH] D38270: [clang] Add getUnsignedPointerDiffType method

aaron.ballman added a comment. > The code for printf diagnostics + new tests are supposed to be added by a > separate diff. I think you should combine that diff and this one into a single patch, otherwise this patch is untestable. Comment at: include/clang/AST/ASTContext.h:1

[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

vsapsai added a comment. To preempt some of review feedback here are attempted and rejected approaches: - Pass `pointerLoc` and `pointerEndLoc` as `pointerRange`. Such source range can be misleading as `pointerLoc` doesn't necesserily point at the beginning. For example, for `int *x` pointer ra

[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Nice catch, Volodymyr! Looks good to me. https://reviews.llvm.org/D38327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

efriedma added a comment. Oops, sorry, lost track of it; I'll commit it today. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

probinson updated this revision to Diff 116862. probinson added a comment. command-line option is cc1 not driver internal flag moved from LangOpts to CodeGenOpts and renamed simplified test https://reviews.llvm.org/D14358 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/Code

[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

vsapsai created this revision. Fixes nullability fix-it for `id`. With this change nullability specifier is inserted after ">" instead of between "id" and "<". rdar://problem/34260995 https://reviews.llvm.org/D38327 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaType.cpp clang

[PATCH] D38326: [CUDA] Work around conflicting function definitions in CUDA-9 headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL314334: [CUDA] Work around conflicting function definitions in CUDA-9 headers. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38326?vs=116856&id=116858#toc Repository: rL LLVM

r314334 - [CUDA] Work around conflicting function definitions in CUDA-9 headers.

Author: tra Date: Wed Sep 27 12:07:15 2017 New Revision: 314334 URL: http://llvm.org/viewvc/llvm-project?rev=314334&view=rev Log: [CUDA] Work around conflicting function definitions in CUDA-9 headers. Differential Revision: https://reviews.llvm.org/D38326 Modified: cfe/trunk/lib/Headers/__cl

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri updated this revision to Diff 116857. lebedev.ri added a comment. Rebased, ping. Vanilla stage-2 build is now warning-clean, the only previous warning was fixed. Repository: rL LLVM https://reviews.llvm.org/D38101 Files: docs/ReleaseNotes.rst include/clang/Basic/DiagnosticGro

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Sep 27, 2017 at 11:50 AM Paul Robinson via Phabricator < revi...@reviews.llvm.org> wrote: > probinson added a comment. > > In https://reviews.llvm.org/D14358#882445, @dblaikie wrote: > > > > I would prefer to eliminate the `` from the instance name as > well, because our debugger reconstru

[PATCH] D38326: [CUDA] Work around conflicting function definitions in CUDA-9 headers.

tra created this revision. Herald added a subscriber: sanjoy. https://reviews.llvm.org/D38326 Files: clang/lib/Headers/__clang_cuda_runtime_wrapper.h Index: clang/lib/Headers/__clang_cuda_runtime_wrapper.h === --- clang/lib/Heade

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

probinson added a comment. In https://reviews.llvm.org/D14358#882445, @dblaikie wrote: > > I would prefer to eliminate the `` from the instance name as well, > > because our debugger reconstructs a name more to its liking from the > > parameter children. However, IIUC the name with params is u

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

predator5047 updated this revision to Diff 116850. predator5047 added a comment. Fixed spelling mistake and added a test case. https://reviews.llvm.org/D38284 Files: clang-tidy/readability/NamespaceCommentCheck.cpp clang-tidy/readability/NamespaceCommentCheck.h test/clang-tidy/google-read

[PATCH] D38303: [Sema] Correct IUnknown to support Unknwnbase.h Header.

rnk added inline comments. Comment at: lib/AST/DeclCXX.cpp:1497-1505 + bool IsInNamespace = false; + const auto *DeclContext = getDeclContext(); + while (!DeclContext->isTranslationUnit()) { +if (DeclContext->isNamespace()) { + IsInNamespace = true; + break; +

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

dblaikie added a comment. > I would prefer to eliminate the `` from the instance name as well, > because our debugger reconstructs a name more to its liking from the > parameter children. However, IIUC the name with params is used for > deduplication in LTO, so that is probably not such a good

[PATCH] D38257: [OpenMP] Fix memory leak when translating arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL314328: [OpenMP] Fix memory leak when translating arguments (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D38257?vs=116607&id=116844#toc Repository: rL LLVM https://revie

[PATCH] D38259: [OpenMP] Fix translation of target args

This revision was automatically updated to reflect the committed changes. Closed by commit rL314330: [OpenMP] Fix translation of target args (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D38259?vs=116610&id=116846#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D38258: [OpenMP] Fix passing of -m arguments to device toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL314329: [OpenMP] Fix passing of -m arguments to device toolchain (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D38258?vs=116608&id=116845#toc Repository: rL LLVM https://

r314330 - [OpenMP] Fix translation of target args

Author: hahnfeld Date: Wed Sep 27 11:12:36 2017 New Revision: 314330 URL: http://llvm.org/viewvc/llvm-project?rev=314330&view=rev Log: [OpenMP] Fix translation of target args ToolChain::TranslateArgs() returns nullptr if no changes are performed. This would currently mean that OpenMPArgs are lost

r314329 - [OpenMP] Fix passing of -m arguments to device toolchain

Author: hahnfeld Date: Wed Sep 27 11:12:34 2017 New Revision: 314329 URL: http://llvm.org/viewvc/llvm-project?rev=314329&view=rev Log: [OpenMP] Fix passing of -m arguments to device toolchain AuxTriple is not set if host and device share a toolchain. Also, removing an argument modifies the DAL wh

r314328 - [OpenMP] Fix memory leak when translating arguments

Author: hahnfeld Date: Wed Sep 27 11:12:31 2017 New Revision: 314328 URL: http://llvm.org/viewvc/llvm-project?rev=314328&view=rev Log: [OpenMP] Fix memory leak when translating arguments Parsing the argument after -Xopenmp-target allocates memory that needs to be freed. Associate it with the fina

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

probinson added a comment. In https://reviews.llvm.org/D14358#881666, @aprantl wrote: > Does this have to be exposed through the driver or could this be a cc1 option > only? My thinking was to make it easier for LLDB to play with it and decide whether DWARF conformance on this point is a good

[PATCH] D38291: clang-format/java: Unbreak genenrics formatting after r299952.

thakis closed this revision. thakis added a comment. r314325, thanks! https://reviews.llvm.org/D38291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r314325 - clang-format/java: Unbreak genenrics formatting after r299952.

Author: nico Date: Wed Sep 27 10:57:50 2017 New Revision: 314325 URL: http://llvm.org/viewvc/llvm-project?rev=314325&view=rev Log: clang-format/java: Unbreak genenrics formatting after r299952. https://reviews.llvm.org/rL299952 merged '>>>' tokens into a single JavaRightLogicalShift token. This b

[PATCH] D38209: [Sema] Correct nothrow inherited by noexcept

erichkeane updated this revision to Diff 116840. erichkeane marked 2 inline comments as done. erichkeane added a comment. 2 small changes @aaron.ballman requested. https://reviews.llvm.org/D38209 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/nothrow-as-noexcept-ctor.cpp Index: test/SemaCXX

[PATCH] D38208: Add support for remembering origins to ExternalASTMerger

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D38208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

Anastasia added a comment. Committed in r314317. Repository: rL LLVM https://reviews.llvm.org/D37804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r314317 - [OpenCL] Fixed CL version in failing test.

Author: stulova Date: Wed Sep 27 10:03:35 2017 New Revision: 314317 URL: http://llvm.org/viewvc/llvm-project?rev=314317&view=rev Log: [OpenCL] Fixed CL version in failing test. Modified: cfe/trunk/test/CodeGenOpenCL/vectorLoadStore.cl Modified: cfe/trunk/test/CodeGenOpenCL/vectorLoadStore.c

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

Anastasia added a comment. Committed in r314304 In https://reviews.llvm.org/D37804#882252, @alekseyshl wrote: > vectorLoadStore.cl is failing on our bots: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187, > please check it out I will commit a fix in a bit. Reposi

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6808 +static void deduceOpenCLImplicitAddrSpace(TypeProcessingState &State, + QualType &T, TypeAttrLocation TAL) { Great! This looks so clear now!

Re: [PATCH] D37826: Refine generation of TBAA information in clang

(As i mentioned to hal offline, i'm too slammed to help here) On Wed, Sep 27, 2017 at 8:47 AM, Ivan A. Kosarev via Phabricator < revi...@reviews.llvm.org> wrote: > kosarev added a comment. > > Colleagues, please let me know if I can do anything else to help with > reviewing the patch. Thanks. > >

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

ilya-biryukov added a comment. I think your change makes sense, but maybe asking for a better description. It appears you: - Enabled crash recovery for some libclang operations on a calling thread even when `LIBCLANG_NOTHREAD` is specified. Previously it would only run under crash recovery if

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

alekseyshl added a comment. vectorLoadStore.cl is failing on our bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187, please check it out Repository: rL LLVM https://reviews.llvm.org/D37804 ___ cfe-commits mailing li

[PATCH] D37826: Refine generation of TBAA information in clang

kosarev added a comment. Colleagues, please let me know if I can do anything else to help with reviewing the patch. Thanks. https://reviews.llvm.org/D37826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[clang-tools-extra] r314309 - [clangd] Handle InitializeParams and store rootUri

Author: malaperle Date: Wed Sep 27 08:31:17 2017 New Revision: 314309 URL: http://llvm.org/viewvc/llvm-project?rev=314309&view=rev Log: [clangd] Handle InitializeParams and store rootUri Summary: The root Uri is the workspace location and will be useful in the context of indexing. We could also a

[PATCH] D38113: OpenCL: Assume functions are convergent

hfinkel added a comment. In https://reviews.llvm.org/D38113#882187, @Anastasia wrote: > In https://reviews.llvm.org/D38113#878840, @jlebar wrote: > > > > ... > Yes, I see this sounds more reasonable indeed. Btw, currently LLVM can remove > `convergent` in some cases to recover the performance

[PATCH] D38113: OpenCL: Assume functions are convergent

Anastasia added a comment. In https://reviews.llvm.org/D38113#878840, @jlebar wrote: > > Yes, that's why if it would be responsibility of the kernel developer to > > specify this explicitly we could avoid this complications in the compiler. > > But if we add it into the language now we still ne

[PATCH] D38258: [OpenMP] Fix passing of -m arguments to device toolchain

gtbercea accepted this revision. gtbercea added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/Driver/openmp-offload.c:89 +/// ### + /// Check the phases graph when using

[PATCH] D38258: [OpenMP] Fix passing of -m arguments to device toolchain

Hahnfeld added inline comments. Comment at: test/Driver/openmp-offload.c:89 +/// ### + /// Check the phases graph when using a single target, different from the host. gtbercea wrote: > Shoul

[PATCH] D38259: [OpenMP] Fix translation of target args

gtbercea accepted this revision. gtbercea added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D38258: [OpenMP] Fix passing of -m arguments to device toolchain

gtbercea added inline comments. Comment at: test/Driver/openmp-offload.c:89 +/// ### + /// Check the phases graph when using a single target, different from the host. Shouldn't these tests b

[PATCH] D38257: [OpenMP] Fix memory leak when translating arguments

gtbercea accepted this revision. gtbercea added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

r314304 - [OpenCL] Handle address space conversion while setting type alignment.

Author: stulova Date: Wed Sep 27 07:37:00 2017 New Revision: 314304 URL: http://llvm.org/viewvc/llvm-project?rev=314304&view=rev Log: [OpenCL] Handle address space conversion while setting type alignment. Added missing addrspacecast case in alignment computation logic of pointer type emission in

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL314304: [OpenCL] Handle address space conversion while setting type alignment. (authored by stulova). Changed prior to commit: https://reviews.llvm.org/D37804?vs=116548&id=116809#toc Repository: rL L

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38113: OpenCL: Assume functions are convergent

Anastasia added a comment. In https://reviews.llvm.org/D38113#878852, @hfinkel wrote: > In https://reviews.llvm.org/D38113#877874, @Anastasia wrote: > > > The problem of adding this attribute conservatively for all functions is > > that it prevents some optimizations to happen. I agree to commit

[PATCH] D38179: [clang-tidy] Handle unions in modernize-use-equals-default check

alexfh added inline comments. Comment at: clang-tidy/modernize/UseEqualsDefaultCheck.cpp:119-120 + + // A defaulted default constructor of a union with a field with a non trivial + // default constructor would be deleted. + if (Record->isUnion()) { malcolm.par

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

alexfh added a comment. Thank you, Artem! Repository: rL LLVM https://reviews.llvm.org/D37023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi added a comment. Eli, if you have trouble committing this please let me know. Not sure what is happening. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

martell updated this revision to Diff 116801. martell added a comment. address comment Repository: rL LLVM https://reviews.llvm.org/D38290 Files: tools/clang/lib/Driver/ToolChain.cpp tools/lld/tools/lld/CMakeLists.txt tools/lld/tools/lld/lld.cpp Index: tools/lld/tools/lld/lld.cpp ===

r314302 - revert rL314300

Author: coby Date: Wed Sep 27 06:02:44 2017 New Revision: 314302 URL: http://llvm.org/viewvc/llvm-project?rev=314302&view=rev Log: revert rL314300 accidently added only tests w/o the respective changes.. Removed: cfe/trunk/test/CodeGen/ms-inline-asm-enums.cpp cfe/trunk/test/CodeGen/ms-in

r314300 - [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

Author: coby Date: Wed Sep 27 05:36:54 2017 New Revision: 314300 URL: http://llvm.org/viewvc/llvm-project?rev=314300&view=rev Log: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions Allow the proper recognition of Enum values and global variables i

Re: r309386 - Recommit r308327 3rd time: Add a warning for missing

Are the pshpack1.h/poppack.h headers included from other headers in the SDK or are they intended for end-users? If they're only used in the SDK then the SDK headers should probably be system headers, so the warning should be silenced. Apart from that there's no real good solution for this issue un

r314298 - [analyzer] Fix an outdated comment in a test. NFC.

Author: dergachev Date: Wed Sep 27 03:59:06 2017 New Revision: 314298 URL: http://llvm.org/viewvc/llvm-project?rev=314298&view=rev Log: [analyzer] Fix an outdated comment in a test. NFC. Modified: cfe/trunk/test/Analysis/null-deref-path-notes.c Modified: cfe/trunk/test/Analysis/null-deref-pa

[PATCH] D38291: clang-format/java: Unbreak genenrics formatting after r299952.

bradfier accepted this revision. bradfier added a comment. This revision is now accepted and ready to land. If this doesn't break the test case for '>>>' then it looks good, although I'm not sure what has changed in the interim to allow that to work. When I made the patch in r299952 we definitel

[PATCH] D37025: [analyzer] Support more pointer arithmetic in bugreporter::getDerefExpr().

This revision was automatically updated to reflect the committed changes. Closed by commit rL314290: [analyzer] Match more patterns in bugreporter::getDerefExpr() API. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D37025?vs=112221&id=116783#toc Repository: rL LLV

r314290 - [analyzer] Match more patterns in bugreporter::getDerefExpr() API.

Author: dergachev Date: Wed Sep 27 02:50:45 2017 New Revision: 314290 URL: http://llvm.org/viewvc/llvm-project?rev=314290&view=rev Log: [analyzer] Match more patterns in bugreporter::getDerefExpr() API. This function can now track null pointer through simple pointer arithmetic, such as '*&*(p + 2

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

This revision was automatically updated to reflect the committed changes. Closed by commit rL314287: [analyzer] Fix and refactor bugreporter::getDerefExpr() API. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D37023?vs=116673&id=116781#toc Repository: rL LLVM htt

r314287 - [analyzer] Fix and refactor bugreporter::getDerefExpr() API.

Author: dergachev Date: Wed Sep 27 02:33:37 2017 New Revision: 314287 URL: http://llvm.org/viewvc/llvm-project?rev=314287&view=rev Log: [analyzer] Fix and refactor bugreporter::getDerefExpr() API. This API is used by checkers (and other entities) in order to track where does a value originate fro

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis edited subscribers, added: cfe-commits; removed: llvm-commits. sdardis added a comment. +CC cfe-commits, -CC llvm-commits. Some comments inlined. I've managed to run the test-suite on one of my machines here and I'm seeing 3 failures: libunwind :: libunwind_01.pass.cpp libunwind ::

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added a comment. Ping 4 https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r314279 - [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true.

Author: mkurdej Date: Wed Sep 27 00:51:51 2017 New Revision: 314279 URL: http://llvm.org/viewvc/llvm-project?rev=314279&view=rev Log: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true. Summary: NamespaceEndCommentsFixer did not fix namespace comments when the brac

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jbcoe requested changes to this revision. jbcoe added a comment. This revision now requires changes to proceed. Looks great. Please add tests to clang/tools/c-index-test/c-index-test.c too as the Python tests are not run on build-bots (to the best of my knowledge). https://reviews.llvm.org/D369