Author: agozillon
Date: Sun Oct 1 23:31:25 2017
New Revision: 314650
URL: http://llvm.org/viewvc/llvm-project?rev=314650&view=rev
Log:
Dependent Address Space Support Test File
Adding regression test for Dependent Address Spaces in relation to
https://reviews.llvm.org/D33666 I forgot to svn add
Author: agozillon
Date: Sun Oct 1 23:25:51 2017
New Revision: 314649
URL: http://llvm.org/viewvc/llvm-project?rev=314649&view=rev
Log:
Dependent Address Space Support
This patch relates to: https://reviews.llvm.org/D33666 This adds support
for template parameters to be passed to the address_spac
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314646: [cmake] Add a separate CMake var to control profile
runtime (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D38441?vs=117255&id=117299#toc
Repository:
rL LLVM
https:/
ruiu added a comment.
This patch virtually sets `ld64` the linker command name for macOS. I'd be a
bit reluctant doing that, because `ld64` sounds like a too generic name to
indicate "a linker for macOS". But that's probably okay because we don't have a
better name.
Can you get an LGTM from so
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm.
Repository:
rL LLVM
https://reviews.llvm.org/D38441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Looks good with some nits.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:73
+template
+class OptionRequirement : public RefactoringOptio
Author: jketema
Date: Sun Oct 1 13:10:14 2017
New Revision: 314633
URL: http://llvm.org/viewvc/llvm-project?rev=314633&view=rev
Log:
Do no circularly define NULL
Reviewed-by: Jan Vesely
Modified:
libclc/trunk/generic/include/clc/clcmacros.h
Modified: libclc/trunk/generic/include/clc/clcma
Author: jketema
Date: Sun Oct 1 13:11:46 2017
New Revision: 314634
URL: http://llvm.org/viewvc/llvm-project?rev=314634&view=rev
Log:
Let get_work_dim take exactly 0 arguments
Reviewed-by: Jan Vesely
Modified:
libclc/trunk/amdgcn/lib/workitem/get_work_dim.cl
libclc/trunk/generic/include
mstorsjo abandoned this revision.
mstorsjo added a comment.
Works fine with the version from r314632 (with a minor fixup in r314635).
https://reviews.llvm.org/D38250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: mstorsjo
Date: Sun Oct 1 13:22:40 2017
New Revision: 314635
URL: http://llvm.org/viewvc/llvm-project?rev=314635&view=rev
Log:
SjLj: Fix building after SVN r314632
The code moved from Unwind_AppleExtras.cpp to Unwind-sjlj.c needed
a few minor modifications to build as C instead of C++.
M
choikwa added a comment.
> Can you get more information on what GCC actually implemented and why? It's
> not clear to me that ignoring the namespaces is the most-useful way to do
> this. I don't want to emulate GCC bugs, but maybe there's a good reason why
> their implementation works this way.
compnerd added a comment.
I believe that SVN r314632 should address the issue more thorougly.
https://reviews.llvm.org/D38250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Sun Oct 1 13:06:48 2017
New Revision: 314632
URL: http://llvm.org/viewvc/llvm-project?rev=314632&view=rev
Log:
SjLj: make the SjLj implementation more portable
This moves the definition of the internal helpers
`__Unwind_SjLj_GetTopOfFunctionStack` and
`__Unwind_SjLj_SetTop
mstorsjo added inline comments.
Comment at: src/Unwind-sjlj.c:481
+#endif // !defined(__APPLE__)
+
#endif // defined(_LIBUNWIND_BUILD_SJLJ_APIS)
compnerd wrote:
> mstorsjo wrote:
> > compnerd wrote:
> > > Can't both of these also be static?
> > No, since they're
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
Actually, Ill go ahead and make the more invasive change and that will provide
this properly.
https://reviews.llvm.org/D38250
___
rwols updated this revision to Diff 117290.
rwols added a comment.
- Fix fillSortText: used the old version, now using new version from upstream
- Fix initialize-params.test and initialize-params-invalid.test to account for
signature help
- All tests pass now
https://reviews.llvm.org/D38048
Fi
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: src/Unwind-sjlj.c:481
+#endif // !defined(__APPLE__)
+
#endif // defined(_LIBUNWIND_BUILD_SJLJ_APIS)
mstorsjo wrote:
> compnerd wrote:
>
rwols added inline comments.
Comment at: clangd/ClangdUnit.cpp:442
static void FillSortText(const CodeCompletionString &CCS,
CompletionItem &Item) {
I seem to have inadvertently used the old fillSortText during the merge from
ups
hfinkel added a comment.
In https://reviews.llvm.org/D37624#885311, @choikwa wrote:
> In https://reviews.llvm.org/D37624#885308, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D37624#885295, @choikwa wrote:
> >
> > > In https://reviews.llvm.org/D37624#885290, @hfinkel wrote:
> > >
> > > > In h
Author: agozillon
Date: Sun Oct 1 05:16:24 2017
New Revision: 314623
URL: http://llvm.org/viewvc/llvm-project?rev=314623&view=rev
Log:
Test Commit.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Se
coby added inline comments.
Comment at: test/CodeGen/ms-inline-asm.cpp:37-38
- int lvar = 10;
- __asm mov eax, offset Foo::ptr
- __asm mov eax, offset Foo::Bar::ptr
-// CHECK-LABEL: define void @_Z2t2v()
rnk wrote:
> These don't seem tested anywhere now
I've t
coby created this revision.
Herald added a subscriber: eraman.
Repository:
rL LLVM
https://reviews.llvm.org/D38445
Files:
lib/Basic/Targets/X86.cpp
test/CodeGen/ms-inline-asm.c
Index: lib/Basic/Targets/X86.cpp
===
--- lib/Ba
mgorny created this revision.
Herald added a subscriber: dberris.
Create a dummy 'gtest' target to satisfy the test dependencies while
doing stand-alone builds. Historically those dependencies were
conditional to non-stand-alone builds but the refactoring
in https://reviews.llvm.org/rL310971 has m
choikwa added a comment.
In https://reviews.llvm.org/D37624#885308, @hfinkel wrote:
> In https://reviews.llvm.org/D37624#885295, @choikwa wrote:
>
> > In https://reviews.llvm.org/D37624#885290, @hfinkel wrote:
> >
> > > In https://reviews.llvm.org/D37624#885288, @choikwa wrote:
> > >
> > > > - ad
24 matches
Mail list logo
