[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

zaks.anna accepted this revision. zaks.anna added a comment. Once the comments by @paquette are addressed, LGTM. Thanks! Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:138 + +OS << " larger or equal to the width of type '" + << B->getLHS()->get

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me. Please fix the additional nits mentioned inline and commit! Also, make sure to do a pass to update the capitalization of variables throughout the file to match the LLV

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added a comment. Are there any further comments on this, or can someone of those who commented on it before approve it? https://reviews.llvm.org/D38679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

r315435 - Reorder.

Author: chapuni Date: Tue Oct 10 21:54:05 2017 New Revision: 315435 URL: http://llvm.org/viewvc/llvm-project?rev=315435&view=rev Log: Reorder. Modified: cfe/trunk/unittests/CodeGen/CMakeLists.txt Modified: cfe/trunk/unittests/CodeGen/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/c

r315428 - ClangCodeGenTests: Update libdeps in rL315392, +clangAST.

Author: chapuni Date: Tue Oct 10 21:20:19 2017 New Revision: 315428 URL: http://llvm.org/viewvc/llvm-project?rev=315428&view=rev Log: ClangCodeGenTests: Update libdeps in rL315392, +clangAST. Modified: cfe/trunk/unittests/CodeGen/CMakeLists.txt Modified: cfe/trunk/unittests/CodeGen/CMakeList

r315411 - Update cc1as_main for MCAsmBackend ownership change in r315410.

Author: lhames Date: Tue Oct 10 18:58:08 2017 New Revision: 315411 URL: http://llvm.org/viewvc/llvm-project?rev=315411&view=rev Log: Update cc1as_main for MCAsmBackend ownership change in r315410. Modified: cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/tools/driver/cc1as_main.cpp

r315408 - [modules] Fix visibility checking for using declarations via ADL.

Author: rsmith Date: Tue Oct 10 18:49:57 2017 New Revision: 315408 URL: http://llvm.org/viewvc/llvm-project?rev=315408&view=rev Log: [modules] Fix visibility checking for using declarations via ADL. We want to check whether the using (shadow) declaration itself is visible, not whether its target

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

george.karpenkov updated this revision to Diff 118522. george.karpenkov added a comment. Typo fix. https://reviews.llvm.org/D38764 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

george.karpenkov added a comment. Marking requests as "done". https://reviews.llvm.org/D38764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

george.karpenkov updated this revision to Diff 118521. george.karpenkov marked 12 inline comments as done. george.karpenkov added a comment. Adhering to comments. https://reviews.llvm.org/D38764 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.

r315402 - [modules] Only take visible using-directives into account during name lookup.

Author: rsmith Date: Tue Oct 10 18:19:11 2017 New Revision: 315402 URL: http://llvm.org/viewvc/llvm-project?rev=315402&view=rev Log: [modules] Only take visible using-directives into account during name lookup. Added: cfe/trunk/test/Modules/using-directive.cpp Modified: cfe/trunk/lib/Sema

[PATCH] D38774: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

vsapsai added a comment. To save reviewers some time. Incomplete array type is not the same as for zero-sized array, it is `c"^c\00"` while for zero-sized array it is `c"[0c]\00"`. Don't know if it matters, I haven't found any difference in behaviour. Though maybe I wasn't looking in the right

r315398 - A '<' with a trigraph '#' is not a valid editor placeholder

Author: arphaman Date: Tue Oct 10 17:41:20 2017 New Revision: 315398 URL: http://llvm.org/viewvc/llvm-project?rev=315398&view=rev Log: A '<' with a trigraph '#' is not a valid editor placeholder Credit to OSS-Fuzz for discovery: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3137#c5 rdar:

[PATCH] D38774: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

vsapsai added a comment. This patch depends on sema change https://reviews.llvm.org/D38773 https://reviews.llvm.org/D38774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315397 - [Modules TS] Diagnose missing/duplicate module-declaration.

Author: rsmith Date: Tue Oct 10 17:36:56 2017 New Revision: 315397 URL: http://llvm.org/viewvc/llvm-project?rev=315397&view=rev Log: [Modules TS] Diagnose missing/duplicate module-declaration. Added: cfe/trunk/test/CXX/modules-ts/dcl.dcl/dcl.module/p1.cpp Modified: cfe/trunk/include/clang

[PATCH] D38773: [Sema] Add support for flexible array members in Obj-C.

vsapsai added a comment. Previous discussion on the mailing list can be found at http://lists.llvm.org/pipermail/cfe-dev/2017-September/055548.html The implementation is not exactly like it was discussed, it has some changes. There is another case when extra ivar is added at the end, it is for

[PATCH] D38774: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

vsapsai created this revision. Fixes an assertion failure when ivar is a struct containing incomplete array. Also completes support for direct flexible array members. rdar://problem/21054495 https://reviews.llvm.org/D38774 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/test/CodeGenObjC/ivar-

[PATCH] D38773: [Sema] Add support for flexible array members in Obj-C.

vsapsai created this revision. Allow Obj-C ivars with incomplete array type but only as the last ivar. Also add a requirement for ivars that contain a flexible array member to be at the end of class too. It is possible to add in a subclass another ivar at the end but we'll emit a warning in this c

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

jroelofs added a comment. In https://reviews.llvm.org/D38599#893990, @jroelofs wrote: > In https://reviews.llvm.org/D38599#893985, @danalbert wrote: > > > In https://reviews.llvm.org/D38599#893903, @jroelofs wrote: > > > > > That reminds me... this does need a testcase or two. > > > > > > Oh, als

[PATCH] D38772: [refactor] allow the use of refactoring diagnostics

arphaman created this revision. Herald added a subscriber: mgorny. This patch allows the refactoring library to use its own set of refactoring-specific diagnostics to reports things like initiation errors. Repository: rL LLVM https://reviews.llvm.org/D38772 Files: include/clang/Basic/AllD

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

dcoughlin added a comment. Looks like a great start! There are a bunch of minor nits inline. The one big thing is that I think your handling of 'const char *' in `typeIsConstString()` isn't quite right. 'const char *' means that the pointed-to characters can't be modified but does allow modifi

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

This revision was automatically updated to reflect the committed changes. Closed by commit rL315392: Include getting generated struct offsets in CodegenABITypes (authored by adrian). Changed prior to commit: https://reviews.llvm.org/D38473?vs=117806&id=118505#toc Repository: rL LLVM https:/

r315392 - Include getting generated struct offsets in CodegenABITypes

Author: adrian Date: Tue Oct 10 16:54:21 2017 New Revision: 315392 URL: http://llvm.org/viewvc/llvm-project?rev=315392&view=rev Log: Include getting generated struct offsets in CodegenABITypes This change adds a new function, CodeGen::getFieldNumber, that enables a user of clang's code generation

Re: [clang-tools-extra] r315287 - Revert "Revert r315214 since diff -Z isn't portable, this is breaking:"

On Tue, Oct 10, 2017 at 2:08 AM, Ilya Biryukov via cfe-commits wrote: > Author: ibiryukov > Date: Tue Oct 10 02:08:47 2017 > New Revision: 315287 > > URL: http://llvm.org/viewvc/llvm-project?rev=315287&view=rev > Log: > Revert "Revert r315214 since diff -Z isn't portable, this is breaking:" > > Th

Re: r298369 - [OpenCL] Added diagnostic for checking length of vector

Hi Egor, On Tue, Mar 21, 2017 at 6:20 AM, Egor Churaev via cfe-commits wrote: > Author: echuraev > Date: Tue Mar 21 08:20:57 2017 > New Revision: 298369 > > URL: http://llvm.org/viewvc/llvm-project?rev=298369&view=rev > Log: > [OpenCL] Added diagnostic for checking length of vector > > Reviewers:

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

aprantl added a comment. I can commit this for you if John is happy with it. https://reviews.llvm.org/D38473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

jroelofs added a comment. In https://reviews.llvm.org/D38599#893985, @danalbert wrote: > In https://reviews.llvm.org/D38599#893903, @jroelofs wrote: > > > That reminds me... this does need a testcase or two. > > > Oh, also, any test I add is going to fail, since the case I'm trying to > account

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert updated this revision to Diff 118502. danalbert edited the summary of this revision. danalbert added a comment. Added a (failing) test case. The test case will fail unless the default value of `_LIBCXX_DYNAMIC_FALLBACK` is changed. https://reviews.llvm.org/D38599 Files: src/private

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#893903, @jroelofs wrote: > That reminds me... this does need a testcase or two. Oh, also, any test I add is going to fail, since the case I'm trying to account for here is not the default behavior. I could make the more invasive ch

[PATCH] D38717: Patch to Bugzilla 31373

efriedma added a comment. Please make sure the title (subject line) for a patch reflects the actual contents of the change, as opposed to referring to Bugzilla; a lot of people skim cfe-commits, so you want to make sure interested reviewers find you patch. Needs a regression test to verify we g

r315381 - [Modules TS] Diagnose attempts to enter module implementation units without the module interface being available.

Author: rsmith Date: Tue Oct 10 15:35:27 2017 New Revision: 315381 URL: http://llvm.org/viewvc/llvm-project?rev=315381&view=rev Log: [Modules TS] Diagnose attempts to enter module implementation units without the module interface being available. Added: cfe/trunk/test/CXX/modules-ts/dcl.dcl/

r315379 - [Modules TS] Module ownership semantics for redeclarations.

Author: rsmith Date: Tue Oct 10 15:33:17 2017 New Revision: 315379 URL: http://llvm.org/viewvc/llvm-project?rev=315379&view=rev Log: [Modules TS] Module ownership semantics for redeclarations. When declaring an entity in the "purview" of a module, it's never a redeclaration of an entity in the pu

[PATCH] D38770: AMDGPU: Use stricter bounds for workitem builtins

arsenm created this revision. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng. https://reviews.llvm.org/D38770 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl

[clang-tools-extra] r315378 - Support: Have directory_iterator::status() return FindFirstFileEx/FindNextFile results on Windows.

Author: pcc Date: Tue Oct 10 15:19:46 2017 New Revision: 315378 URL: http://llvm.org/viewvc/llvm-project?rev=315378&view=rev Log: Support: Have directory_iterator::status() return FindFirstFileEx/FindNextFile results on Windows. This allows clients to avoid an unnecessary fs::status() call on ea

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#893903, @jroelofs wrote: > That reminds me... this does need a testcase or two. Didn't realize I could do multi binary test cases with this test runner. It'll be a little messy, but I'll try adding one. Repository: rL LLVM http

r315378 - Support: Have directory_iterator::status() return FindFirstFileEx/FindNextFile results on Windows.

Author: pcc Date: Tue Oct 10 15:19:46 2017 New Revision: 315378 URL: http://llvm.org/viewvc/llvm-project?rev=315378&view=rev Log: Support: Have directory_iterator::status() return FindFirstFileEx/FindNextFile results on Windows. This allows clients to avoid an unnecessary fs::status() call on ea

[PATCH] D26350: Keep invalid Switch in the AST

rsmith added inline comments. Comment at: lib/Parse/ParseStmt.cpp:1297 - if (Switch.isInvalid()) { -// Skip the switch body. -// FIXME: This is not optimal recovery, but parsing the body is more -// dangerous due to the presence of case and default statements, whic

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

george.karpenkov updated this revision to Diff 118493. https://reviews.llvm.org/D38764 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/NonnilStringConstantsChecker.cpp test/Analysis/nonnil-string-constants.mm

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

jroelofs added a comment. That reminds me... this does need a testcase or two. Repository: rL LLVM https://reviews.llvm.org/D38599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

rprichard added a comment. Some relevant code links: - https://github.com/llvm-mirror/clang/blob/8c9bf999aa40ab6077b958b5edcf587b9d76ce24/lib/CodeGen/ItaniumCXXABI.cpp#L359 ==> iOS64CXXABI overrides shouldRTTIBeUnique to return false. - https://github.com/llvm-mirror/libcxx/blob/ca79c159d8bfbe

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun, mgorny. https://reviews.llvm.org/D38764 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/NonnilStringConstantsChecker.cpp tes

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

rprichard added a comment. Here's the Clang bug I filed: https://bugs.llvm.org/show_bug.cgi?id=34907 Repository: rL LLVM https://reviews.llvm.org/D38599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

rprichard added a comment. I assume std::type_info::operator== also needs to be adjusted to compare string names? It looks like libc++'s version of the function does string comparisons for ARM64 iOS, but only on some classes (e.g. public(?) ones). Look for the _LIBCPP_HAS_NONUNIQUE_TYPEINFO and

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth updated this revision to Diff 118482. Nebiroth added a comment. Rebased on master. https://reviews.llvm.org/D38425 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Pro

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

rsmith added a comment. @rjmccall Do you have any more comments? https://reviews.llvm.org/D38473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. LGTM Would you like me to commit this for you? https://reviews.llvm.org/D36955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D36973: [libclang] Add support for querying cursor availability

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. LGTM Would you like me to commit this for you? https://reviews.llvm.org/D36973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D38755: Fixed crash during indexing default template template param

This revision was automatically updated to reflect the committed changes. Closed by commit rL315367: Fix indexer crash for default template template parameter value (authored by jkorous). Changed prior to commit: https://reviews.llvm.org/D38755?vs=118451&id=118476#toc Repository: rL LLVM ht

r315367 - Fix indexer crash for default template template parameter value

Author: jkorous Date: Tue Oct 10 14:09:49 2017 New Revision: 315367 URL: http://llvm.org/viewvc/llvm-project?rev=315367&view=rev Log: Fix indexer crash for default template template parameter value rdar://33058798 Differential Revision: https://reviews.llvm.org/D38755 Added: cfe/trunk/test/

r315366 - Add test for regression caused by reverted patch r315251.

Author: rsmith Date: Tue Oct 10 14:07:44 2017 New Revision: 315366 URL: http://llvm.org/viewvc/llvm-project?rev=315366&view=rev Log: Add test for regression caused by reverted patch r315251. Modified: cfe/trunk/test/SemaCXX/linkage2.cpp Modified: cfe/trunk/test/SemaCXX/linkage2.cpp URL: htt

r315358 - [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

Author: carrot Date: Tue Oct 10 13:31:27 2017 New Revision: 315358 URL: http://llvm.org/viewvc/llvm-project?rev=315358&view=rev Log: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType() Usually compare expression should return i1 type, so EmitScalarConversion i

[PATCH] D38755: Fixed crash during indexing default template template param

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D38755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D38402: [clang-refactor] Apply source replacements

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D38402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D38402: [clang-refactor] Apply source replacements

arphaman updated this revision to Diff 118471. arphaman marked 6 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D38402 Files: include/clang/Frontend/CommandLineSourceLoc.h test/Refactor/tool-apply-replacements.cpp

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

This revision was automatically updated to reflect the committed changes. Closed by commit rL315358: [CGExprScalar] In EmitCompare trunc the result if it has different type as E… (authored by Carrot). Changed prior to commit: https://reviews.llvm.org/D38656?vs=118236&id=118464#toc Repository:

r315355 - Revert "[clang-fuzzer] Allow building without coverage instrumentation."

Author: morehouse Date: Tue Oct 10 13:13:13 2017 New Revision: 315355 URL: http://llvm.org/viewvc/llvm-project?rev=315355&view=rev Log: Revert "[clang-fuzzer] Allow building without coverage instrumentation." This reverts r315336 due to build breakage with gcc. http://lab.llvm.org:8011/builders/u

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a comment. Thanks for the pointer to that patch, I'll take a look tomorrow. Comment at: src/UnwindRegistersRestore.S:492 +#elif defined(__mips__) && _MIPS_SIM == _ABIO32 + Needs checking for soft-float. Comment at: src/UnwindR

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov added inline comments. Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29 + // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar c#>, <#ns::baz d#> + // CHECK-2: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz c#>

[PATCH] D38755: Fixed crash during indexing default template template param

jkorous-apple created this revision. fix + testcase https://reviews.llvm.org/D38755 Files: lib/Index/IndexDecl.cpp test/Index/index-template-template-param.cpp Index: test/Index/index-template-template-param.cpp === --- /dev/

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

bader updated this revision to Diff 118437. bader added a comment. Applied comments. https://reviews.llvm.org/D33681 Files: lib/Parse/ParseDecl.cpp lib/Sema/SemaType.cpp test/SemaOpenCL/func.cl test/SemaOpenCL/invalid-pipes-cl2.0.cl Index: test/SemaOpenCL/invalid-pipes-cl2.0.cl ==

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:144 + if (auto *I = dyn_cast(V)) { +// If the block literal is emitted as an instruction, it is an alloca +// and the block invoke function is stored to GEP

[libclc] r315342 - travis: Enable external function call checks on llvm-{4, 5}

Author: jvesely Date: Tue Oct 10 11:10:24 2017 New Revision: 315342 URL: http://llvm.org/viewvc/llvm-project?rev=315342&view=rev Log: travis: Enable external function call checks on llvm-{4,5} Reviewer: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libc

[libclc] r315341 - Make image builtins r600/llvm-3.9 only

Author: jvesely Date: Tue Oct 10 11:10:21 2017 New Revision: 315341 URL: http://llvm.org/viewvc/llvm-project?rev=315341&view=rev Log: Make image builtins r600/llvm-3.9 only The implementation uses r600 sepcific intrinsics LLVM-4 switched to _ro_t and _rw_t image types Portions of the code can be

[libclc] r315343 - travis: enable checks of nvptx libraries

Author: jvesely Date: Tue Oct 10 11:10:25 2017 New Revision: 315343 URL: http://llvm.org/viewvc/llvm-project?rev=315343&view=rev Log: travis: enable checks of nvptx libraries Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libclc/trunk/.travis

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

arphaman added inline comments. Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29 + // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar c#>, <#ns::baz d#> + // CHECK-2: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz c#> +} -

r315339 - [clang-fuzzer] Build proto-to-cxx with fuzzer-no-link.

Author: morehouse Date: Tue Oct 10 10:59:37 2017 New Revision: 315339 URL: http://llvm.org/viewvc/llvm-project?rev=315339&view=rev Log: [clang-fuzzer] Build proto-to-cxx with fuzzer-no-link. Makes it possible to build with any sanitizer or none at all. Modified: cfe/trunk/tools/clang-fuzzer/

r315338 - [lit] Add host_cxx to lit config

Author: fjricci Date: Tue Oct 10 10:53:45 2017 New Revision: 315338 URL: http://llvm.org/viewvc/llvm-project?rev=315338&view=rev Log: [lit] Add host_cxx to lit config Summary: This is required to get the clang version for sanitized builds. Reviewers: zturner Subscribers: llvm-commits Different

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38642: [clang-fuzzer] Allow building without coverage instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315336: [clang-fuzzer] Allow building without coverage instrumentation. (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D38642?vs=118097&id=118420#toc Repository: rL LLVM

r315336 - [clang-fuzzer] Allow building without coverage instrumentation.

Author: morehouse Date: Tue Oct 10 10:41:43 2017 New Revision: 315336 URL: http://llvm.org/viewvc/llvm-project?rev=315336&view=rev Log: [clang-fuzzer] Allow building without coverage instrumentation. Summary: Compile with DummyClangFuzzer.cpp as entry point rather than libFuzzer's main when cover

[PATCH] D38567: [config] Warn when POSIX_C_SOURCE breaks threading support on Darwin

vsk abandoned this revision. vsk added a comment. For those following along, Alex worked out that this doesn't affect apple-clang 802. We took a closer look and found that the build break just affects clang-900, and was introduced in this r290889. The fix (r293167) didn't make it into clang-900

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

Carrot added a comment. In https://reviews.llvm.org/D38656#892740, @nemanjai wrote: > In https://reviews.llvm.org/D38656#892072, @Carrot wrote: > > > I worked on a similar bug as 31161, and then found this one, it should be > > same as in comment7. > > What is the current status of the work on

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

Anastasia accepted this revision. Anastasia added a comment. I would prefer to merge the new test with test/SemaOpenCL/func.cl, but otherwise LGTM! Thanks! https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added a comment. > (*) I know that you aren't considering OpenCL C++ yet, but often these > representation/model questions are easier to answer when thinking about C++ > instead of C because type differences are so much more directly important in > C++. In OpenCL C++, I assume it w

[PATCH] D38742: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions in sm_70

tra created this revision. Herald added subscribers: sanjoy, jholewinski. https://reviews.llvm.org/D38742 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-nvptx-sm_70.cu Index: clang/test/CodeGen/builtins-nvptx-sm_70.cu

r315330 - For dllexport class templates, export specializations of member functions (PR34849) (take 2)

Author: hans Date: Tue Oct 10 09:53:25 2017 New Revision: 315330 URL: http://llvm.org/viewvc/llvm-project?rev=315330&view=rev Log: For dllexport class templates, export specializations of member functions (PR34849) (take 2) This is a re-commit of r315025, but making sure to only apply this to sp

[PATCH] D38567: [config] Warn when POSIX_C_SOURCE breaks threading support on Darwin

arphaman added inline comments. Comment at: include/__threading_support:26 +#if (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && (__MAC_OS_X_VERSION_MIN_REQUIRED < 101300)) \ +|| (defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && (__IPHONE_OS_VERSION_MIN_REQUIRED < 11)) \

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:144 + if (auto *I = dyn_cast(V)) { +// If the block literal is emitted as an instruction, it is an alloca +// and the block invoke function is stored to GEP of this alloca. yaxu

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

bsdjhb added a comment. I keep running into issues trying to cross-build LLVM (it keeps wanting to use /usr/bin/cc or host libraries even though cross-compiling is enabled). I wonder if the failures you saw Simon might be due to https://bugs.llvm.org/show_bug.cgi?id=33858? Could you try apply

[clang-tools-extra] r315325 - [clangd] Use UniqueFunction for deferred computations.

Author: ibiryukov Date: Tue Oct 10 09:12:54 2017 New Revision: 315325 URL: http://llvm.org/viewvc/llvm-project?rev=315325&view=rev Log: [clangd] Use UniqueFunction for deferred computations. Previsouly, `std::future` that were results of `std::async(std::launch::deferred, ...` were used. Modifie

[clang-tools-extra] r315323 - [clangd] Added forgotten return in UniqueFunction.

Author: ibiryukov Date: Tue Oct 10 09:12:47 2017 New Revision: 315323 URL: http://llvm.org/viewvc/llvm-project?rev=315323&view=rev Log: [clangd] Added forgotten return in UniqueFunction. This hasn't bitten us because we only used functions returning 'void'. Modified: clang-tools-extra/trunk/

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

No :( I tried reverting only r315256 but still got the errors. On Tue, Oct 10, 2017 at 6:10 PM Richard Smith wrote: > On 10 Oct 2017 05:41, "Eric Liu via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Hi Richard, > > This is breaking the boostrap stage in the internal integration. I'm >

[clang-tools-extra] r315324 - [clangd] Added missing #includes to Function.h

Author: ibiryukov Date: Tue Oct 10 09:12:50 2017 New Revision: 315324 URL: http://llvm.org/viewvc/llvm-project?rev=315324&view=rev Log: [clangd] Added missing #includes to Function.h Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h URL:

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

On 10 Oct 2017 05:41, "Eric Liu via cfe-commits" wrote: Hi Richard, This is breaking the boostrap stage in the internal integration. I'm seeing "unsupported: typedef changes linkage of anonymous type, but linkage was already computed" error for many `struct`s defined with typedef. I'm not sure i

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

Thanks for reverting. We saw build failures in Chromium too. E.g. from https://build.chromium.org/p/chromium.clang/builders/ToTLinux/builds/134: In file included from ../../third_party/breakpad/breakpad/src/common/linux/symbol_upload.cc:34: ../../third_party/breakpad/breakpad/src/common/linux/sym

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

martong added inline comments. Comment at: lib/StaticAnalyzer/Core/IssueHash.cpp:39 + // primary template. + if (const FunctionDecl *InstantiatedFrom = + Target->getInstantiatedFromMemberFunction()) Could we use here FunctionDecl::getPrimaryTemplate()

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k created this revision. Changed Header files of the intrinsics fro lowering test and testn intrinsics to IR code. Removed test and testn builtins from clang this is the clang side, the llvm side revision is D38736 . https://reviews.llvm.org/D38737 File

[PATCH] D38733: [CodeGen] Generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. This patch enables explicit generation of TBAA information in all cases where LValue base info is propagated or constructed in non-trivial ways. Eventually, we will consider each of these cases to make sure the TBAA information is c

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

mppf added a comment. Since I don't have commit access, could somebody commit this for me please? Thanks. https://reviews.llvm.org/D38473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] r315317 - [clangd] clang-format the source code. NFC.

Author: ibiryukov Date: Tue Oct 10 07:21:04 2017 New Revision: 315317 URL: http://llvm.org/viewvc/llvm-project?rev=315317&view=rev Log: [clangd] clang-format the source code. NFC. Modified: clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp clang-tools-extra/trunk/clangd/Protoco

[PATCH] D38731: [clangd] Allow to pass code completion opts to ClangdServer.

ilya-biryukov created this revision. https://reviews.llvm.org/D38731 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h unittests/clangd/ClangdTests.cpp Index: unittests/clangd/ClangdTests.cpp

r315315 - [OPENMP] Add default codegen|tests for 'target parallel for[ simd]'

Author: abataev Date: Tue Oct 10 07:14:43 2017 New Revision: 315315 URL: http://llvm.org/viewvc/llvm-project?rev=315315&view=rev Log: [OPENMP] Add default codegen|tests for 'target parallel for[ simd]' constructs. Added default codegen for 'target parallel for' construct + tests for default codeg

r315314 - Fix a (slightly weird) 'comma operator within array index expression' warning on VS builds. NFCI.

Author: rksimon Date: Tue Oct 10 06:56:17 2017 New Revision: 315314 URL: http://llvm.org/viewvc/llvm-project?rev=315314&view=rev Log: Fix a (slightly weird) 'comma operator within array index expression' warning on VS builds. NFCI. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modifie

[PATCH] D38723: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg with nits. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:163 const NestedNameSpecifier *Specifier; +// Determine whether the prefix qualifiers of th

[PATCH] D38452: Mark test as a long-test

rogfer01 added a comment. Friendly ping :) https://reviews.llvm.org/D38452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

FYI, I tweaked the tree in rL315283. Shall we restore it? On Tue, Oct 10, 2017 at 9:41 PM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > This is breaking the boostrap stage in the internal integration. I'm > seeing "unsupported: typedef changes linkage of anonymou

r315309 - Revert "[Modules TS] Module ownership semantics for redeclarations."

Author: ioeric Date: Tue Oct 10 06:09:40 2017 New Revision: 315309 URL: http://llvm.org/viewvc/llvm-project?rev=315309&view=rev Log: Revert "[Modules TS] Module ownership semantics for redeclarations." This reverts commit r315251. See the original commit thread for reason. Removed: cfe/trunk

[PATCH] D38683: [X86][AVX512] lowering broadcastm intrinsic - clang part

RKSimon added inline comments. Comment at: test/CodeGen/avx512cdintrin.c:106 + // CHECK: insertelement <16 x i32> %{{.*}}, i32 %{{.*}} + return _mm512_broadcastmw_epi32(_mm512_cmpeq_epi32_mask ( a, b)); } Any reason why you can't use the actual insertion indi

r315308 - Revert "[Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module."

Author: ioeric Date: Tue Oct 10 06:00:18 2017 New Revision: 315308 URL: http://llvm.org/viewvc/llvm-project?rev=315308&view=rev Log: Revert "[Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module." This reverts commit r315256. See the origina

  1   2   >