NoQ added inline comments.
Comment at: test/Analysis/casts.c:134-139
+ clang_analyzer_eval(y1 == y2); // expected-warning{{TRUE}}
+
+ // FIXME: should be FALSE (i.e. equal pointers).
+ clang_analyzer_eval(y1 - y2); // expected-warning{{UNKNOWN}}
+ // FIXME: should be TRUE (i.
NoQ created this revision.
Herald added a subscriber: szepet.
In https://bugs.llvm.org/show_bug.cgi?id=34460 CStringChecker tries to
`evalCast()` a memory region from `void *` to `char *` for the purposes of
modeling `mempcpy()`. The memory region turned out to be an element region of
type `uns
kosarev created this revision.
kosarev added a project: clang.
Prepared on top of https://reviews.llvm.org/D38795.
Repository:
rL LLVM
https://reviews.llvm.org/D38796
Files:
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.cpp
CodeGen/CodeGenFunction.h
CodeGen/CodeGenModule.cpp
CodeGen/C
mstorsjo added a comment.
@mgrang, did you ever get to completing this? I've got a need for this now
(only `__dmb` so far), and if you don't have time, I can try to finish it.
https://reviews.llvm.org/D36111
___
cfe-commits mailing list
cfe-commits
baloghadamsoftware added a comment.
I tried to extend the type to avoid overflow scenarios. Unfortunately, this
breaks essential calculations based on the overflow scenarios (e.g.
ProgramSate::assumeInbound()). So I see no other option than to abandon this
patch and return to the local solution
hamzasood added a comment.
I have access now, so I'm able to commit this myself.
However it's been a while since it was approved, so I'd be grateful if someone
could take another look to make sure nothing has changed in the meantime
(besides potentially needing to re-tag some new APIs).
https:
martong added inline comments.
Comment at: test/Analysis/bug_hash_test.cpp:105
+void g() {
+ TX x;
+ TX xl;
As we discussed, the checking of the equality of the `IssueString` in case of
`TX` and `TX` is implicit. And as such it is hard to see that it
is reall
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/IssueHash.cpp:39
+ // primary template.
+ if (const FunctionDecl *InstantiatedFrom =
+ Target->getInstantiatedFromMemberFunction())
martong wrote:
> Could we use here FunctionDecl::ge
kosarev created this revision.
kosarev added a project: clang.
Prepared on top of https://reviews.llvm.org/D38733.
Repository:
rL LLVM
https://reviews.llvm.org/D38795
Files:
CodeGen/CGExpr.cpp
Index: CodeGen/CGExpr.cpp
===
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315453: [OpenCL] Allow function declaration with empty
argument list. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D33681?vs=118437&id=118588#toc
Repository:
rL LLVM
https:
Author: hokein
Date: Wed Oct 11 04:15:48 2017
New Revision: 315452
URL: http://llvm.org/viewvc/llvm-project?rev=315452&view=rev
Log:
[clang-rename] Don't add prefix qualifiers to the declaration and definition of
the renamed symbol.
Reviewers: ioeric
Reviewed By: ioeric
Subscribers: klimek, cf
Author: bader
Date: Wed Oct 11 04:16:31 2017
New Revision: 315453
URL: http://llvm.org/viewvc/llvm-project?rev=315453&view=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Treat 'f()' as 'f(void)' rather than a function w/o a prototype.
Reviewers: Anastasia, yaxunl
Reviewe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315452: [clang-rename] Don't add prefix qualifiers to the
declaration and definition of… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D38723?vs=118573&id=118587#toc
Repositor
kosarev created this revision.
kosarev added a project: clang.
This patch should not bring in any functional changes. Prepared on top of
https://reviews.llvm.org/D38733, https://reviews.llvm.org/D38788,
https://reviews.llvm.org/D38791 and https://reviews.llvm.org/D38793.
Repository:
rL LLVM
kosarev created this revision.
kosarev added a project: clang.
Repository:
rL LLVM
https://reviews.llvm.org/D38793
Files:
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.h
Index: CodeGen/CodeGenFunction.h
===
--- CodeGen/CodeGenF
kosarev created this revision.
kosarev added a project: clang.
This patch should not bring in any functional changes. Prepared on top of
https://reviews.llvm.org/D38733.
Repository:
rL LLVM
https://reviews.llvm.org/D38791
Files:
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.h
Index: Code
hokein updated this revision to Diff 118573.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D38723
Files:
lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
unittests/Rename/RenameClassTest.cpp
Index: unittests/Rename/RenameC
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
kosarev created this revision.
kosarev added a project: clang.
Prepared on top of https://reviews.llvm.org/D38733.
Repository:
rL LLVM
https://reviews.llvm.org/D38788
Files:
CodeGen/CGClass.cpp
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.h
Index: CodeGen/CodeGenFunction.h
hokein added a comment.
The code looks most good to me, a few nits.
Comment at: lib/Basic/DiagnosticIDs.cpp:46
unsigned WarnShowInSystemHeader : 1;
- unsigned Category : 5;
+ unsigned Category : 6;
just curious: is this change needed?
kosarev updated this revision to Diff 118551.
kosarev added a comment.
Removed changes related to functions like getNaturalTypeAlignment() that
generate LValue base info objects to simplify the patch. These removed changes
will be addressed with separate patches.
https://reviews.llvm.org/D3873
jklaehn added a comment.
In https://reviews.llvm.org/D36955#893856, @jbcoe wrote:
> LGTM
>
> Would you like me to commit this for you?
Yes, I would appreciate it.
https://reviews.llvm.org/D36955
___
cfe-commits mailing list
cfe-commits@lists.llvm
jklaehn marked an inline comment as done.
jklaehn added a comment.
In https://reviews.llvm.org/D36973#893851, @jbcoe wrote:
> LGTM
>
> Would you like me to commit this for you?
Yes, that would be great!
https://reviews.llvm.org/D36973
___
cfe-com
hokein accepted this revision.
hokein added a comment.
LGTM, let's check in it.
Repository:
rL LLVM
https://reviews.llvm.org/D38402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Wed Oct 11 00:47:54 2017
New Revision: 315439
URL: http://llvm.org/viewvc/llvm-project?rev=315439&view=rev
Log:
Revert r314955: "Remove PendingBody mechanism for function and ObjC method
deserialization."
This is breaking a build of https://github.com/abseil/abseil-cpp and
101 - 125 of 125 matches
Mail list logo
