[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

2017-10-14 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. I don't think we should depend on LLVM for the locking stuff. This sort of infrastructure is in the same bucket as the demangler which we haven't really solved. I *do* find it weird to do it this way though. I think you should have some mutex functions which include

r315845 - [Lex] Remove unused variables. No functionality change.

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 21:27:37 2017 New Revision: 315845 URL: http://llvm.org/viewvc/llvm-project?rev=315845=rev Log: [Lex] Remove unused variables. No functionality change. Modified: cfe/trunk/include/clang/Lex/VariadicMacroSupport.h cfe/trunk/lib/Lex/TokenLexer.cpp Modified:

r315842 - [c++2a] Fix failing regression test related to not adding the extension warning to a diagnostic group (in r315840)

2017-10-14 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Sat Oct 14 19:13:17 2017 New Revision: 315842 URL: http://llvm.org/viewvc/llvm-project?rev=315842=rev Log: [c++2a] Fix failing regression test related to not adding the extension warning to a diagnostic group (in r315840) In passing also complete a comment that I left

r315840 - [c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion)

2017-10-14 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Sat Oct 14 18:26:26 2017 New Revision: 315840 URL: http://llvm.org/viewvc/llvm-project?rev=315840=rev Log: [c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion) This patch implements an extension to the preprocessor: __VA_OPT__(contents) --> which expands

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

2017-10-14 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: include/unwind.h:125 uintptr_t private_2; // holds sp that phase1 found for phase2 to use -#ifndef __LP64__ +#if !defined(__LP64__) && !defined(_WIN64) // The implementation of _Unwind_Exception uses an attribute mode on the

r315831 - Revert "Mark test as unsupported until r315808 is fixed"

2017-10-14 Thread Konstantin Zhuravlyov via cfe-commits
Author: kzhuravl Date: Sat Oct 14 15:24:31 2017 New Revision: 315831 URL: http://llvm.org/viewvc/llvm-project?rev=315831=rev Log: Revert "Mark test as unsupported until r315808 is fixed" Test is fixed in r315830 Modified: cfe/trunk/test/Misc/backend-resource-limit-diagnostics.cl Modified:

r315829 - Mark test as unsupported until r315808 is fixed

2017-10-14 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Sat Oct 14 15:14:23 2017 New Revision: 315829 URL: http://llvm.org/viewvc/llvm-project?rev=315829=rev Log: Mark test as unsupported until r315808 is fixed This is causing: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/43381 Modified:

[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

2017-10-14 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D38704#892479, @zturner wrote: > I'm a little nervous about re-inventing a poor man's version of a reader > writer lock. Can we not just copy LLVM's? I had a closer look at this, and noticed the following: - The LLVM RWMutex class on

[PATCH] D37905: [libclang, bindings]: add spelling location

2017-10-14 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn added inline comments. Comment at: bindings/python/clang/cindex.py:214 +class Location(object): +"""A Location is a specific kind of source location. A SourceLocation Can you also add `Location` to `__all__`? https://reviews.llvm.org/D37905

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-10-14 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 119035. Rakete added a comment. Rebased and friendly ping :) https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp test/Parser/cxx1z-class-template-argument-deduction.cpp

[PATCH] D38675: [analyzer] MisusedMovedObjectChecker: Moving the checker out of alpha state

2017-10-14 Thread Peter Szecsi via Phabricator via cfe-commits
szepet updated this revision to Diff 119032. szepet added a comment. Test file (running line) update. https://reviews.llvm.org/D38675 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td test/Analysis/MisusedMovedObject.cpp Index: test/Analysis/MisusedMovedObject.cpp

[PATCH] D38900: libunwind: document tested FreeBSD configs and sort OS list

2017-10-14 Thread Ed Maste via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315814: libunwind: document tested FreeBSD configs and sort OS list (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D38900?vs=118958=119031#toc Repository: rL LLVM

[libunwind] r315814 - libunwind: document tested FreeBSD configs and sort OS list

2017-10-14 Thread Ed Maste via cfe-commits
Author: emaste Date: Sat Oct 14 10:04:04 2017 New Revision: 315814 URL: http://llvm.org/viewvc/llvm-project?rev=315814=rev Log: libunwind: document tested FreeBSD configs and sort OS list libunwind is known to work on FreeBSD i386, amd64 (x86_64) and arm64. It is the unwinder provided by the

[PATCH] D38900: libunwind: document tested FreeBSD configs and sort OS list

2017-10-14 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Seems ok to me, with whatever other architectures it's verified on as well. https://reviews.llvm.org/D38900 ___ cfe-commits mailing list

r315811 - Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 08:59:34 2017 New Revision: 315811 URL: http://llvm.org/viewvc/llvm-project?rev=315811=rev Log: Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer." The warnings in libc++ tests were fixed in the meantime. Modified:

[libcxx] r315809 - Placate unused variable warnings uncovered by improvements to clang's -Wunused-variable

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 08:52:38 2017 New Revision: 315809 URL: http://llvm.org/viewvc/llvm-project?rev=315809=rev Log: Placate unused variable warnings uncovered by improvements to clang's -Wunused-variable Modified: libcxx/trunk/test/libcxx/depr/depr.c.headers/complex.h.pass.cpp

[PATCH] D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer.

2017-10-14 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni added subscribers: EricWF, chapuni. chapuni added a comment. Excuse me, I have reverted it in https://reviews.llvm.org/rL315806. check-libcxx dislikes it. See also; http://bb9.pgr.jp/#/builders/20/builds/111 Repository: rL LLVM https://reviews.llvm.org/D38678

r315806 - Revert rL315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-14 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Oct 14 07:46:04 2017 New Revision: 315806 URL: http://llvm.org/viewvc/llvm-project?rev=315806=rev Log: Revert rL315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer." check-libcxx dislikes it. Modified:

[PATCH] D38922: [analyzer] LoopUnrolling: check the bitwidth of the used numbers (pr34943)

2017-10-14 Thread Peter Szecsi via Phabricator via cfe-commits
szepet created this revision. Herald added subscribers: baloghadamsoftware, whisperity. The loop unrolling feature aims to track the maximum possible steps a loop can make. In order to implement this, it investigates the initial value of the counter variable and the bound number. (There has to

r315805 - Fix build failure on android due to missing std::to_string()

2017-10-14 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Sat Oct 14 05:51:52 2017 New Revision: 315805 URL: http://llvm.org/viewvc/llvm-project?rev=315805=rev Log: Fix build failure on android due to missing std::to_string() Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

2017-10-14 Thread Peter Szecsi via Phabricator via cfe-commits
szepet created this revision. Herald added subscribers: baloghadamsoftware, whisperity. Extended the matched assignment operators when checking for bound changes in a body of the loop. This updated list covers all the (current) possible assignments. https://reviews.llvm.org/D38921 Files:

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

2017-10-14 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315804: [OpenCL] Emit enqueued block as kernel (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D38134?vs=118795=119017#toc Repository: rL LLVM

r315804 - [OpenCL] Emit enqueued block as kernel

2017-10-14 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Sat Oct 14 05:23:50 2017 New Revision: 315804 URL: http://llvm.org/viewvc/llvm-project?rev=315804=rev Log: [OpenCL] Emit enqueued block as kernel In OpenCL the kernel function and non-kernel function has different calling conventions. For certain targets they have different

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

2017-10-14 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! Great work! https://reviews.llvm.org/D38816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38919: [libcxx] Implemented from Library Fundamentals V2

2017-10-14 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood created this revision. This patch implements make_array and to_array from the Library Fundamentals V2 TS. https://reviews.llvm.org/D38919 Files: include/experimental/array test/std/experimental/container/array/creation/make_array.fail.cpp