jina.nahias added inline comments.
Comment at: test/CodeGen/avx512f-builtins.c:6231
+ // CHECK: bitcast <16 x i1> %{{.*}} to i16
+ // CHECK: and i32 %{{.*}}, 255
+ // CHECK: shl i32 %{{.*}}, 8
craig.topper wrote:
> Does this really produce kunpackb in the back
Author: marshall
Date: Sun Nov 12 20:15:39 2017
New Revision: 318012
URL: http://llvm.org/viewvc/llvm-project?rev=318012&view=rev
Log:
Put the status in the wrong column
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
URL:
http://llvm.org/viewvc/llv
Author: marshall
Date: Sun Nov 12 19:59:22 2017
New Revision: 318011
URL: http://llvm.org/viewvc/llvm-project?rev=318011&view=rev
Log:
Implement P0550R2: Transformation Trait remove_cvref
Added:
libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.other/remove_cvref.pass.cpp
Modified:
mgrang added a comment.
In https://reviews.llvm.org/D39947#922889, @rjmccall wrote:
> In https://reviews.llvm.org/D39947#922870, @mgrang wrote:
>
> > Although this patches fixes the above unit test failures, the generated
> > code is very different from the one that the tests expect. As a result
sgolemon added a comment.
Fixed in parallel by https://reviews.llvm.org/D39013
https://reviews.llvm.org/D38892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
I think the implementation looks fine. The metadata design also sounds good to
me, but I'd like Hal to weigh in before you commit.
Repository:
rL LLVM
https://reviews.llvm.org/D39455
___
cfe-commits mailing list
cfe-co
rjmccall added a comment.
That's the template type-propagation problem: the template was invoked with a
size_t, but that's erased down to the canonical type by the template machinery.
That can't be fixed within the template, but at use sites, we could
theoretically recognize that e.g. the resu
lebedev.ri added a comment.
In https://reviews.llvm.org/D39462#922847, @rjmccall wrote:
> In https://reviews.llvm.org/D39462#922844, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D39462#922826, @rjmccall wrote:
> >
> > > I don't speak for the entire project, but I'm not sure I'm interested
rwols marked 4 inline comments as done.
rwols added a comment.
Is this ready to merge? I'd like to implement tests in another differential,
I'm having trouble referencing a temp dir from `lit` in a JSON request to
clangd.
Comment at: clangd/ClangdServer.cpp:429
+ auto Tagged
rwols updated this revision to Diff 122606.
rwols added a comment.
- Merge with upstream, fix merge conflicts
- Add a FIXME for a caching strategy for .clang-format files
https://reviews.llvm.org/D39430
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clan
rjmccall added a comment.
In https://reviews.llvm.org/D39947#922870, @mgrang wrote:
> Although this patches fixes the above unit test failures, the generated code
> is very different from the one that the tests expect. As a result, these
> tests need to be adjusted. Could the reviewers please c
rjmccall added a comment.
I see. The problem now, though, is that things involving, say, a size_t and a
numeric_limits will never warn.
Repository:
rL LLVM
https://reviews.llvm.org/D39462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kastiglione created this revision.
Herald added a subscriber: klimek.
Allow the `isDefinition()` matcher to apply to `ObjCMethodDecl` nodes, in
addition to those it already supports. For whatever reason, `ObjCMethodDecl`
does not inherit from `FunctionDecl` and so this is specialization is necessa
xgsa added a comment.
In https://reviews.llvm.org/D39622#919579, @aprantl wrote:
> For clarification: what is the "symbols table" you are referring to in the
> description?
I meant the data dumped with "nm -an ./test".
By the way, I haven't abandoned the patch, I have found one more case when
On Thu, Nov 09, 2017 at 05:37:32PM -0800, Volodymyr Sapsai wrote:
> On Nov 9, 2017, at 12:13, Reimar Döffinger wrote:
> >
> > Hello!
> >
> > On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote:
> >> Thanks for the patch, Reimar. Can you please add tests to ensure this
> >> function
mgrang added a comment.
Although this patches fixes the above unit test failures, the generated code is
very different from the one that the tests expect. As a result, these tests
need to be adjusted. Could the reviewers please comment/suggest on whether it
is ok to fix the tests as a result of
mgrang created this revision.
mgrang added a project: clang.
This fixes the following failures uncovered by https://reviews.llvm.org/D39245:
Clang :: OpenMP/task_firstprivate_codegen.cpp
Clang :: OpenMP/task_private_codegen.cpp
Clang :: OpenMP/taskloop_firstprivate_codegen.cpp
Clang :: Op
lebedev.ri added a comment.
In https://reviews.llvm.org/D39462#922826, @rjmccall wrote:
> I don't speak for the entire project, but I'm not sure I'm interested in the
> diagnostic you're actually offering to contribute here. It may produce a
> warning on your specific test case, but I think it
smeenai added a comment.
In https://reviews.llvm.org/D39462#922847, @rjmccall wrote:
> In https://reviews.llvm.org/D39462#922844, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D39462#922826, @rjmccall wrote:
> >
> > > I don't speak for the entire project, but I'm not sure I'm interested in
rjmccall added a comment.
I don't speak for the entire project, but I'm not sure I'm interested in the
diagnostic you're actually offering to contribute here. It may produce a
warning on your specific test case, but I think it's really much too rigid and
will lead to massive false positives.
Agreed! Just wanted to do it but then I noticed that there's already one
that landed in r307791! :)
On Sun, Oct 29, 2017 at 2:06 PM, Kim Gräsman wrote:
> A clang-tidy check to remove empty messages from source would be nice,
> though...
>
> - Kim
>
> Den 27 okt. 2017 10:24 fm skrev "Nicolas Less
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Hmm. It looks like the intent is for CompareOverloadCandidatesForDisplay to be
a total order, but I'm sure there are cases where it isn't. Okay, LGTM.
https://reviews.llvm.org/D39944
rjmccall added a comment.
In https://reviews.llvm.org/D39462#922844, @lebedev.ri wrote:
> In https://reviews.llvm.org/D39462#922826, @rjmccall wrote:
>
> > I don't speak for the entire project, but I'm not sure I'm interested in
> > the diagnostic you're actually offering to contribute here. It
Author: marshall
Date: Sun Nov 12 10:52:16 2017
New Revision: 318000
URL: http://llvm.org/viewvc/llvm-project?rev=318000&view=rev
Log:
Two more papers from Albuquerque
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
URL:
http://llvm.org/viewvc/llvm-
Author: marshall
Date: Sun Nov 12 10:48:42 2017
New Revision: 317996
URL: http://llvm.org/viewvc/llvm-project?rev=317996&view=rev
Log:
Updated C++2a status page with new features/defects approved in Albuquerque.
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_st
mgrang created this revision.
mgrang added a project: clang.
This fixes failure in Misc/diag-template-diffing.cpp uncovered by
https://reviews.llvm.org/D39245.
https://reviews.llvm.org/D39944
Files:
lib/Sema/SemaOverload.cpp
Index: lib/Sema/SemaOverload.cpp
26 matches
Mail list logo
