kastiglione updated this revision to Diff 123131.
kastiglione added a comment.
Add tests
https://reviews.llvm.org/D40024
Files:
lib/Tooling/ArgumentsAdjusters.cpp
unittests/Tooling/ToolingTest.cpp
Index: unittests/Tooling/ToolingTest.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318383: [docs] Mention that dwarf unwinding should be
supported on arm64/windows (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D39632?vs=121601&id=123130#toc
Repository:
r
Author: mstorsjo
Date: Wed Nov 15 23:16:36 2017
New Revision: 318383
URL: http://llvm.org/viewvc/llvm-project?rev=318383&view=rev
Log:
[docs] Mention that dwarf unwinding should be supported on arm64/windows
This didn't require any further changes to libunwind as long as win64
in general is handl
Author: marshall
Date: Wed Nov 15 21:48:32 2017
New Revision: 318378
URL: http://llvm.org/viewvc/llvm-project?rev=318378&view=rev
Log:
More of P0600 - '[[nodiscard]] in the Library' mark empty() as nodiscard in
filesystem::path
Added:
libcxx/trunk/test/std/experimental/filesystem/class.path
Author: marshall
Date: Wed Nov 15 20:48:34 2017
New Revision: 318375
URL: http://llvm.org/viewvc/llvm-project?rev=318375&view=rev
Log:
More of P0600 - '[[nodiscard]] in the Library' mark empty() as nodiscard in
match_results.
Added:
libcxx/trunk/test/std/re/re.results/re.results.size/empty.
alexfh added a comment.
And, btw, sorry for the long delay. I've been on travelling / on vacation for
the last few weeks.
https://reviews.llvm.org/D38171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
alexfh added a comment.
In https://reviews.llvm.org/D38171#925929, @xazax.hun wrote:
> In https://reviews.llvm.org/D38171#909346, @leanil wrote:
>
> > In https://reviews.llvm.org/D38171#901427, @xazax.hun wrote:
> >
> > > One problem to think about when we add all clang-diagnostic as "first or
>
Author: echristo
Date: Wed Nov 15 19:18:09 2017
New Revision: 318371
URL: http://llvm.org/viewvc/llvm-project?rev=318371&view=rev
Log:
Add NDEBUG checks around LLVM_DUMP_METHOD functions for Wunused-function
warnings.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp
Eugene.Zelenko added a comment.
Please mention new module in docs/clang-tidy/index.rst.
Repository:
rL LLVM
https://reviews.llvm.org/D40108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:31
+ void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
+
+CheckFactories.registerCheck(
Please remove empty line.
Comment a
zturner added a comment.
I'm not suuuper opposed, but at the same time if this code is bothering people
(and it is, consistently), I don't changing the requirements from "confusing
rule A" to "confusing rule B" is going to solve the long term burden that
people keep running into.
Not asking yo
Eugene.Zelenko added a comment.
Please split this review with one check per review.
Comment at: docs/ReleaseNotes.rst:83
+
+ Check to prevent creation of statically-stored objects in Fuchsia.
+
Please fix double space
Comment at: docs/clang
rnk added a comment.
This seems to cause a crash on startup in some gtest binaries when I self-host,
so I guess I should debug that tomorrow before committing. The rest of clang's
tests pass. I guess we don't use virtual inheritance. =S
https://reviews.llvm.org/D40109
__
Author: wizard
Date: Wed Nov 15 17:28:29 2017
New Revision: 318366
URL: http://llvm.org/viewvc/llvm-project?rev=318366&view=rev
Log:
add check to avoid throwing objc exception according to Google Objective-C guide
Summary:
This is a small check to avoid throwing objc exceptions.
In specific it wi
Author: arphaman
Date: Wed Nov 15 17:31:27 2017
New Revision: 318367
URL: http://llvm.org/viewvc/llvm-project?rev=318367&view=rev
Log:
[DeclPrinter] Extract function PrintConstructorInitializers, NFC
Patch by Nikolai Kosjar!
Differential Revision: https://reviews.llvm.org/D40066
Modified:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318366: add check to avoid throwing objc exception according
to Google Objective-C guide (authored by Wizard).
Repository:
rL LLVM
https://reviews.llvm.org/D40058
Files:
clang-tools-extra/trunk/clan
Author: arphaman
Date: Wed Nov 15 17:28:25 2017
New Revision: 318365
URL: http://llvm.org/viewvc/llvm-project?rev=318365&view=rev
Log:
[DeclPrinter] Honor TerseOutput for constructors
Patch by Nikolai Kosjar!
Differential Revision: https://reviews.llvm.org/D39957
Modified:
cfe/trunk/lib/AST
compnerd created this revision.
Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff, jfb.
This option is not used in the frontend. Remove the method.
Repository:
rL LLVM
https://reviews.llvm.org/D40115
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChains/BareMe
compnerd added a comment.
@rjmccall this is quite a straightforward change, just not sure if there is
some use for this that I cant think of off the top of my head to preserve this.
Repository:
rL LLVM
https://reviews.llvm.org/D40115
___
cfe-com
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D40109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
hans added a comment.
I think the patch is fine, but Zach should probably sign off on it.
https://reviews.llvm.org/D39994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Thanks for the patch!
Comment at: lib/Frontend/ASTUnit.cpp:541
+// language.
+PP.getIdentifierTable().AddKeywords(LangOpt);
+
Have you tried adding the keywords in `PP.Initialize`? We might not need an
additional parameter to
ahatanak created this revision.
Herald added a subscriber: javed.absar.
IRGen for __fp16 vectors on X86 is currently completely broken. For example
when the following code is compiled:
half4 hv0, hv1, hv2; // these are vectors of __fp16.
void foo221() {
hv0 = hv1 + hv2;
}
clang gen
mgrang added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:8845
+
+ // Structures with either a non-trivial destructor or a non-trivial
+ // copy constructor are always indirectly.
Comment sounds incomplete.
Comment at: lib/CodeGen/
rnk created this revision.
Herald added a subscriber: aprantl.
The MS ABI convention is that the 'this' pointer on entry is the address
of the vfptr that was used to make the virtual method call. In other
words, the pointer on entry always points to the base subobject that
introduced the virtual m
juliehockett created this revision.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
This adds a Fuchsia module to clang-tidy to warn for features that are
disallowed. The following checks were added to the new module:
fuchsia-default-arguments: Check
morehouse added a comment.
Patch is out-of-date. But the flag has been enabled internally for over a
month with no issues. I'll update this patch soon, so we can flip the default
here.
https://reviews.llvm.org/D37860
___
cfe-commits mailing list
vsapsai added a comment.
On the first glance string erase and insert seem to be done correctly. But we
can still improve the tests. Can you please add tests for tricky cases where
new line or backslash appear in unexpected places? Some of the examples are
R"ab\
cd"
R"ab
c"
R"
alexshap added a comment.
probably a test would be useful
https://reviews.llvm.org/D40024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton accepted this revision.
benhamilton added a comment.
LGTM
https://reviews.llvm.org/D40058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka added a comment.
What is the status of this patch?
https://reviews.llvm.org/D37860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Wizard updated this revision to Diff 123093.
Wizard added a comment.
nit fix
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjCExceptionCheck.h
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GoogleTidyModu
benhamilton added a comment.
File names look good now, thanks.
Comment at: clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp:1
+//===--- AvoidThrowingObjcExceptionCheck.cpp -
clang-tidy--===//
+//
Objc -> ObjC
https://reviews.llvm.org/D4
Wizard updated this revision to Diff 123091.
Wizard marked an inline comment as done.
Wizard added a comment.
rename again
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjCExceptionCheck.h
clang-tidy/google/CMa
Wizard updated this revision to Diff 123090.
Wizard marked 6 inline comments as done.
Wizard added a comment.
rename file
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjC2ExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjC2ExceptionCheck.h
clang-tidy/google/CM
Author: chapuni
Date: Wed Nov 15 15:04:44 2017
New Revision: 318347
URL: http://llvm.org/viewvc/llvm-project?rev=318347&view=rev
Log:
clang/module.modulemap: clang/Basic/X86Target.def may be textual header.
Modified:
cfe/trunk/include/clang/module.modulemap
Modified: cfe/trunk/include/clang/
Wizard updated this revision to Diff 123089.
Wizard marked 2 inline comments as done.
Wizard added a comment.
address comments
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjcExceptionCheck.h
clang-tidy/google
mgrang added inline comments.
Comment at: test/Driver/riscv64-toolchain.c:1
+// A basic clang -cc1 command-line, and simple environment check.
+
I just saw that this test fails with the error:
error: backend data layout 'e-m:e-i64:64-n32:64-S128' does not match
mgrang added a comment.
@asb I cherry-picked this patch and was able to compile a simple program for
elf triple. By manually adding a few libs on the link line I was also able to
make it link for linux triple.
Could you please respond to the comment about risv32-ld? Other than that this
patch L
Author: erichkeane
Date: Wed Nov 15 14:36:24 2017
New Revision: 318345
URL: http://llvm.org/viewvc/llvm-project?rev=318345&view=rev
Log:
Add X86Target.def that was forgotten in r30734
Added:
cfe/trunk/include/clang/Basic/X86Target.def
Added: cfe/trunk/include/clang/Basic/X86Target.def
URL:
benhamilton added inline comments.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.h:1
+//===--- AvoidThrowingObjCExceptionCheck.h - clang-tidy--*- C++
-*-===//
+//
benhamilton wrote:
> Don't forget to rename the file to AvoidThrowingObjcEx
benhamilton added inline comments.
Comment at: test/clang-tidy/google-objc-avoid-throwing-exception.m:17-20
+- (void)f2 {
+[NSException raise:@"TestException" format:@"Test"];
+// CHECK-MESSAGES: :[[@LINE-1]]:18: warning: pass in NSError ** instead of
throwing exception
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
Looking good. Please rename the files correctly, or it will not build on Linux.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp:23
+ Finder->addM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318343: Split x86 "Processor" info into its own def file.
[NFC] (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D40093?vs=123081&id=123083#toc
Repository:
rL LLVM
https:/
rnk added a comment.
I haven't dug into this code to really understand if this is right and won't
change our version detection logic, but yes, broadly I believe we should just
consult PATH, find a cl.exe, and check its version. I'd like to reduce this
path validation to a minimum.
https://rev
Author: erichkeane
Date: Wed Nov 15 14:25:39 2017
New Revision: 318343
URL: http://llvm.org/viewvc/llvm-project?rev=318343&view=rev
Log:
Split x86 "Processor" info into its own def file. [NFC]
A first step toward removing the repetition of
features/CPU info in the x86 target info, this
patch pull
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D40093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
erichkeane updated this revision to Diff 123081.
erichkeane retitled this revision from "Split x86 "Processor" info into its own
def file." to "Split x86 "Processor" info into its own def file. [NFC]".
erichkeane added a comment.
realized I had added amdfam17 as an alias, which
isn't supposed to
Wizard updated this revision to Diff 123079.
Wizard marked 10 inline comments as done.
Wizard added a comment.
address comments
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjcExceptionCheck.h
clang-tidy/googl
Author: sammccall
Date: Wed Nov 15 13:50:53 2017
New Revision: 318339
URL: http://llvm.org/viewvc/llvm-project?rev=318339&view=rev
Log:
[clangd] Loosen more brittle tests
Modified:
clang-tools-extra/trunk/test/clangd/completion-snippet.test
clang-tools-extra/trunk/test/clangd/completion.t
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > ABataev wrote:
> > > Hah
danielmarjamaki added a comment.
> Could you do a similar analysis that I did above to check why does this not
> work for the multidimensional case? (I.e.: checking what constraints are
> generated and what the analyzer does with them.)
the "location.dump()" will just say "x".
the ProgramState
Author: sammccall
Date: Wed Nov 15 13:33:56 2017
New Revision: 318337
URL: http://llvm.org/viewvc/llvm-project?rev=318337&view=rev
Log:
[clangd] Revert broken r318329 and disable tests on PS4
(Clearly this is not a permanent solution)
Added:
clang-tools-extra/trunk/test/clangd/lit.local.cfg
kzhuravl abandoned this revision.
kzhuravl added a comment.
Agreed to do it later.
https://reviews.llvm.org/D39879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+ "cannot initialize object parameter of type %0 with an expression "
+ "of type %1">;
jtbandes wrote:
> aaron.bal
Nebiroth updated this revision to Diff 123069.
Nebiroth marked 3 inline comments as done.
Nebiroth added a comment.
Added test for didChangeConfiguration notification.
Compilation database and extra file flags are now properly reloaded when
changing database path.
ClangdConfigurationParams now us
Author: sammccall
Date: Wed Nov 15 12:10:14 2017
New Revision: 318329
URL: http://llvm.org/viewvc/llvm-project?rev=318329&view=rev
Log:
[clangd] Fix flag name from r318327
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
Modified: clang-tools-extra/trunk/clangd/GlobalCo
Author: marshall
Date: Wed Nov 15 12:02:27 2017
New Revision: 318328
URL: http://llvm.org/viewvc/llvm-project?rev=318328&view=rev
Log:
More of P0600 - '[[nodiscard]] in the Library' mark empty() as nodiscard in
string, string_view, and the free function std::empty(). Removed tabs from
, which is
jtbandes added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+ "cannot initialize object parameter of type %0 with an expression "
+ "of type %1">;
aaron.ballman wrote:
> I don't t
On Wed, Nov 15, 2017 at 8:43 PM, Alex L wrote:
> This doesn't seem like a good permanent solution (as Paul pointed out -std
> will change in the future).
>
Right, clearly not :-) It's a temporary fix to get the tests to pass.
Reverting the patch isn't that useful because it only masks the problem
This doesn't seem like a good permanent solution (as Paul pointed out -std
will change in the future). Will you be able to avoid this in the future?
On 15 November 2017 at 11:38, Sam McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sammccall
> Date: Wed Nov 15 11:38:09 2017
>
Author: sammccall
Date: Wed Nov 15 11:38:09 2017
New Revision: 318327
URL: http://llvm.org/viewvc/llvm-project?rev=318327&view=rev
Log:
[clangd] Try to unbreak tests on PS4 by targeting PC explicitly
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
Modified: clang-tools
On Nov 12, 2017, at 12:37, Reimar Döffinger wrote:
>
> On Thu, Nov 09, 2017 at 05:37:32PM -0800, Volodymyr Sapsai wrote:
>> On Nov 9, 2017, at 12:13, Reimar Döffinger wrote:
>>>
>>> Hello!
>>>
>>> On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote:
Thanks for the patch, Reim
efriedma added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:8913
+ }
+ return getNaturalAlignIndirect(Ty, /*ByVal=*/true);
+}
The spec says "Aggregates larger than 2✕XLEN bits are passed by reference and
are replaced in the argument list with the ad
erichkeane created this revision.
A first step toward removing the repetition of
features/CPU info in the x86 target info, this
patch pulls all the processor information out into
its own .def file.
https://reviews.llvm.org/D40093
Files:
include/clang/Basic/X86Target.def
lib/Basic/Targets/X8
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318325: [test] Alignment must be >
__STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new (authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D39221?vs=119990&id=123062#toc
Repos
Author: caseycarter
Date: Wed Nov 15 11:14:45 2017
New Revision: 318325
URL: http://llvm.org/viewvc/llvm-project?rev=318325&view=rev
Log:
[test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new
Differential Revision: D39221
Modified:
libcxx/trunk/test/std/language.su
Sorry about these - I've finally understood what's going on.
It looks like the PS4 has a different default --std, which probably doesn't
make sense for clangd. I'll override it.
On Wed, Nov 15, 2017 at 7:49 PM, Robinson, Paul
wrote:
> Hi Sam,
> It looks like llvm-clang-lld-x86_64-scei-ps4-window
aaron.ballman added reviewers: rsmith, aaron.ballman.
aaron.ballman added a comment.
I think the new wording is a bit more clear, in general.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+ "cannot initialize obje
Also at least one more builder is affected:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13517
Thanks
Galina
On Wed, Nov 15, 2017 at 10:54 AM, Galina Kistanova
wrote:
> Hello Sam,
>
> One of tests is failing on
> http://lab.llvm.org:8011/builders/ll
rjmccall added a comment.
Okay. I'm fine with living with both formats as long as we're not exposing
this as a feature.
Repository:
rL LLVM
https://reviews.llvm.org/D39955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Hello Sam,
One of tests is failing on
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/20638
Please have a look?
Thanks
Galina
...
Failing Tests (1):
Clang Tools :: clangd/completion.test
On Wed, Nov 15, 2017 at 1:16 AM, Sam McCall via cfe-commits <
cf
aaron.ballman added inline comments.
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:13
+
+#include
+#include
Including is forbidden by our coding standard. However, it doesn't
appear to be used in the source file, either.
Commen
Hi Sam,
It looks like llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast has been
failing a couple of clangd tests ever since this went in.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13517
Please fix or revert ASAP when bots go red. Failures like this
mstorsjo added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:683
+ if (LangOpts.SEHExceptions)
+Builder.defineMacro("__SEH__");
Please define `__ARM_DWARF_EH__` if dwarf is enabled on arm, see D39533, as I
commented earlier. (Sorry, I for
Author: ibiryukov
Date: Wed Nov 15 10:04:56 2017
New Revision: 318317
URL: http://llvm.org/viewvc/llvm-project?rev=318317&view=rev
Log:
[clangd] clang-format the source code. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Author: sammccall
Date: Wed Nov 15 09:53:46 2017
New Revision: 318316
URL: http://llvm.org/viewvc/llvm-project?rev=318316&view=rev
Log:
[clangd] Fix time units in clangd performance trace
Modified:
clang-tools-extra/trunk/clangd/Trace.cpp
Modified: clang-tools-extra/trunk/clangd/Trace.cpp
UR
arphaman added a comment.
In https://reviews.llvm.org/D39730#926108, @jkorous-apple wrote:
> Sorry, what do you mean by "this works in the body of the class"?
>
> Definition of constructor inside class definition has been working even
> before:
>
> struct foo {
> foo();
> f
> };
>
Author: hans
Date: Wed Nov 15 09:47:58 2017
New Revision: 318314
URL: http://llvm.org/viewvc/llvm-project?rev=318314&view=rev
Log:
Try to fix test/SemaCXX/deleted-operator.cpp after r318309
The number of 'built-in candidate' notes now varies since __float128 may
or may not be a candidate dependin
Author: marshall
Date: Wed Nov 15 09:47:09 2017
New Revision: 318313
URL: http://llvm.org/viewvc/llvm-project?rev=318313&view=rev
Log:
Clean up the tests for free data(), size() and empty()
Modified:
libcxx/trunk/test/std/iterators/iterator.container/data.pass.cpp
libcxx/trunk/test/std/it
sammccall created this revision.
This scale is much easier to mix with other signals, such as fuzzy match
strength.
Mostly NFC, but it does reorder some low-priority items that get folded
together at a score of 0 (see completion-qualifiers.test).
Removed the exact sortText from the testcases, be
ilya-biryukov updated this revision to Diff 123035.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Removed /*ref*/.
- Changed the command-line flag: it's -pch-storage now instead of
-in-memory-pchs.
- Actually pass the StoreInMemory flag to PrecompiledPreamble::B
cameron314 updated this revision to Diff 123044.
cameron314 added a comment.
Fully rebased, with a test.
https://reviews.llvm.org/D20124
Files:
include/clang/Lex/PreprocessingRecord.h
include/clang/Serialization/ASTBitCodes.h
include/clang/Serialization/ASTReader.h
include/clang/Seriali
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318309: BuiltinOperatorOverloadBuilder: Don't consider types
that are unavailable on… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D39579?vs=121824&id=123041#toc
Repository:
hans added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:7618
- // Define some constants used to index and iterate over the arithemetic types
- // provided via the getArithmeticType() method below.
- // The "promoted arithmetic types" are the arithmetic
+ SmallVect
Author: hans
Date: Wed Nov 15 09:11:53 2017
New Revision: 318309
URL: http://llvm.org/viewvc/llvm-project?rev=318309&view=rev
Log:
BuiltinOperatorOverloadBuilder: Don't consider types that are unavailable on
the target (PR35174)
In the PR, Clang ended up in a situation where it tried to mangle t
Author: dblaikie
Date: Wed Nov 15 08:52:12 2017
New Revision: 318304
URL: http://llvm.org/viewvc/llvm-project?rev=318304&view=rev
Log:
ASTMatchers.h: Fix ODR violations by avoiding internal linkage variables in
headers
Internal linkage variables ODR referenced from inline functions create
ODR vi
hokein added inline comments.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.h:1
+//===--- AvoidThrowingObjcExceptionCheck.h - clang-tidy--*- C++
-*-===//
+//
benhamilton wrote:
> Naming nit-pick: We are currently using `ObjC`, not `Objc`.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:238
if (Preamble) {
-Preamble->AddImplicitPreamble(*CI, Buffer.get());
+Preamble->AddImplicitPreamble(*CI, /*ref*/ VFS, Buffer.get());
} else {
sammccall wrote:
> ref is still he
jdenny updated this revision to Diff 123027.
jdenny added a comment.
1. Capitalized some of the new local variables according to coding standards.
2. Rebased on master/trunk fetched today.
https://reviews.llvm.org/D39694
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Bas
benhamilton requested changes to this revision.
benhamilton added a comment.
This revision now requires changes to proceed.
Almost there.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp:22
+void AvoidThrowingObjcExceptionCheck::registerMatchers(MatchFinder *Fi
ilya-biryukov added inline comments.
Comment at: lib/Frontend/PrecompiledPreamble.cpp:206
+ std::unique_ptr Storage;
+ if (InMemStorage) {
+OS = llvm::make_unique(*InMemStorage);
klimek wrote:
> ilya-biryukov wrote:
> > klimek wrote:
> > > It looks like we
sdardis added a comment.
> Mips is the only other implementer of shouldSignExtUnsignedType but is
> unaffected, as unlike classifyArgumentType, classifyReturnType will not
> extend i32 values (@sdardis: is this a bug?).
I believe this is an oversight that is addressed in the backend. The MIPS64
spatel added a comment.
Ping.
https://reviews.llvm.org/D39812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jkorous-apple added a comment.
Sorry, what do you mean by "this works in the body of the class"?
Definition of constructor inside class definition has been working even before:
struct foo {
foo();
f
};
Do you mean that a test shall be added in order to check that it still works?
https:/
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> ABataev wrote:
> > Hahnfeld wrote:
> > > rjm
asb updated this revision to Diff 123020.
asb marked an inline comment as done.
asb added a comment.
Updated to address review comments. I've added some extra test coverage that
demonstrates that argument lowering happens the same once registers are
exhausted, as well as more coverage around var
asb added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:8858
+ else
+NeededArgGPRs = 1;
+
efriedma wrote:
> It looks like the ABI says there's a special rule for varargs here?
You're right, I neglected vararg calls. Now addressed and test cases add
baloghadamsoftware added a comment.
Thank you for your respone! However, I think you (not you, Artem, but you three
at Apple) do not really understand that I need to compare A+m to B+n not only
because of the iterator range checking, but also in later parts. So your
proposal means that I am not
NoQ added a comment.
The unconstrained rearrangements for `+`/`-`/`==`/`!=` are definitely good to
go regardless of anything else.
Within the checker, we propose to manually simplify both `$x - N < $x` and `$x
+ N > $x` to true (where N is positive), because in general this is unsound
(due to
1 - 100 of 126 matches
Mail list logo
