[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover closed this revision. t.p.northover added a comment. Thanks Richard, and all other reviewers. I committed this as r320250, with a couple of sanitizer test fixes as r320251 and r320284 (thanks Ahmed!). Repository: rC Clang https://reviews.llvm.org/D40948 _

[PATCH] D39451: P0620 follow-up: deducing `auto` from braced-init-list in new expr

lichray added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D39451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r305110 - [ODRHash] Add support for TemplateArgument types.

On 12/8/17 9:14 PM, Richard Trieu wrote: Vassil, It depends on which parts of the AST you want to be stable.  The ODRHashing is stable across TU's, but it may depend on information that you don't want to be part of the hash.  For instance, if you have "using F = float;" in you code, then the

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

gottesmm added a comment. SGTM. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn updated this revision to Diff 126298. jklaehn added a comment. ping (rebased) https://reviews.llvm.org/D36952 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py include/clang-c/Index.h test/Index/load-classes.cpp tools/c-index-test/c-index-test.

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

JonasToth added a comment. > The "enforcement" listed on the C++ Core Guidelines is very unhelpful, so it > might be worth bringing it up as an issue on their bug tracker. ES.100 > basically says "you know what we mean, wink wink" as enforcement and doesn't > give any guidance as to what is saf

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

CaseyCarter added inline comments. Comment at: include/tuple:1015 struct __find_exactly_one_checked { - static constexpr bool __matches[] = {is_same<_T1, _Args>::value...}; +#if defined(__clang__) && __clang_major__ > 5 && __cplusplus > 201402L +// Workaround https://bugs.l

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

CaseyCarter updated this revision to Diff 126297. CaseyCarter added a comment. Hide the ugly version test in `<__config>`, define a slightly-more-meaningful macro `_LIBCPP_WORKAROUND_CLANG_28385`. https://reviews.llvm.org/D41048 Files: include/__config include/tuple Index: include/tuple

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

CaseyCarter added a comment. In https://reviews.llvm.org/D41048#950635, @mclow.lists wrote: > Ah - that was the factor I was missing. > The tests pass for me with `-std=c++2a`, but fail for `std=c++17` > > Casey's original post said they fail with `2a`, and I'm *still* not seeing > that. They

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

mclow.lists added a comment. Ah - that was the factor I was missing. The tests pass for me with `-std=c++2a`, but fail for `std=c++17` Casey's original post said they fail with `2a`, and I'm *still* not seeing that. https://reviews.llvm.org/D41048

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

JonasToth added a comment. In https://reviews.llvm.org/D41056#950605, @khuttun wrote: > In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote: > > > May be //bugprone// is better module then //misc//? > > > Maybe. I can move it if all the reviewers think that it would be better > suit

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

dexonsmith resigned from this revision. dexonsmith added a comment. Akira and/or John should take a look instead of me. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

lebedev.ri added a comment. In https://reviews.llvm.org/D41048#950606, @CaseyCarter wrote: > In https://reviews.llvm.org/D41048#950601, @mclow.lists wrote: > > > These tests don't fail for me. (using a clang I built two days ago) > > > What about the repro for #35578 >

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

gottesmm added a reviewer: dexonsmith. gottesmm added a comment. I do not work on objcarc any longer. +CC Duncan. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

alexey.knyshev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:24 + + class WalkAST : public ConstStmtVisitor { +const CheckerBase *Checker; kromanenkov wrote: > Do you consider using ASTMatchers like in NumberObje

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

CaseyCarter added a comment. In https://reviews.llvm.org/D41048#950601, @mclow.lists wrote: > These tests don't fail for me. (using a clang I built two days ago) What about the repro for #35578 ? That repro and these four tests trigger the bug for m

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

khuttun added a comment. In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote: > May be //bugprone// is better module then //misc//? Maybe. I can move it if all the reviewers think that it would be better suited there. Repository: rL LLVM https://reviews.llvm.org/D41056 ___

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn added a comment. In https://reviews.llvm.org/D35181#948925, @rsmith wrote: > LGTM, but I'd like the old `IdentifierTable` constructor to be removed if > there are no callers left. It's still being used in e.g. `FormatTokenLexer`, where the populated `IdentifierTable` is passed to the

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

mclow.lists added inline comments. Comment at: include/tuple:1015 struct __find_exactly_one_checked { - static constexpr bool __matches[] = {is_same<_T1, _Args>::value...}; +#if defined(__clang__) && __clang_major__ > 5 && __cplusplus > 201402L +// Workaround https://bugs.l

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

mclow.lists added a comment. These tests don't fail for me. (using a clang I built two days ago) https://reviews.llvm.org/D41048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

Eugene.Zelenko added a comment. May be //bugprone// is better module then //misc//? Comment at: docs/ReleaseNotes.rst:60 +- New `misc-uniqueptr-release-unused-retval + `_ check ---

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

alexey.knyshev updated this revision to Diff 126293. alexey.knyshev added a comment. 1. Now implemented via MatchFinder 2. Added missing License header 3. Pass all StringRefs by value 4. Method names now start from small letter 5. Using StringRef::edit_distance instead of custom "similarity" metri

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

khuttun created this revision. Herald added subscribers: xazax.hun, mgorny. Detects calls to std::unique_ptr::release where the return value is unused. https://reviews.llvm.org/D41056 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UniqueptrRelease

r320297 - Fix MSVC 'not all control paths return a value' warning

Author: rksimon Date: Sun Dec 10 03:05:14 2017 New Revision: 320297 URL: http://llvm.org/viewvc/llvm-project?rev=320297&view=rev Log: Fix MSVC 'not all control paths return a value' warning Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.