Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

This is causing problems in some internal builds that specify both -mios-simulator-version-min=9.0 and --target=x86_64-apple-ios My expectation would be for the code to take the minimum OS version number from the -mios-simulator-version-min flag. In fact, however, the code seems to be completely

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir updated this revision to Diff 127887. krasimir added a comment. - Address review comments Repository: rC Clang https://reviews.llvm.org/D41487 Files: ; include/clang/Format/Format.h lib/Format/Format.cpp Index: include/clang/Format/Format.h

[PATCH] D38639: [clangd] #include statements support for Open definition

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:183 + unsigned CharNumber = SourceMgr.getSpellingColumnNumber( + DeclMacrosFinder->getSearchedLocation()); + ilya-biryukov wrote: > Replace with

[PATCH] D41492: [Frontend] Correctly handle instantiating ctors with skipped bodies

ilya-biryukov created this revision. ilya-biryukov added reviewers: sepavloff, klimek. Previsouly clang tried instantiating member initializers even if ctor body was skipped, this caused spurious errors (see the test). Repository: rC Clang https://reviews.llvm.org/D41492 Files:

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ilya-biryukov, mgorny, klimek. The tools is used to generate global symbols for clangd (global code completion), The format is YAML, which is only for **experiment**. TEST: used the tool to generate

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#961367, @probinson wrote: > With the GDB test results and LLDB able to handle it, this LGTM. > Carlos, do you have commit access? Hi Paul, Thanks for the LGTM. I do not have commit access.

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir added inline comments. Comment at: lib/Format/Format.cpp:903-907 + for (int i = Styles.size() - 1; i >= 0; --i) { +if (Styles[i].Language != FormatStyle::LK_None) { + Style->AddLanguageStyle(Styles[i]); } } klimek wrote: > This seems a

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

klimek added inline comments. Comment at: lib/Format/Format.cpp:893 for (int i = Styles.size() - 1; i >= 0; --i) { -if (Styles[i].Language == Language || -Styles[i].Language == FormatStyle::LK_None) { +if (!LanguageFound && (Styles[i].Language == Language || +

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE321272: [clangd] Index symbols share storage within a slab. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D41483?vs=127877=127879#toc Repository: rCTE

[clang-tools-extra] r321272 - [clangd] Index symbols share storage within a slab.

Author: sammccall Date: Thu Dec 21 06:58:44 2017 New Revision: 321272 URL: http://llvm.org/viewvc/llvm-project?rev=321272=rev Log: [clangd] Index symbols share storage within a slab. Summary: Symbols are not self-contained - it's only safe to hand them out if you guarantee the lifetime of the

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall updated this revision to Diff 127877. sammccall marked 4 inline comments as done. sammccall added a comment. Comment changes requiested in review. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41483 Files: clangd/index/Index.cpp clangd/index/Index.h

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/Index.h:136 + // Intern table for strings. Not StringPool as we don't refcount, just insert. + llvm::StringSet Strings; llvm::DenseMap Symbols;

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice, LGTM. Comment at: clangd/index/Index.h:108 // // FIXME: Use a space-efficient implementation, a lot of Symbol fields could // share the same storage.

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

szepet accepted this revision. szepet added a comment. In https://reviews.llvm.org/D41444#961110, @a.sidorin wrote: > Test both with and without '-fdelayed-template-parsing' in C++ mode. This solution LGTM as well. Just a small nit added inline. Comment at:

[PATCH] D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!)

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing the patch. Repository: rC Clang https://reviews.llvm.org/D40705 ___ cfe-commits mailing list

[clang-tools-extra] r321267 - [clangd] Log more info about preambles

Author: ibiryukov Date: Thu Dec 21 06:05:28 2017 New Revision: 321267 URL: http://llvm.org/viewvc/llvm-project?rev=321267=rev Log: [clangd] Log more info about preambles Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL:

r321266 - Added helper to get size of PrecompiledPreamble

Author: ibiryukov Date: Thu Dec 21 06:04:39 2017 New Revision: 321266 URL: http://llvm.org/viewvc/llvm-project?rev=321266=rev Log: Added helper to get size of PrecompiledPreamble Modified: cfe/trunk/include/clang/Frontend/PrecompiledPreamble.h

[PATCH] D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls.

lebedev.ri added a comment. In https://reviews.llvm.org/D41456#961826, @malcolm.parsons wrote: > This check could also handle else after goto. Yes, certainly. Though i'm not too sure on the restrictions. The obvious precondition is, the label can to be defined anywhere **except** after the

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

ilya-biryukov added inline comments. Comment at: clangd/index/Index.h:136 + // Intern table for strings. Not StringPool as we don't refcount, just insert. + llvm::StringSet Strings; llvm::DenseMap Symbols; A comment on why we use

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir created this revision. krasimir added reviewers: klimek, djasper. This patch adds a FormatStyleSet for storing per-language FormatStyles for the purposes of formatting code blocks inside the main code. Repository: rC Clang https://reviews.llvm.org/D41487 Files:

[PATCH] D40451: [OpenMP] Add function attribute for triggering shared memory lowering in the LLVM backend

gtbercea closed this revision. gtbercea added a comment. Committed here https://reviews.llvm.org/D41123 Repository: rL LLVM https://reviews.llvm.org/D40451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

a.sidorin added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:32 + +static RunOptions getRunOptionsForLanguage(Language Lang) { + ArgVector BasicArgs; xazax.hun wrote: > I wonder if in the future it would be worth to use something else, like >

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea updated this revision to Diff 127865. gtbercea added a comment. Address comments. Repository: rL LLVM https://reviews.llvm.org/D41486 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_target_teams_codegen.cpp Index:

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

sberg updated this revision to Diff 127863. sberg added a comment. As suggested, solve the issue instead by removing any "noexcept" from the typeinfo emitted for the -fsanitize=function checks. https://reviews.llvm.org/D40720 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Comment at: unittests/AST/ASTImporterTest.cpp:32 + +static RunOptions getRunOptionsForLanguage(Language Lang) { + ArgVector BasicArgs; I wonder

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea added a comment. In https://reviews.llvm.org/D41486#961981, @Hahnfeld wrote: > https://reviews.llvm.org/D41012? This patch doesn't update the documentation > with function signatures. Ok so I see that your patch uses a different order of the arguments. I've just added the data

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. https://reviews.llvm.org/D41012? This patch doesn't update the documentation with function signatures. Repository: rL LLVM https://reviews.llvm.org/D41486

[PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

Hahnfeld added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/interface.h:1290-1291 EXTERN void __kmpc_spmd_kernel_deinit(); -EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized); -EXTERN bool __kmpc_kernel_parallel(void

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea created this revision. gtbercea added reviewers: ABataev, carlo.bertolli, hfinkel, Hahnfeld, caomhin. Herald added a subscriber: jholewinski. This patch adds a missing argument to the runtime interface. Tests are adjusted accordingly. Repository: rL LLVM

[PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

gtbercea created this revision. gtbercea added reviewers: carlo.bertolli, ABataev, Hahnfeld, grokos, caomhin, hfinkel. This patch extends the libomptarget functionality in patch https://reviews.llvm.org/D14254 with support for the data sharing scheme for supporting implicitly shared variables.

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall updated this revision to Diff 127849. sammccall added a comment. Don't intern unless the symbol was actually inserted. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41483 Files: clangd/index/Index.cpp clangd/index/Index.h unittests/clangd/FileIndexTests.cpp

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. Symbols are not self-contained - it's only safe to hand them out if you guarantee the lifetime of the underlying data. Before this lands, I'm going to measure the

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru added a comment. I added two more reviewers as we would like to get that in trunk before 6.0 branches. https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41454: [clangd] Add ClangdUnit diagnostics tests using annotated code.

sammccall updated this revision to Diff 127843. sammccall added a comment. Tighten preprocessor test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41454 Files: clangd/Protocol.cpp clangd/Protocol.h test/clangd/diagnostics-preamble.test unittests/clangd/CMakeLists.txt

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41345: [clangd] Add more symbol information for code completion.

sammccall added inline comments. Comment at: clangd/index/Index.h:122 + + llvm::Optional Detail; + ioeric wrote: > sammccall wrote: > > I think you probably want a raw pointer rather than optional: > > - reduce the size of the struct when it's absent > > -

[PATCH] D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls.

malcolm.parsons added a comment. This check could also handle else after goto. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

Hahnfeld added a comment. @hfinkel I think you requested this documentation on the mailing list. Can you take a look if it matches your expectations so we can get this bundled in the 6.0 release? Comment at: docs/OpenMPSupport.rst:17 + +Clang fully supports OpenMP 3.1 + some

[clang-tools-extra] r321252 - [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

Author: hokein Date: Thu Dec 21 00:45:18 2017 New Revision: 321252 URL: http://llvm.org/viewvc/llvm-project?rev=321252=rev Log: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension. Summary: Previously, we use a separate GitHub repository

[PATCH] D41391: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321252: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd`… (authored by hokein, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41391 Files:

[PATCH] D41394: [CodeGen] Support generation of TBAA info in the new format

kosarev updated this revision to Diff 127838. kosarev added a comment. Updated as suggested. https://reviews.llvm.org/D41394 Files: lib/CodeGen/CodeGenTBAA.cpp test/CodeGen/tbaa.cpp Index: test/CodeGen/tbaa.cpp === ---

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/fuchsia-overloaded-operator.rst:17 + +See the features disallowed in Fuchsia at https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md juliehockett wrote: > JonasToth wrote: > > Could you

[PATCH] D41452: [CodeGen] Fix access sizes in new-format TBAA tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL321250: [CodeGen] Fix access sizes in new-format TBAA tags (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D41452?vs=127724=127834#toc Repository: rL LLVM

r321250 - [CodeGen] Fix access sizes in new-format TBAA tags

Author: kosarev Date: Thu Dec 21 00:14:16 2017 New Revision: 321250 URL: http://llvm.org/viewvc/llvm-project?rev=321250=rev Log: [CodeGen] Fix access sizes in new-format TBAA tags The new format requires to specify both the type of the access and its size. This patch fixes setting access sizes

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D40478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40381: Parse concept definition

changyu marked 6 inline comments as done. changyu added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7735 + ActOnDocumentableDecl(NewDecl); + CurContext->addDecl(NewDecl); + return NewDecl; faisalv wrote: > Why not use 'PushOnScopeChains' onto the

<    1   2