[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rsmith added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3878 + } else { +// FIXME: We could filter out definitely-unreachable catch handlers. +EHCatchScope *LaterCatchScope = There are a lot of other optimizations possible her

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added subscribers: kristof.beyls, sanjoy, aemerson. This patch fixes three issues with how Clang emits code to catch exceptions by reference: 1. We would sometimes bind the reference directly to the exception object when a

r322530 - [Sema] Fix a crash on invalid features in multiversioning

Author: gbiv Date: Mon Jan 15 19:01:50 2018 New Revision: 322530 URL: http://llvm.org/viewvc/llvm-project?rev=322530&view=rev Log: [Sema] Fix a crash on invalid features in multiversioning We were trying to emit a diag::err_bad_multiversion_option diagnostic, which expects an int as its first arg

[libcxx] r322529 - More constexpr algorithms from P0202: lower_bound, upper_bound, equal_range, binary_search

Author: marshall Date: Mon Jan 15 18:34:41 2018 New Revision: 322529 URL: http://llvm.org/viewvc/llvm-project?rev=322529&view=rev Log: More constexpr algorithms from P0202: lower_bound, upper_bound, equal_range, binary_search Modified: libcxx/trunk/include/algorithm libcxx/trunk/test/std

[libcxx] r322528 - Actually CALL the constexpr tests.

Author: marshall Date: Mon Jan 15 18:11:13 2018 New Revision: 322528 URL: http://llvm.org/viewvc/llvm-project?rev=322528&view=rev Log: Actually CALL the constexpr tests. Modified: libcxx/trunk/test/std/algorithms/alg.nonmodifying/mismatch/mismatch.pass.cpp libcxx/trunk/test/std/algorithm

[libcxx] r322527 - More constexpr (re P0202) - equal and mismatch

Author: marshall Date: Mon Jan 15 18:04:10 2018 New Revision: 322527 URL: http://llvm.org/viewvc/llvm-project?rev=322527&view=rev Log: More constexpr (re P0202) - equal and mismatch Modified: libcxx/trunk/include/algorithm libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.equal/equal.

[PATCH] D41534: Don't add empty InstalledDir as a candidate GCC location

jackoalan abandoned this revision. jackoalan added a comment. I've found that passing `--gcc-toolchain=/usr` results in the exact behavior I'm after. Feel free to reopen if desired. Repository: rC Clang https://reviews.llvm.org/D41534 ___ cfe-c

[PATCH] D41816: [analyzer] Model and check unrepresentable left shifts

rnkovacs added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:150 +SB.getKnownValue(state, C.getSVal(B->getRHS())); +if ((unsigned) RHS->getZExtValue() > LHS->countLeadingZeros()) { + OS << "The result of the left shif

[PATCH] D41816: [analyzer] Model and check unrepresentable left shifts

rnkovacs updated this revision to Diff 129905. rnkovacs marked an inline comment as done. https://reviews.llvm.org/D41816 Files: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp lib/StaticAnalyzer/Core/BasicValueFactory.cpp test/Analysis/bitwise-ops.c Index: test/Analysis/bitwise-ops.c

[PATCH] D40023: [RISCV] Implement ABI lowering

asb added a comment. Thanks Eli, that saved me some time - fixed in https://reviews.llvm.org/rL322514 (clang-x86_64-linux-selfhost-modules-2 is now green). Comment at: lib/CodeGen/TargetInfo.cpp:8913 + } + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); +} -

[PATCH] D41517: mmintrin.h documentation fixes and updates

efriedma added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// RKSimon wrote: > efriedma wrote: > > craig.topper wrote:

r322518 - Revert 319303: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2

Author: erichkeane Date: Mon Jan 15 13:16:25 2018 New Revision: 322518 URL: http://llvm.org/viewvc/llvm-project?rev=322518&view=rev Log: Revert 319303: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2 Differential Revision: https://reviews.llvm.org/D40673 Removed:

[PATCH] D42004: [Driver] Suggest valid integrated tools

modocache added a comment. Great, thanks for the review @bkramer! Repository: rC Clang https://reviews.llvm.org/D42004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42004: [Driver] Suggest valid integrated tools

This revision was automatically updated to reflect the committed changes. Closed by commit rC322517: [Driver] Suggest valid integrated tools (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42004?vs=129668&id=129902#toc Repository: rC Clang https://

r322517 - [Driver] Suggest valid integrated tools

Author: modocache Date: Mon Jan 15 13:05:40 2018 New Revision: 322517 URL: http://llvm.org/viewvc/llvm-project?rev=322517&view=rev Log: [Driver] Suggest valid integrated tools Summary: There are only two valid integrated Clang driver tools: `-cc1` and `-cc1as`. If a user asks for an unknown tool,

r322516 - [OPENMP] Update status of OpenMP support, NFC.

Author: abataev Date: Mon Jan 15 13:01:29 2018 New Revision: 322516 URL: http://llvm.org/viewvc/llvm-project?rev=322516&view=rev Log: [OPENMP] Update status of OpenMP support, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL: http://llvm.org/vie

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129901. JonasToth added a comment. - last nits i found Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clang-tidy/cppcoreguidelines/AvoidGotoCheck.h clang-tidy/cppcoreguide

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth added a comment. In https://reviews.llvm.org/D41648#976665, @aaron.ballman wrote: > My gut reaction is still that this check is going to be too chatty on real > world code bases to be of value beyond compliance with the C++ Core > Guidelines, but that's also sufficient enough reason t

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129900. JonasToth added a comment. - remove spurious whitespace Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clang-tidy/cppcoreguidelines/AvoidGotoCheck.h clang-tidy/cpp

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129899. JonasToth marked 3 inline comments as done. JonasToth added a comment. - hicpp alias added - update documentation Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clan

r322514 - [RISCV] Fix test failures on non-assert builds introduced in r322494

Author: asb Date: Mon Jan 15 12:45:15 2018 New Revision: 322514 URL: http://llvm.org/viewvc/llvm-project?rev=322514&view=rev Log: [RISCV] Fix test failures on non-assert builds introduced in r322494 Thanks to Eli Friedman, who suggested the reason these tests failed on a few buildbots yet works

r322513 - Fixed memory leak in unit test introduced in my previous commit r322503

Author: cameron314 Date: Mon Jan 15 12:37:35 2018 New Revision: 322513 URL: http://llvm.org/viewvc/llvm-project?rev=322513&view=rev Log: Fixed memory leak in unit test introduced in my previous commit r322503 Modified: cfe/trunk/unittests/libclang/LibclangTest.cpp Modified: cfe/trunk/unittes

[PATCH] D40023: [RISCV] Implement ABI lowering

efriedma added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:8913 + } + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); +} asb wrote: > efriedma wrote: > > asb wrote: > > > efriedma wrote: > > > > The spec says "Aggregates larger than 2✕XLEN bits

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

aaron.ballman added a comment. My gut reaction is still that this check is going to be too chatty on real world code bases to be of value beyond compliance with the C++ Core Guidelines, but that's also sufficient enough reason to have the check in the first place. Perhaps a reasonable approach

[PATCH] D41815: [clang-tidy] implement check for goto

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.h:19-20 + +/// The usage of `goto` has been discouraged for a long time and is diagnosed +/// with this check. +/// This comment is a bit out of date now that it no longe

[PATCH] D42085: Add va_start()/va_copy()/va_end to Builtins.def

thakis created this revision. thakis added a reviewer: hans. That way, clang suggests including stdarg.h when these are used in C files. https://reviews.llvm.org/D42085 Files: include/clang/Basic/Builtins.def Index: include/clang/Basic/Builtins.def ==

[PATCH] D42059: [clangd] Improve const-correctness of Symbol->Detail. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL322509: [clangd] Improve const-correctness of Symbol->Detail. NFC (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4205

[PATCH] D42059: [clangd] Improve const-correctness of Symbol->Detail. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322509: [clangd] Improve const-correctness of Symbol->Detail. NFC (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D42059?vs=129830&id=129895#toc Repository:

[clang-tools-extra] r322509 - [clangd] Improve const-correctness of Symbol->Detail. NFC

Author: sammccall Date: Mon Jan 15 12:09:09 2018 New Revision: 322509 URL: http://llvm.org/viewvc/llvm-project?rev=322509&view=rev Log: [clangd] Improve const-correctness of Symbol->Detail. NFC Summary: This would have caught a bug I wrote in an early version of D42049, where an index user could

[libcxx] r322507 - Fix constexpr failure on C++11-based buildbots.

Author: marshall Date: Mon Jan 15 11:59:09 2018 New Revision: 322507 URL: http://llvm.org/viewvc/llvm-project?rev=322507&view=rev Log: Fix constexpr failure on C++11-based buildbots. Modified: libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.find.end/find_end_pred.pass.cpp Modified: l

[PATCH] D40023: [RISCV] Implement ABI lowering

efriedma added a comment. Looks like it fails with assertions disabled; no-asserts builds disable value labels, so the IR output looks a little different. Repository: rL LLVM https://reviews.llvm.org/D40023 ___ cfe-commits mailing list cfe-commi

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth added a comment. > Using regex could be a reasonable way out, but isn't going to solve the > problem in general because not all of the macro names are ones the user has > control over. Having to whitelist dozens of macros by name means this check > is simply going to be disabled by th

[libcxx] r322506 - More constexpr from P0202. count and count_if. Also fix a comment that Morwenn noted.

Author: marshall Date: Mon Jan 15 11:40:34 2018 New Revision: 322506 URL: http://llvm.org/viewvc/llvm-project?rev=322506&view=rev Log: More constexpr from P0202. count and count_if. Also fix a comment that Morwenn noted. Modified: libcxx/trunk/include/algorithm libcxx/trunk/test/std/algo

[PATCH] D41523: xmmintrin.h documentation fixes and updates

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[libcxx] r322505 - Some of the tests from earlier today had 'int' as the return type when it should have been 'bool'. Fix that. It doesn't change the behavior of any of the tests, but it's more accura

Author: marshall Date: Mon Jan 15 11:32:32 2018 New Revision: 322505 URL: http://llvm.org/viewvc/llvm-project?rev=322505&view=rev Log: Some of the tests from earlier today had 'int' as the return type when it should have been 'bool'. Fix that. It doesn't change the behavior of any of the tests,

[libcxx] r322504 - More P0202 constexpr-ifying. All the find_XXX algorithms in this commit.

Author: marshall Date: Mon Jan 15 11:26:05 2018 New Revision: 322504 URL: http://llvm.org/viewvc/llvm-project?rev=322504&view=rev Log: More P0202 constexpr-ifying. All the find_XXX algorithms in this commit. Modified: libcxx/trunk/include/algorithm libcxx/trunk/test/std/algorithms/alg.no

[PATCH] D40023: [RISCV] Implement ABI lowering

asb added a comment. The riscv32-abi and risc64-abi tests are failing (specifically the vararg checks) on the clang-with-thin-lto and modules-slave-2 buildbots: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/7892 http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-m

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 129893. JonasToth added a comment. - address eugene comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rC322503: [PCH] Serialize skipped preprocessor ranges (authored by cameron314, committed by ). Changed prior to commit: https://reviews.llvm.org/D20124?vs=125333&id=129892#toc Repository: rC Clang htt

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:8 +constructs exist for the task. +The relevant sections in the C++ Coreguidelines are +`Enum.1

r322503 - [PCH] Serialize skipped preprocessor ranges

Author: cameron314 Date: Mon Jan 15 11:14:16 2018 New Revision: 322503 URL: http://llvm.org/viewvc/llvm-project?rev=322503&view=rev Log: [PCH] Serialize skipped preprocessor ranges The skipped preprocessor ranges are now serialized in the AST PCH file. This fixes, for example, libclang's clang_g

r322502 - [OPENMP] Update docs for OpenMP status, NFC.

Author: abataev Date: Mon Jan 15 11:08:36 2018 New Revision: 322502 URL: http://llvm.org/viewvc/llvm-project?rev=322502&view=rev Log: [OPENMP] Update docs for OpenMP status, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL: http://llvm.org/viewv

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 129890. JonasToth marked 2 inline comments as done. JonasToth added a comment. - doc fix Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuide

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 129889. JonasToth marked 2 inline comments as done. JonasToth added a comment. - address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguideli

r322501 - [OPENMP] Add codegen for `depend` clauses on `target` directive.

Author: abataev Date: Mon Jan 15 11:06:12 2018 New Revision: 322501 URL: http://llvm.org/viewvc/llvm-project?rev=322501&view=rev Log: [OPENMP] Add codegen for `depend` clauses on `target` directive. Added basic support for codegen of `depend` clauses on `target` directive. Added: cfe/trunk/t

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene.Zelenko added inline comments. Comment at: clang-tidy/cppcoreguidelines/MacroUsageCheck.h:15 +#include "clang/Lex/Preprocessor.h" + +namespace clang { Please include . Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:

r322494 - [RISCV] Implement RISCV ABI lowering

Author: asb Date: Mon Jan 15 09:54:52 2018 New Revision: 322494 URL: http://llvm.org/viewvc/llvm-project?rev=322494&view=rev Log: [RISCV] Implement RISCV ABI lowering RISCVABIInfo is implemented in terms of XLen, supporting both RV32 and RV64. Unfortunately we need to count argument registers in

[analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

Hi, Added evaluation of __builtin_constant_p to the dedicated StaticAnalyzer checker along with a regression test. 'make clang-test' results: Testing Time: 335.63s Expected Passes : 11769 Expected Failures : 19 Unsupported Tests : 50 - felixIndex: lib/StaticAnalyzer/Checkers/BuiltinFunct

Re: D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

On 13/01/18 12:33, Blower, Melanie wrote: >> -Original Message- >> From: Szabolcs Nagy via Phabricator [mailto:revi...@reviews.llvm.org] >> Sent: Friday, January 12, 2018 3:18 PM >> >> nsz added a comment. >> >> >> it is not clear to me from the original bug report what "fedora 27 worklo

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 129886. JonasToth added a comment. - [Feature] implement regex for allowed macros - [Test] add proper tests for regex silencing Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt cl

Re: r322065 - Avoid assumption that lit tests are writable (in a couple more places). NFC

I feel like this sort of change will regress quite quickly - in the sense that most 'cp' in tests is probably there to put it somewhere writable (in some cases its to put it in a particular location, not about writability). Any way we could fix 'cp' in lit to do the right thing here? (I doubt any t

Re: r322350 - [ODRHash] Don't hash friend functions.

I'm surprised this problem is unique to friend functions with definitions inline and the friend declaration site - doesn't a similar issue occur with member functions of templates that are not instantiated in some (similar) contexts? Is there a common solution that could be used for both cases? O

Re: r322405 - Disable test for Windows to fix Windows buildbots.

might be worth having an explanation (probably in both the commit message and in a comment in the source) about why this test isn't supported on windows? On Fri, Jan 12, 2018 at 1:50 PM Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Jan 12 13:49:20

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 added a comment. I have no commit access, please commit the patch for me. https://reviews.llvm.org/D5767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41998: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322497: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit… (authored by sbenza, committed by ). Changed prior to commit: https://reviews.llvm.org/D41998?vs=129880&id=12988

[PATCH] D41998: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322497: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit… (authored by sbenza, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews

[PATCH] D41998: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts.

sbenza updated this revision to Diff 129880. sbenza marked an inline comment as done. sbenza added a comment. minor fix Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41998 Files: clang-tidy/readability/RedundantSmartptrGetCheck.cpp test/clang-tidy/readability-redundant-sma

[clang-tools-extra] r322497 - [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts.

Author: sbenza Date: Mon Jan 15 10:03:20 2018 New Revision: 322497 URL: http://llvm.org/viewvc/llvm-project?rev=322497&view=rev Log: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts. Summary: Expand readability-redundant-smartptr-g

[PATCH] D40023: [RISCV] Implement ABI lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rL322494: [RISCV] Implement RISCV ABI lowering (authored by asb, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D40023?vs=129683&id=129878#toc

[libcxx] r322493 - partition_point gets the P0202 treatment

Author: marshall Date: Mon Jan 15 09:53:34 2018 New Revision: 322493 URL: http://llvm.org/viewvc/llvm-project?rev=322493&view=rev Log: partition_point gets the P0202 treatment Modified: libcxx/trunk/include/algorithm libcxx/trunk/test/std/algorithms/alg.modifying.operations/alg.partition

[PATCH] D42077: Ensure code complete with !LoadExternal sees all local decls.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. noload_lookups() was too lazy: in addition to avoiding external decls, it avoided populating the lazy lookup structure for internal decls. This is the right behavior for the existing

[libcxx] r322492 - More constexpr algorithms from P0202. any_of/all_of/none_of.

Author: marshall Date: Mon Jan 15 09:20:36 2018 New Revision: 322492 URL: http://llvm.org/viewvc/llvm-project?rev=322492&view=rev Log: More constexpr algorithms from P0202. any_of/all_of/none_of. Modified: libcxx/trunk/include/algorithm libcxx/trunk/test/std/algorithms/alg.nonmodifying/al

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

JonasToth added inline comments. Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:47 +"^::std::launder$|" +"^::std::unique_ptr<.*>::release$|" +"^::std::.*::allocate$|"

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

baloghadamsoftware updated this revision to Diff 129871. baloghadamsoftware added a comment. Rebased to current Part 3. Comment added. https://reviews.llvm.org/D32845 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/Inp

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware updated this revision to Diff 129870. baloghadamsoftware added a comment. Rebased to current Part 2. https://reviews.llvm.org/D32747 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/Inputs/system-head

[PATCH] D42074: [clangd] Collect enum constants in SymbolCollector

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:75 + // Skip nameless declarations. + if (ND->getDeclName().isEmpty()) +return true; What are those declarations exactly? Comment at: unittests/clangd/Symbo

[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

bkramer added a comment. We should have a unit test for this, otherwise it's dead code. Comment at: include/clang/Sema/Lookup.h:791 + /// \param Ctx the context which Sema begins to visit. + virtual void BeginVisitContext(DeclContext *Ctx) {}; }; ilya-biryuk

[PATCH] D42073: [clangd] Query all visible scopes based on all visible using-namespace declarationsand containing namespace for global qualified code completion.

ilya-biryukov added a comment. Discussed this offline. If we move most to collect visited `DeclContext`s to `CodeCompletionDeclConsumer` (from `CodeComplete.cpp`) and provide a list of `DeclContext`s to `CodeCompletionConsumer`, we will be able to get rid of running lookup manually in clangd.

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129868. JonasToth added a comment. - doc clarified that check is c++ only - add missing tests for `do` and `range-for`, not all combinations done, but every loop construct is used as outer and inner loop Repository: rCTE Clang Tools Extra https://revie

[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

ilya-biryukov added inline comments. Comment at: include/clang/Sema/Lookup.h:791 + /// \param Ctx the context which Sema begins to visit. + virtual void BeginVisitContext(DeclContext *Ctx) {}; }; Maybe rename it to `VisitedContext` ? Seems more in-line with `F

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129865. JonasToth marked an inline comment as done. JonasToth added a comment. - [Fix] bug with language mode Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clang-tidy/cppco

[PATCH] D42074: [clangd] Collect enum constants in SymbolCollector

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added a subscriber: klimek. - ignore nameless symbols - include enum constant declarataion Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42074 Files: clangd/index/SymbolCollector.cpp unittests/cla

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129863. JonasToth marked 4 inline comments as done. JonasToth added a comment. - address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clang-tidy/cppcoregui

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:43 + + // Backward jumps are diagnosed in all language modes. Forward jumps + // are sometimes required in C to free resources or do other clean-up aaron.ballman wrote:

[PATCH] D42073: [clangd] Query all visible scopes based on all visible using-namespace declarationsand containing namespace for global qualified code completion.

hokein created this revision. hokein added reviewers: sammccall, ilya-biryukov. Herald added a subscriber: klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42073 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp Index: unittests/clangd/CodeCompleteT

[libcxx] r322489 - First part of P0202: Adding constexpr modifiers to functions in and . This commit is all the is_XXX algorithms.

Author: marshall Date: Mon Jan 15 08:16:32 2018 New Revision: 322489 URL: http://llvm.org/viewvc/llvm-project?rev=322489&view=rev Log: First part of P0202: Adding constexpr modifiers to functions in and . This commit is all the is_XXX algorithms. Modified: libcxx/trunk/include/algorithm

[PATCH] D42072: [Sema] Expose current scope in qualified-id code completion.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Repository: rC Clang https://reviews.llvm.org/D42072 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp =

[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Repository: rC Clang https://reviews.llvm.org/D42071 Files: include/clang/Sema/Lookup.h lib/Sema/SemaLookup.cpp Index: lib/Sema/SemaLookup.cpp === --- lib

[PATCH] D42059: [clangd] Improve const-correctness of Symbol->Detail. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LTGM. Comment at: clangd/index/SymbolYAML.cpp:84 + return nullptr; +return new (*static_cast(IO.getContext())) +T(std::move(*Opt)); woo, I l

[PATCH] [scan-build] Mention --keep-cc in the HTML documentation

--- Feel free to squash this into the keep-cc introduction commit if appropriate. www/analyzer/scan-build.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/analyzer/scan-build.html b/www/analyzer/scan-build.html index b16f6bb..83efea9 100644 --- a/www/analyzer/scan-bui

Re: [PATCH] [scan-build] Add an option to skip overriding CC and CXX make vars

LGTM. Would you like me to commit it for you? Jon On 1/14/18 9:22 AM, Paul Fertser wrote: Autoconf and some other systems tend to add essential compilation options to CC (e.g. -std=gnu99). When running such an auto-generated makefile, scan-build does not need to change CC and CXX as they are

Re: [PATCH] [analyzer] Fix -x language argument for C preprocessed sources

LGTM. Would you like me to commit it for you? Jon On 1/14/18 3:50 AM, Paul Fertser wrote: clang's -x option doesn't accept c-cpp-output as a language (even though 463eb6ab was merged, the driver still doesn't handle that). This bug prevents testing C language projects when ccache is used. F

[PATCH] D42060: [clangd] Use fuzzy match to select top N index results.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clangd/index/MemIndex.cpp:60 } - return true; + return false; } this should be `more`? Repository: rCTE Clang Tools Extra https:

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. Excellent, I'll rebase and commit. Thanks everyone for your patience! https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41523: xmmintrin.h documentation fixes and updates

RKSimon added a comment. Apart for the -Wdocumentation issue (which can be handled separately), is there anything else stalling this ticket? https://reviews.llvm.org/D41523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D42004: [Driver] Suggest valid integrated tools

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The -cc1 stuff isn't exactly user-facing, so we didn't put so much emphasis on providing great error messages there. This change LGTM. Repository: rC Clang https://reviews.llvm.org/D4200

[PATCH] D41517: mmintrin.h documentation fixes and updates

RKSimon added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// efriedma wrote: > craig.topper wrote: > > kromanova wrote:

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322480: [clangd] Merge results from static/dynamic index. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42049 Files:

[clang-tools-extra] r322480 - [clangd] Merge results from static/dynamic index.

Author: sammccall Date: Mon Jan 15 04:33:00 2018 New Revision: 322480 URL: http://llvm.org/viewvc/llvm-project?rev=322480&view=rev Log: [clangd] Merge results from static/dynamic index. Summary: We now hide the static/dynamic split from the code completion, behind a new implementation of the Symb

[PATCH] D42063: [clangd] Avoid combinatorial explosion in CodeCompleteTests.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, klimek. This test dominates our unit test runtime, and the change speeds it up by 10x. We lose coverage of some combinations of flags, but I'm not sure that's finding many bugs. 3300

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clangd/index/Merge.cpp:34 + Dynamic->fuzzyFind(Ctx, Req, [&](const Symbol &S) { DynB.insert(S); }); + SymbolSlab Dyn = std::move(DynB).bu

[PATCH] D42060: [clangd] Use fuzzy match to select top N index results.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. This makes performance slower but more predictable (it always processes every symbol). We need to find ways to make this fast, possibly by precomputing short queries o

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

This revision was automatically updated to reflect the committed changes. Closed by commit rC322479: [clang-format] Adds a FormatStyleSet (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D41487?vs=128933&id=129832#toc Repository: rC Clang https://revi

r322479 - [clang-format] Adds a FormatStyleSet

Author: krasimir Date: Mon Jan 15 04:06:16 2018 New Revision: 322479 URL: http://llvm.org/viewvc/llvm-project?rev=322479&view=rev Log: [clang-format] Adds a FormatStyleSet Summary: This patch adds a FormatStyleSet for storing per-language FormatStyles for the purposes of formatting code blocks in

[PATCH] D42059: [clangd] Improve const-correctness of Symbol->Detail. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. This would have caught a bug I wrote in an early version of https://reviews.llvm.org/D42049, where an index user could overwrite data internal to the index because th

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

sammccall added inline comments. Comment at: clangd/index/Merge.cpp:29 + //b) if it's in the dynamic slab, merge it and yield the result + // 3) now yield all the dynamic symbols we haven't processed. + bool More = false; // We'll be incomplete if either source w

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:605 + if (Pos && !Pos->isValid()) { +// If I do not put a tag here, some invalidation tests will fail +static CheckerProgramPointTag Tag("InvalidatedIteratorChecker", --

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

sammccall updated this revision to Diff 129824. sammccall marked 2 inline comments as done. sammccall added a comment. Fixed bug where we wrote into the underlying index's symbols. Extended testcase. Added documentation around contracts. Repository: rCTE Clang Tools Extra https://reviews.llvm

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki added a comment. ping^2 https://reviews.llvm.org/D41179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added a comment. ping https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >