ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. (See the comment about changing the comment, though)
Comment at: clangd/index/SymbolCollector.cpp:75
+ // Skip nameless declarations.
+ if (ND->getDeclN
ro added a comment.
Excellent, thanks a lot.
Repository:
rC Clang
https://reviews.llvm.org/D42029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fedor.sergeev added a comment.
I'm trying!
I had no access to Solaris box, and I finally got one yesterday, though it is
rather old one and slow.
I plan to resolve it all till the end of this week.
Repository:
rC Clang
https://reviews.llvm.org/D42029
__
ilya-biryukov requested changes to this revision.
ilya-biryukov added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:345
+ if (!Buffer) {
+llvm::errs() << diag::err_missing_vfs_overlay_file << OverlayFile;
+r
ilya-biryukov added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h:30
vector(initializer_list<_E> init);
+ ~vector();
};
hokein wrote:
> ilya-biryukov wrote:
> > Why do we need to add this destructor in this patch?
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322858: [OpenMP] Correct generation of offloading entries
(authored by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42168
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/Op
vladimir.plyashkun added a comment.
In https://reviews.llvm.org/D41947#980298, @ilya-biryukov wrote:
> Looks good. Do you have commit access or do you need someone to land this
> patch for you?
No, i don't have commit access.
Repository:
rC Clang
https://reviews.llvm.org/D41947
___
Author: hahnfeld
Date: Thu Jan 18 07:38:03 2018
New Revision: 322858
URL: http://llvm.org/viewvc/llvm-project?rev=322858&view=rev
Log:
[OpenMP] Correct generation of offloading entries
Firstly, each offloading entry must have a unique name or the
linker will complain if there are multiple files w
Author: sammccall
Date: Thu Jan 18 07:31:30 2018
New Revision: 322856
URL: http://llvm.org/viewvc/llvm-project?rev=322856&view=rev
Log:
[clangd] Remove unused IncludeGlobals completion option, always pass true to
sema
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
clang-tools-
krasimir added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1710
+enum CommentAlignment { CA_None, CA_Code, CA_Preprocessor };
+
Please comment these.
Comment at: lib/Format/TokenAnnotator.cpp:1756
+ if (Alignment == CA_Pre
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access or do you need someone to land this patch
for you?
Repository:
rC Clang
https://reviews.llvm.org/D41947
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322853: [Frontend] Allow to use PrecompiledPreamble without
calling CanReuse (authored by ibiryukov, committed by ).
Herald added a subscriber: ioeric.
Changed prior to commit:
https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322854: [clangd] Always use preamble (even stale) for code
completion (authored by ibiryukov, committed by ).
Herald added subscribers: llvm-commits, ioeric.
Repository:
rL LLVM
https://reviews.llvm.or
Author: ibiryukov
Date: Thu Jan 18 07:17:00 2018
New Revision: 322854
URL: http://llvm.org/viewvc/llvm-project?rev=322854&view=rev
Log:
[clangd] Always use preamble (even stale) for code completion
Summary:
This improves performance of code completion, because we avoid stating
the files from the
Author: ibiryukov
Date: Thu Jan 18 07:16:53 2018
New Revision: 322853
URL: http://llvm.org/viewvc/llvm-project?rev=322853&view=rev
Log:
[Frontend] Allow to use PrecompiledPreamble without calling CanReuse
Summary:
The new method 'OverridePreamble' allows to override the preamble of
any source fil
mclow.lists created this revision.
mclow.lists added a reviewer: EricWF.
Herald added subscribers: kristof.beyls, aemerson.
See https://bugs.llvm.org/show_bug.cgi?id=35945, which reports that libc++
doesn't build for the Raspberry PI.
The problem is that the exception class is defined as a `char
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D42168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ilya-biryukov created this revision.
ilya-biryukov added reviewers: bkramer, arphaman.
This patch removes IdentifierInfo from completion token after remembering
the identifier in the preprocessor.
Prior to this patch, completion token had the IdentifierInfo set to null when
completing at the star
ro added a comment.
Thanks for the quick review. Could you commit the base patch (which had been
approved some time ago) and this one?
Repository:
rC Clang
https://reviews.llvm.org/D42029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
baloghadamsoftware updated this revision to Diff 130403.
baloghadamsoftware added a comment.
Updated according to the comments.
https://reviews.llvm.org/D41938
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/Si
Hahnfeld updated this revision to Diff 130399.
Hahnfeld retitled this revision from "[OpenMP] Generate unique name for
offloading entries" to "[OpenMP] Correct generation of offloading entries".
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
Use `llvm::Twine`, add `Packed
ioeric added a comment.
Herald added a reviewer: jkorous-apple.
Overall looks good! Some ideas about code structure inlined.
Comment at: clangd/CodeComplete.cpp:327
+// The CompletionRecorder captures Sema code-complete output, including
context.
+// It filters out ignored res
Author: rksimon
Date: Thu Jan 18 05:28:54 2018
New Revision: 322845
URL: http://llvm.org/viewvc/llvm-project?rev=322845&view=rev
Log:
Fix MSVC "uninitialized variable" warning.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modified: cfe/trunk/tools/c-index-test/c-index-test.c
URL:
h
hokein updated this revision to Diff 130395.
hokein marked an inline comment as done.
hokein added a comment.
Add one more test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42074
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: u
vladimir.plyashkun updated this revision to Diff 130385.
vladimir.plyashkun added a comment.
Moved logic to `ClangTidyMain`
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
Index
yvvan updated this revision to Diff 130384.
yvvan added a comment.
Rebased. Applies for current master.
Also ping again...
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/CodeCompleteOptions.h
lib/Frontend/ASTU
vladimir.plyashkun updated this revision to Diff 130382.
vladimir.plyashkun added a comment.
Implemented test-case to check that `BaseFS` is actually used in `ClangTool`
Repository:
rC Clang
https://reviews.llvm.org/D41947
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
Author: sammccall
Date: Thu Jan 18 02:24:01 2018
New Revision: 322827
URL: http://llvm.org/viewvc/llvm-project?rev=322827&view=rev
Log:
[clangd] Output log messages to stderr when not configured (e.g. in tests). NFC
Modified:
clang-tools-extra/trunk/clangd/Logger.cpp
clang-tools-extra/tru
ioeric added inline comments.
Comment at: unittests/clangd/SymbolCollectorTests.cpp:164
+TEST_F(SymbolCollectorTest, IncludeEnums) {
+ CollectorOpts.IndexMainFiles = false;
Could you add a test case like the following and check whether `ns::X` is in
the resul
hokein added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:75
+ // Skip nameless declarations.
+ if (ND->getDeclName().isEmpty())
+return true;
ilya-biryukov wrote:
> What are those declarations exactly?
This would ignore anonymous declarat
hokein updated this revision to Diff 130372.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a reviewer: jkorous-apple.
Ignore enum constants in scoped enum.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42074
Files:
clangd/index/SymbolCollector
On 18 January 2018 at 00:38, Rafael Avila de Espindola via cfe-commits
wrote:
> With this I am getting a test failure on linux:
>
> TEST 'Clang :: Driver/riscv-gnutools.c' FAILED
>
> Script:
> --
> /home/admin/llvm/build/bin/clang -target riscv32-linux-un
Author: hokein
Date: Thu Jan 18 01:47:57 2018
New Revision: 322826
URL: http://llvm.org/viewvc/llvm-project?rev=322826&view=rev
Log:
[ASTMatcher] Add isScoped matcher for enumDecl.
Summary:
Reviewers: bkramer, aaron.ballman
Subscribers: aaron.ballman, cfe-commits, klimek
Differential Revision:
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rC322826: [ASTMatcher] Add isScoped matcher for enumDecl.
(authored by hokein, comm
hokein updated this revision to Diff 130370.
hokein added a comment.
- add the matcher to dynamic registry.
- add documentation.
- remove duplicated ";".
Repository:
rC Clang
https://reviews.llvm.org/D42185
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
Author: sammccall
Date: Thu Jan 18 01:27:56 2018
New Revision: 322824
URL: http://llvm.org/viewvc/llvm-project?rev=322824&view=rev
Log:
[clangd] CodeCompleteTests cleanup: naming, ordering, helpers. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-
hintonda updated this revision to Diff 130367.
hintonda added a comment.
Refactor to eliminate need for second stage and toolchain files.
Repository:
rC Clang
https://reviews.llvm.org/D41829
Files:
cmake/caches/Linux.cmake
Index: cmake/caches/Linux.cmake
==
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL322822: [clang-tidy] Don't generate fix for argument
constructed from std… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository
Author: hokein
Date: Thu Jan 18 00:58:18 2018
New Revision: 322822
URL: http://llvm.org/viewvc/llvm-project?rev=322822&view=rev
Log:
[clang-tidy] Don't generate fix for argument constructed from
std::initializer_list.
Summary:
A follow-up fix of rL311652.
The previous `vector` in our test is di
hintonda created this revision.
hintonda added reviewers: compnerd, beanz.
Herald added a subscriber: mgorny.
If CMAKE_ASM_COMPILER is set, cmake assumes
CMAKE_ASM_COMPILER_ID was also set, and doesn't try to set it.
Without CMAKE_ASM_COMPILER_ID, cmake can't set
CMAKE_ASM_COMPILER_OPTIONS_TARGET
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL322821: [clangd] Use fuzzy match to select top N index
results. (authored by sammccall, committed by ).
Herald added a reviewer: jkorous-apple.
Herald added a su
Author: sammccall
Date: Thu Jan 18 00:35:04 2018
New Revision: 322821
URL: http://llvm.org/viewvc/llvm-project?rev=322821&view=rev
Log:
[clangd] Use fuzzy match to select top N index results.
Summary:
This makes performance slower but more predictable (it always processes
every symbol). We need t
101 - 142 of 142 matches
Mail list logo
