thakis closed this revision.
thakis added a comment.
r323426, thanks!
https://reviews.llvm.org/D42497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Jan 25 06:38:29 2018
New Revision: 323426
URL: http://llvm.org/viewvc/llvm-project?rev=323426=rev
Log:
clang-cl: Simplify handling of /arch: flag.
r213083 initially implemented /arch: support by mapping it to CPU features.
Then r241077 additionally mapped it to CPU, which
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D42497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323425: [clangd] Provide a helper to report estimated memory
usage per-file (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323425: [clangd] Provide a helper to report estimated
memory usage per-file (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42480?vs=131435=131438#toc
Author: ibiryukov
Date: Thu Jan 25 06:32:21 2018
New Revision: 323425
URL: http://llvm.org/viewvc/llvm-project?rev=323425=rev
Log:
[clangd] Provide a helper to report estimated memory usage per-file
Reviewers: sammccall, ioeric, hokein
Reviewed By: ioeric
Subscribers: klimek, cfe-commits,
Author: ibiryukov
Date: Thu Jan 25 06:30:46 2018
New Revision: 323424
URL: http://llvm.org/viewvc/llvm-project?rev=323424=rev
Log:
[clangd] Fixed the file comment of new file. NFC
Modified:
clang-tools-extra/trunk/clangd/CompileArgsCache.cpp
Modified:
Author: ibiryukov
Date: Thu Jan 25 06:29:29 2018
New Revision: 323423
URL: http://llvm.org/viewvc/llvm-project?rev=323423=rev
Log:
[clangd] Added forgotten files
Added:
clang-tools-extra/trunk/clangd/CompileArgsCache.cpp
clang-tools-extra/trunk/clangd/CompileArgsCache.h
Added:
ilya-biryukov updated this revision to Diff 131435.
ilya-biryukov marked 6 inline comments as done.
ilya-biryukov added a comment.
- Added a FIXME to CppFile::getUsedBytes()
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42480
Files:
clangd/ClangdServer.cpp
ilya-biryukov added a comment.
Thanks for reviewing this!
Comment at: unittests/clangd/ClangdTests.cpp:428
+TEST_F(ClangdVFSTest, MemoryUsage) {
+ MockFSProvider FS;
ioeric wrote:
> ilya-biryukov wrote:
> > ioeric wrote:
> > > Can we add a test for
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323421: [CodeGen] Decorate aggregate accesses with TBAA tags
(authored by kosarev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41539?vs=131257=131434#toc
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323421: [CodeGen] Decorate aggregate accesses with TBAA tags
(authored by kosarev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM, but I'd like Anastasia to approve.
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D42532
___
cfe-commits mailing list
Author: kosarev
Date: Thu Jan 25 06:21:55 2018
New Revision: 323421
URL: http://llvm.org/viewvc/llvm-project?rev=323421=rev
Log:
[CodeGen] Decorate aggregate accesses with TBAA tags
Differential Revision: https://reviews.llvm.org/D41539
Modified:
cfe/trunk/lib/CodeGen/CGAtomic.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323420: [clangd] Moved caching of compile commands to
ClangdServer (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42429?vs=131429=131432#toc
Repository:
Author: ibiryukov
Date: Thu Jan 25 06:19:21 2018
New Revision: 323420
URL: http://llvm.org/viewvc/llvm-project?rev=323420=rev
Log:
[clangd] Moved caching of compile commands to ClangdServer
Summary:
It allows to get rid of CppFile::getLastCommand and simplify the
code in the upcoming threading
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323419: [clang-format] Fixes indentation of inner text proto
messages (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: krasimir
Date: Thu Jan 25 06:10:43 2018
New Revision: 323419
URL: http://llvm.org/viewvc/llvm-project?rev=323419=rev
Log:
[clang-format] Fixes indentation of inner text proto messages
Summary:
Consider the text proto:
```
message {
sub { key: value }
}
```
Previously the first `{` was
ilya-biryukov updated this revision to Diff 131429.
ilya-biryukov marked 5 inline comments as done.
ilya-biryukov added a comment.
Herald added subscribers: hintonda, mgorny.
- Addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42429
Files:
thakis added inline comments.
Comment at: lib/Driver/ToolChains/Arch/X86.cpp:43
if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) {
+// Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap().
hans wrote:
> I wonder if it
thakis updated this revision to Diff 131428.
thakis edited the summary of this revision.
https://reviews.llvm.org/D42497
Files:
lib/Driver/ToolChains/Arch/X86.cpp
test/Driver/cl-x86-flags.c
Index: test/Driver/cl-x86-flags.c
===
Fznamznon created this revision.
Herald added subscribers: cfe-commits, Anastasia, yaxunl.
For OpenCL 1.1 embedded profile 64 bit integers i.e. long,
ulong including the appropriate vector data types and operations
on 64-bit integers are optional. The "cles_khr_int64" extension
string will be
ilya-biryukov added inline comments.
Comment at: clangd/Function.h:141
namespace detail {
+/// Optional-like type that sets its value to llvm::None when it was moved
+/// constructed from.
sammccall wrote:
> As noted in the thread I don't think this pulls its
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clangd/ClangdUnit.cpp:664
+ std::lock_guard Lock(Mutex);
+ return ASTMemUsage + PreambleMemUsage;
+}
ilya-biryukov wrote:
> ioeric wrote:
>
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:324
+ /// Returns estimated memory usage for each of the currently files.
+ /// The order of results is unspecified.
ioeric wrote:
>
ilya-biryukov updated this revision to Diff 131415.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Fixed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42480
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for this cleanup!
The way we deal with ResourceDir still doesn't feel ideal, but that's no worse
here and everything else is better!
Comment at:
ilya-biryukov added a comment.
LG. Let's move the APIs to callbacks and start passing Contexts everywhere.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall added inline comments.
Comment at: clangd/Function.h:141
namespace detail {
+/// Optional-like type that sets its value to llvm::None when it was moved
+/// constructed from.
As noted in the thread I don't think this pulls its weight for us.
Swapping
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
r322838 changed semantics for llvm::Optional that removes the
guarantee of setting the value to empty after move.
This change creates a wrapper around Optional
hokein added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:28
+enum NamingStyle {
+ StandardProperty = 1,
+ CategoryProperty = 2,
Please add documentation describing what these properties are.
Comment at:
ilya-biryukov updated this revision to Diff 131407.
ilya-biryukov added a comment.
- Remove redundant code
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42524
Files:
clangd/JSONRPCDispatcher.cpp
clangd/Trace.cpp
clangd/Trace.h
Index: clangd/Trace.h
ilya-biryukov added a comment.
I've tried experimenting with that and came up with an alternative that has
less changes to the API. Could you take a look, too?
https://reviews.llvm.org/D42524
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42499
xazax.hun updated this revision to Diff 131406.
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
- Address review comments.
https://reviews.llvm.org/D42335
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
The new API allows tracing events to outlive individual Spans and
gives a guarantee that invididual Spans will be not be called from
multiple threads.
jolesiak requested changes to this revision.
jolesiak added inline comments.
This revision now requires changes to proceed.
Comment at: test/Format/lit.local.cfg:2-3
+# Suffixes supported by clang-format.
+config.suffixes = ['.cpp', '.h', '.m', '.mm', '.java', '.js', '.ts',
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Overall looks good! Thanks for working on this!
Comment at: lib/AST/ExternalASTMerger.cpp:403
+ASTImporter *Importer = C.second;
+NamedDecl *ND =
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323412: [Driver] Add support for mips32 and scudo (authored
by sdardis, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: sdardis
Date: Thu Jan 25 02:09:33 2018
New Revision: 323412
URL: http://llvm.org/viewvc/llvm-project?rev=323412=rev
Log:
[Driver] Add support for mips32 and scudo
r317337 missed that scudo is supported on MIPS32, so permit that option for
MIPS32.
Reviewers: cryptoad, atanasyan
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:163
+
+ template Context derive(Type &) const && {
+static Key::type> Private;
s/`const &&`/`&&`
Comment at: clangd/Context.h:165
+static Key::type> Private;
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323410: [clangd] Disable typo correction when doing code
completion. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42491?vs=131286=131400#toc
Repository:
Author: hokein
Date: Thu Jan 25 01:44:06 2018
New Revision: 323410
URL: http://llvm.org/viewvc/llvm-project?rev=323410=rev
Log:
[clangd] Disable typo correction when doing code completion.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek, jkorous-apple, cfe-commits,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323410: [clangd] Disable typo correction when doing code
completion. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42491
ioeric added inline comments.
Comment at: clangd/ClangdServer.h:324
+ /// Returns estimated memory usage for each of the currently files.
+ /// The order of results is unspecified.
s/currently/current/ ? or current open?
Comment at:
hans added a comment.
Thanks for looking into this!
Comment at: lib/Driver/ToolChains/Arch/X86.cpp:43
if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) {
+// Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap().
I wonder
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
simark wrote:
> ilya-biryukov wrote:
> > Are you planning to to address this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323408: [clangd] Limit completion results. (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42484
Files:
Author: hokein
Date: Thu Jan 25 01:20:09 2018
New Revision: 323408
URL: http://llvm.org/viewvc/llvm-project?rev=323408=rev
Log:
[clangd] Limit completion results.
Summary:
* truncate symbols from static/dynamic index to the limited number
(which would save lots of cost in constructing the merged
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein updated this revision to Diff 131394.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42484
Files:
clangd/CodeComplete.cpp
clangd/index/Merge.cpp
clangd/tool/ClangdMain.cpp
hokein added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:131
+ "0 means no limit."),
+llvm::cl::init(100), llvm::cl::Hidden);
+
sammccall wrote:
> I think we probably want to keep the default at 0 for now. I'm fine with 100
>
ahatanak created this revision.
ahatanak added reviewers: rjmccall, vsk.
This patch fixes what looks like a bug in IRGen's member initialization where
it uses the alignment of a complete object instead of its non-virtual alignment
when emitting the base constructor.
For example, when emitting
101 - 152 of 152 matches
Mail list logo
