[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

2018-01-26 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. If you want to force DWARF 2, probably clamping the version in LLVM would be simpler? Although most of the debug-info tests are architecture-specific and wouldn't run for an NVPTX target anyway. Repository: rC Clang https://reviews.llvm.org/D42581

[PATCH] D42521: [CodeGen] Use the non-virtual alignment when emitting the base class subobject constructor

2018-01-26 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC323578: [CodeGen] Use the non-virtual alignment when emitting the base (authored by ahatanak, committed by ). Repository: rC Clang https://reviews.llvm.org/D42521 Files: lib/CodeGen/CGClass.cpp te

r323578 - [CodeGen] Use the non-virtual alignment when emitting the base

2018-01-26 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Fri Jan 26 16:34:09 2018 New Revision: 323578 URL: http://llvm.org/viewvc/llvm-project?rev=323578&view=rev Log: [CodeGen] Use the non-virtual alignment when emitting the base constructor. Previously, clang would emit an over-aligned (16-byte) store to initialize B::x in B's

[PATCH] D42248: Always allow "#pragma region".

2018-01-26 Thread Matt Davis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC323577: Always allow "#pragma region". (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D42248 Files: lib/Lex/Pragma.cpp test/Frontend/region-pragmas.c Index: te

r323577 - Always allow "#pragma region".

2018-01-26 Thread Matt Davis via cfe-commits
Author: mattd Date: Fri Jan 26 16:25:29 2018 New Revision: 323577 URL: http://llvm.org/viewvc/llvm-project?rev=323577&view=rev Log: Always allow "#pragma region". Summary: Both MS and PS4 targets are capable of recognizing the existence of: #pragma region, #pragma endregion. Since this pragma i

[PATCH] D42608: Driver: Prefer vendor supplied gcc toolchain

2018-01-26 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. Herald added a subscriber: srhines. This patch fixes an issue on Fedora where if you had the x86_64 cross compiler installed on your x86_64 system, then clang would use that compiler as the default toolchain. This was happening because the cross compiler is install

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-01-26 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. modocache added reviewers: rsmith, GorNishanov, eric_niebler. Herald added a subscriber: EricWF. Depends on https://reviews.llvm.org/D42605. An implementation of the behavior described in `[dcl.fct.def.coroutine]/7`: when a promise type overloads `operator new` us

[PATCH] D42605: [Sema] Toggle diags when finding allocators (NFCI)

2018-01-26 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. modocache added reviewers: rsmith, GorNishanov, eric_niebler. Many methods in Sema take a `bool Diagnose` parameter. Examples of such methods include `Sema::FindDeallocationFunction` and `Sema::SpecialMemberIsTrivial`. Calling these methods with `Diagnose = false`

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

2018-01-26 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r323547 Repository: rC Clang https://reviews.llvm.org/D42508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

2018-01-26 Thread Ian Tessier via Phabricator via cfe-commits
itessier added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:93 + /// \brief Show color diagnostics. + llvm::Optional ShowColor; + alexfh wrote: > This doesn't belong to ClangTidyOptions. It's specific to the CLI, but CLI is > not the only fronten

Re: [PATCH] D35338: Add the -fdestroy-globals flag

2018-01-26 Thread Vedant Kumar via cfe-commits
Yeah, I think we have internal users who would be happy to use this flag as well. Stepping back a bit. It's been a while since I followed the discussion on cfe-dev, but I don't recall there being any objections to the flag name or to using it for particular targets. IIRC the objections are abo

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

2018-01-26 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 131650. tra added a comment. Addressed Justin's comments. https://reviews.llvm.org/D42513 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp clang/lib/Driver/ToolChains/Cuda.cpp clang/lib/Headers/CMakeLi

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

2018-01-26 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObj

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

2018-01-26 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton requested review of this revision. benhamilton marked 2 inline comments as done. benhamilton added inline comments. Comment at: test/Format/lit.local.cfg:1 +# Suffixes supported by clang-format. +config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js

[libcxx] r323563 - Fix the BinaryPredicate form of std::is_permutation to not rely on operator==

2018-01-26 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri Jan 26 13:23:27 2018 New Revision: 323563 URL: http://llvm.org/viewvc/llvm-project?rev=323563&view=rev Log: Fix the BinaryPredicate form of std::is_permutation to not rely on operator== According to [1], forms 2 and 4 of std::is_permutation should use the passed in binary pr

Re: [PATCH] D35338: Add the -fdestroy-globals flag

2018-01-26 Thread Nico Weber via cfe-commits
I'd love to use this flag in non-firmware code FWIW. On Fri, Jan 26, 2018 at 4:07 PM, Ian Tessier via Phabricator via cfe-commits wrote: > itessier added a comment. > > > That seems like a nice win and I like the convenience of this approach. > That said I've just remembered that there's a threa

[PATCH] D35338: Add the -fdestroy-globals flag

2018-01-26 Thread Ian Tessier via Phabricator via cfe-commits
itessier added a comment. > That seems like a nice win and I like the convenience of this approach. That > said I've just remembered that there's a thread on cfe-dev about this: > [RFC] Suppress C++ static destructor registration > I don't think a consensus was reached. From what I gather, some p

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-26 Thread Don Hinton via cfe-commits
On Thu, Jan 25, 2018 at 5:20 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On Jan 25, 2018, at 17:09, Don Hinton wrote: > > > > On Thu, Jan 25, 2018 at 4:21 PM, Duncan P. N. Exon Smith < > dexonsm...@apple.com> wrote: > >> >> >> On Jan 25, 2018, at 16:18, Duncan P. N. Exon Smit

[PATCH] D16403: Add scope information to CFG

2018-01-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > Do we need to have one-to-one mapping between ScopeBegins and corresponding > ScopeEnds or is it OK to assume that ScopeEnd can terminate several nested > scopes? It's fine if `ScopeEnds` terminates multiple scopes - as long as it is easy to find out what scopes are bein

[PATCH] D16403: Add scope information to CFG

2018-01-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Hmm. @m.ostapenko @szepet @mgehre - I think it might be a good time to figure out if `ScopeBegin`/`ScopeEnd`, `LoopEntrance`/`LoopExit`, `LifetimeEnds`, `AutomaticObjectDtor` elements work nicely together. How should they be ordered with respect to each other? Is any of the

r323554 - Try to unbreak 32 bit builds after r323528.

2018-01-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jan 26 12:01:13 2018 New Revision: 323554 URL: http://llvm.org/viewvc/llvm-project?rev=323554&view=rev Log: Try to unbreak 32 bit builds after r323528. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc

Re: r323528 - [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80.

2018-01-26 Thread Vlad Tsyrklevich via cfe-commits
This change has broken a number of buildbots, e.g. http://lab.llvm.org:8011/builders/sanitizer-windows/builds/23163 On Fri, Jan 26, 2018 at 6:15 AM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Jan 26 06:14:11 2018 > New Revision: 323528 > > URL: h

[PATCH] D42573: [wip] The new threading implementation

2018-01-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. OK, here's a braindump, probably nothing surprising after our offline discussion. TL;DR: the only design I *know* is extensible in ways we care about is the one that basically shards Scheduler into a bunch of per-TU schedulers. I think that's probably the way to go, b

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

2018-01-26 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added a reviewer: sylvestre.ledru. Repository: rC Clang https://reviews.llvm.org/D42593 Files: include/clang/Driver/Options.td test/Driver/clang_f_opts.c Index: test/Driver/clang_f_opts.c ===

r323552 - [X86] Add 'rdrnd' feature to silvermont to match recent gcc bug fix.

2018-01-26 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Jan 26 11:34:45 2018 New Revision: 323552 URL: http://llvm.org/viewvc/llvm-project?rev=323552&view=rev Log: [X86] Add 'rdrnd' feature to silvermont to match recent gcc bug fix. gcc recently fixed this bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83546 Modified:

[PATCH] D42588: [index] Fix crash when indexing a C++14 PCH/module related to TemplateTemplateParmDecls of alias templates

2018-01-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323549: [index] Fix crash when indexing a C++14 PCH/module related to… (authored by akirtzidis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

r323549 - [index] Fix crash when indexing a C++14 PCH/module related to TemplateTemplateParmDecls of alias templates

2018-01-26 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Fri Jan 26 11:26:12 2018 New Revision: 323549 URL: http://llvm.org/viewvc/llvm-project?rev=323549&view=rev Log: [index] Fix crash when indexing a C++14 PCH/module related to TemplateTemplateParmDecls of alias templates TemplateTemplateParmDecls of alias templates ended-u

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

2018-01-26 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); ABataev wrote: > tra wrote:

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

2018-01-26 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/AST/ExprClassification.cpp:652 +if (Ctx.getCanonicalType(ASE->getBase()->getType()).isConstQualified()) + return Cl::CM_ConstQualified; + avt77 wrote: > rjmccall wrote: > > Is there a reason why the places

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

2018-01-26 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); tra wrote: > ABataev wr

r323547 - AST: support protocol conformances on id/class/interfaces in MS ABI

2018-01-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jan 26 11:08:26 2018 New Revision: 323547 URL: http://llvm.org/viewvc/llvm-project?rev=323547&view=rev Log: AST: support protocol conformances on id/class/interfaces in MS ABI Add support for mangling ObjC protocol conformances in MS ABI as if they are COM interfaces. B

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

2018-01-26 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); ABataev wrote: > tra wrote:

[PATCH] D42588: [index] Fix crash when indexing a C++14 PCH/module related to TemplateTemplateParmDecls of alias templates

2018-01-26 Thread Nathan Hawes via Phabricator via cfe-commits
nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rC Clang https://reviews.llvm.org/D42588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D42588: [index] Fix crash when indexing a C++14 PCH/module related to TemplateTemplateParmDecls of alias templates

2018-01-26 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi created this revision. akyrtzi added reviewers: cfe-commits, nathawes. Herald added subscribers: kristof.beyls, aemerson. TemplateTemplateParmDecls of alias templates ended-up serialized as 'file-level decls' which was causing a crash while trying to index a PCH/module file that containe

r323543 - [X86] Define __IBT__ when -mibt is specified.

2018-01-26 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Jan 26 10:31:14 2018 New Revision: 323543 URL: http://llvm.org/viewvc/llvm-project?rev=323543&view=rev Log: [X86] Define __IBT__ when -mibt is specified. Modified: cfe/trunk/lib/Basic/Targets/X86.cpp cfe/trunk/test/Preprocessor/x86_target_features.c Modified: cf

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

2018-01-26 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); tra wrote: > There's mo

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

2018-01-26 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); There's more than one -g op

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

2018-01-26 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.h:395 + CGBuilderTy &Builder, + llvm::Metadata **MetadataDecl = nullptr); I think ``` llvm::DILocalVariable* EmitDeclareOfAutoVari

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

2018-01-26 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added a comment. Just a gentle reminder that this patch still needs to be accepted (the LLVM support for it has been merged). https://reviews.llvm.org/D41698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

2018-01-26 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: tra, jlebar. Herald added subscribers: JDevlieghere, aprantl. NVPTX target supports debug info in DWARF-2 format. Patch adds emission of debug info in DWARF-2 by default. Repository: rC Clang https://reviews.llvm.org/D42581 Files: lib

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

2018-01-26 Thread Daniil Fukalov via Phabricator via cfe-commits
dfukalov updated this revision to Diff 131593. dfukalov retitled this revision from "[AMDGPU] Add ds_fadd builtin function" to "[AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions". dfukalov added a comment. Sorry, missed them Repository: rC Clang https://reviews.llvm.org/D42578 Files

[PATCH] D42561: [PR36008] Avoid -Wsign-compare warning for enum constants in typeof expressions

2018-01-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8959 + if (!S.getLangOpts().CPlusPlus) { +if (const TypeOfExprType *TET = dyn_cast(RHS->getType())) + RHS = TET->getUnderlyingExpr()->IgnoreParenImpCasts(); lebedev.ri wrote: > P

[PATCH] D42578: [AMDGPU] Add ds_fadd builtin function

2018-01-26 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. Were you going to add min and max separately? Repository: rC Clang https://reviews.llvm.org/D42578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r323485 - [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel.

2018-01-26 Thread Amara Emerson via cfe-commits
Author: aemerson Date: Thu Jan 25 16:27:22 2018 New Revision: 323485 URL: http://llvm.org/viewvc/llvm-project?rev=323485&view=rev Log: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel. Differential Revision: https://reviews.llvm.org/D42276 Added: cfe/trunk/test/

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2018-01-26 Thread Nikhil Gupta via Phabricator via cfe-commits
nikhgupt added inline comments. Herald added a subscriber: hintonda. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:395 +return XFE && !YFE; + return XFE->getName() < YFE->getName(); +} getName could yield incorrect results if two files in the projec

[PATCH] D42578: [AMDGPU] Add ds_fadd builtin function

2018-01-26 Thread Daniil Fukalov via Phabricator via cfe-commits
dfukalov created this revision. dfukalov added reviewers: arsenm, b-sumner. dfukalov added a project: AMDGPU. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl. Repository: rC Clang https://reviews.llvm.org/D42578 Files: include/clang/Basic/Built

[PATCH] D42570: clang-format: [JS] Prevent ASI before [ and (.

2018-01-26 Thread Martin Probst via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323532: clang-format: [JS] Prevent ASI before [ and (. (authored by mprobst, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42570 Files: cfe/t

r323532 - clang-format: [JS] Prevent ASI before [ and (.

2018-01-26 Thread Martin Probst via cfe-commits
Author: mprobst Date: Fri Jan 26 07:07:49 2018 New Revision: 323532 URL: http://llvm.org/viewvc/llvm-project?rev=323532&view=rev Log: clang-format: [JS] Prevent ASI before [ and (. Summary: JavaScript automatic semicolon insertion can trigger before [ and (, so avoid breaking before them if the p

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

2018-01-26 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: bkramer. Herald added subscribers: cfe-commits, hintonda, mgorny. Repository: rC Clang https://reviews.llvm.org/D42577 Files: include/clang/Lex/HeaderSearch.h lib/Lex/HeaderSearch.cpp unittests/Lex/CMakeLists.txt unittests/Lex/Head

[PATCH] D42570: clang-format: [JS] Prevent ASI before [ and (.

2018-01-26 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Makes sense. Repository: rC Clang https://reviews.llvm.org/D42570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

2018-01-26 Thread Ben Hamilton via cfe-commits
It's needed because otherwise lit ignores the .h file, which is the configuration specified in the lit config in the parent directory. On Fri, Jan 26, 2018, 01:55 Krasimir Georgiev via Phabricator < revi...@reviews.llvm.org> wrote: > krasimir requested changes to this revision. > krasimir added i

[PATCH] D42573: [wip] The new threading implementation

2018-01-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks, this helps me understand where previous patch is coming from! I have some comments on the ThreadPool part, which basically amount to trying to represent the same abstract structure with fewer pieces. But I still want to consider whether that's the right structu

r323528 - [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80.

2018-01-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jan 26 06:14:11 2018 New Revision: 323528 URL: http://llvm.org/viewvc/llvm-project?rev=323528&view=rev Log: [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80. We can stash the cached transparent tag bit in existing pointer padding. Everything coming out o

[PATCH] D42575: [clangd] Better handling symbols defined in macros.

2018-01-26 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ioeric. Herald added subscribers: jkorous-apple, ilya-biryukov, klimek. For symbols defined inside macros: - use expansion location, if the symbol is formed via macro concatenation. - use spelling location, otherwise. This will fix some symb

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-01-26 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

2018-01-26 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Thanks for the comments! Comment at: clangd/ClangdLSPServer.cpp:284 + std::string ResultUri = ""; + if (Result) { +auto U = URI::create(*Result); sammccall wrote: > But basically I think this shows that the API is awkward. We shoul

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

2018-01-26 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 131576. ioeric marked 8 inline comments as done. ioeric added a comment. - Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42419 Files: clangd/ClangdLSPServer.cpp clangd/Protocol.cpp clangd/Protocol.h clangd/UR

r323524 - [ASTImporter] avoid warnings: unused var, switch covered

2018-01-26 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Jan 26 04:06:44 2018 New Revision: 323524 URL: http://llvm.org/viewvc/llvm-project?rev=323524&view=rev Log: [ASTImporter] avoid warnings: unused var, switch covered Modified: cfe/trunk/lib/AST/ASTImporter.cpp cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: c

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

2018-01-26 Thread Alexey Bader via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323522: [OpenCL] Add "cles_khr_int64" extension. (authored by bader, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42532 Files: cfe/trunk/inc

r323522 - [OpenCL] Add "cles_khr_int64" extension.

2018-01-26 Thread Alexey Bader via cfe-commits
Author: bader Date: Fri Jan 26 03:48:46 2018 New Revision: 323522 URL: http://llvm.org/viewvc/llvm-project?rev=323522&view=rev Log: [OpenCL] Add "cles_khr_int64" extension. Summary: For OpenCL 1.1 embedded profile 64 bit integers i.e. long, ulong including the appropriate vector data types and op

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

2018-01-26 Thread Aleksei Sidorin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC323519: [ASTImporter] Support LambdaExprs and improve template support (authored by a.sidorin, committed by ). Changed prior to commit: https://reviews.llvm.org/D42301?vs=131279&id=131568#toc Repositor

r323519 - [ASTImporter] Support LambdaExprs and improve template support

2018-01-26 Thread Aleksei Sidorin via cfe-commits
Author: a.sidorin Date: Fri Jan 26 03:36:54 2018 New Revision: 323519 URL: http://llvm.org/viewvc/llvm-project?rev=323519&view=rev Log: [ASTImporter] Support LambdaExprs and improve template support Also, a number of style and bug fixes was done: * ASTImporterTest: added sanity check for sourc

[PATCH] D42573: [wip] The new threading implementation

2018-01-26 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:266 + +ParseInputs Inputs; +std::shared_ptr Resources; These fields should probably be grouped into multiple groups: - `Inputs` - capture the latest input. Can only be used on the main

[clang-tools-extra] r323518 - [clangd] Fix GCC build break 'declaration changes meaning'

2018-01-26 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Jan 26 03:23:33 2018 New Revision: 323518 URL: http://llvm.org/viewvc/llvm-project?rev=323518&view=rev Log: [clangd] Fix GCC build break 'declaration changes meaning' Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp Modified: clang-tools-extra/trunk/

[PATCH] D42573: [wip] The new threading implementation

2018-01-26 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: cfe-commits, hintonda, ioeric, jkorous-apple, mgorny, klimek. DO NOT SUBMIT (yet). This is a non-final version of the patch. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D

r323517 - [Tooling] Test more APIs of ToolExecutor. NFC.

2018-01-26 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Jan 26 03:10:32 2018 New Revision: 323517 URL: http://llvm.org/viewvc/llvm-project?rev=323517&view=rev Log: [Tooling] Test more APIs of ToolExecutor. NFC. Modified: cfe/trunk/unittests/Tooling/ExecutionTest.cpp Modified: cfe/trunk/unittests/Tooling/ExecutionTest.cpp

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

2018-01-26 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:246 + + ParseInputs Inputs = getInputs(File); + std::shared_ptr Preamble = sammccall wrote: > I think you want to take a reference here, and then capture by value Makes sense, less copies.

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

2018-01-26 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 131565. ilya-biryukov marked 14 inline comments as done. ilya-biryukov added a comment. Herald added subscribers: hintonda, mgorny. - Adressed review comments. - Move threading code to separate files. Repository: rCTE Clang Tools Extra https://revie

[PATCH] D42517: [clangd] RFC: Pass Context implicitly using TLS.

2018-01-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 131564. sammccall added a comment. Rebase on the Span changes that landed as r323511 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42517 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/Cl

[PATCH] D42561: [PR36008] Avoid -Wsign-compare warning for enum constants in typeof expressions

2018-01-26 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8959 + if (!S.getLangOpts().CPlusPlus) { +if (const TypeOfExprType *TET = dyn_cast(RHS->getType())) + RHS = TET->getUnderlyingExpr()->IgnoreParenImpCasts(); Please also add a commen

[PATCH] D42570: clang-format: [JS] Prevent ASI before [ and (.

2018-01-26 Thread Martin Probst via Phabricator via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. Herald added a subscriber: klimek. JavaScript automatic semicolon insertion can trigger before [ and (, so avoid breaking before them if the previous token is likely to terminate an expression. Repository: rC Clang https://revi

[PATCH] D42569: [ARM] disable FPU features when using soft floating point.

2018-01-26 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm created this revision. keith.walker.arm added reviewers: efriedma, compnerd. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar, aemerson. This change was orignally approved in Differential Revision https://reviews.llvm.org/D40256 and committed in r319420 and subseq

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

2018-01-26 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: test/Format/lit.local.cfg:1 +# Suffixes supported by clang-format. +config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js', -

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

2018-01-26 Thread Andrew V. Tischenko via Phabricator via cfe-commits
avt77 added inline comments. Comment at: lib/AST/ExprClassification.cpp:652 +if (Ctx.getCanonicalType(ASE->getBase()->getType()).isConstQualified()) + return Cl::CM_ConstQualified; + rjmccall wrote: > Is there a reason why the places that compute the typ

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

2018-01-26 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:115 + +bool prefixedPropertyNameMatches(const llvm::StringRef &PropertyName, + const std::vector &Acronyms) { Wizard wrote: > hokein wrote: > >

[PATCH] D42499: [clangd] Modify the Span API so that Spans propagate with contexts.

2018-01-26 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323511: [clangd] Modify the Span API so that Spans propagate with contexts. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[clang-tools-extra] r323511 - [clangd] Modify the Span API so that Spans propagate with contexts.

2018-01-26 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Jan 26 01:00:30 2018 New Revision: 323511 URL: http://llvm.org/viewvc/llvm-project?rev=323511&view=rev Log: [clangd] Modify the Span API so that Spans propagate with contexts. Summary: This is probably the right behavior for distributed tracers, and makes unpaired begi

[PATCH] D42499: [clangd] Modify the Span API so that Spans propagate with contexts.

2018-01-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 131546. sammccall marked 2 inline comments as done. sammccall added a comment. Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42499 Files: clangd/ClangdUnit.cpp clangd/Context.h clangd/Function.h clangd/JSO

[PATCH] D42499: [clangd] Modify the Span API so that Spans propagate with contexts.

2018-01-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/JSONRPCDispatcher.cpp:31 + RequestArgs(json::obj *Args) : Args(Args) {} + std::mutex Mu; + json::obj *Args; ilya-biryukov wrote: > We could make the fields private

r323509 - [NFC] fix trivial typos in comments and documents

2018-01-26 Thread Hiroshi Inoue via cfe-commits
Author: inouehrs Date: Fri Jan 26 00:15:52 2018 New Revision: 323509 URL: http://llvm.org/viewvc/llvm-project?rev=323509&view=rev Log: [NFC] fix trivial typos in comments and documents "in in" -> "in", "on on" -> "on" etc. Modified: cfe/trunk/docs/InternalsManual.rst cfe/trunk/docs/doxy