[PATCH] D43189: [DebugInfo] Avoid name conflict of generated VLA expression variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324988: [DebugInfo] Avoid name conflict of generated VLA expression variable. (authored by s.desmalen, committed by ). Repository: rC Clang https://reviews.llvm.org/D43189 Files:

[PATCH] D43180: [clang-format] Support text proto extensions

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Cool, thanks. Repository: rC Clang https://reviews.llvm.org/D43180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43224: Fix typos.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D43224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43224: Fix typos.

brucem created this revision. brucem added reviewers: mclow.lists, EricWF. Repository: rCXX libc++ https://reviews.llvm.org/D43224 Files: docs/DesignDocs/AvailabilityMarkup.rst docs/DesignDocs/CapturingConfigInfo.rst Index: docs/DesignDocs/CapturingConfigInfo.rst

[PATCH] D43159: Modernize: Use nullptr more.

brucem added a comment. In https://reviews.llvm.org/D43159#1004617, @jroelofs wrote: > Is it worth adding `-Werror=zero-as-null-pointer-constant` to the build? I'll look at this as a follow up. Repository: rCXX libc++ https://reviews.llvm.org/D43159

[PATCH] D43159: Modernize: Use nullptr more.

brucem added a comment. In https://reviews.llvm.org/D43159#1004639, @dim wrote: > In https://reviews.llvm.org/D43159#1004625, @EricWF wrote: > > > So my main concern with this patch is that `nullptr` is actually > > `#defined`'ed in C++03 mode. That definition comes from the `__nullptr` > >

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 133996. brucem added a comment. Addressed minor issues. - Addressed missing __end_ initialization from valarray. - Removed cast that was no longer needed. - Added nullptr usage to include/regex. Repository: rCXX libc++ https://reviews.llvm.org/D43159

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak updated this revision to Diff 133994. ahatanak marked 8 inline comments as done. ahatanak added a comment. Address review comments and feedback I got from John offline. The main changes are in CGNonTrivialStruct.cpp. I cleaned up the class hierarchy and used variadic template functions

[PATCH] D43223: [clang-tidy] Update fuchsia-multiple-inheritance to not fail

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating the fuchsia-multiple-inheritance to gracefully handle unknown record types (e.g. templatized classes)

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

malaperle added a comment. I haven't looked at the newest patch yet but I gave it a quick try and saw something odd. If I change the configuration to something invalid (say I specify the path to a CMakeLists.txt), then I get many errors/diagnostics, which is normal. But then when I change the

[PATCH] D43221: Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to treat __assume(0) like __builtin_unreachable.

thakis created this revision. thakis added reviewers: rsmith, rnk. Herald added a subscriber: whisperity. Fixes PR29134. https://reviews.llvm.org/D43221 Files: include/clang/AST/Expr.h lib/AST/Expr.cpp lib/Analysis/CFG.cpp lib/Analysis/ReachableCode.cpp

[PATCH] D43108: Support for the mno-stack-arg-probe flag

nruslan added a comment. @hans: One real-world example is when it is used to compile UEFI code using PE/COFF targets natively. Obviously, UEFI uses ABI which is basically almost the same as MS ABI, except that chkstk is not used. It mostly works (I actually was able to get it running) except

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. @ioeric I'm working on a few other priorities over the next few weeks, sorry, but should get back to this relatively soon after that. I would just land it, but I expect some downstream breakage I want to make sure I have time to fix. @malaperle Sounds good – I'll keep

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added inline comments. Comment at: clangd/ClangdUnit.h:51 +using IncludeReferenceMap = std::unordered_map; + ilya-biryukov wrote: > We use `unordered_map` as a `vector>` here. (i.e. we never look up > values by key,

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 133978. malaperle added a comment. Herald added subscribers: ioeric, jkorous-apple. Move tests to XRefsTests, change IncludeReferenceMap to a vector and rename it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files:

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

weimingz updated this revision to Diff 133977. weimingz added a comment. Modified the random generator in filesystem_test_helper to use high_resolution_clock as seed. https://reviews.llvm.org/D41316 Files: CMakeLists.txt include/__config_site.in include/random src/random.cpp

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak added a comment. OK, I see. It's pretty easy to come up with an example. constexpr int foo1(int a = 12) { return a * a; } constexpr int foo2(int a = foo1()) { return a - 12; } https://reviews.llvm.org/D42776 ___

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak added inline comments. Comment at: lib/AST/ExprConstant.cpp:597 +} +void clearDefaultArgNum() { CurDefaultArgNum = 0; } +unsigned CurDefaultArgNum = 0, NextDefaultArgNum = 0; rsmith wrote: > This is wrong: these scopes can nest, so you can't

Re: r324498 - [Driver] Add option to manually control discarding value names in LLVM IR.

Ah.. hrm :/ On Mon, Feb 12, 2018 at 6:03 PM Eric Fiselier wrote: > On Mon, Feb 12, 2018 at 4:01 PM, David Blaikie wrote: > >> ah, sweet :) >> >> On Mon, Feb 12, 2018 at 2:59 PM Eric Fiselier wrote: >> >>> On Mon, Feb 12, 2018 at 3:35 PM, David

Re: r324498 - [Driver] Add option to manually control discarding value names in LLVM IR.

On Mon, Feb 12, 2018 at 4:01 PM, David Blaikie wrote: > ah, sweet :) > > On Mon, Feb 12, 2018 at 2:59 PM Eric Fiselier wrote: > >> On Mon, Feb 12, 2018 at 3:35 PM, David Blaikie >> wrote: >> >>> >>> >>> On Mon, Feb 12, 2018 at 2:25 PM Eric

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, I didn't find any issues https://reviews.llvm.org/D36918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133966. vitalybuka added a comment. fix rebase issues introduced in the last patch https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[libcxxabi] r324970 - [demangler] Support for initializer lists and designated initializers.

Author: epilk Date: Mon Feb 12 16:15:56 2018 New Revision: 324970 URL: http://llvm.org/viewvc/llvm-project?rev=324970=rev Log: [demangler] Support for initializer lists and designated initializers. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp

[libcxxabi] r324968 - [demangler] All on one type should share one entry in the substitution table.

Author: epilk Date: Mon Feb 12 16:15:46 2018 New Revision: 324968 URL: http://llvm.org/viewvc/llvm-project?rev=324968=rev Log: [demangler] All on one type should share one entry in the substitution table. Previously, both s and got their own entries. Modified:

[libcxxabi] r324969 - [demangler] Support for dependent elaborate type specifiers.

Author: epilk Date: Mon Feb 12 16:15:53 2018 New Revision: 324969 URL: http://llvm.org/viewvc/llvm-project?rev=324969=rev Log: [demangler] Support for dependent elaborate type specifiers. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

NoQ updated this revision to Diff 133956. NoQ added a comment. - Test `const C = coin ? C(x, y) : C(z, w);`. - Fix comments surrounding the assertion. https://reviews.llvm.org/D43104 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/CallEvent.cpp

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. Hmmm, I'm a bit lost on the CFLAGS bit. I couldn't find a reference to LIBOMP_TEST_CFLAGS anywhere in the openmp tree. There is a LIBOMP_CFLAGS that doesn't appear to be test specific. To try to find a way to modify the CFLAGS for tests I looked at how

r324965 - [Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo correction

Author: bruno Date: Mon Feb 12 15:43:21 2018 New Revision: 324965 URL: http://llvm.org/viewvc/llvm-project?rev=324965=rev Log: [Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo correction Typo correction is the last step here, remapping should come first.

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

rsmith added inline comments. Comment at: lib/AST/APValue.cpp:27 +APValue::LValueBase Base; +bool IsOnePastTheEnd; CharUnits Offset; Move this to the end so it can share space with `IsNullPtr`. Comment at:

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak updated this revision to Diff 133947. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address Erik's and Roman's review comments. https://reviews.llvm.org/D42776 Files: include/clang/AST/APValue.h lib/AST/APValue.cpp lib/AST/ExprConstant.cpp

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak added inline comments. Comment at: lib/AST/ExprConstant.cpp:1165-1173 + auto LB = Temporaries.lower_bound(Key); + + // If an element with key Key is found, reset the value and return it. This + // can happen if Key is part of a default argument expression. + if (LB

Re: r324498 - [Driver] Add option to manually control discarding value names in LLVM IR.

ah, sweet :) On Mon, Feb 12, 2018 at 2:59 PM Eric Fiselier wrote: > On Mon, Feb 12, 2018 at 3:35 PM, David Blaikie wrote: > >> >> >> On Mon, Feb 12, 2018 at 2:25 PM Eric Fiselier wrote: >> >>> On Mon, Feb 12, 2018 at 9:15 AM, David Blaikie

Re: r324498 - [Driver] Add option to manually control discarding value names in LLVM IR.

On Mon, Feb 12, 2018 at 3:35 PM, David Blaikie wrote: > > > On Mon, Feb 12, 2018 at 2:25 PM Eric Fiselier wrote: > >> On Mon, Feb 12, 2018 at 9:15 AM, David Blaikie >> wrote: >> >>> >>> >>> On Wed, Feb 7, 2018 at 10:38 AM Eric Fiselier via

[libcxx] r324959 - [libcxx] [test] Strip trailing whitespace, NFC.

Author: stl_msft Date: Mon Feb 12 14:54:35 2018 New Revision: 324959 URL: http://llvm.org/viewvc/llvm-project?rev=324959=rev Log: [libcxx] [test] Strip trailing whitespace, NFC. Modified: libcxx/trunk/test/std/algorithms/alg.modifying.operations/alg.copy/copy.pass.cpp

[PATCH] D42605: [Sema] Toggle diags when finding allocators (NFCI)

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42775: [analyzer] Exploration strategy prioritizing unexplored coverage first

This revision was automatically updated to reflect the committed changes. Closed by commit rC324956: [analyzer] Exploration strategy prioritizing unexplored coverage first (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r324956 - [analyzer] Exploration strategy prioritizing unexplored coverage first

Author: george.karpenkov Date: Mon Feb 12 14:39:57 2018 New Revision: 324956 URL: http://llvm.org/viewvc/llvm-project?rev=324956=rev Log: [analyzer] Exploration strategy prioritizing unexplored coverage first See reviews.llvm.org/M1 for evaluation, and

[PATCH] D42875: [CFG] [analyzer] Add construction context for ReturnStmt.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324952: [CFG] Provide construction contexts for return value constructors. (authored by dergachev, committed by ). Herald

r324954 - [X86] Reverse the operand order of the implementation of the kunpack builtins.

Author: ctopper Date: Mon Feb 12 14:38:52 2018 New Revision: 324954 URL: http://llvm.org/viewvc/llvm-project?rev=324954=rev Log: [X86] Reverse the operand order of the implementation of the kunpack builtins. The second operand needs to be in the lower bits of the concatenation. This matches

[PATCH] D42875: [CFG] [analyzer] Add construction context for ReturnStmt.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC324952: [CFG] Provide construction contexts for return value constructors. (authored by dergachev, committed by ).

r324952 - [CFG] Provide construction contexts for return value constructors.

Author: dergachev Date: Mon Feb 12 14:36:36 2018 New Revision: 324952 URL: http://llvm.org/viewvc/llvm-project?rev=324952=rev Log: [CFG] Provide construction contexts for return value constructors. When the current function returns a C++ object by value, CFG elements for constructors that

Re: r324498 - [Driver] Add option to manually control discarding value names in LLVM IR.

On Mon, Feb 12, 2018 at 2:25 PM Eric Fiselier wrote: > On Mon, Feb 12, 2018 at 9:15 AM, David Blaikie wrote: > >> >> >> On Wed, Feb 7, 2018 at 10:38 AM Eric Fiselier via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: ericwf >>> Date: Wed Feb

[PATCH] D42876: [analyzer] Support returning objects by value.

NoQ updated this revision to Diff 133933. NoQ added a comment. Well, it still seems to be a reasonable improvement given how all temporary materialization works now, and it's under the flag (`-analyzer-config cfg-temporary-dtors=true`), so i guess i'll mark it as TODO and commit, and i'll keep

[PATCH] D42972: Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324948: Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD. (authored by jhb, committed by ). Changed prior to commit: https://reviews.llvm.org/D42972?vs=10=133935#toc Repository:

[PATCH] D42972: Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324948: Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD. (authored by jhb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42972

Re: r324498 - [Driver] Add option to manually control discarding value names in LLVM IR.

On Mon, Feb 12, 2018 at 9:15 AM, David Blaikie wrote: > > > On Wed, Feb 7, 2018 at 10:38 AM Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ericwf >> Date: Wed Feb 7 10:36:51 2018 >> New Revision: 324498 >> >> URL:

r324948 - Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD.

Author: jhb Date: Mon Feb 12 14:22:01 2018 New Revision: 324948 URL: http://llvm.org/viewvc/llvm-project?rev=324948=rev Log: Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD. Summary: FreeBSD N64 MIPS systems can include 32-bit libraries for O32 in /usr/lib32 similar to the 32-bit

[PATCH] D43209: Put type attributes after class keyword

dim created this revision. dim added reviewers: EricWF, mclow.lists. Compiling `` in C++17 or higher mode results in: functional:2500:1: warning: attribute '__visibility__' is ignored, place it after "class" to apply attribute to type declaration [-Wignored-attributes] _LIBCPP_TYPE_VIS ^

r324946 - [analyzer] [tests] Fix a typo in analyzer testing script.

Author: george.karpenkov Date: Mon Feb 12 14:13:01 2018 New Revision: 324946 URL: http://llvm.org/viewvc/llvm-project?rev=324946=rev Log: [analyzer] [tests] Fix a typo in analyzer testing script. Incorrect option instance construction. Modified: cfe/trunk/utils/analyzer/SATestBuild.py

[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

az closed this revision. az added a comment. Committed as r324940 and r324912 https://reviews.llvm.org/D42993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

On Mon, Feb 12, 2018 at 08:54:56PM +, Stephen Hines via Phabricator via cfe-commits wrote: > srhines added a comment. > > LGTM, but we should make sure that there are no objections, especially since > there is no rationale for why this was present to begin with. Older versions of the GNU

r324940 - [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic - clang portion

Author: az Date: Mon Feb 12 13:26:06 2018 New Revision: 324940 URL: http://llvm.org/viewvc/llvm-project?rev=324940=rev Log: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic - clang portion https://reviews.llvm.org/D42993 Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

mstorsjo added a comment. In https://reviews.llvm.org/D43184#1005281, @smeenai wrote: > FYI, binutils auto-import actually creates a fake IAT entry rather than using > a dynamic initializer. I think it's actually a pretty cute trick. >

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

srhines added a comment. LGTM, but we should make sure that there are no objections, especially since there is no rationale for why this was present to begin with. Repository: rC Clang https://reviews.llvm.org/D43203 ___ cfe-commits mailing

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 133919. gtbercea added a comment. Add regression tests. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D42923: [CUDA] Allow external variables in separate compilation

tra added inline comments. Comment at: test/SemaCUDA/extern-shared.cu:4 +// These declarations are fine in separate compilation mode! +// RUN: %clang_cc1 -fsyntax-only -fcuda-rdc -verify=rdc %s +// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -fcuda-rdc -verify=rdc %s

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. -ast-print prints omp pragmas with a trailing space. While this behavior is likely of little concern to most users, surely it's unintentional, and it's annoying for some source-level work I'm

[PATCH] D42923: [CUDA] Allow external variables in separate compilation

Hahnfeld added inline comments. Comment at: test/SemaCUDA/extern-shared.cu:4 +// These declarations are fine in separate compilation mode! +// RUN: %clang_cc1 -fsyntax-only -fcuda-rdc -verify=rdc %s +// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -fcuda-rdc -verify=rdc %s

[PATCH] D43044: [DebugInfo] Update Checksum handling in CGDebugInfo

scott.linder closed this revision. scott.linder added a comment. Closed by https://reviews.llvm.org/rC324929 Repository: rC Clang https://reviews.llvm.org/D43044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r324929 - [DebugInfo] Update Checksum handling in CGDebugInfo

Author: scott.linder Date: Mon Feb 12 11:47:05 2018 New Revision: 324929 URL: http://llvm.org/viewvc/llvm-project?rev=324929=rev Log: [DebugInfo] Update Checksum handling in CGDebugInfo Update to match new DIFile API. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D42923: [CUDA] Allow external variables in separate compilation

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/SemaCUDA/extern-shared.cu:4 +// These declarations are fine in separate compilation mode! +// RUN: %clang_cc1 -fsyntax-only -fcuda-rdc -verify=rdc %s +//

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. I don't have any other remarks, looks good. Repository: rC Clang https://reviews.llvm.org/D43197 ___ cfe-commits mailing list

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

danalbert created this revision. danalbert added a reviewer: srhines. libgcc won't unwind without an .eh_frame_hdr section. Repository: rC Clang https://reviews.llvm.org/D43203 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/linux-ld.c Index: test/Driver/linux-ld.c

[libcxx] r324923 - Implement LWG 2835 - fix

Author: marshall Date: Mon Feb 12 11:13:24 2018 New Revision: 324923 URL: http://llvm.org/viewvc/llvm-project?rev=324923=rev Log: Implement LWG 2835 - fix Modified: libcxx/trunk/include/tgmath.h libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/include/tgmath.h URL:

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133902. MaskRay marked an inline comment as done. MaskRay added a comment. Rename `Enabled` to `UseStdExperimental` and only suggest std::experimental:: (not `std::`) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

aaron.ballman added a comment. In https://reviews.llvm.org/D43120#1005100, @Szelethus wrote: > I also came up with this problem: > >RegularException funcReturningExceptioniTest(int i) { > return RegularException(); >} > >void returnedValueTest() { >

[PATCH] D43189: [DebugInfo] Avoid name conflict of generated VLA expression variable.

probinson added a comment. Please make sure to cite the PR in the commit message. https://reviews.llvm.org/D43189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. Thx! Repository: rL LLVM https://reviews.llvm.org/D42895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133895. ioeric marked 15 inline comments as done. ioeric added a comment. - Addressed some review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric added inline comments. Comment at: clangd/ClangdServer.cpp:370 +/// File, by matching \p Header against all include search directories for \p +/// File via `clang::HeaderSearch`. +/// sammccall wrote: > ioeric wrote: > > sammccall wrote: > > > sammccall

Re: [PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

> On Feb 12, 2018, at 8:32 AM, David Blaikie wrote: > > Unit test? Added in r324917. -- adrian ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324914 - [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

Author: maskray Date: Mon Feb 12 09:42:09 2018 New Revision: 324914 URL: http://llvm.org/viewvc/llvm-project?rev=324914=rev Log: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo Summary: CXIdxEntityRefInfo contains the member `CXIdxEntityRefKind kind;` to differentiate implicit and

r324917 - Add a unit test for Driver::getDefaultModuleCachePath().

Author: adrian Date: Mon Feb 12 09:59:54 2018 New Revision: 324917 URL: http://llvm.org/viewvc/llvm-project?rev=324917=rev Log: Add a unit test for Driver::getDefaultModuleCachePath(). Added: cfe/trunk/unittests/Driver/ModuleCacheTest.cpp Modified:

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

rnk added a comment. In https://reviews.llvm.org/D43184#1005281, @smeenai wrote: > FYI, binutils auto-import actually creates a fake IAT entry rather than using > a dynamic initializer. I think it's actually a pretty cute trick. >

[PATCH] D43108: Support for the mno-stack-arg-probe flag

MatzeB added a comment. - No test. - What about `-mstack-arg-probe`, shouldn't we have that for consistency? - I'd prefer not to review clang changes myself as I don't know that part of the code too well. Repository: rC Clang https://reviews.llvm.org/D43108

r324915 - Further cleanup to Driver mode code, as suggested by dblaikie [NFC]

Author: erichkeane Date: Mon Feb 12 09:47:01 2018 New Revision: 324915 URL: http://llvm.org/viewvc/llvm-project?rev=324915=rev Log: Further cleanup to Driver mode code, as suggested by dblaikie [NFC] Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL:

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42895?vs=133632=133890#toc Repository: rL

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

smeenai added a comment. FYI, binutils auto-import actually creates a fake IAT entry rather than using a dynamic initializer. I think it's actually a pretty cute trick. http://blog.omega-prime.co.uk/2011/07/04/everything-you-never-wanted-to-know-about-dlls/#how-auto-import-works has details.

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

This revision was automatically updated to reflect the committed changes. Closed by commit rC324913: [Sema] Dont mark plain MS enums as fixed (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D43110?vs=133670=133887#toc Repository: rC Clang

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

This revision was automatically updated to reflect the committed changes. Closed by commit rL324913: [Sema] Dont mark plain MS enums as fixed (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43110?vs=133670=133886#toc

[PATCH] D42844: [OpenCL] Add test for atomic pointers.

Anastasia added a comment. In https://reviews.llvm.org/D42844#1004663, @Fznamznon wrote: > Yes, we don't have anything OpenCL specific for atomic pointers. > But we have OpenCL specific in pointers and atomics separately and we have > address spaces. > Why not to test all at once? We don't

r324913 - [Sema] Don't mark plain MS enums as fixed

Author: rnk Date: Mon Feb 12 09:37:06 2018 New Revision: 324913 URL: http://llvm.org/viewvc/llvm-project?rev=324913=rev Log: [Sema] Don't mark plain MS enums as fixed Summary: This fixes a flaw in our AST: PR27098 MSVC always gives plain enums the underlying type 'int'. Clang does this as well,

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

rnk added a comment. In https://reviews.llvm.org/D43184#1005161, @majnemer wrote: > Do I understand correctly that this workarounds a feature missing in lld? > Does MinGW emit the same sorts of object files as clang in these scenarios? You can see it that way, but having the linker synthesize

[libcxx] r324911 - Implement LWG#2908 - The less-than operator for shared pointers could do more, and mark 2878 as complete as well (we already do that)

Author: marshall Date: Mon Feb 12 09:26:40 2018 New Revision: 324911 URL: http://llvm.org/viewvc/llvm-project?rev=324911=rev Log: Implement LWG#2908 - The less-than operator for shared pointers could do more, and mark 2878 as complete as well (we already do that) Modified:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 133882. gtbercea added a comment. Fix warning message. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp

[PATCH] D43189: [DebugInfo] Avoid name conflict of generated VLA expression variable.

CarlosAlbertoEnciso added a comment. LGTM. Thanks. https://reviews.llvm.org/D43189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324909 - Update target-note-test to be current with the AMDGPU changes

Author: erichkeane Date: Mon Feb 12 09:19:57 2018 New Revision: 324909 URL: http://llvm.org/viewvc/llvm-project?rev=324909=rev Log: Update target-note-test to be current with the AMDGPU changes Modified: cfe/trunk/test/Misc/target-invalid-cpu-note.c Modified:

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. The only thing this needs now is to get correct testing support. Could you add support for passing down to the configuration script an additional set of cflags like compiler-rt and libomp do (as a separate patch)? If you look at libomp, you'll see LIBOMP_TEST_CFLAGS

[PATCH] D43181: [CodeGen] Initialize large arrays by copying from a global

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:421 + // with explicit initializers should be large enough. + if (NumInitElements > 8 && elementType->isBuiltinType()) { +CodeGen::CodeGenModule = CGF.CGM; Is there a good reason to use

[PATCH] D43171: [AMDGPU] Change constant addr space to 4 for clang

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM. Other clean up can be done as a separate patch. Comment at: test/CodeGenOpenCL/address-spaces.cl:37 +// SPIR: i32 addrspace(2)* %arg +// GIZ: i32 addrspace(4)* %arg

[PATCH] D43189: [DebugInfo] Avoid name conflict of generated VLA expression variable.

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGDecl.cpp:1002 getContext().CreateTypeSourceInfo(QT), SC_Auto); + ArtificialDecl->setImplicit(); Thanks!

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

grokos added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:559 +if (!FoundBCLibrary) + getDriver().Diag(diag::remark_drv_omp_offload_target_missingbcruntime); + } Should we be more specific when it comes to the name of the missing bc file

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

rnk added a comment. In https://reviews.llvm.org/D43110#1004107, @rsmith wrote: > Thanks! I'd noticed this weirdness but wasn't sure what we could do about it > without breaking MS compat. I like this approach a lot. Great, sorry for the delay. > If we want to change the C behavior too, I

[PATCH] D43095: Make attribute-target on a Definition-after-use update the LLVM attributes

echristo added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325 +llvm::AttrBuilder Attrs; +if (GetCPUAndFeaturesAttributes(D, Attrs)) { + // We know that GetCPUAndFeaturesAttributes will always have the + // newest set, since

[PATCH] D43095: Make attribute-target on a Definition-after-use update the LLVM attributes

erichkeane marked 3 inline comments as done. erichkeane added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325 +llvm::AttrBuilder Attrs; +if (GetCPUAndFeaturesAttributes(D, Attrs)) { + // We know that GetCPUAndFeaturesAttributes will

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks good with one additional change to the test. Side note: We should also add all the LLVM extensions to http://wiki.dwarfstd.org/index.php?title=Vendor_Extensions.

[PATCH] D43095: Make attribute-target on a Definition-after-use update the LLVM attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rC324907: Make attribute-target on a Definition-after-use update the LLVM attributes (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D43095?vs=133519=133880#toc

r324907 - Make attribute-target on a Definition-after-use update the LLVM attributes

Author: erichkeane Date: Mon Feb 12 09:01:41 2018 New Revision: 324907 URL: http://llvm.org/viewvc/llvm-project?rev=324907=rev Log: Make attribute-target on a Definition-after-use update the LLVM attributes As reported here: https://bugs.llvm.org/show_bug.cgi?id=36301 The issue is that the 'use'

  1   2   >