kosarev added a comment.
John, the patch hangs for about a month now and Hal still seems to be extremely
busy. Can we commit this with the constant to be whatever you think is most
correct and the fix it as needed and if needed later? At this very moment we
don't analyze the size fields of tags
Author: rsmith
Date: Mon Feb 19 01:05:48 2018
New Revision: 325475
URL: http://llvm.org/viewvc/llvm-project?rev=325475&view=rev
Log:
[cxx_dr_status] Tests for CWG issues 641-687.
Modified:
cfe/trunk/test/CXX/drs/dr6xx.cpp
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/test/CXX/drs/
Author: sammccall
Date: Mon Feb 19 01:31:26 2018
New Revision: 325476
URL: http://llvm.org/viewvc/llvm-project?rev=325476&view=rev
Log:
[clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!
Summary:
There are a few implementation options here - alternatives are either both
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325476: [clangd] Fix use-after-free in SymbolYAML: strings
are owned by yaml::Input! (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
ilya-biryukov added a subscriber: hokein.
ilya-biryukov added a comment.
LGTM. We'll need to publish new version of VSCode extensions. +@hokein, who did
that before.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43385
___
cfe-comm
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:355
+/// \brief Get string representation of \p Kind, useful for for debugging.
+llvm::StringRef printCompleti
Author: sammccall
Date: Mon Feb 19 01:43:46 2018
New Revision: 325477
URL: http://llvm.org/viewvc/llvm-project?rev=325477&view=rev
Log:
[clangd] Add "clangd.trace" VSCode setting to enable tracing.
Summary:
Setting the CLANGD_TRACE environment variable directly is awkward with VSCode's
"reload fr
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325477: [clangd] Add "clangd.trace" VSCode
setting to enable tracing. (authored by sammccall, committed by ).
Changed p
Author: kosarev
Date: Mon Feb 19 01:49:11 2018
New Revision: 325478
URL: http://llvm.org/viewvc/llvm-project?rev=325478&view=rev
Log:
[CodeGen] Initialize large arrays by copying from a global
Currently, clang compiles explicit initializers for array
elements into series of store instructions. Fo
hokein added a comment.
Will make a new release for clangd vscode extension today.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325478: [CodeGen] Initialize large arrays by copying from a
global (authored by kosarev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43181?vs=134590&id=134865#toc
Repository:
r
Author: sammccall
Date: Mon Feb 19 01:56:28 2018
New Revision: 325480
URL: http://llvm.org/viewvc/llvm-project?rev=325480&view=rev
Log:
[clangd] Tracing: name worker threads, and enforce naming scheduled async tasks
Summary:
This has a bit of a blast radius, but I think there's enough value in "f
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325480: [clangd] Tracing: name worker threads, and enforce
naming scheduled async tasks (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43388?vs=134617&id=13
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325480: [clangd] Tracing: name worker threads, and enforce
naming scheduled async tasks (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
Reduced repro:
$ clang -cc1 -triple i386-pc-windows-msvc19.11.0 -emit-pch
-fms-extensions -fms-compatibility -fms-compatibility-version=19.11
-std=c++14 -fdelayed-template-parsing -x c++-header a.ii -o /dev/null
a.ii:
namespace a {
enum b { c };
}
template class d { static constexpr a::b e = a:
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43452
Files:
clangd/clients/clangd-vscode/package.json
Index: clangd/clients/clangd-vscode/
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(Do we need to bump this for the market to update properly? How do we decide
when to bump it?)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43452
_
CarlosAlbertoEnciso added a subscriber: aheejin.
CarlosAlbertoEnciso added a comment.
Thanks @aheejin
Repository:
rL LLVM
https://reviews.llvm.org/D42640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
hokein added a comment.
In https://reviews.llvm.org/D43452#1011825, @sammccall wrote:
> (Do we need to bump this for the market to update properly? How do we decide
> when to bump it?)
Yes, every time we need to make a new release extension to vscode market, we
need to bump the version.
Rep
ilya-biryukov added a comment.
In https://reviews.llvm.org/D39571#1007393, @simark wrote:
> If I do it in this order, I get one diagnostic both times, when I don't
> expect one the second time the file is parsed. But if I do it the other way
> (first parse with no errors, second parse with an
Author: ioeric
Date: Mon Feb 19 02:45:48 2018
New Revision: 325482
URL: http://llvm.org/viewvc/llvm-project?rev=325482&view=rev
Log:
[clangd] Try to fix build bot failure caused by r325343: escape regex string.
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: cl
Author: dylanmckay
Date: Mon Feb 19 02:46:16 2018
New Revision: 325483
URL: http://llvm.org/viewvc/llvm-project?rev=325483&view=rev
Log:
[AVR] Set the program address space in the data layout
This is accompanied by r325481 in LLVM.
Modified:
cfe/trunk/lib/Basic/Targets/AVR.h
Modified: cfe/t
Author: hokein
Date: Mon Feb 19 02:49:12 2018
New Revision: 325484
URL: http://llvm.org/viewvc/llvm-project?rev=325484&view=rev
Log:
[clangd] Bump vs-code clangd extension v0.0.3
Reviewers: sammccall
Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-commits, ioeric
Differential Revision: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325484: [clangd] Bump vs-code clangd extension v0.0.3
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43452
Files:
clang-t
I've sent r325482 which (hopefully) fixes the failure. I'll keep an eye on
the bot to make sure this is fixed ASAP.
Sorry about the inconvenience!
o Eric
On Mon, Feb 19, 2018 at 11:39 AM Carlos Alberto Enciso via Phabricator <
revi...@reviews.llvm.org> wrote:
> CarlosAlbertoEnciso added a subs
kosarev updated this revision to Diff 134877.
kosarev edited the summary of this revision.
kosarev added a comment.
Do not change the size field of may-alias TBAA descriptors for now.
https://reviews.llvm.org/D42366
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenTBAA.cpp
lib/Code
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43454
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
unittests/clang
Author: ibiryukov
Date: Mon Feb 19 03:15:33 2018
New Revision: 325486
URL: http://llvm.org/viewvc/llvm-project?rev=325486&view=rev
Log:
[clangd] Mark non-changing fields of CppFile as const. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.h
Modified: clang-tools-extra/trunk/clangd/Cl
ilya-biryukov added a comment.
In https://reviews.llvm.org/D39571#1011842, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D39571#1007393, @simark wrote:
>
> > If I do it in this order, I get one diagnostic both times, when I don't
> > expect one the second time the file is parsed. But if I
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43455
Files:
clangd/clients/clangd-vscode/README.md
Index: clangd/clients/clangd-vscode/REA
ilya-biryukov added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:355
+/// \brief Get string representation of \p Kind, useful for for debugging.
+llvm::StringRef printCompletionKind(enum CodeCompletionContext::Kind Kind);
+
sammccall wro
sammccall added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:355
+/// \brief Get string representation of \p Kind, useful for for debugging.
+llvm::StringRef printCompletionKind(enum CodeCompletionContext::Kind Kind);
+
ilya-biryukov wro
lebedev.ri added a comment.
Great work!
Some more review...
Comment at: clang-doc/ClangDoc.cpp:32
+ ECtx.reportResult(
+ Name, Mapper.emitInfo(D, getComment(D), Name, getLine(D), getFile(D)));
+}
I wonder if `Name` should be `std::move()`'d ? Or not, `rep
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D43440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ilya-biryukov updated this revision to Diff 134888.
ilya-biryukov added a comment.
- Rename printCompletionKind to getCompletionKindString
Repository:
rC Clang
https://reviews.llvm.org/D43379
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/CodeCompleteConsumer.cpp
Index: lib/
ilya-biryukov updated this revision to Diff 134889.
ilya-biryukov added a comment.
- Rename usage of printCompletionKind to getCompletionKindString
- Remove tracing of the filename, TUScheduler now provides those traces
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43377
Files
Author: mprobst
Date: Mon Feb 19 04:32:13 2018
New Revision: 325489
URL: http://llvm.org/viewvc/llvm-project?rev=325489&view=rev
Log:
clang-format: [JS] fix `of` detection.
Summary:
`of` is only a keyword when after an identifier, but not when after
an actual keyword.
Before:
return of (a, b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325489: clang-format: [JS] fix `of` detection. (authored by
mprobst, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43440
Files:
cfe/trunk/lib
Author: ibiryukov
Date: Mon Feb 19 04:35:33 2018
New Revision: 325490
URL: http://llvm.org/viewvc/llvm-project?rev=325490&view=rev
Log:
[CodeComplete] Add a helper to print CodeCompletionContext::Kind
Summary: Will be used in clangd. See D43377.
Reviewers: sammccall
Reviewed By: sammccall
Subs
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325490: [CodeComplete] Add a helper to print
CodeCompletionContext::Kind (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43379?vs=134888&id=134891#toc
Reposit
Author: ibiryukov
Date: Mon Feb 19 04:35:57 2018
New Revision: 325491
URL: http://llvm.org/viewvc/llvm-project?rev=325491&view=rev
Log:
[clangd] Attach more information about Sema completion to traces
Reviewers: hokein, ioeric, sammccall
Reviewed By: sammccall
Subscribers: klimek, cfe-commits,
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325491: [clangd] Attach more information about Sema
completion to traces (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43377?vs=134889&id=134892#toc
Repos
Author: kwalker
Date: Mon Feb 19 04:40:26 2018
New Revision: 325492
URL: http://llvm.org/viewvc/llvm-project?rev=325492&view=rev
Log:
[ARM] disable FPU features when using soft floating point.
To be compatible with GCC if soft floating point is in effect any FPU
specified is effectively ignored,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325492: [ARM] disable FPU features when using soft floating
point. (authored by kwalker, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42569
mgorny added a comment.
Ping for the third time.
https://reviews.llvm.org/D34365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sammccall
Date: Mon Feb 19 05:04:41 2018
New Revision: 325493
URL: http://llvm.org/viewvc/llvm-project?rev=325493&view=rev
Log:
[clangd] Invert return value of fuzzyFind() (fix MemIndex's return value)
Have had way too many bugs by converting between "isComplete" and
"isIncomplete". LSP i
lebedev.ri added inline comments.
Comment at: clang-doc/ClangDocBinary.h:82
+
+static std::map BlockIdNameMap = {
+ {NAMESPACE_BLOCK_ID, "NamespaceBlock"},
lebedev.ri wrote:
> Nice!
> Some thoughts:
> 1. I agree it makes sense to keep it close to the enum defini
lebedev.ri added a comment.
clang 6.0 defaults to C++14, BTW.
https://reviews.llvm.org/D34365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ibiryukov
Date: Mon Feb 19 05:53:49 2018
New Revision: 325496
URL: http://llvm.org/viewvc/llvm-project?rev=325496&view=rev
Log:
[CodeComplete] Avoid name clashes of 'Kind' inside CodeCompletionContext. NFC
CodeCompletionContext had declarations of field and enum inside, both named
'Kind'
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
thanks! couple of nits
Comment at: clangd/clients/clangd-vscode/README.md:55
+
+Everytime you make a change to `clangd-vscode`, you are expected to publish a
+new versi
hokein updated this revision to Diff 134900.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43455
Files:
clangd/clients/clangd-vscode/README.md
Index: clangd/clients/clangd-vscode/READ
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/clients/clangd-vscode/README.md:61
+* Make sure install the `vsce` command (`npm install -g vsce`)
+* `llvm-vs-code-extensions` account
+
sammccall wrote:
> increase the ver
GBuella created this revision.
GBuella added reviewers: craig.topper, zvi, echristo.
Herald added a subscriber: cfe-commits.
Cannon Lake does not support CLWB, therefore it
does not include all features listed under SKX.
Repository:
rC Clang
https://reviews.llvm.org/D43459
Files:
lib/Basic
GBuella added a comment.
See also: https://reviews.llvm.org/D43380
Repository:
rC Clang
https://reviews.llvm.org/D43459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon Feb 19 06:01:52 2018
New Revision: 325499
URL: http://llvm.org/viewvc/llvm-project?rev=325499&view=rev
Log:
[clangd] Add brief instructions on how to make a release for vscode-clangd
extension.
Reviewers: sammccall
Subscribers: klimek, ilya-biryukov, jkorous-apple, ioer
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rCTE325499: [clangd] Add brief instructions on how to make a
release for vscode-clangd… (authored by hokein, committed by ).
Changed prior to commit:
https://revie
Merged to 6.0 in r325500.
On Fri, Feb 16, 2018 at 8:44 PM, Reid Kleckner via cfe-commits
wrote:
> Author: rnk
> Date: Fri Feb 16 11:44:47 2018
> New Revision: 325375
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325375&view=rev
> Log:
> [MS] Make constexpr static data members implicitly inline
Hahnfeld created this revision.
Hahnfeld added reviewers: jlebar, tra.
Herald added a subscriber: cfe-commits.
Binaries for multiple architectures are combined by fatbinary,
so the current code was effectively not needed.
Repository:
rC Clang
https://reviews.llvm.org/D43461
Files:
include/
Author: hokein
Date: Mon Feb 19 06:26:55 2018
New Revision: 325503
URL: http://llvm.org/viewvc/llvm-project?rev=325503&view=rev
Log:
[clangd] Correct the doc, password => Personal Access Token.
Modified:
clang-tools-extra/trunk/clangd/clients/clangd-vscode/README.md
Modified: clang-tools-ext
ioeric created this revision.
ioeric added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous-apple, klimek.
o Avoid inserting a header include into the header itself.
o Avoid inserting non-header files.
o Canonicalize include paths for symbols in dynamic index.
miyuki added a comment.
No, I'll commit it myself. Thank you for the review.
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: krasimir
Date: Mon Feb 19 07:31:25 2018
New Revision: 325509
URL: http://llvm.org/viewvc/llvm-project?rev=325509&view=rev
Log:
[clang-format] Fixup a case of text proto message attributes
Summary: This patch fixes a case where a proto message attribute is wrongly
identified as an text pr
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This patch fixes a case where a proto message attribute is wrongly identified
as an text proto extension.
Repository:
rC Clang
https://reviews.llvm.org/D43465
Files:
lib/Format/TokenAnnotator.cpp
unittests/Fo
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325509: [clang-format] Fixup a case of text proto message
attributes (authored by krasimir, committed by ).
Herald added a
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325509: [clang-format] Fixup a case of text proto message
attributes (authored by krasimir, committed by ).
Changed prior
simark accepted this revision.
simark added a comment.
This revision is now accepted and ready to land.
I don't have the setup to test at the moment, but the code looks good to me.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43454
__
ilya-biryukov added inline comments.
Comment at: clangd/Headers.cpp:45
+bool hasHeaderExtension(PathRef Path) {
+ constexpr static const char *HeaderExtensions[] = {".h", ".hpp", ".hh",
+ ".hxx"};
There is anot
simark added a comment.
In https://reviews.llvm.org/D39571#1011877, @ilya-biryukov wrote:
> > That looks like another preamble-handling bug. It's much easier to fix and
> > it's clangd-specific, so I'll make sure to fix that soon.
> > Thanks for bringing this up, we haven't been testing compile
sammccall added inline comments.
Comment at: clangd/Headers.cpp:42-43
};
+/// Returns true if \p Path has header extensions like .h and .hpp etc.
+bool hasHeaderExtension(PathRef Path) {
As discussed offline, this seems dubious.
- this is probably the generali
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX325510: [libcxx] Improve accuracy of complex asinh and
acosh (authored by miyuki, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41629
Files:
include/complex
test/libcxx/numer
Author: krasimir
Date: Mon Feb 19 08:00:21 2018
New Revision: 325513
URL: http://llvm.org/viewvc/llvm-project?rev=325513&view=rev
Log:
[clang-format] Fix text proto extension scope opening detection
Summary:
This fixes the detection of scope openers in text proto extensions; previously
they were
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This fixes the detection of scope openers in text proto extensions; previously
they were not detected correctly leading to instances like:
msg {
[aa.bb
] {
key: value
}
}
Repository:
rC Clang
https:/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325513: [clang-format] Fix text proto extension scope
opening detection (authored by krasimir, committed by ).
Changed pr
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325513: [clang-format] Fix text proto extension scope
opening detection (authored by krasimir, committed by ).
Herald adde
Author: miyuki
Date: Mon Feb 19 07:41:36 2018
New Revision: 325510
URL: http://llvm.org/viewvc/llvm-project?rev=325510&view=rev
Log:
[libcxx] Improve accuracy of complex asinh and acosh
Summary:
Currently std::asinh and std::acosh use std::pow to compute x^2. This
results in a significant error w
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I'm fine with that plan. LGTM.
https://reviews.llvm.org/D42366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
rjmccall added a comment.
Discourse nitpick: I would encourage you to just use the ordinary phrase "null
pointer", or just "null", when referring to a pointer value that happens to be
null and to reserve "nullptr" for *statically* null pointers, especially the
`nullptr` expression.
If the poin
ioeric added inline comments.
Comment at: clangd/Headers.cpp:45
+bool hasHeaderExtension(PathRef Path) {
+ constexpr static const char *HeaderExtensions[] = {".h", ".hpp", ".hh",
+ ".hxx"};
ilya-biryukov wrote:
ioeric updated this revision to Diff 134932.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Stop indexing main files in dynamic index; addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/H
sammccall added a comment.
Naming conventions tend to stick around for a while - `clang-doc/ClangDocXYZ.h`
seems a bit unwieldy compared to `clang-doc/XYZ.h` - might be worth considering.
Comment at: clang-doc/ClangDoc.cpp:37
+ Context = Result.Context;
+ if (const auto *M =
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This LGTM, but you should wait a few days in case Richard has thoughts or
concerns.
Repository:
rC Clang
https://reviews.llvm.org/D42840
__
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
tbourvon updated this revision to Diff 134936.
tbourvon added a comment.
This updates the patch to use `clang::tooling::fixit::getText()` instead of the
custom `getStmtText`. This also adds a macro unit test.
https://reviews.llvm.org/D37014
Files:
clang-tidy/readability/CMakeLists.txt
clan
Author: aaronballman
Date: Mon Feb 19 09:32:07 2018
New Revision: 325520
URL: http://llvm.org/viewvc/llvm-project?rev=325520&view=rev
Log:
Add several more attributes to be parsed in C with [[]] when
-fdouble-square-bracket-attributes is specified.
Also flags a few attributes that should not be
sammccall added inline comments.
Comment at: clangd/Headers.h:26
///
/// \param Header is an absolute file path.
+/// \return A quoted "path" or . This returns an empty string if:
File also needs to be absolute.
(May want to add asserts for this at the start of
ilya-biryukov added inline comments.
Comment at: clangd/Headers.cpp:60
Argv.push_back(S.c_str());
IgnoringDiagConsumer IgnoreDiags;
auto CI = clang::createInvocationFromCommandLine(
Not related to this patch, but just noticed that we don't call
`FS->s
ilya-biryukov added inline comments.
Comment at: clangd/index/CanonicalIncludes.cpp:21
llvm::StringRef CanonicalPath) {
addRegexMapping((llvm::Twine("^") + llvm::Regex::escape(Path) + "$").str(),
CanonicalPath);
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325522: [clangd] Do not reuse preamble if compile args
changed (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43454?v
Author: ibiryukov
Date: Mon Feb 19 10:18:49 2018
New Revision: 325522
URL: http://llvm.org/viewvc/llvm-project?rev=325522&view=rev
Log:
[clangd] Do not reuse preamble if compile args changed
Reviewers: hokein, ioeric, sammccall, simark
Reviewed By: simark
Subscribers: klimek, jkorous-apple, cfe
ioeric updated this revision to Diff 134943.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- addressed comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
clangd/index/Canon
ioeric marked 5 inline comments as done.
ioeric added inline comments.
Comment at: clangd/Headers.cpp:60
Argv.push_back(S.c_str());
IgnoringDiagConsumer IgnoreDiags;
auto CI = clang::createInvocationFromCommandLine(
ilya-biryukov wrote:
> Not related t
ioeric updated this revision to Diff 134944.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- added a comment about thread safety
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
cl
ioeric updated this revision to Diff 134947.
ioeric added a comment.
- assert in the very beginning!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
clangd/index/CanonicalIncludes.cpp
clangd/index
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ioeric
Date: Mon Feb 19 10:48:44 2018
New Revision: 325523
URL: http://llvm.org/viewvc/llvm-project?rev=325523&view=rev
Log:
[clangd] Fixes for #include insertion.
Summary:
o Avoid inserting a header include into the header itself.
o Avoid inserting non-header files (by not indexing symbo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325523: [clangd] Fixes for #include insertion. (authored by
ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43462
Files:
clang-tools-ex
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325523: [clangd] Fixes for #include insertion. (authored
by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43462?vs=134947&id=134952#toc
Repository:
rL LLVM
https://rev
arichardson added a comment.
Herald added a subscriber: christof.
ping
Repository:
rCXX libc++
https://reviews.llvm.org/D42139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
`MaterializeTemporaryExpr` captures lifetime extension information. In the
analyzer it is important to have this information at construction
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm fine with this, but I don't really think it's a good solution (but none of
our LIT config is ideal). In particular for the link flags might not work well,
because the order of linker flags
1 - 100 of 131 matches
Mail list logo
