[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 136944. jdemeule added a comment. Update patch after reviewer comments. https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h clang-apply-replacements/lib/Tooling/ApplyReplacements

Re: r326676 - Amend r326665 to print out the `used` attribute subjects in a different order.

Awesome, thanks! On Sun, Mar 4, 2018, 11:26 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Sun Mar 4 08:24:10 2018 > New Revision: 326676 > > URL: http://llvm.org/viewvc/llvm-project?rev=326676&view=rev > Log: > Amend r326665 to print out the

[PATCH] D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

a.sidorin created this revision. a.sidorin added reviewers: r.stahl, xazax.hun, jingham, szepet. Herald added subscribers: martong, rnkovacs. This patch introduces the ability to test an arbitrary sequence of imports between a given set of virtual source files. This should finally allow us t

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:207 + llvm::DenseMap> + GroupedReplacements; + ioeric wrote: > jdemeule wrote: > > ioeric wrote: > > > I don't think we need to do the deduplication here

r326676 - Amend r326665 to print out the `used` attribute subjects in a different order.

Author: aaronballman Date: Sun Mar 4 08:24:10 2018 New Revision: 326676 URL: http://llvm.org/viewvc/llvm-project?rev=326676&view=rev Log: Amend r326665 to print out the `used` attribute subjects in a different order. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/test/Sema/att

Re: r326665 - Create a subject list for the `used` attribute rather than use custom checking logic.

Good suggestion -- I've switched the order in r326676. ~Aaron On Sat, Mar 3, 2018 at 6:16 PM, Nico Weber wrote: > Is it easy to mention variables first in the diag? That's probably the most > common subject for this attribute. (If it's not easy, nevermind -- > definitely a polish thing.) > > On

r326675 - Replace the custom handling for several attributes; NFC.

Author: aaronballman Date: Sun Mar 4 07:32:01 2018 New Revision: 326675 URL: http://llvm.org/viewvc/llvm-project?rev=326675&view=rev Log: Replace the custom handling for several attributes; NFC. These attributes were only customized because of the need to check for attribute mutual exclusion, b

[PATCH] D44075: [analyzer] CStringChecker.cpp: Remove the duplicated check about null dereference on dest-buffer or src-buffer.

MTC created this revision. MTC added reviewers: dcoughlin, NoQ, xazax.hun, cfe-commits. Herald added subscribers: a.sidorin, rnkovacs, szepet. Herald added a reviewer: george.karpenkov. `CheckBufferAccess()` calls `CheckNonNull()`, so there are some calls to `CheckNonNull()` that are useless. R