GorNishanov updated this revision to Diff 140903.
GorNishanov added a comment.
incorporated review feedback
https://reviews.llvm.org/D45121
Files:
include/experimental/coroutine
GorNishanov added a comment.
In https://reviews.llvm.org/D45121#1056408, @lewissbaker wrote:
> The `coroutine_handle` type does not have a
> `from_address()` or a `from_promise()` static functions in the same way that
> the `coroutine_handle` implementation does.
> Is this intentional or an
Author: ericwf
Date: Tue Apr 3 21:48:26 2018
New Revision: 329149
URL: http://llvm.org/viewvc/llvm-project?rev=329149=rev
Log:
Fix undefined macro issue in locale tests; Try 2
Modified:
Author: ericwf
Date: Tue Apr 3 21:39:38 2018
New Revision: 329148
URL: http://llvm.org/viewvc/llvm-project?rev=329148=rev
Log:
Fix undefined macro issue in locale tests
Modified:
Author: ericwf
Date: Tue Apr 3 21:33:09 2018
New Revision: 329145
URL: http://llvm.org/viewvc/llvm-project?rev=329145=rev
Log:
Update Clang version on Appveyor bots
Modified:
libcxx/trunk/appveyor-reqs-install.cmd
Modified: libcxx/trunk/appveyor-reqs-install.cmd
URL:
rjmccall added a comment.
The other changes I see here seem reasonable, but please do split the patch.
Comment at: include/clang/Basic/Cuda.h:61
+ GFX900,
+ GFX902,
LAST,
Does this actually have anything to do with HIP? You have a lot of changes in
this
EricWF added inline comments.
Comment at: include/experimental/coroutine:262
+struct noop_coroutine_promise {};
+
This whole thing should be wrapped in a `__has_builtin(__builtin_coro_noop)` so
the header still compiles with older clang versions.
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, LGTM with the reduced set of changes to the functionality.
Repository:
rC Clang
https://reviews.llvm.org/D44580
___
cfe-commits
Author: ericwf
Date: Tue Apr 3 21:21:54 2018
New Revision: 329144
URL: http://llvm.org/viewvc/llvm-project?rev=329144=rev
Log:
Touch up tests for new header; fix module.modulemap.
This patch does some housekeeping for the new header.
It adds it to the module.modulemap, and the
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay. LGTM. Thank you for putting the effort into maintaining both rules
simultaneously.
https://reviews.llvm.org/D45176
___
cfe-commits
Author: ericwf
Date: Tue Apr 3 21:00:14 2018
New Revision: 329143
URL: http://llvm.org/viewvc/llvm-project?rev=329143=rev
Log:
Fix locale test data for GLIBC 2.27 and newer.
GLIBC 2.27 changed the locale data for fr_FR and ru_RU. In particular
they change the decimal and thousands separators
faisalv added a comment.
Thanks for working on this fairly embarrassing bug (let's fix this before the
week is over :)
Comment at: clang/lib/Sema/SemaDecl.cpp:12886
if (!IsInstantiation && FD && FD->isConstexpr() && !FD->isInvalidDecl() &&
+
smeenai planned changes to this revision.
smeenai added a comment.
This doesn't pass all tests right now, and I'll also need to change the test in
accordance with the review comments.
Repository:
rC Clang
https://reviews.llvm.org/D44619
___
smeenai added a comment.
Finally got a chance to dig into some of the failures this patch is causing.
Here's an example crasher (run with `clang -cc1 -triple i686-windows
-emit-llvm`):
struct Q {
Q(int);
~Q();
};
struct Z {};
struct A {
A(Q);
};
struct B : Z, A {
On 3 April 2018 at 13:07, Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Apr 1, 2018, at 6:00 PM, Richard Smith wrote:
>
> On 28 March 2018 at 14:13, Akira Hatanaka via cfe-commits lists.llvm.org> wrote:
>
>> Author: ahatanak
rsmith updated this revision to Diff 140897.
rsmith marked an inline comment as done.
https://reviews.llvm.org/D45176
Files:
AST/ASTImporter.cpp
AST/DeclCXX.cpp
AST/RecordLayoutBuilder.cpp
CXX/drs/dr14xx.cpp
CXX/drs/dr16xx.cpp
CXX/drs/dr18xx.cpp
CXX/drs/dr21xx.cpp
rsmith marked an inline comment as done.
rsmith added inline comments.
Comment at: AST/DeclCXX.cpp:1130
data().IsStandardLayout = false;
+ data().IsCXX11StandardLayout = false;
+}
rjmccall wrote:
> `IsCXX11StandardLayout` should be
rsmith updated this revision to Diff 140896.
https://reviews.llvm.org/D45176
Files:
AST/ASTImporter.cpp
AST/DeclCXX.cpp
AST/RecordLayoutBuilder.cpp
CXX/drs/dr14xx.cpp
CXX/drs/dr16xx.cpp
CXX/drs/dr18xx.cpp
CXX/drs/dr21xx.cpp
CXX/drs/dr22xx.cpp
Layout/watchos-standard-layout.cpp
Dor1s added a comment.
Friendly ping. We'll probably land it tomorrow anyway, as it blocks another fix
needed for llvm-cov, but having another pair of eyes to look at this would be
still helpful :)
Repository:
rC Clang
https://reviews.llvm.org/D45178
NoQ added inline comments.
Comment at: test/Analysis/unions.cpp:82
uu = vv;
-// FIXME: Should be true.
-clang_analyzer_eval(uu.i == 5); // expected-warning{{UNKNOWN}}
+clang_analyzer_eval(uu.i == 5); // expected-warning{{TRUE}}
}
This test
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
(1) We weren't invalidating our unions correctly. The previous behavior in
`invalidateRegionsWorker::VisitCluster()` was to //direct//-bind
Author: arphaman
Date: Tue Apr 3 19:11:20 2018
New Revision: 329141
URL: http://llvm.org/viewvc/llvm-project?rev=329141=rev
Log:
Split test/Driver/darwin-sdkroot.c into two tests
The test additions in r329110 are Darwin-specific, as they rely
on a code path that is reachabled when driver is
efriedma created this revision.
efriedma added reviewers: compnerd, SjoerdMeijer, fhahn.
Herald added subscribers: kristof.beyls, javed.absar, mehdi_amini.
Currently, the interaction between the triple, the CPU, and the supported
features is a mess: the driver edits the triple to indicate the
lewissbaker accepted this revision.
lewissbaker added a comment.
This revision is now accepted and ready to land.
The `coroutine_handle` type does not have a
`from_address()` or a `from_promise()` static functions in the same way that
the `coroutine_handle` implementation does.
Is this
pcc created this revision.
pcc added reviewers: vlad.tsyrklevich, eugenis, kcc, t.p.northover, olista01.
Herald added subscribers: hiraditya, kristof.beyls, javed.absar, rengolin.
The implementation of shadow call stack on aarch64 is quite different to
the implementation on x86_64. Instead of
EricWF added a comment.
Herald added a subscriber: christof.
I spoke to STL on the MSVC team a while ago, and he stated that if we produced
a paper describing why we need `#include_next` and the rational behind it, and
they would pass that on to the front-end team. They didn't guarantee that
EricWF added a comment.
Have you verified that we're not losing test coverage here? That is, are you
sure we still have tests for the rvalue overloads in other test files?
Comment at:
libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp:41
+const VT v3(3);
EricWF added a comment.
Ping. I would like to get a way for libc++ to detect this case before the next
release.
Repository:
rC Clang
https://reviews.llvm.org/D45015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
Ping.
https://reviews.llvm.org/D40218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
In https://reviews.llvm.org/D44883#1054326, @thakis wrote:
> In https://reviews.llvm.org/D44883#1048751, @dblaikie wrote:
>
> > Historically Clang's policy on warnings was, I think, much more
> > conservative than it seems to be today. There was a strong desire not
mgrang added a comment.
@asb Should we keep frame pointer enabled for debug builds? Internally, for
ARM/Thumb we leave frame pointer ON if debug is enabled.
Repository:
rC Clang
https://reviews.llvm.org/D45237
___
cfe-commits mailing list
On Tue, Apr 3, 2018 at 4:01 PM Alex L via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 3 April 2018 at 14:30, Chandler Carruth wrote:
>
>> On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: arphaman
>>>
mgrang created this revision.
mgrang added a reviewer: asb.
Herald added subscribers: shiva0217, kito-cheng.
The logic was broken for Linux triples as it returns true in the switch for
Triple.isOSLinux().
Repository:
rC Clang
https://reviews.llvm.org/D45237
Files:
manojgupta added a reviewer: chandlerc.
manojgupta added a comment.
Chandler, I recall that you are also a Gentoo user so please take a look.
Repository:
rC Clang
https://reviews.llvm.org/D45233
___
cfe-commits mailing list
On 3 April 2018 at 14:30, Chandler Carruth wrote:
> On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: arphaman
>> Date: Tue Apr 3 13:50:05 2018
>> New Revision: 329110
>>
>> URL:
manojgupta added a comment.
Michał, will appreciate if you can test this on your (multiple?) Gentoo
configurations.
Will work on updating the testcases after that.
To test it locally, I used the following :
$ cat test.cpp
#include
#include
int main() {
std::cout << " Hello,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329128: [ObjC] Use the name specified by objc_runtime_name
instead of the class (authored by ahatanak, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: ahatanak
Date: Tue Apr 3 15:50:16 2018
New Revision: 329128
URL: http://llvm.org/viewvc/llvm-project?rev=329128=rev
Log:
[ObjC] Use the name specified by objc_runtime_name instead of the class
identifier.
This patch fixes a few places in CGObjCMac.cpp where the class
identifier was used
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Perhaps we could add a comment for the first such occurrence of the cast
in each file explaining it.
Repository:
rCXX libc++
https://reviews.llvm.org/D45128
rinon created this revision.
rinon added reviewers: hans, rnk.
Herald added subscribers: cfe-commits, mgorny.
If LLVM_ENABLE_LIBXML2=OFF, we should not attempt to link clang against
libxml2.
Repository:
rC Clang
https://reviews.llvm.org/D45234
Files:
CMakeLists.txt
Index: CMakeLists.txt
manojgupta created this revision.
manojgupta added a reviewer: mgorny.
1. Find GCC's LDPATH from the actual GCC config file.
2. Make library detection to take into account crossdev installed
cross-compiler gcc libraries even when a sysroot is specified.
3. Avoid picking libraries from a similar
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329127: [CUDA] Check initializers of instantiated template
variables. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45231?vs=140867=140871#toc
Repository:
rC
nemanjai added a comment.
In https://reviews.llvm.org/D44921#1050299, @joerg wrote:
> GCC supports -mbss-plt to get the legacy behavior. Not sure if anyone
> actually uses it though.
@spetrovic Is this something we want to implement?
https://reviews.llvm.org/D44921
Author: tra
Date: Tue Apr 3 15:41:06 2018
New Revision: 329127
URL: http://llvm.org/viewvc/llvm-project?rev=329127=rev
Log:
[CUDA] Check initializers of instantiated template variables.
We were already performing checks on non-template variables,
but the checks on templated ones were missing.
mzeren-vmw added a comment.
In https://reviews.llvm.org/D42034#1051965, @mzeren-vmw wrote:
> Update other verifyFormat implementations.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D42034
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329122: Add the -fsanitize=shadow-call-stack flag (authored
by vlad.tsyrklevich, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44801
Files:
Author: vlad.tsyrklevich
Date: Tue Apr 3 15:33:53 2018
New Revision: 329122
URL: http://llvm.org/viewvc/llvm-project?rev=329122=rev
Log:
Add the -fsanitize=shadow-call-stack flag
Summary:
Add support for the -fsanitize=shadow-call-stack flag which causes clang
to add ShadowCallStack attribute
vlad.tsyrklevich updated this revision to Diff 140868.
vlad.tsyrklevich added a comment.
- Small test, doc updates
Repository:
rC Clang
https://reviews.llvm.org/D44801
Files:
docs/ShadowCallStack.rst
docs/index.rst
include/clang/Basic/Sanitizers.def
lib/CodeGen/CGDeclCXX.cpp
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
We were already performing checks on non-template variables,
but the checks on templated ones were missing.
https://reviews.llvm.org/D45231
Files:
clang/include/clang/Sema/Sema.h
rjmccall added a comment.
Yes, if we think that the committee is likely to include questionable functions
on the `[[nodiscard]]` list which we don't want to warn about pre-C++17, then
it makes sense to have two internal macros, one for functions like `std::move`
that should be unconditionally
EricWF added a comment.
I'm also in favor of making this opt-out instead of opt-in, except for a
handful of functions like `unique_ptr::release` which may yield false
positives. However, for functions where discarding the return value is always a
bug, I don't see an issue in libc++ emitting a
rjmccall added inline comments.
Comment at: AST/DeclCXX.cpp:1130
data().IsStandardLayout = false;
+ data().IsCXX11StandardLayout = false;
+}
`IsCXX11StandardLayout` should be based on `FieldRec->isCXX11StandardLayout()`,
I assume.
lebedev.ri added a comment.
In https://reviews.llvm.org/D45179#1056183, @rjmccall wrote:
> Is Marshall arguing that the standard doesn't allow compilers to warn about
> failing to use these function results prior to C++17?
No. He was simply saying that people are opposed to having nodiscard
Author: eugenezelenko
Date: Tue Apr 3 14:31:50 2018
New Revision: 329115
URL: http://llvm.org/viewvc/llvm-project?rev=329115=rev
Log:
[StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use
warnings; other minor fixes (NFC).
Modified:
rjmccall added a comment.
I think the appropriate place to do this is in IsStandardConversion,
immediately after the call to ResolveAddressOfOverloadedFunction. You might
want to add a general utility for getting the type-of-reference of a function
decl.
https://reviews.llvm.org/D45223
craig.topper added inline comments.
Comment at: test/Preprocessor/predefined-arch-macros.c:1164
+// CHECK_ICX_M32: #define __corei7 1
+// CHECK_ICX_M32: #define __corei7__ 1
+// CHECK_ICX_M32: #define __i386 1
The ICX_M32 and ICX_M64 should be contiguous in the
rjmccall added a comment.
Is Marshall arguing that the standard doesn't allow compilers to warn about
failing to use these function results prior to C++17? Because I don't think
that's true; warnings are thoroughly non-normative.
If libc++ wants to allow its users to opt out of these warnings
On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Tue Apr 3 13:50:05 2018
> New Revision: 329110
>
> URL: http://llvm.org/viewvc/llvm-project?rev=329110=rev
> Log:
> [driver][darwin] Do not infer -simulator environment for
See my reply to the original commit, but I think this is the wrong fix.
On Tue, Apr 3, 2018 at 2:13 PM Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Tue Apr 3 14:10:26 2018
> New Revision: 329113
>
> URL:
Author: arphaman
Date: Tue Apr 3 14:10:26 2018
New Revision: 329113
URL: http://llvm.org/viewvc/llvm-project?rev=329113=rev
Log:
Add REQUIRES: darwin-system to test/Driver/darwin-sdkroot.c
The test from r329110 is for Darwin only
Modified:
cfe/trunk/test/Driver/darwin-sdkroot.c
Modified:
mstorsjo added a comment.
In https://reviews.llvm.org/D45152#1056134, @rnk wrote:
> In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote:
>
> > In https://reviews.llvm.org/D45152#1055871, @rnk wrote:
> >
> > > Seems reasonable, looks good.
> >
> >
> > Any opinion on the wording of the
Author: arphaman
Date: Tue Apr 3 13:50:05 2018
New Revision: 329110
URL: http://llvm.org/viewvc/llvm-project?rev=329110=rev
Log:
[driver][darwin] Do not infer -simulator environment for non-simulator SDKs
rdar://36369832
Modified:
cfe/trunk/lib/Driver/ToolChains/Darwin.cpp
yunlian updated this revision to Diff 140857.
https://reviews.llvm.org/D44788
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
rnk added a comment.
In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote:
> In https://reviews.llvm.org/D45152#1055871, @rnk wrote:
>
> > Seems reasonable, looks good.
>
>
> Any opinion on the wording of the option name?
Maybe what we're trying to do is find the sysroot relative to
mstorsjo added a comment.
In https://reviews.llvm.org/D45152#1055871, @rnk wrote:
> Seems reasonable, looks good.
Any opinion on the wording of the option name?
Repository:
rC Clang
https://reviews.llvm.org/D45152
___
cfe-commits mailing list
sammccall added a comment.
In https://reviews.llvm.org/D44720#1055997, @MaskRay wrote:
> Glad you took another look. I don't want to yield, let's find another
> reviewer :)
OK - the people with the most context on this particular code are ilya-biryukov
and klimek (but klimek is out this
lebedev.ri added a comment.
In https://reviews.llvm.org/D45179#1056108, @Quuxplusone wrote:
> > Opt-in is an enhancement. Of course, it would be nice to always default it
> > to on, but as it was disscussed with @mclow.lists, this is simply not going
> > to happen. This is the best we'll get.
Quuxplusone added a comment.
>> If we must have an opt-in/out mechanism (which I don't believe we do)
>
> Yes, we do. Opt-out is pre-existing, and removing it would be an
> [unacceptable] regression.
Ah, I see now that you weren't the originator of
`_LIBCPP_DISABLE_NODISCARD_AFTER_CXX17`;
lebedev.ri added a comment.
In https://reviews.llvm.org/D45163#1056044, @rjmccall wrote:
> It seems reasonable to ask libc++ to use
> `__attribute__((warn_unused_result))` if `[[nodiscard]]` is unavailable.
https://reviews.llvm.org/D45179 should hopefully add an **opt-in** define to
allow
lebedev.ri added inline comments.
Comment at: test/libcxx/diagnostics/force_nodiscard.fail.cpp:15
+// MODULES_DEFINES: _LIBCPP_FORCE_NODISCARD
+#define _LIBCPP_FORCE_NODISCARD
+#include <__config>
Quuxplusone wrote:
> What is the purpose of
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:951
TARGET_BUILTIN(__builtin_ia32_rndscalepd_mask, "V8dV8dIiV8dUcIi", "",
"avx512f")
+TARGET_BUILTIN(__builtin_ia32_floorps_mask, "V16fV16fV16fUs", "", "avx512f")
Quuxplusone added a comment.
In https://reviews.llvm.org/D45163#1055957, @lebedev.ri wrote:
> In https://reviews.llvm.org/D45163#1055856, @rjmccall wrote:
>
> > Well, we should feel welcome to submit patches to the C++ library
> > implementations, I think. I can understand why Marshall is
Quuxplusone added inline comments.
Comment at: test/libcxx/diagnostics/force_nodiscard.fail.cpp:15
+// MODULES_DEFINES: _LIBCPP_FORCE_NODISCARD
+#define _LIBCPP_FORCE_NODISCARD
+#include <__config>
What is the purpose of `_LIBCPP_FORCE_NODISCARD`?
On one of your
rjmccall added a comment.
Trust me, I understand that this is an important function, but a lot of
functions are important, and we're not going to hardcode knowledge about all of
them in the compiler.
It seems reasonable to ask libc++ to use `__attribute__((warn_unused_result))`
if
yaxunl created this revision.
yaxunl added reviewers: rjmccall, tra.
The following test causes overloading resolution failure in clang due to
missing kernel calling convention in the function pointer type.
template
__global__ void EmptyKernel(void) {}
struct Dummy {
/// Type
MaskRay added a comment.
Glad you took another look. I don't want to yield, let's find another reviewer
:)
Comment at: clangd/FuzzyMatch.cpp:230
void FuzzyMatcher::buildGraph() {
+ Scores[0][0][Miss] = Scores[0][0][Match] = {0, Miss};
for (int W = 0; W < WordN; ++W) {
ahatanak abandoned this revision.
ahatanak added a comment.
This appears to have been fixed.
https://reviews.llvm.org/D25001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
Thanks for your work on this patch!
I think there a several useful improvements here, which I'd love to see landed.
Particularly the logic around matches that end early is much better.
There are also places that change existing design decisions in ways that don't
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329102: [analyzer] Fix diagnostics in callees of interesting
callees. (authored by dergachev, committed by ).
Herald
Author: dergachev
Date: Tue Apr 3 11:52:30 2018
New Revision: 329102
URL: http://llvm.org/viewvc/llvm-project?rev=329102=rev
Log:
[analyzer] Fix diagnostics in callees of interesting callees.
removeUnneededCalls() is responsible for removing path diagnostic pieces within
functions that don't
lebedev.ri added a comment.
In https://reviews.llvm.org/D45163#1055856, @rjmccall wrote:
> Well, we should feel welcome to submit patches to the C++ library
> implementations, I think. I can understand why Marshall is waiting to just
> do this until he gets a comprehensive committee paper,
tra added a comment.
In https://reviews.llvm.org/D44747#1055894, @yaxunl wrote:
> Let's revert it for now. I will create a review after fixing it and commit it
> again with the fix.
>
> Thanks.
>
> Sam
reverted in r329099.
Repository:
rL LLVM
https://reviews.llvm.org/D44747
Author: tra
Date: Tue Apr 3 11:29:31 2018
New Revision: 329099
URL: http://llvm.org/viewvc/llvm-project?rev=329099=rev
Log:
Revert "Set calling convention for CUDA kernel"
This reverts r328795 which introduced an issue with referencing __global__
function templates. More details in the original
rsmith marked an inline comment as done.
rsmith added inline comments.
Comment at: ReleaseNotes.rst:68-72
+- Clang implements the proposed resolution of LWG issue 2358, along with the
+ `corresponding change to the Itanium C++ ABI
+
devnexen added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D44878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Apr 3 11:28:13 2018
New Revision: 329098
URL: http://llvm.org/viewvc/llvm-project?rev=329098=rev
Log:
Use Clang when referring to the project and clang when referring to the binary.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
Author: dblaikie
Date: Tue Apr 3 11:22:14 2018
New Revision: 329097
URL: http://llvm.org/viewvc/llvm-project?rev=329097=rev
Log:
Restrict a test using named file descriptors to using the system shell
Modified:
cfe/trunk/test/Misc/dev-fd-fs.c
Modified: cfe/trunk/test/Misc/dev-fd-fs.c
URL:
tejohnson created this revision.
tejohnson added a reviewer: pcc.
Herald added subscribers: eraman, inglorion, mehdi_amini.
The clang driver option -save-temps was not passed to the LTO config,
so when invoking the ThinLTO backends via clang during distributed
builds there was no way to get LTO
Let's revert it for now. I will create a review after fixing it and commit it
again with the fix.
Thanks.
Sam
-Original Message-
From: Artem Belevich via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: Tuesday, April 03, 2018 2:09 PM
To: Liu, Yaxun (Sam) ;
tra added a comment.
In https://reviews.llvm.org/D44747#1055877, @yaxunl wrote:
> I will try fixing that.
>
> The CUDA kernel calling convention should be dropped in all DRE's since it is
> invisible to the user.
>
> Sam
Apparently it's not always the case.
Here's a bit more elaborate example
khuttun abandoned this revision.
khuttun added a comment.
Figured out a better way to do this by using
`FunctionDecl::getInstantiatedFromMemberFunction`
Repository:
rC Clang
https://reviews.llvm.org/D45161
___
cfe-commits mailing list
ormris added a comment.
No such luck...
Patch:
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
(revision 329079)
+++
I will try fixing that.
The CUDA kernel calling convention should be dropped in all DRE's since it is
invisible to the user.
Sam
-Original Message-
From: Artem Belevich via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: Tuesday, April 03, 2018 1:51 PM
To: Liu, Yaxun (Sam)
ormris added a comment.
About to test with CPlusPlus14 enabled
Here's the output from those two commands.
(lldb) frame var -g crazy
error: no variable named 'crazy' found in this frame
(lldb) frame var -g crazy
error: no variable named 'crazy' found in this frame
(lldb)
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Seems reasonable, looks good.
Repository:
rC Clang
https://reviews.llvm.org/D45152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaxunl updated this revision to Diff 140827.
yaxunl retitled this revision from "[WIP][HIP] Let CUDA toolchain support HIP
language mode" to "[HIP] Let CUDA toolchain support HIP language mode".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Fixed typo which causes lit test
tra added inline comments.
Comment at: lib/Sema/SemaType.cpp:3319-3330
+ // Attribute AT_CUDAGlobal affects the calling convention for AMDGPU targets.
+ // This is the simplest place to infer calling convention for CUDA kernels.
+ if (S.getLangOpts().CUDA &&
rjmccall added a comment.
Well, we should feel welcome to submit patches to the C++ library
implementations, I think. I can understand why Marshall is waiting to just do
this until he gets a comprehensive committee paper, but he might consider
taking a patch in the meantime. But I'm not sure
jingham added a comment.
Apparently this makes a global variable, so "frame var" wouldn't show it by
default. What does "frame var -g" show?
We would also need to get:
(lldb) frame var -g crazy
or something like it to work. "frame var" has its own parser to support "->"
and ".". That
tra added inline comments.
Comment at: lib/Sema/SemaType.cpp:3319-3330
+ // Attribute AT_CUDAGlobal affects the calling convention for AMDGPU targets.
+ // This is the simplest place to infer calling convention for CUDA kernels.
+ if (S.getLangOpts().CUDA &&
1 - 100 of 153 matches
Mail list logo