This revision was automatically updated to reflect the committed changes.
Closed by commit rC329519: [Sema] Fix PR35832 - Ambiguity accessing anonymous
struct/union with multiple… (authored by EricWF, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45411
Files:
Author: ericwf
Date: Sat Apr 7 22:50:01 2018
New Revision: 329519
URL: http://llvm.org/viewvc/llvm-project?rev=329519=rev
Log:
[Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple
bases.
Summary:
Currently clang doesn't do qualified lookup when building indirect field
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329518: [Sema] Remove dead code in
BuildAnonymousStructUnionMemberReference. NFCI (authored by EricWF, committed
by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329517: [Sema] Fix PR22637 - IndirectFieldDecls
discard qualifiers during template… (authored by EricWF, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45412?vs=141520=141523#toc
Author: ericwf
Date: Sat Apr 7 22:12:55 2018
New Revision: 329518
URL: http://llvm.org/viewvc/llvm-project?rev=329518=rev
Log:
[Sema] Remove dead code in BuildAnonymousStructUnionMemberReference. NFCI
Summary:
This patch cleans up a bunch of dead or unused code in
Author: ericwf
Date: Sat Apr 7 22:11:59 2018
New Revision: 329517
URL: http://llvm.org/viewvc/llvm-project?rev=329517=rev
Log:
[Sema] Fix PR22637 - IndirectFieldDecl's discard qualifiers during template
instantiation.
Summary:
Currently Clang fails to propagate qualifiers from the
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I think there was a point when we weren't always creating CXXThisExprs eagerly
for these accesses. Now that we are, yeah, this should be dead.
Repository:
rC Clang
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D45412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Well, that is a really silly bug. Fix LGTM.
https://reviews.llvm.org/D45411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF updated this revision to Diff 141522.
EricWF added a comment.
- Upload with correct test.
https://reviews.llvm.org/D45411
Files:
lib/Sema/SemaExprMember.cpp
test/SemaCXX/PR35832.cpp
Index: test/SemaCXX/PR35832.cpp
===
EricWF created this revision.
EricWF added reviewers: rsmith, lebedev.ri, aaron.ballman, bkramer, rjmccall.
Currently Clang fails to propagate qualifiers from the `CXXThisExpr` to the
rebuilt `FieldDecl` for IndirectFieldDecls. For example:
template struct Foo {
struct { int x; };
EricWF created this revision.
EricWF added reviewers: rsmith, aaron.ballman, rjmccall.
EricWF added a dependency: D45410: [Sema] Remove dead code in
BuildAnonymousStructUnionMemberReference. NFCI.
Currently clang doesn't do qualified lookup when building indirect field decl
references. This
EricWF created this revision.
EricWF added reviewers: rsmith, aaron.ballman, majnemer, rjmccall.
This patch cleans up a bunch of dead or unused code in
BuildAnonymousStructUnionMemberReference.
The dead code was a branch that built a new CXXThisExpr when we weren't given a
base object
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D45392#1060845, @Wizard wrote:
> In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote:
>
> > If this is Apple guideline, check name should reflect this. I think will be
> > good idea to have general check for Apple naming
Wizard updated this revision to Diff 141515.
Wizard edited the summary of this revision.
Wizard added a comment.
resolve comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/IvarDeclarationCheck.cpp
Wizard marked 4 inline comments as done.
Wizard added a comment.
In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote:
> If this is Apple guideline, check name should reflect this. I think will be
> good idea to have general check for Apple naming conventions instead of
> separate
DHowett-MSFT added a comment.
It seems more fragile to check the contents of the protocol rather than the
invariant we care most about (its size).
I'm willing to do that, and am updating the patch accordingly, but I don't want
to commit to a more fragile test than is necessary.
Illustratively,
NoQ added a comment.
The output looks reasonable to me, but we'll need to see if other consumers of
the plist output (IDEs that supports the analyzer, such as Xcode) will be able
to accept the modified output (at least, will be able to ignore it). I'll have
a look.
Repository:
rC Clang
dim updated this revision to Diff 141513.
dim added a comment.
- Use "values" instead of "options"
- Remove deprecated standard values
Repository:
rC Clang
https://reviews.llvm.org/D45406
Files:
docs/CommandGuide/clang.rst
Index: docs/CommandGuide/clang.rst
malcolm.parsons added a comment.
Please add to release notes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329515: [libclang] Add clang_File_tryGetRealPathName
(authored by MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
mgorny created this revision.
mgorny added reviewers: simark, ilya-biryukov.
Herald added a subscriber: ioeric.
Explicitly include and build lib/Testing/Support from LLVM sources when
doing a stand-alone build. This is necessary since clangd tests started
to depend on LLVMTestingSupport library
Szelethus created this revision.
Szelethus added reviewers: dergachev.a, xazax.hun.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, whisperity.
Herald added a reviewer: george.karpenkov.
Added notes to `-analyzer-output=plist`.
Repository:
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D45311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rjmccall
Date: Sat Apr 7 13:16:47 2018
New Revision: 329513
URL: http://llvm.org/viewvc/llvm-project?rev=329513=rev
Log:
Generalize the swiftcall API since being passed indirectly isn't
C++-specific anymore.
Modified:
cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h
rsmith added a comment.
In https://reviews.llvm.org/D45406#1060773, @dim wrote:
> In https://reviews.llvm.org/D45406#1060768, @mgorny wrote:
>
> > To be honest, I find those '(deprecated)' confusing — the user may
> > mistakenly assume that it's about all values rather than the alias.
>
>
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329512: [Driver] Update GCC libraries detection logic for
Gentoo. (authored by manojgupta, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45233?vs=141295=141501#toc
Repository:
Author: manojgupta
Date: Sat Apr 7 12:59:58 2018
New Revision: 329512
URL: http://llvm.org/viewvc/llvm-project?rev=329512=rev
Log:
[Driver] Update GCC libraries detection logic for Gentoo.
Summary:
1. Find GCC's LDPATH from the actual GCC config file.
2. Avoid picking libraries from a similar
Hi Alex,
The two tests you added in this commit seem to be failing because of a crash on
one of the Windows bots. Can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/8912
FAIL: Clang :: Index/create-libclang-parsing-reproducer.c (7891 of 37034)
dim added a comment.
In https://reviews.llvm.org/D45406#1060768, @mgorny wrote:
> To be honest, I find those '(deprecated)' confusing — the user may mistakenly
> assume that it's about all values rather than the alias.
Sure, what would you suggest as an alternative? Not listing them, listing
mgorny added a comment.
To be honest, I find those '(deprecated)' confusing — the user may mistakenly
assume that it's about all values rather than the alias.
Comment at: docs/CommandGuide/clang.rst:105
+
+ Supported options for the C language are:
+
dim created this revision.
dim added reviewers: rsmith, dexonsmith, sylvestre.ledru, mgorny.
Herald added subscribers: krytarowski, fhahn.
After a remark on a FreeBSD mailing list that the clang man page did
not have any list of possible values for the `-std=` flag, I have now
attempted to
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
Works fine, thanks a lot! Note that I haven't tested crossdev or anything
special, just regular multilib.
Repository:
rC Clang
https://reviews.llvm.org/D45233
MaskRay added a comment.
Done.
ninja -C ~/Dev/llvm/debug unittests/libclang/libclangTests
~/Dev/llvm/debug/tools/clang/unittests/libclang/libclangTests
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits mailing list
MaskRay updated this revision to Diff 141496.
MaskRay added a comment.
Add unittests/libclang/LibclangTest.cpp test
Repository:
rC Clang
https://reviews.llvm.org/D42893
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
MaskRay updated this revision to Diff 141492.
MaskRay added a comment.
Rebase
Repository:
rC Clang
https://reviews.llvm.org/D42893
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang.exports
theraven added a comment.
Isn't it better to test for the correct structure existing in the IR?
Repository:
rC Clang
https://reviews.llvm.org/D45305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall closed this revision.
rjmccall added a comment.
Committed as r329508.
Repository:
rC Clang
https://reviews.llvm.org/D44580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rjmccall
Date: Sat Apr 7 10:42:06 2018
New Revision: 329508
URL: http://llvm.org/viewvc/llvm-project?rev=329508=rev
Log:
Allow equality comparisons between block pointers and
block-pointer-compatible ObjC object pointer types.
Patch by Dustin Howett!
Added:
rjmccall accepted this revision.
rjmccall added a comment.
Hmm. Alright, I guess.
Repository:
rC Clang
https://reviews.llvm.org/D45305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zinovy.nis created this revision.
zinovy.nis added reviewers: angelgarcia, malcolm.parsons, alexfh.
zinovy.nis added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
The threshold option is 'MinTypeNameLength' with default value '0' which means
'replace any
jbcoe added a comment.
Tests for libclang are in clang/unittests/libclang/LibclangTest.cpp
Given the surgical nature of this change I hope it will be quick to add a test.
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits
Author: zinovy.nis
Date: Sat Apr 7 04:22:01 2018
New Revision: 329495
URL: http://llvm.org/viewvc/llvm-project?rev=329495=rev
Log:
[clang-tidy] Fix compilation for MSVS@PSP4 for ParentVirtualCallCheck.cpp
There's an error for PSP4 platform only:
C:\Program Files (x86)\Microsoft Visual Studio
cpplearner added inline comments.
Comment at: test/CXX/dcl.dcl/dcl.attr/dcl.attr.unused/p2.cpp:5
int I [[maybe_unused]];
- static int SI [[maybe_unused]]; // expected-warning {{'maybe_unused'
attribute only applies to variables, functions, methods, types, enumerations,
mgorny added a comment.
I'm sorry, I see the problem now — the diff generated by Phabricator does not
include the empty files x_x (seriously, this thing keeps surprising me in how
broken it could be). I'm going to try again with correct file set tonight or
tomorrow. If you could send the
lebedev.ri added inline comments.
Comment at: test/CXX/dcl.dcl/dcl.attr/dcl.attr.unused/p2.cpp:5
int I [[maybe_unused]];
- static int SI [[maybe_unused]]; // expected-warning {{'maybe_unused'
attribute only applies to variables, functions, methods, types, enumerations,
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329493: [Sema] Extend -Wself-assign and -Wself-assign-field
to warn on overloaded self… (authored by lebedevri, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44883
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329493: [Sema] Extend -Wself-assign and -Wself-assign-field
to warn on overloaded self… (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
cpplearner created this revision.
cpplearner added reviewers: aaron.ballman, rsmith.
Herald added a subscriber: cfe-commits.
IIUC a static data member is a variable, so [[maybe_unused]] should be allowed
to apply to a static data member.
Repository:
rC Clang
https://reviews.llvm.org/D45403
Author: lebedevri
Date: Sat Apr 7 03:39:21 2018
New Revision: 329493
URL: http://llvm.org/viewvc/llvm-project?rev=329493=rev
Log:
[Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded
self-assignment (classes)
Summary:
This has just bit me, so i though it would be nice to
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX329490: [libcxx][test] Silence -Wself-assign diagnostics
(authored by lebedevri, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D45128
Files:
Author: lebedevri
Date: Sat Apr 7 03:36:03 2018
New Revision: 329490
URL: http://llvm.org/viewvc/llvm-project?rev=329490=rev
Log:
[libcxx][test] Silence -Wself-assign diagnostics
Summary:
D44883 extends -Wself-assign to also work on C++ classes.
These new warnings pop up in the test suite, so
Hahnfeld added a comment.
Can this revision be split further? The summary mentions many things that might
make up multiple independent changes...
Comment at: lib/Driver/ToolChains/Cuda.cpp:263
+// HIP needs c++11.
+CC1Args.push_back("-std=c++11");
+// Skip CUDA
lebedev.ri added a comment.
Test?
https://reviews.llvm.org/D45401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe added a comment.
I’ll see if I can find a suitable location for a test.
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
incertia updated this revision to Diff 141477.
incertia added a comment.
Pulled the check outside of the case statement.
https://reviews.llvm.org/D45401
Files:
lib/Sema/SemaExpr.cpp
lib/Sema/SemaExprCXX.cpp
Index: lib/Sema/SemaExprCXX.cpp
incertia created this revision.
incertia added reviewers: rjmccall, rsmith.
incertia added a project: clang.
Herald added a subscriber: cfe-commits.
To my understanding, the contents of a condition will always be implicitly
casted to an rvalue before evaluation. Thus, moving the check to
57 matches
Mail list logo