[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. Thanks ! anybody who can land it for me I ll be grateful. https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL329671: [ExprConstant] Use an AST node and a version number as a key to create (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329671 - [ExprConstant] Use an AST node and a version number as a key to create

Author: ahatanak Date: Mon Apr 9 22:15:01 2018 New Revision: 329671 URL: http://llvm.org/viewvc/llvm-project?rev=329671=rev Log: [ExprConstant] Use an AST node and a version number as a key to create an APValue and retrieve it from map Temporaries. The version number is needed when a single AST

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak updated this revision to Diff 141788. ahatanak marked an inline comment as done. ahatanak set the repository for this revision to rC Clang. ahatanak added a comment. Use pair as the key. Repository: rC Clang https://reviews.llvm.org/D42776 Files: clang/include/clang/AST/APValue.h

[PATCH] D45016: [libcxx] [test] Avoid MSVC truncation warnings.

STL_MSFT added a comment. Ping? https://reviews.llvm.org/D45016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r329665 - [libcxx] [test] Use the correct type from strlen. Include correct header.

Author: bion Date: Mon Apr 9 20:04:07 2018 New Revision: 329665 URL: http://llvm.org/viewvc/llvm-project?rev=329665=rev Log: [libcxx] [test] Use the correct type from strlen. Include correct header. Modified:

[PATCH] D45449: [CUDA] Document recent changes

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Overall LGTM. We could use specific instructions for what exactly one needs to do in order to use relocatable device code in practice. Could be a separate patch. Repository: rC Clang

Re: r329652 - [AST] Attempt to fix buildbot warnings + appease MSVC; NFCI

Thanks! > On Apr 9, 2018, at 6:11 PM, George Burgess IV via cfe-commits > wrote: > > Author: gbiv > Date: Mon Apr 9 18:11:26 2018 > New Revision: 329652 > > URL: http://llvm.org/viewvc/llvm-project?rev=329652=rev > Log: > [AST] Attempt to fix buildbot warnings +

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. In addition to the currently proposed approach #if ... #error ... #endif // header content I also tried #if ... #error ... #else // header content #endif It allows to have fewer error messages but can be more surprising. It can look like the only

r329652 - [AST] Attempt to fix buildbot warnings + appease MSVC; NFCI

Author: gbiv Date: Mon Apr 9 18:11:26 2018 New Revision: 329652 URL: http://llvm.org/viewvc/llvm-project?rev=329652=rev Log: [AST] Attempt to fix buildbot warnings + appease MSVC; NFCI GCC 4.8.4 on a bot was warning about `ArgPassingKind` not fitting in `ArgPassingRestrictions`, which appears

[PATCH] D45470: Emit an error when mixing and

vsapsai created this revision. vsapsai added reviewers: rsmith, EricWF, mclow.lists. Herald added subscribers: christof, jkorous-apple. Atomics in C and C++ are incompatible at the moment and mixing the headers can result in confusing error messages. Emit an error explicitly telling about the

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a checker to the Fuchsia module to flag instances of attempting to log the system's numerical

[libclc] r329647 - hypot: Port from amd builtins

Author: jvesely Date: Mon Apr 9 17:11:58 2018 New Revision: 329647 URL: http://llvm.org/viewvc/llvm-project?rev=329647=rev Log: hypot: Port from amd builtins v2: Fix whitespace errors Use only subnormal path. Passes CTS on carrizo and turks. Signed-off-by: Jan Vesely

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv updated this revision to Diff 141768. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Address feedback https://reviews.llvm.org/D45059 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv added a comment. Thanks! I plan to commit this tomorrow, to give time for any last-minute comments. Thanks again to everyone for the review. :) https://reviews.llvm.org/D45059 ___ cfe-commits mailing list

LLVM buildmaster will restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

dblaikie added subscribers: lebedev.ri, dblaikie. dblaikie added a comment. FWIW - I had some thoughts on this a while back: https://reviews.llvm.org/D4313 Repository: rL LLVM https://reviews.llvm.org/D43779 ___ cfe-commits mailing list

Re: [PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

FWIW - I had some thoughts on this a while back: https://reviews.llvm.org/D4313 On Mon, Apr 9, 2018 at 4:54 AM Roman Lebedev via Phabricator via llvm-commits wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D43779#1061444, @alexfh wrote: > > > In

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 141762. paulsemel added a comment. Added a good test for the `int (*)()` function prototype, as we decided to accept it as a valid function for the dumper Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added inline comments. Comment at: test/Sema/builtin-dump-struct.c:8 + void *b; + int (*goodfunc)(const char *, ...); + int (*badfunc1)(const char *); aaron.ballman wrote: > paulsemel wrote: > > aaron.ballman wrote: > > > paulsemel wrote: > > > >

Re: r329580 - [Tooling] A CompilationDatabase wrapper that infers header commands.

Hello Sam, It looks like this commit added broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/8957/steps/test-check-all/logs/stdio Failing Tests (5): Clang-Unit :: Tooling/./ToolingTests.exe/InterpolateTest.Case Clang-Unit

Re: r329617 - [ObjC++] Never pass structs that transitively contain __weak fields in

Sorry for the breakage, I reverted the patch in r329627 and reapplied it with a fix in r329635. Let me know if the tests are still failing. > On Apr 9, 2018, at 3:47 PM, Galina Kistanova wrote: > > Hello Akira, > > This commit added broken tests to one of our builders: >

r329635 - [ObjC++] Never pass structs that transitively contain __weak fields in

Author: ahatanak Date: Mon Apr 9 15:48:22 2018 New Revision: 329635 URL: http://llvm.org/viewvc/llvm-project?rev=329635=rev Log: [ObjC++] Never pass structs that transitively contain __weak fields in registers. This patch fixes a bug in r328731 that caused structs transitively containing __weak

Re: r329617 - [ObjC++] Never pass structs that transitively contain __weak fields in

Hello Akira, This commit added broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/8964 Failing Tests (8): Clang :: CodeGenObjCXX/objc-struct-cxx-abi.mm Clang :: SemaObjCXX/attr-trivial-abi.mm . . . Please have a look? The

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141759. aheejin added a comment. - Add a test in which try-catches are nested within a catch - Rebase Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny created this revision. jdenny added reviewers: rsmith, hfinkel. jdenny added a dependency: D45463: [AST] Print correct tag decl for tag specifier. For example, given: struct T1 { struct T2 *p0; }; -ast-print produced: struct T1 { struct T2; struct T2 *p0; };

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added inline comments. Comment at: test/Sema/builtin-dump-struct.c:8 + void *b; + int (*goodfunc)(const char *, ...); + int (*badfunc1)(const char *); paulsemel wrote: > aaron.ballman wrote: > > paulsemel wrote: > > > aaron.ballman wrote: > > >

[PATCH] D45403: Make [[maybe_unused]] work with static data members

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:2054 - } - // If this is spelled as the standard C++17 attribute, but not in C++17, warn Quuxplusone wrote: > @aaron.ballman writes: > > I don't think we're currently diagnosing

r329630 - [AST] Fix some Clang-tidy modernize-use-auto warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Apr 9 15:14:10 2018 New Revision: 329630 URL: http://llvm.org/viewvc/llvm-project?rev=329630=rev Log: [AST] Fix some Clang-tidy modernize-use-auto warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/ASTStructuralEquivalence.h

[PATCH] D45455: [CFI] Disable CFI checks for __cxa_decrement_exception_refcount

This revision was automatically updated to reflect the committed changes. Closed by commit rL329629: [CFI] Disable CFI checks for __cxa_decrement_exception_refcount (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny created this revision. jdenny added reviewers: rsmith, nik, jbcoe, aaron.ballman, hfinkel. For example, given: void fn() { struct T *p0; struct T { int i; } *p1; } -ast-print produced: void fn() { struct T { int i; } *p0; struct T { int i; } *p1; } Compiling

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

Eugene.Zelenko added a comment. Will be good idea to add HICPP alias. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45455: [CFI] Disable CFI checks for __cxa_decrement_exception_refcount

This revision was automatically updated to reflect the committed changes. Closed by commit rCXXA329629: [CFI] Disable CFI checks for __cxa_decrement_exception_refcount (authored by vlad.tsyrklevich, committed by ). Changed prior to commit: https://reviews.llvm.org/D45455?vs=141733=141752#toc

[libcxxabi] r329629 - [CFI] Disable CFI checks for __cxa_decrement_exception_refcount

Author: vlad.tsyrklevich Date: Mon Apr 9 15:11:28 2018 New Revision: 329629 URL: http://llvm.org/viewvc/llvm-project?rev=329629=rev Log: [CFI] Disable CFI checks for __cxa_decrement_exception_refcount Summary: exception_header->exceptionDestructor is a void(*)(void*) function pointer; however,

r329628 - [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Apr 9 14:54:38 2018 New Revision: 329628 URL: http://llvm.org/viewvc/llvm-project?rev=329628=rev Log: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/ASTImporter.h

[PATCH] D45403: Make [[maybe_unused]] work with static data members

Quuxplusone added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:2054 - } - // If this is spelled as the standard C++17 attribute, but not in C++17, warn @aaron.ballman writes: > I don't think we're currently diagnosing static data members of classes

r329627 - Revert "[ObjC++] Never pass structs that transitively contain __weak fields in"

Author: ahatanak Date: Mon Apr 9 14:47:58 2018 New Revision: 329627 URL: http://llvm.org/viewvc/llvm-project?rev=329627=rev Log: Revert "[ObjC++] Never pass structs that transitively contain __weak fields in" This reverts commit r329617. It broke a windows bot.

[PATCH] D45458: MallocChecker refactoring of calls checkers

NoQ added a reviewer: xazax.hun. NoQ added a subscriber: xazax.hun. NoQ added a comment. Herald added a subscriber: rnkovacs. @xazax.hun: do you think the approach you took in the `Valist` checker is applicable here? Did you like how it ended up working? Cause i'd love to see `CallDescription`

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 141745. paulsemel marked an inline comment as done. paulsemel added a comment. Updated the amperstamp in the Sema test to be consistent with the remaining part of it. Repository: rC Clang https://reviews.llvm.org/D44093 Files:

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel marked an inline comment as done. paulsemel added a comment. No problem, thanks for getting back on this ! I was busy because of my midterms anyway :) Comment at: test/Sema/builtin-dump-struct.c:8 + void *b; + int (*goodfunc)(const char *, ...); + int

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ accepted this revision. NoQ added a comment. Thanks! Eww. Weird AST. I wonder how this should work: // RUN: %clang_analyze_cc1 -analyzer-checker debug.ExprInspection -fheinous-gnu-extensions -w %s -verify int clang_analyzer_eval(int); int global; void testRValueOutput() {

[PATCH] D45458: MallocChecker refactoring of calls checkers

devnexen added a comment. Splitting from https://reviews.llvm.org/D45149 as requested. Repository: rC Clang https://reviews.llvm.org/D45458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45458: MallocChecker refactoring of calls checkers

devnexen created this revision. devnexen added reviewers: NoQ, thakis. Herald added a subscriber: cfe-commits. - Splitting some by family to reduce the list of function identifiers. Repository: rC Clang https://reviews.llvm.org/D45458 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp

[PATCH] D44878: libFuzzer OpenBSD support

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45456: [Attr] Print enum attributes at correct position

jdenny created this revision. jdenny added reviewers: aaron.ballman, hfinkel. In enum declarations, enum attributes were always printed after the tag and any member list. When no member list was present but the enum was a type specifier in a variable declaration, the attribute then applied to

[PATCH] D45403: Make [[maybe_unused]] work with static data members

aaron.ballman added a comment. I don't think we're currently diagnosing static data members of classes as being unused in the first place; are there plans to implement that functionality so that someone might want to write the attribute there? Comment at:

[PATCH] D45149: MallocChecker, adding specific BSD calls

jdenny added a comment. Hi David. While I did make some superficial changes here recently, I'm no authority on what belongs here. However, I would suggest that the refactoring patch be split from the original patch. Thanks. https://reviews.llvm.org/D45149

[PATCH] D45109: Remove -cc1 option "-backend-option"

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Uh sure. :) Though I'd almost do it the other way around. That said, -mllvm probably has more uptake. Repository: rC Clang https://reviews.llvm.org/D45109

[PATCH] D45196: [libc++abi] Replace __sync_* functions with __libcpp_atomic_* functions.

efriedma added a comment. Ping. Repository: rCXXA libc++abi https://reviews.llvm.org/D45196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45109: Remove -cc1 option "-backend-option"

efriedma added reviewers: pcc, echristo, rsmith. efriedma added a comment. Not sure who to add as reviewers here. Repository: rC Clang https://reviews.llvm.org/D45109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44984: [HIP] Add hip file type and codegen for kernel launching

yaxunl added a comment. ping. Any further changes need to be done for this patch? Thanks. https://reviews.llvm.org/D44984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

NoQ added inline comments. Comment at: test/Analysis/egraph-dump-int128.c:3 +// RUN: mkdir -p %t.dir +// RUN: env TMPDIR=%t.dir TEMP=%t.dir TMP=%t.dir %clang_analyze_cc1 -analyzer-checker=debug.ViewExplodedGraph %s + george.karpenkov wrote: > At least on a mac,

[PATCH] D45455: [CFI] Disable CFI checks for __cxa_decrement_exception_refcount

vlad.tsyrklevich created this revision. Herald added subscribers: cfe-commits, christof. exception_header->exceptionDestructor is a void(*)(void*) function pointer; however, it can point to destructors like std:: exception::~exception that don't match that type signature. Repository: rCXXA

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

ahatanak closed this revision. ahatanak added a comment. Committed in r329617. Repository: rC Clang https://reviews.llvm.org/D45384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45454: Make __gcov_flush visible outside a shared library

chh created this revision. chh added reviewers: sylvestre.ledru, davidxl, rnk, void. __gcov_flush is not called from other functions in GCDAProfiling.c, but have been used by Android, which needs an interface function to flush profile data of multiple .so files. See

[libcxx] r329618 - [test] [NFC] cleanup aligned_storage test

Author: caseycarter Date: Mon Apr 9 13:41:45 2018 New Revision: 329618 URL: http://llvm.org/viewvc/llvm-project?rev=329618=rev Log: [test] [NFC] cleanup aligned_storage test * `s/"" )/"")/g` * Don't redundantly test triviality for `TEST_STD_VER > 17` Modified:

r329617 - [ObjC++] Never pass structs that transitively contain __weak fields in

Author: ahatanak Date: Mon Apr 9 13:39:47 2018 New Revision: 329617 URL: http://llvm.org/viewvc/llvm-project?rev=329617=rev Log: [ObjC++] Never pass structs that transitively contain __weak fields in registers. This patch fixes a bug in r328731 that caused structs transitively containing __weak

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

ahatanak updated this revision to Diff 141730. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D45384 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Type.h clang/lib/AST/Decl.cpp

[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. the sanitizer part had been accepted https://reviews.llvm.org/D44877 https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r329612 - asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address

Author: vitalybuka Date: Mon Apr 9 13:10:29 2018 New Revision: 329612 URL: http://llvm.org/viewvc/llvm-project?rev=329612=rev Log: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address Summary: Right now to disable -fsanitize=kernel-address instrumentation,

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai added a comment. Are there more thoughts on this change? https://reviews.llvm.org/D34331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

zinovy.nis updated this revision to Diff 141719. zinovy.nis marked 9 inline comments as done. zinovy.nis added a comment. - Default value is **5**. - Switched to 'tooling::fixit::getText'. - Updated rst docs. https://reviews.llvm.org/D45405 Files: clang-tidy/modernize/UseAutoCheck.cpp

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a few minor nits to be fixed. Comment at: docs/clang-tidy/checks/android-comparison-in-temp-failure-retry.rst:4 +android-comparison-in-temp-failure-retry +=

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 5, 2018, at 1:25 PM, John McCall wrote: > > > >> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka > > wrote: >> >> >>> On Apr 5, 2018, at 12:39 PM, John McCall >> >

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 141717. apazos edited the summary of this revision. apazos added a comment. Herald added a subscriber: zzheng. Updated code according to the ISA string rules that have been clarified. https://reviews.llvm.org/D45284 Files:

r329608 - Revert "[ObjC] Make C++ triviality type traits available to non-trivial C"

Author: ahatanak Date: Mon Apr 9 12:39:27 2018 New Revision: 329608 URL: http://llvm.org/viewvc/llvm-project?rev=329608=rev Log: Revert "[ObjC] Make C++ triviality type traits available to non-trivial C" This reverts commit r329289. It was decided that we shouldn't expose the __has_* traits to

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny updated this revision to Diff 141715. jdenny added a comment. Rebased onto a more recent master. https://reviews.llvm.org/D45093 Files: include/clang/AST/ASTContext.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Sema/Sema.cpp lib/Sema/SemaChecking.cpp

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added a comment. Sorry for the delayed review; I'm back from vacation now and am picking things up again. Comment at: test/Sema/builtin-dump-struct.c:8 + void *b; + int (*goodfunc)(const char *, ...); + int (*badfunc1)(const char *);

[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, majnemer, rjmccall. Since "Da" and "Dc" (auto and decltype(auto)) are under in the mangling grammer, they shouldn't have a substitution (https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling-compression). I

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

erichkeane added a comment. In https://reviews.llvm.org/D45383#1062099, @efriedma wrote: > Basically, yes, although I was thinking you could be a bit more aggressive. > At least, anything marked "t" for custom typechecking is probably not > something which should be redeclared. Ok, thank

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

efriedma added a comment. Basically, yes, although I was thinking you could be a bit more aggressive. At least, anything marked "t" for custom typechecking is probably not something which should be redeclared. Repository: rC Clang https://reviews.llvm.org/D45383

[PATCH] D45421: [X86] Emit native IR for pmuldq/pmuludq builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329605: [X86] Emit native IR for pmuldq/pmuludq builtins. (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D45421?vs=141691=141707#toc Repository: rL LLVM

r329605 - [X86] Emit native IR for pmuldq/pmuludq builtins.

Author: ctopper Date: Mon Apr 9 12:17:54 2018 New Revision: 329605 URL: http://llvm.org/viewvc/llvm-project?rev=329605=rev Log: [X86] Emit native IR for pmuldq/pmuludq builtins. I believe all the pieces are now in place in the backend to make this work correctly. We can either mask the input

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

erichkeane added a comment. In https://reviews.llvm.org/D45383#1062078, @efriedma wrote: > > I believe it is permissible to implement va_copy and va_end as a function, > > isn't it? > > I guess you could, in theory, but LLVM doesn't support any targets which do > that. Ok, fair enough. So

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

efriedma added a comment. > I believe it is permissible to implement va_copy and va_end as a function, > isn't it? I guess you could, in theory, but LLVM doesn't support any targets which do that. Repository: rC Clang https://reviews.llvm.org/D45383

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

DHowett-MSFT updated this revision to Diff 141701. DHowett-MSFT edited the summary of this revision. DHowett-MSFT added a comment. I've fixed the test to check the LLVM IR; I chose to use `CHECK-SAME` and use indentation to clarify what was going on. We're now checking that an empty protocol is

[PATCH] D45449: [CUDA] Document recent changes

Hahnfeld created this revision. Hahnfeld added reviewers: tra, jlebar, rsmith. Herald added a subscriber: cfe-commits. Hahnfeld added a dependency: D42922: [CUDA] Register relocatable GPU binaries. - Finding installations via ptxas binary - Relocatable device code Repository: rC Clang

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld updated this revision to Diff 141698. Hahnfeld added a comment. Correct test check prefix. https://reviews.llvm.org/D42922 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGenCUDA/device-stub.cu Index: test/CodeGenCUDA/device-stub.cu

[PATCH] D45421: [X86] Emit native IR for pmuldq/pmuludq builtins.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM (assuming the backend gets this right in all cases and we have tests for that). https://reviews.llvm.org/D45421 ___ cfe-commits mailing

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

erichkeane added a comment. In https://reviews.llvm.org/D45383#1062014, @efriedma wrote: > > I don't see redeclaring the latter 3 as being disallowed, > > It is in fact disallowed by the standard, in the section describing > va_start/va_arg/va_end/va_copy: "If a macro definition is suppressed

[libcxxabi] r329601 - [demangler] Support for fold expressions.

Author: epilk Date: Mon Apr 9 11:33:01 2018 New Revision: 329601 URL: http://llvm.org/viewvc/llvm-project?rev=329601=rev Log: [demangler] Support for fold expressions. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified:

[libcxxabi] r329600 - [demangler] Support for .

Author: epilk Date: Mon Apr 9 11:32:25 2018 New Revision: 329600 URL: http://llvm.org/viewvc/llvm-project?rev=329600=rev Log: [demangler] Support for . Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified:

[libcxxabi] r329599 - [demangler] Support for partially substituted sizeof....

Author: epilk Date: Mon Apr 9 11:31:50 2018 New Revision: 329599 URL: http://llvm.org/viewvc/llvm-project?rev=329599=rev Log: [demangler] Support for partially substituted sizeof Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified:

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

efriedma added a comment. > I don't see redeclaring the latter 3 as being disallowed, It is in fact disallowed by the standard, in the section describing va_start/va_arg/va_end/va_copy: "If a macro definition is suppressed in order to access an actual function, or a program defines an external

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Right, sorry. LGTM, but maybe Artem has something to add as well. I don't have any suggestions, and trying to modifying lifetimes of expressions in environment for the sake

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:3082 +if (X.isUnknown()) { + // The value being casted to rvalue can be garbage-collected after + // the cast is modeled. Try to recover the memory region being casted

[PATCH] D44921: [PowerPC] Option for secure plt mode

nemanjai added a subscriber: chmeee. nemanjai added a comment. In https://reviews.llvm.org/D44921#1056672, @spetrovic wrote: > -mbss-plt is currently default in LLVM, once secure plt support is finished > we can set secure plt as default in LLVM, but not for now. I was thinking in case the

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv updated this revision to Diff 141693. george.burgess.iv added a comment. Rebased https://reviews.llvm.org/D38479 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv added a comment. Hi! It fell off my radar, but I'm happy to put it back on my queue. :) There's still a few aarch64-specific backend bits I need to fix before this patch should go in. https://reviews.llvm.org/D38479 ___

[PATCH] D45421: [X86] Emit native IR for pmuldq/pmuludq builtins.

craig.topper updated this revision to Diff 141691. craig.topper added a comment. Use shifts or and to match what InstCombine will do. This sidesteps the illegal type question. https://reviews.llvm.org/D45421 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx2-builtins.c

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

I had compilation errors here on MVSV@PSP and for ARM: FAILED: /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/clang-tidy/bugprone

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1061433, @alexfh wrote: > I wonder whether the readability-identifier-naming check could be extended to > support this use case instead of adding a new check specifically for > underscores in ivar names? Hmm

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:3082 +if (X.isUnknown()) { + // The value being casted to rvalue can be

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

Eugene.Zelenko added a comment. It'll be good idea to have option to apply this check for pointer/references only, or include built-in types/enums. Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" + +#include

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/SVals.cpp:304 const nonloc::ConcreteInt& C = castAs(); - if (C.getValue().isUnsigned()) -os << C.getValue().getZExtValue(); - else -os << C.getValue().getSExtValue(); -

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv updated this revision to Diff 141687. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Herald added a subscriber: srhines. Addressed feedback https://reviews.llvm.org/D45059 Files: clang-tidy/android/AndroidTidyModule.cpp

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv added a comment. Thanks for the feedback! > and I suspect that your interest in this check is also related to android? Yup :) > Alternatively, if there are other checks specific to the GNU C library > planned, we could add a new module for it. I have nothing planned, so I'm

[PATCH] D45406: Document -std= values for different languages

dim added a comment. So, does this look good enough to commit? Repository: rC Clang https://reviews.llvm.org/D45406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

george.karpenkov accepted this revision. george.karpenkov added a comment. LGTM. Sorry for the delay, I thought that a single acceptance was sufficient. https://reviews.llvm.org/D41938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

pfultz2 added a comment. This seems like it would be nice to have in `bugprone-*` as well. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >