[clang-tools-extra] r329875 - [Documentation] Fix options order for Release Notes in modernize-use-auto.

Author: zinovy.nis Date: Wed Apr 11 22:45:16 2018 New Revision: 329875 URL: http://llvm.org/viewvc/llvm-project?rev=329875=rev Log: [Documentation] Fix options order for Release Notes in modernize-use-auto. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-auto.rst

[clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

Author: zinovy.nis Date: Wed Apr 11 22:41:24 2018 New Revision: 329873 URL: http://llvm.org/viewvc/llvm-project?rev=329873=rev Log: [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseAutoCheck.cpp

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

smeenai added a comment. This LGTM given that Eric accepted your previous change. I'm happy to accept it in a day or two if he hasn't gotten the chance to take a look by then. Comment at: libcxx/CMakeLists.txt:101 +if (FUCHSIA) + set(ABI_VERSION_DEFAULT 2) +else()

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1064196, @sammccall wrote: > (BTW @hokein has https://reviews.llvm.org/D45513 to add row/col to the index, > which will allow all the file-reading stuff to be cleaned up, but no need to > wait on that since it's all working now).

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle updated this revision to Diff 142112. malaperle marked 2 inline comments as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

DHowett-MSFT added a comment. Hi! Is there anything else holding up this patch? Thanks! Repository: rC Clang https://reviews.llvm.org/D45305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r329869 - [ODRHash] Skip more types hashing TypedefType

Author: rtrieu Date: Wed Apr 11 19:26:49 2018 New Revision: 329869 URL: http://llvm.org/viewvc/llvm-project?rev=329869=rev Log: [ODRHash] Skip more types hashing TypedefType To get the underlying type for TypedefType's, also skip ElaboratedType's. Modified: cfe/trunk/lib/AST/ODRHash.cpp

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek added a comment. ping? Repository: rCXX libc++ https://reviews.llvm.org/D45529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r329866 - Lex: make `clang::Preprocessor::macros` work on MSVC

Author: compnerd Date: Wed Apr 11 16:47:25 2018 New Revision: 329866 URL: http://llvm.org/viewvc/llvm-project?rev=329866=rev Log: Lex: make `clang::Preprocessor::macros` work on MSVC The order of argument construction is reversed on MS ABI on Windows. When `macros` was invoked, the `end` call is

[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

flyingforyou created this revision. flyingforyou added a reviewer: SjoerdMeijer. Herald added subscribers: kristof.beyls, javed.absar. This matches what GCC does. https://github.com/gcc-mirror/gcc/blob/master/gcc/config/aarch64/aarch64-c.c https://reviews.llvm.org/D45544 Files:

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. In https://reviews.llvm.org/D45015#1064922, @vsapsai wrote: > Another approach is `__has_feature` but I don't think it is applicable in > this case. > > Is there a way right now to detect that aligned allocation is supported by > clang, regardless of link time? Asking

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. Another approach is `__has_feature` but I don't think it is applicable in this case. Is there a way right now to detect that aligned allocation is supported by clang, regardless of link time? Asking to make sure we are consistent. Repository: rC Clang

[PATCH] D44130: Driver: Add gcc search path for RHEL devtoolset-7

This revision was automatically updated to reflect the committed changes. Closed by commit rL329854: Driver: Add gcc search path for RHEL devtoolset-7 (authored by tstellar, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44130 Files:

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

NoQ added a comment. We've found a crash on our internal buildbot, would you like to have a look?: **`$ cat repro.c`** int foo(int x, int y) { short a = x - 1U; return a - y; } **`$ clang -cc1 -analyze -analyzer-checker=core repro.c`** Assertion failed: (APSIntType(LInt) ==

r329854 - Driver: Add gcc search path for RHEL devtoolset-7

Author: tstellar Date: Wed Apr 11 15:29:35 2018 New Revision: 329854 URL: http://llvm.org/viewvc/llvm-project?rev=329854=rev Log: Driver: Add gcc search path for RHEL devtoolset-7 Reviewers: bruno Reviewed By: bruno Subscribers: bruno, cfe-commits Differential Revision:

Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

Should we have two versions of `__gcov_flush`? One version is visible outside a .so file, we use dlsym to find and call it to dump profile data of .so files, like Android. One version is hidden and must be called from another wrapper function in a .so file. An application that wants to flush .so

r329851 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Wed Apr 11 13:57:28 2018 New Revision: 329851 URL: http://llvm.org/viewvc/llvm-project?rev=329851=rev Log: [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. As far as I know, there are no updates required from me for this pull request-- I rebased on the main trunk recently, and will do it again tonight to be sure. So it should be compiling/working just fine. I believe it is just awaiting final approval from somebody.

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added a comment. In https://reviews.llvm.org/D45532#1064685, @Szelethus wrote: > In https://reviews.llvm.org/D45532#1064670, @Szelethus wrote: > > > I wasn't too clear on this one: unknown fields are regarded as > > uninitialized, what I wrote was a temporary change in the code so I could

[PATCH] D43817: [x86] wbnoinvd intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC329848: [x86] wbnoinvd intrinsic (authored by GBuella, committed by ). Repository: rC Clang https://reviews.llvm.org/D43817 Files: docs/ClangCommandLineReference.rst

Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

On Wed, Apr 11, 2018 at 11:31 AM, Chih-Hung Hsieh via Phabricator via llvm-commits wrote: > chh added a comment. > > Yes, calling `__gcov_flush` within .so files are different, > but it's a revert of https://reviews.llvm.org/D38124. > I think

r329843 - [OPENMP] Code cleanup, NFC.

Author: abataev Date: Wed Apr 11 12:21:00 2018 New Revision: 329843 URL: http://llvm.org/viewvc/llvm-project?rev=329843=rev Log: [OPENMP] Code cleanup, NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added a comment. In https://reviews.llvm.org/D45532#1064670, @Szelethus wrote: > I wasn't too clear on this one: unknown fields are regarded as uninitialized, > what I wrote was a temporary change in the code so I could check whether it > would work. Woops, I meant that unknown

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added inline comments. Comment at: test/clang-tidy/readability-identifier-naming-objc.m:8-9 +// RUN: ]}' -- -fno-delayed-template-parsing \ +// RUN: -I%S/Inputs/readability-identifier-naming \ +// RUN: -isystem %S/Inputs/readability-identifier-naming/system +

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 142057. Wizard added a comment. remove unnecessary flags Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming-objc.m Index:

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added a comment. Ok, thanks, looking forward to it! Comment at: test/Analysis/ctor-uninitialized-member.cpp:869 +void f44() { + ContainsUnionWithSimpleUnionTest2(); // xpected-warning{{1 uninitialized field}} +} Szelethus wrote: > NoQ wrote: > > Hmm,

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added a comment. In https://reviews.llvm.org/D45532#1064652, @NoQ wrote: > > In most cases, all fields of a union is regarded as unknown. I checked > > these cases by regarding unknown fields as uninitialized. > > The whole point of making them unknown, as far as i understand, was to

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added inline comments. Comment at: test/Analysis/ctor-uninitialized-member.cpp:869 +void f44() { + ContainsUnionWithSimpleUnionTest2(); // xpected-warning{{1 uninitialized field}} +} NoQ wrote: > Hmm, shouldn't it say "expected"? Do these tests

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added a comment. That's a lot of code, so it'll take me some time to understand what's going on here. You might be able to help me by the large patch in smaller logical chunks. The idea looks reasonable. We're having specific warnings for, eg., assigning an uninitialized value, which fire

[PATCH] D45454: Make __gcov_flush visible outside a shared library

chh added a comment. Yes, calling `__gcov_flush` within .so files are different, but it's a revert of https://reviews.llvm.org/D38124. I think https://bugs.llvm.org/show_bug.cgi?id=27224 can be fixed by hiding only llvm_gcda_* functions, without any change to `__gcov_flush`. (1) Before

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

This revision was automatically updated to reflect the committed changes. Closed by commit rL329836: [CodeGen] Handle __func__ inside __finally (authored by smeenai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45523 Files:

r329836 - [CodeGen] Handle __func__ inside __finally

Author: smeenai Date: Wed Apr 11 11:17:35 2018 New Revision: 329836 URL: http://llvm.org/viewvc/llvm-project?rev=329836=rev Log: [CodeGen] Handle __func__ inside __finally When we enter a __finally block, the CGF's CurCodeDecl will be null (because CodeGenFunction::StartFunction is given an

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus updated this revision to Diff 142053. Szelethus added a comment. Reuploaded the diff with full context. https://reviews.llvm.org/D45532 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

Quuxplusone added a comment. In https://reviews.llvm.org/D45179#1064589, @lebedev.ri wrote: > I'm waiting for @mclow.lists to have the final say re this differential. Ack. :) > So roughly: > > // NOTE: Do not use [[nodiscard]] in pre-C++17 mode > // to avoid -Wc++17-extensions

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

lebedev.ri added a comment. Please always upload all patches with full context (`-U9`) Repository: rC Clang https://reviews.llvm.org/D45532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r329833 - [Documentation] Fix formatting and order in Release Notes for recent changes in modernize-use-auto.

Author: eugenezelenko Date: Wed Apr 11 11:03:57 2018 New Revision: 329833 URL: http://llvm.org/viewvc/llvm-project?rev=329833=rev Log: [Documentation] Fix formatting and order in Release Notes for recent changes in modernize-use-auto. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dkrupp, whisperity. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, mgorny. Herald added a reviewer: george.karpenkov. This checker checks at the end of a constructor call whether all fields of the

[PATCH] D45061: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329829: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D45061?vs=141932=142047#toc Repository:

r329830 - [NVPTX] Removed 'satom' feature which is no longer used.

Author: tra Date: Wed Apr 11 10:51:33 2018 New Revision: 329830 URL: http://llvm.org/viewvc/llvm-project?rev=329830=rev Log: [NVPTX] Removed 'satom' feature which is no longer used. Differential Revision: https://reviews.llvm.org/D45061 Modified: cfe/trunk/lib/Basic/Targets/NVPTX.cpp

r329829 - [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.

Author: tra Date: Wed Apr 11 10:51:19 2018 New Revision: 329829 URL: http://llvm.org/viewvc/llvm-project?rev=329829=rev Log: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins. When NVPTX TARGET_BUILTIN specifies sm_XX or ptxYY as required feature, consider those features

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

lebedev.ri added a comment. I'm waiting for @mclow.lists to have the final say re this differential. In https://reviews.llvm.org/D45179#1057187, @Quuxplusone wrote: > In https://reviews.llvm.org/D45179#1056706, @lebedev.ri wrote: > > > gcc does not silence the warning produced by > > these

[PATCH] D43817: [x86] wbnoinvd intrinsic

craig.topper accepted this revision. craig.topper added a comment. LGTM https://reviews.llvm.org/D43817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45061: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.

tra added a comment. In https://reviews.llvm.org/D45061#1063791, @echristo wrote: > Guessing that SM_60 (etc) are defines? > > Anyhow LGTM. I'm not sure you can split up the satom part of the patch, but > if you can that'd be great. > > -eric I'll split out removal of satom feature into a

[PATCH] D45406: Document -std= values for different languages

This revision was automatically updated to reflect the committed changes. Closed by commit rL329827: Document -std= values for different languages (authored by dim, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek created this revision. phosek added reviewers: EricWF, beanz. Herald added subscribers: cfe-commits, christof, mgorny. This is neeeded since the CMake value is used for the SOVERSION. Repository: rCXX libc++ https://reviews.llvm.org/D45529 Files: libcxx/CMakeLists.txt Index:

r329827 - Document -std= values for different languages

Author: dim Date: Wed Apr 11 10:21:52 2018 New Revision: 329827 URL: http://llvm.org/viewvc/llvm-project?rev=329827=rev Log: Document -std= values for different languages Summary: After a remark on a FreeBSD mailing list that the clang man page did not have any list of possible values for the

[PATCH] D45526: [clang-format] Prefer breaking after ObjC category close paren

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak. Herald added subscribers: cfe-commits, klimek. Previously, `clang-format` would break Objective-C category extensions after the opening parenthesis to avoid breaking the protocol list: % echo "@interface

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Comment at: test/CodeGen/exceptions-seh-finally.c:281 +// CHECK-LABEL: define internal void @"?fin$0@0@finally_with_func@@"({{[^)]*}}) +// CHECK: call void

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

aprantl added a comment. What's your use-case for this? Comment at: test/CodeGen/no-ident-version.c:4 +// CHECK-NOT: llvm.ident +// CHECK-NOT: producer: +int main(void) {} You'll also want to check for something positive, otherwise this test will succeed even

[PATCH] D45454: Make __gcov_flush visible outside a shared library

davidxl added a comment. The behavior will change if the shared libraries are not 'dlopen'ed but loaded at program startup time. https://reviews.llvm.org/D45454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

MTC updated this revision to Diff 142026. MTC marked 2 inline comments as done. MTC added a comment. - Move the `CXXThisRegion`'s check to `LoopWidening.cpp` - Use `isa(R)` instead of `CXXThisRegion::classof(R)`. Repository: rC Clang https://reviews.llvm.org/D45491 Files:

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

smeenai added inline comments. Comment at: test/CodeGen/exceptions-seh-finally.c:281 +// CHECK-LABEL: define internal void @"?fin$0@0@finally_with_func@@"({{[^)]*}}) +// CHECK: call void @cleanup_with_func(i8* getelementptr inbounds ([18 x i8], [18 x i8]*

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

smeenai created this revision. smeenai added reviewers: compnerd, majnemer, rnk. When we enter a __finally block, the CGF's CurCodeDecl will be null (because CodeGenFunction::StartFunction is given an empty GlobalDecl for a __finally block), and so the dyn_cast here will result in an assertion

[PATCH] D45521: [clang-format] Improve ObjC guessing heuristic by supporting all @keywords

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak. Herald added subscribers: cfe-commits, klimek. This diff improves the Objective-C guessing heuristic by replacing the hard-coded list of a subset of Objective-C @keywords with a general check which supports all

r329816 - Fix bugs around handling C++11 attributes.

Author: klimek Date: Wed Apr 11 07:51:54 2018 New Revision: 329816 URL: http://llvm.org/viewvc/llvm-project?rev=329816=rev Log: Fix bugs around handling C++11 attributes. Previously, we would format: int a() { ... } [[unused]] int b() { ... } as... int a() {} [[unused] int b() {} Now we

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL329814: [NEON] Support vfma_n and vfms_n intrinsics (authored by kosarev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC329814: [NEON] Support vfma_n and vfms_n intrinsics (authored by kosarev, committed by ). Repository: rL LLVM https://reviews.llvm.org/D45483 Files: include/clang/Basic/arm_neon.td

r329814 - [NEON] Support vfma_n and vfms_n intrinsics

Author: kosarev Date: Wed Apr 11 07:43:11 2018 New Revision: 329814 URL: http://llvm.org/viewvc/llvm-project?rev=329814=rev Log: [NEON] Support vfma_n and vfms_n intrinsics Differential Revision: https://reviews.llvm.org/D45483 Modified: cfe/trunk/include/clang/Basic/arm_neon.td

[clang-tools-extra] r329813 - [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

Author: malcolm.parsons Date: Wed Apr 11 07:39:17 2018 New Revision: 329813 URL: http://llvm.org/viewvc/llvm-project?rev=329813=rev Log: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329813: [clang-apply-replacements] Convert tooling::Replacements to tooling… (authored by malcolm.parsons, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1064113, @russell.gallop wrote: > We also see an assertion failure prior to the revert. At r329738: Yes, you're right - thaks again for this test case. Repository: rL LLVM https://reviews.llvm.org/D43578

[PATCH] D45092: [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking

This revision was automatically updated to reflect the committed changes. Closed by commit rC329810: [Driver] Dont forward -m[no-]unaligned-access options to GCC when… (authored by mcrosier, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r329810 - [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking

Author: mcrosier Date: Wed Apr 11 07:20:37 2018 New Revision: 329810 URL: http://llvm.org/viewvc/llvm-project?rev=329810=rev Log: [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking Differential Revision: https://reviews.llvm.org/D45092 Modified:

Re: r329804 - [Sema] Fix built-in decrement operator overload resolution

While you're here... ++ should not be available for bool in C++17 onwards. :) On Wed, 11 Apr 2018, 14:39 Jan Korous via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: jkorous > Date: Wed Apr 11 06:36:29 2018 > New Revision: 329804 > > URL:

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri updated this revision to Diff 142003. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. - Drop stale comment - Switch to pre{in,de}crement Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 Files:

[PATCH] D45517: [analyzer] WIP: False positive refutation with Z3

rnkovacs created this revision. rnkovacs added reviewers: george.karpenkov, NoQ, dcoughlin. Herald added subscribers: a.sidorin, szepet, baloghadamsoftware, whisperity, fhahn. This is a prototype of a bug reporter visitor that invalidates bug reports by re-checking constraints of certain states

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from some minor nits, LGTM! Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:28 +// Do not count decomposition declarations (C++17's

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

zinovy.nis added a comment. The build was broken by someone else's commit then. From my side there was a warning only I fixed immediately. ср, 11 апр. 2018 г. в 16:26, Alexander Kornienko via Phabricator < revi...@reviews.llvm.org>: > alexfh added a comment. > > In

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri updated this revision to Diff 141997. lebedev.ri added a reviewer: alexfh. lebedev.ri added a comment. After a quick IRC chat with @aaron.ballman, it was discovered that there has been a big misunderstanding: we don't need to ignore/exempt *all* the variables declared in macros, we

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

MTC marked 2 inline comments as done. MTC added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1024-1027 + // 'this' pointer is not an lvalue, we should not invalidate it. + if (CXXThisRegion::classof(baseR)) +return; + NoQ wrote: > I

[PATCH] D44988: [Sema] Fix decrement availability for built-in types

This revision was automatically updated to reflect the committed changes. Closed by commit rL329804: [Sema] Fix built-in decrement operator overload resolution (authored by jkorous, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329804 - [Sema] Fix built-in decrement operator overload resolution

Author: jkorous Date: Wed Apr 11 06:36:29 2018 New Revision: 329804 URL: http://llvm.org/viewvc/llvm-project?rev=329804=rev Log: [Sema] Fix built-in decrement operator overload resolution C++ [over.built] p4: "For every pair (T, VQ), where T is an arithmetic type other than bool, and VQ is

[PATCH] D45515: [NEON] Support vrndns_f32 intrinsic

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D45515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you, that's much better! I'd also appreciate, if you could document the options this check supports in its .rst document (separately from this patch). A few more comments

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

MTC added a comment. In https://reviews.llvm.org/D45491#1063364, @george.karpenkov wrote: > @MTC what happens for > > this.j = 0; > for (int i=0; i<100; i++) > this.j++; > > > ? @george.karpenkov `this`'s value will remain unchanged, `j` will be invalidated. 1 void

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

alexfh added a comment. In https://reviews.llvm.org/D45405#1063890, @zinovy.nis wrote: > Roman, I see you've fixed them. Thanks a lot! > I did not face with these errors on MSVS'201 so had no chance to fix early. No stress, but as Roman said, please watch the bots after committing a patch:

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai updated this revision to Diff 141989. HsiangKai added a comment. Update the test case for inlined functions. The inlined label will attach to DISubprogram(..., labels: !n) Repository: rC Clang https://reviews.llvm.org/D45045 Files: lib/CodeGen/CGDebugInfo.cpp

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. (BTW @hokein has https://reviews.llvm.org/D45513 to add row/col to the index, which will allow all the file-reading stuff to be cleaned up, but no need to wait on that since it's all working now). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay Marc-André - I got stuck on "how to test ClangdLSPServer" and then distracted! But this looks great. Comment at: clangd/ClangdLSPServer.cpp:101

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141983. aheejin added a comment. - Rebase Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D45363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D43578: -ftime-report switch support in Clang

On Wed, Apr 11, 2018 at 6:18 AM, Andrew V. Tischenko via Phabricator via cfe-commits wrote: > avt77 added a comment. > > In https://reviews.llvm.org/D43578#1062950, @thakis wrote: > > > @davezarzycki remarks in https://reviews.llvm.org/D45485 that this > breaks the

[PATCH] D45515: [NEON] Support vrndns_f32 intrinsic

kosarev created this revision. kosarev added reviewers: t.p.northover, rengolin, SjoerdMeijer. kosarev added a project: clang. Herald added a subscriber: javed.absar. https://reviews.llvm.org/D45515 Files: include/clang/Basic/arm_neon.td lib/CodeGen/CGBuiltin.cpp

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141979. aheejin added a comment. - Change personality function name to a unique one Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp

[clang-tools-extra] r329789 - [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

Author: jonastoth Date: Wed Apr 11 02:53:08 2018 New Revision: 329789 URL: http://llvm.org/viewvc/llvm-project?rev=329789=rev Log: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise This patch resolves the bug https://bugs.llvm.org/show_bug.cgi?id=36963. - implement missing

[clang-tools-extra] r329790 - [clang-tidy] fix buildbots from hicpp-signed-bitwise

Author: jonastoth Date: Wed Apr 11 03:22:25 2018 New Revision: 329790 URL: http://llvm.org/viewvc/llvm-project?rev=329790=rev Log: [clang-tidy] fix buildbots from hicpp-signed-bitwise The applied patch to diagnose assignment operators introduced breakage on some architectures. This patch tries

[PATCH] D44921: [PowerPC] Option for secure plt mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL329795: [PowerPC] Option for secure plt mode (authored by spetrovic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329795 - [PowerPC] Option for secure plt mode

Author: spetrovic Date: Wed Apr 11 05:24:44 2018 New Revision: 329795 URL: http://llvm.org/viewvc/llvm-project?rev=329795=rev Log: [PowerPC] Option for secure plt mode This patch enables option for secure plt mode in clang (-msecure-plt). Differential Revision: https://reviews.llvm.org/D44921

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, I'd been wondering about that... Comment at: clangd/index/SymbolCollector.cpp:36 + return *T; +return ND; + } uber-nit: these three

[PATCH] D43578: -ftime-report switch support in Clang

russell.gallop added a comment. We also see an assertion failure prior to the revert. At r329738: $ cat test.cpp template struct A { template using rebind_alloc = _Other; }; template struct _Wrap_alloc { template using rebind_alloc = typename A<_Alloc>::template

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

Anastasia added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:434 +llvm_unreachable("Unsupported OpenCL C++ version"); + Builder.defineMacro("__CL_CPP_VERSION_1_0__", "100"); +} else { There is no such macro in the spec it

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

Anastasia updated this revision to Diff 141975. Anastasia edited the summary of this revision. Anastasia added a comment. Changed to `-cl-std=c++` since it's explicitly defined in spec. We could reuse `OpenCLVersion` in `LangOpts` but I think it might be cleaner to add separate

Re: r329784 - [Tooling] Optimize memory usage in InMemoryToolResults.

On Wed, Apr 11, 2018 at 10:16 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Wed Apr 11 01:13:07 2018 > New Revision: 329784 > ... > > == > ---

[PATCH] D43817: [x86] wbnoinvd intrinsic

GBuella added inline comments. Comment at: lib/Basic/Targets/X86.cpp:188 setFeatureEnabledImpl(Features, "mpx", true); if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX setFeatureEnabledImpl(Features, "sgx", true);

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rsmith added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:68 + /// \brief A map containing the comparison category values built from the + /// standard library. The key is a value of ComparisonCategoryValue. + llvm::DenseMap

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware added a comment. Thank you for your thorough review, I will do the fixes next week, after the Euro LLVM. https://reviews.llvm.org/D33537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

szepet marked an inline comment as done. szepet added a comment. Hello Aleksei, Thanks for carrying the ASTImporter improvements (in general)! I will rebase it and upload for sure, but probably just next week. (After EuroLLVM.) https://reviews.llvm.org/D38845

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1062950, @thakis wrote: > @davezarzycki remarks in https://reviews.llvm.org/D45485 that this breaks the > shared build. The proposed fix there is to make several of clang's modules > depend on LLVM's IR library ("Core"). This seems

[PATCH] D45406: Document -std= values for different languages

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me, thank you Repository: rC Clang https://reviews.llvm.org/D45406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

JonasToth closed this revision. JonasToth added a comment. Commit in https://reviews.llvm.org/rCTE329789 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >