r331958 - [X86] Change the implementation of scalar masked load/store intrinsics to not use a 512-bit intermediate vector.

Author: ctopper Date: Wed May 9 22:43:43 2018 New Revision: 331958 URL: http://llvm.org/viewvc/llvm-project?rev=331958=rev Log: [X86] Change the implementation of scalar masked load/store intrinsics to not use a 512-bit intermediate vector. This is unnecessary for AVX512VL supporting CPUs like

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331957: [Itanium] Emit type info names with external linkage. (authored by EricWF, committed by ). Changed prior to commit: https://reviews.llvm.org/D46665?vs=146065=146069#toc Repository: rC Clang

r331957 - [Itanium] Emit type info names with external linkage.

Author: ericwf Date: Wed May 9 22:25:15 2018 New Revision: 331957 URL: http://llvm.org/viewvc/llvm-project?rev=331957=rev Log: [Itanium] Emit type info names with external linkage. Summary: The Itanium ABI requires that the type info for pointer-to-incomplete types to have internal linkage, so

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

EricWF added a comment. @rjmccall Thank you for the quick review! https://reviews.llvm.org/D46665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Looks really good, thanks. https://reviews.llvm.org/D46665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

EricWF updated this revision to Diff 146065. EricWF marked 3 inline comments as done. EricWF added a comment. Address @rjmccall's comments. https://reviews.llvm.org/D46665 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-linkage.cpp Index: test/CodeGenCXX/rtti-linkage.cpp

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

asb added a comment. Just wanted to explicitly say that I'm happy the updated patch reflects the changes to docs and comments I requested. @hfinkel - are you happy for this to land now? https://reviews.llvm.org/D39053 ___ cfe-commits mailing list

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

apazos added a comment. Thanks for updating the patch, @spetrovic. Can we have this committed? This patch has shown to produce code size improvements for a number of targets (Mips, X86, ARM, RISC-V). https://reviews.llvm.org/D39053 ___ cfe-commits

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

mikerice added a comment. 1. It probably makes sense to allow omp simd with OpenCL. Some people here have been successfully using it anyway. 2. I can give that a try. The test just tests that the compiler doesn't segfault. What would you prefer instead, something that checks the AST or the

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

rjmccall added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3098 +InfoLinkage = getTypeInfoLinkage(CGM, Ty); +NameLinkage = getTypeInfoLinkage(CGM, Ty, /*ForName*/ true); + } rjmccall wrote: > I think we could probably just have the

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

rjmccall added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3098 +InfoLinkage = getTypeInfoLinkage(CGM, Ty); +NameLinkage = getTypeInfoLinkage(CGM, Ty, /*ForName*/ true); + } I think we could probably just have the function return both

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

jfb added a comment. In https://reviews.llvm.org/D42933#1093503, @smeenai wrote: > Yeah, I think we all agree now that a portability warning isn't really > tractable. Note that even for the warnings that motivated this diff, they > should have only fired if `size_t` and NSInteger had separate

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

EricWF updated this revision to Diff 146053. EricWF marked an inline comment as done. EricWF added a comment. Address @rsmith's inline comments. - Calculate the linkage for the type name using the linkage for the type. - Promote the type name visibility for the incomplete class types as well as

[PATCH] D46670: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jkorous, MaskRay, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46670 Files: clangd/ClangdLSPServer.cpp clangd/SourceCode.cpp clangd/SourceCode.h Index:

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

ioeric updated this revision to Diff 146046. ioeric added a comment. - Minor cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46497 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

ioeric added a comment. In https://reviews.llvm.org/D46497#1089755, @sammccall wrote: > I'm concerned about the scope of this patch - it does too many things and > touches too many files for me to feel comfortable that I understand it well > enough to review. > Is it possible to split it up?

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

ioeric updated this revision to Diff 146045. ioeric marked 15 inline comments as done. ioeric added a comment. - Merged with origin/master - Address review comments. - Revert unintended change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46497 Files:

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

EricWF marked an inline comment as done. EricWF added a comment. @rsmith What should the visibility of the type name be in cases where the type info is hidden? Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3033 + return {llvm::GlobalValue::InternalLinkage, +

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:1871-1902 if (!CheckConstantExpression(Info, DiagLoc, EltTy,

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric updated this revision to Diff 146042. ioeric added a comment. - Merged with origin/master Repository: rC Clang https://reviews.llvm.org/D46496 Files: include/clang/Format/Format.h include/clang/Tooling/Core/HeaderIncludes.h lib/Format/Format.cpp

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

ABataev added a comment. 1. Is this allowed to use OpenMP for OpenCL programs at all? 2. If it is allowed, I think it would be better to set the TypeSourceInfo for the artificial variable Repository: rC Clang https://reviews.llvm.org/D46667 ___

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

ABataev added a comment. BTW, the test itself does not check anything. Repository: rC Clang https://reviews.llvm.org/D46667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

rnk added a comment. Is it possible to fix this in assignInheritanceModel instead? I'd imagine we'd get the most recent decl. If that's not the issue, maybe you're fixing the bug in the right spot, but we need to find out where other class template attributes are moved from instantiation to

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk added inline comments. Comment at: clang/include/clang/AST/Expr.h:662 + /// Indicates how the constant expression will be used. + enum ConstExprUsage { EvaluateForCodeGen, EvaluateForMangling }; + I expect we could come up with a better name, but is this

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk updated this revision to Diff 146039. rnk added a comment. - getting closer https://reviews.llvm.org/D43320 Files: clang/include/clang/AST/Expr.h clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/dllimport-constexpr.cpp

[libcxx] r331910 - Allow copy elision in path concatenation

Author: xbolva00 Date: Wed May 9 11:57:17 2018 New Revision: 331910 URL: http://llvm.org/viewvc/llvm-project?rev=331910=rev Log: Allow copy elision in path concatenation Summary: Just port of libstdc++'s fix to libc++ fs:

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

mikerice created this revision. mikerice added reviewers: Anastasia, ABataev, erichkeane, cfe-commits. Herald added subscribers: guansong, yaxunl. Compiler crashes when omp simd is used in an OpenCL file: clang -c -fopenmp omp_simd.cl __kernel void test(__global int *data, int size) {

[PATCH] D46656: [Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to match what the middle and backends understand

This revision was automatically updated to reflect the committed changes. Closed by commit rL331943: [Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r331943 - [Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to match what the middle and backends understand

Author: ctopper Date: Wed May 9 17:05:13 2018 New Revision: 331943 URL: http://llvm.org/viewvc/llvm-project?rev=331943=rev Log: [Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to match what the middle and backends understand Previously we emitted something like

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

rsmith added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3033 + return {llvm::GlobalValue::InternalLinkage, + llvm::GlobalValue::LinkOnceODRLinkage}; +return {llvm::GlobalValue::InternalLinkage, Shouldn't this be based on the

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

EricWF updated this revision to Diff 146034. EricWF added a comment. - Correct copy-paste error. https://reviews.llvm.org/D46665 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-linkage.cpp Index: test/CodeGenCXX/rtti-linkage.cpp

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 146032. juliehockett added a comment. Reverted because of memory leak in PPCallbacksTest, this fixes it. https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rsmith added inline comments. Comment at: clang/include/clang/AST/Expr.h:670-672 + /// Evaluate an expression that is required to be a core constant expression. + bool EvaluateAsCoreConstExpr(EvalResult , QualType ParamType, + CCEKind CCE, const

[PATCH] D46593: Allow copy elision in path concatenation

chandlerc added a comment. In https://reviews.llvm.org/D46593#1093758, @jwakely wrote: > @chandlerc thanks for catching this. > > As the original author I agree to contribute this patch to libc++ under the > terms of the MIT and the University of Illinois licences, and under the terms > of

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

EricWF created this revision. EricWF added reviewers: rsmith, rjmccall, majnemer, vsapsai. The Itanium ABI requires that the type info for pointer-to-incomplete types to have internal linkage, so that it doesn't interfere with the type info once completed. Currently it also marks the type info

[PATCH] D46593: Allow copy elision in path concatenation

jwakely added a comment. @chandlerc thanks for catching this. As the original author I agree to contribute this patch to libc++ under the terms of the MIT and the University of Illinois licences, and under the terms of "Apache 2 with LLVM exception" if necessary in future. This permission

r331938 - [CUDA] Added -f[no-]cuda-short-ptr option

Author: tra Date: Wed May 9 16:10:09 2018 New Revision: 331938 URL: http://llvm.org/viewvc/llvm-project?rev=331938=rev Log: [CUDA] Added -f[no-]cuda-short-ptr option The option enables use of 32-bit pointers for accessing const/local/shared memory. The feature is disabled by default.

[PATCH] D46148: [CUDA] Added -f[no-]cuda-short-ptr option

This revision was automatically updated to reflect the committed changes. Closed by commit rL331938: [CUDA] Added -f[no-]cuda-short-ptr option (authored by tra, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk added inline comments. Comment at: clang/include/clang/AST/Expr.h:670-672 + /// Evaluate an expression that is required to be a core constant expression. + bool EvaluateAsCoreConstExpr(EvalResult , QualType ParamType, + CCEKind CCE, const

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk updated this revision to Diff 146025. rnk added a comment. - don't expose CCEK, use a bool https://reviews.llvm.org/D43320 Files: clang/include/clang/AST/Expr.h clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/dllimport-constexpr.cpp

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett reopened this revision. juliehockett added a comment. Sorry, branches got crossed. Reverted and reopened. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r331934 - Revert "[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module"

Author: juliehockett Date: Wed May 9 15:28:18 2018 New Revision: 331934 URL: http://llvm.org/viewvc/llvm-project?rev=331934=rev Log: Revert "[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module" This reverts commit r331930, which was landed by accident. Removed:

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

adr26 created this revision. adr26 added a reviewer: rnk. adr26 added a project: clang. Herald added a subscriber: cfe-commits. Ensure latest MPT decl has a MSInheritanceAttr when instantiating templates, to avoid null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel(). See

Re: [clang-tools-extra] r331905 - [tools] Updating PPCallbacks::InclusionDirective calls

Reverted, found the memory leak and will put up a patch to fix it & reland in a bit. Thanks! On Wed, May 9, 2018 at 3:13 PM Evgenii Stepanov wrote: > HI, > > ASan says there is a use-after-free after this change: > >

[clang-tools-extra] r331931 - Revert "[tools] Updating PPCallbacks::InclusionDirective calls"

Author: juliehockett Date: Wed May 9 15:25:43 2018 New Revision: 331931 URL: http://llvm.org/viewvc/llvm-project?rev=331931=rev Log: Revert "[tools] Updating PPCallbacks::InclusionDirective calls" This reverts commit r331905, since it's dependent on reverted r331905. Modified:

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE331930: [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module (authored by juliehockett, committed by ).

r331932 - Revert "[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective"

Author: juliehockett Date: Wed May 9 15:25:47 2018 New Revision: 331932 URL: http://llvm.org/viewvc/llvm-project?rev=331932=rev Log: Revert "[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective" This reverts commit r331904 because of a memory leak. Modified:

[clang-tools-extra] r331930 - [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module

Author: juliehockett Date: Wed May 9 15:25:42 2018 New Revision: 331930 URL: http://llvm.org/viewvc/llvm-project?rev=331930=rev Log: [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module Adding a check to restrict system includes to a whitelist. Given a list of includes that are

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1413 + } else if (!Init->isEvaluatable(CE.CGM.getContext())) { +return false; + } else if (InitTy->hasPointerRepresentation()) { sepavloff wrote: > rsmith wrote: > > sepavloff

Re: [clang-tools-extra] r331905 - [tools] Updating PPCallbacks::InclusionDirective calls

HI, ASan says there is a use-after-free after this change: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/5410/steps/check-clang%20asan/logs/stdio MSan also sees a problem, but ASan's is likely closer to the root cause:

r331928 - Update pragma-attribute-supported-attributes-list.test.

Author: manojgupta Date: Wed May 9 15:05:53 2018 New Revision: 331928 URL: http://llvm.org/viewvc/llvm-project?rev=331928=rev Log: Update pragma-attribute-supported-attributes-list.test. Update the test to include the new attribute NoStackProtector to fix the build fails. Modified:

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric updated this revision to Diff 146012. ioeric added a comment. - Merged with origin/master Repository: rC Clang https://reviews.llvm.org/D46496 Files: include/clang/Format/Format.h include/clang/Tooling/Core/HeaderIncludes.h lib/Format/Format.cpp

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331925: [Clang] Implement function attribute no_stack_protector. (authored by manojgupta, committed by ). Changed prior to commit: https://reviews.llvm.org/D46300?vs=145988=146008#toc Repository: rC

r331925 - [Clang] Implement function attribute no_stack_protector.

Author: manojgupta Date: Wed May 9 14:41:18 2018 New Revision: 331925 URL: http://llvm.org/viewvc/llvm-project?rev=331925=rev Log: [Clang] Implement function attribute no_stack_protector. Summary: This attribute tells clang to skip this function from stack protector when -stack-protector option

[PATCH] D46176: Add SourceManagerForFile helper which sets up SourceManager and dependencies for a single file with code snippet

This revision was automatically updated to reflect the committed changes. Closed by commit rL331923: Add SourceManagerForFile helper which sets up SourceManager and dependencies… (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r331923 - Add SourceManagerForFile helper which sets up SourceManager and dependencies for a single file with code snippet

Author: ioeric Date: Wed May 9 14:35:52 2018 New Revision: 331923 URL: http://llvm.org/viewvc/llvm-project?rev=331923=rev Log: Add SourceManagerForFile helper which sets up SourceManager and dependencies for a single file with code snippet Summary: This can be used to create a virtual

[PATCH] D46176: Add SourceManagerForFile helper which sets up SourceManager and dependencies for a single file with code snippet

ioeric updated this revision to Diff 146004. ioeric marked 4 inline comments as done. ioeric added a comment. - address review comments. Repository: rC Clang https://reviews.llvm.org/D46176 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Format/Format.cpp

[PATCH] D46593: Allow copy elision in path concatenation

xbolva00 added a comment. Ping @jwakely Repository: rCXX libc++ https://reviews.llvm.org/D46593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46000: [AST] Added a helper to extract a user-friendly text of a comment.

ioeric added a comment. Thanks for adding the tests! Comment at: include/clang/AST/RawCommentList.h:138 + /// the overload with ASTContext in the rest of the code. + std::string getFormattedText(const SourceManager , + DiagnosticsEngine ) const;

[PATCH] D46593: Allow copy elision in path concatenation

chandlerc added a comment. Sorry folks, but you can't just take patches to libstdc++ and apply them to libc++. These libraries have different licenses, and so the author of the patch (Jonathan Wakely in this case) need's to *explicitly* contribute that patch to libc++ under libc++'s license.

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/fuchsia-restrict-system-includes.rst:32 + A string containing a semi-colon separated list of allowed include filenames. + The default is an empty string, which allows all includes.

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

manojgupta added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D46300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D46300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

efriedma added a comment. There is no difference between "signalling" and "non-signalling" unless you're using "#pragma STDC FENV_ACCESS", which is currently not supported. Presumably the work to implement that will include some LLVM IR intrinsic which can encode the difference, but for now

Re: [PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

> On May 9, 2018, at 1:25 PM, Shoaib Meenai via Phabricator > wrote: > > smeenai added a comment. > > Yeah, I think we all agree now that a portability warning isn't really > tractable. Note that even for the warnings that motivated this diff, they > should have

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

smeenai added a comment. Yeah, I think we all agree now that a portability warning isn't really tractable. Note that even for the warnings that motivated this diff, they should have only fired if `size_t` and NSInteger had separate types, so it wasn't a portability warning in that sense to

[PATCH] D46602: [clang-tidy] Store checks profiling info as YAML files

lebedev.ri updated this revision to Diff 145995. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. - Make json less flat, store source filename in it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46602 Files: clang-tidy/ClangTidy.cpp

[PATCH] D46603: [Support] TimerGroup changes

lebedev.ri updated this revision to Diff 145994. lebedev.ri added a comment. - Use sane (not the same as the one right before..) suffix for when json-printing mem usage. Admittedly, i haven't tried it, but it just does not make sense otherwise. Repository: rL LLVM

[PATCH] D46084: Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 145993. leonardchan added a comment. - Restrict usage of fixed point types only to C https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def

[PATCH] D46659: [clang-tidy/google-readability-casting] Allow C-style casts to/from Objective-C object types

benhamilton added a comment. An alternative implementation would be to allow C-style casts (either always or only for ObjC objects) within Objective-C methods inside Objective-C++ files, but that may get messy with things like shared macros. Repository: rCTE Clang Tools Extra

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

manojgupta updated this revision to Diff 145988. manojgupta added a comment. Updated test case for error msg with arguments. Updated the documentation. Repository: rC Clang https://reviews.llvm.org/D46300 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D46656: [Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to match what the middle and backends understand

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM - thanks! https://reviews.llvm.org/D46656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46659: [clang-tidy/google-readability-casting] Allow C-style casts to/from Objective-C object types

benhamilton created this revision. benhamilton added reviewers: alexfh, Wizard, hokein. Herald added a subscriber: cfe-commits. Previously, `google-readability-casting` would trigger for Objective-C++ code using C-style casts to or from Objective-C object types. The official Google Objective-C

[PATCH] D46643: CodeGen: Emit string literal in constant address space

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1375 +Loc = Address(EmitCastToVoidPtrInAllocaAddrSpace(Loc.getPointer()), + Loc.getAlignment()); rjmccall wrote: > I don't understand

[PATCH] D46656: [Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to match what the middle and backends understand

craig.topper created this revision. craig.topper added a reviewer: spatel. Currently we emit something like rotl(x, n) { n &= bitwidth -1; return n != 0 ? ((x << n) | (x >> (bitwidth - n)) : x; } We use a select to avoid the undefined behavior on the (bitwidth - n) shift. The middle and

[PATCH] D46593: Allow copy elision in path concatenation

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX331910: Allow copy elision in path concatenation (authored by xbolva00, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D46593 Files: include/experimental/filesystem Index:

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 145978. juliehockett marked 3 inline comments as done. juliehockett added a comment. Updating the inclusiondirective to filter out non-system files https://reviews.llvm.org/D43778 Files: clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett added inline comments. Comment at: docs/ReleaseNotes.rst:116 + + Checks for allowed system includes and suggests removal of any others. If no + includes are specified, the check will exit without issuing any warnings. Eugene.Zelenko wrote: > Is it

[PATCH] D45470: Emit an error when include after

vsapsai added a comment. In https://reviews.llvm.org/D45470#1092260, @jfb wrote: > In https://reviews.llvm.org/D45470#1092212, @vsapsai wrote: > > > Here is another approach that should emit an error only when mixing headers > > causes compilation problems. > > > > Have no ideas how to test the

[PATCH] D46651: [OpenCL] Support placement new/delete in Sema

rjmccall added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:2030 + } +} I think a better interpretation of this rule would be to just error on attempts to use the standard non-placement operator new/delete instead of trying to outlaw the

[PATCH] D46615: [tools] Updating PPCallbacks::InclusionDirective calls

This revision was automatically updated to reflect the committed changes. juliehockett marked an inline comment as done. Closed by commit rL331905: [tools] Updating PPCallbacks::InclusionDirective calls (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits,

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rL331904: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r331905 - [tools] Updating PPCallbacks::InclusionDirective calls

Author: juliehockett Date: Wed May 9 11:27:37 2018 New Revision: 331905 URL: http://llvm.org/viewvc/llvm-project?rev=331905=rev Log: [tools] Updating PPCallbacks::InclusionDirective calls [revision] added SrcMgr::CharacteristicKind to the InclusionDirective callback, this revision updates

r331904 - [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

Author: juliehockett Date: Wed May 9 11:27:33 2018 New Revision: 331904 URL: http://llvm.org/viewvc/llvm-project?rev=331904=rev Log: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective Adding a SrcMgr::CharacteristicKind parameter to the InclusionDirective in PPCallbacks, and

[PATCH] D46643: CodeGen: Emit string literal in constant address space

rjmccall added a comment. The part about string literals looks fine, but: Comment at: lib/CodeGen/CGDecl.cpp:1375 +Loc = Address(EmitCastToVoidPtrInAllocaAddrSpace(Loc.getPointer()), + Loc.getAlignment()); I don't understand why a patch

[PATCH] D46633: [analyzer] add range check for InitList lookup

george.karpenkov added a comment. Looks good, thanks! Repository: rL LLVM https://reviews.llvm.org/D46633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice created this revision. mikerice added reviewers: rnk, thakis, erichkeane, cfe-commits. Implement support for MS-style PCH through headers. This enables support for /Yc and /Yu where the through header is either on the command line or included in the source. It replaces the current

r331899 - [OPENMP] Generate unique names for offloading regions id.

Author: abataev Date: Wed May 9 11:02:37 2018 New Revision: 331899 URL: http://llvm.org/viewvc/llvm-project?rev=331899=rev Log: [OPENMP] Generate unique names for offloading regions id. It is required to emit unique names for offloading regions ids. Required to support compilation and linking

[PATCH] D46615: [tools] Updating PPCallbacks::InclusionDirective calls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit, LGTM (no need for more review, you can fix the nit and commit). Comment at: clang-move/ClangMove.cpp:135 +

[PATCH] D46651: [OpenCL] Support placement new/delete in Sema

svenvh created this revision. svenvh added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. Stop crashing on placement new/delete in OpenCL C++ mode, and reject non-placement new/delete with a diagnostic instead of a crash. Repository: rC Clang

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping! Repository: rC Clang https://reviews.llvm.org/D46485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett added a comment. This will break things in clang-tools-extra without https://reviews.llvm.org/D46615, so I'm going to hold off landing this until that goes through https://reviews.llvm.org/D46614 ___ cfe-commits mailing list

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D43341#1093117, @juliehockett wrote: > This will break things in clang-tools-extra without > https://reviews.llvm.org/D46615, so I'm going to hold off landing this until > that goes through Oops wrong patch disregard

[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

ilya-biryukov added a comment. In https://reviews.llvm.org/D42966#1085303, @mikhail.ramalho wrote: > Hi, > > > Where do virtual files come from in the first place? > > From the linemarker: I tried dumping locations in presence of line markers. They have non-null `FileEntry` and a reasonable

[PATCH] D46601: [OpenCL] Fix typos in emitted enqueue kernel function names

This revision was automatically updated to reflect the committed changes. Closed by commit rL331895: [OpenCL] Fix typos in emitted enqueue kernel function names (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r331895 - [OpenCL] Fix typos in emitted enqueue kernel function names

Author: yaxunl Date: Wed May 9 10:07:06 2018 New Revision: 331895 URL: http://llvm.org/viewvc/llvm-project?rev=331895=rev Log: [OpenCL] Fix typos in emitted enqueue kernel function names Two typos: vaarg => vararg get_kernel_preferred_work_group_multiple =>

[PATCH] D45900: CodeGen: Fix invalid bitcast for lifetime.start/end

rjmccall added a comment. In https://reviews.llvm.org/D45900#1093154, @yaxunl wrote: > In https://reviews.llvm.org/D45900#1083377, @rjmccall wrote: > > > Oh, I see, it's not that the lifetime intrinsics don't handle pointers in > > the alloca address space, it's that we might have already

[PATCH] D46332: [X86] Only enable the __ud2 and __int2c builtins if intrin.h has been included.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331893: [X86] Only enable the __ud2 and __int2c builtins if intrin.h has been included. (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D46332 Files:

r331893 - [X86] Only enable the __ud2 and __int2c builtins if intrin.h has been included.

Author: ctopper Date: Wed May 9 09:57:48 2018 New Revision: 331893 URL: http://llvm.org/viewvc/llvm-project?rev=331893=rev Log: [X86] Only enable the __ud2 and __int2c builtins if intrin.h has been included. Differential Revision: https://reviews.llvm.org/D46332 Modified:

[PATCH] D45900: CodeGen: Fix invalid bitcast for lifetime.start/end

yaxunl added a comment. In https://reviews.llvm.org/D45900#1083377, @rjmccall wrote: > Oh, I see, it's not that the lifetime intrinsics don't handle pointers in the > alloca address space, it's that we might have already promoted them into > `DefaultAS`. > > Do the LLVM uses of lifetime

  1   2   >