[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 146999. nik added a comment. Addressed inline nit. Repository: rC Clang https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Index/complete-and-plugins.c Index: test/Index/complete-and-plugins.c ==

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. If this is fine now, please submit as I don't have the permissions to do so. Repository: rC Clang https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz updated this revision to Diff 147002. Typz marked 6 inline comments as done. Typz added a comment. Address review comment & rebase Repository: rC Clang https://reviews.llvm.org/D43290 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/Form

Re: r332314 - [AST] Fix printing tag decl groups in decl contexts

On Tue, May 15, 2018 at 7:30 PM, Joel E. Denny wrote: > Hi Hans, > > On Tue, May 15, 2018 at 6:23 AM, Hans Wennborg wrote: >> >> This broke the ast-print-record-decl.c test on Windows, see for >> example >> http://lab.llvm.org:8011/builders/clang-with-thin-lto-windows/builds/9066 >> >> One way to

r332434 - clang-format: tweak formatting of variable initialization blocks

Author: typz Date: Wed May 16 01:03:52 2018 New Revision: 332434 URL: http://llvm.org/viewvc/llvm-project?rev=332434&view=rev Log: clang-format: tweak formatting of variable initialization blocks Summary: This patch changes the behavior of PenaltyBreakBeforeFirstCallParameter so that is does not

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rC332434: clang-format: tweak formatting of variable initialization blocks (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D43290?vs=147002&id=147003#toc Repository:

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz updated this revision to Diff 147005. Typz marked 3 inline comments as done. Typz added a comment. Rebase on latest master & address review comments Repository: rC Clang https://reviews.llvm.org/D42684 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Forma

r332436 - clang-format: Allow optimizer to break template declaration.

Author: typz Date: Wed May 16 01:25:03 2018 New Revision: 332436 URL: http://llvm.org/viewvc/llvm-project?rev=332436&view=rev Log: clang-format: Allow optimizer to break template declaration. Summary: Introduce `PenaltyBreakTemplateDeclaration` to control the penalty, and change `AlwaysBreakTempl

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332436: clang-format: Allow optimizer to break template declaration. (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42684?

[PATCH] D46906: [clangd] Fix a link failure in unittests

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz updated this revision to Diff 147011. Typz added a comment. Rebase on latest master Repository: rC Clang https://reviews.llvm.org/D43015 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/T

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46906: [clangd] Fix a link failure in unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rL332438: [clangd] Fix a link failure in unittests (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46906 Files: clang-tools

[clang-tools-extra] r332438 - [clangd] Fix a link failure in unittests

Author: aheejin Date: Wed May 16 01:53:57 2018 New Revision: 332438 URL: http://llvm.org/viewvc/llvm-project?rev=332438&view=rev Log: [clangd] Fix a link failure in unittests Summary: D46524 (rL332378) introduced a link failure when built with `-DSHARED_LIB=ON`, which this patch fixes. Reviewers

[PATCH] D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: modernize/UseAutoCheck.cpp:40 +? Alpha +: (std::isspace(C) || (!RemoveStars && C == '*')) ? Space + : Pu

[PATCH] D33440: clang-format: better handle statement macros

Typz updated this revision to Diff 147024. Typz added a comment. Herald added a subscriber: mgrang. Rebase on latest master Repository: rC Clang https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenL

[PATCH] D46932: [AArch64] Correct inline assembly test case for S modifier [NFC]

peter.smith created this revision. peter.smith added reviewers: t.p.northover, manojgupta. Herald added subscribers: kristof.beyls, eraman, rengolin. Herald added a reviewer: javed.absar. The existing test for the AArch64 constraint S uses the A and L modifiers. These modifiers were implemented i

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. In https://reviews.llvm.org/D37813#958222, @klimek wrote: > Some initial design work has been done, and Krasimir said that he's > interested. No timeline though :( @klimek , @krasimir : any progress on this new preprocessor-like way to configure macros ? Repository:

[PATCH] D37813: clang-format: better handle namespace macros

Typz updated this revision to Diff 147027. Typz added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D37813 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp lib/Format/NamespaceEndCommentsFixer.cpp

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

avsej added a comment. Herald added a subscriber: chrib. A modified version of this patch (v8-6.7.17-fix-gcc-unwind-header.patch ) has been integrated in Fedora Linux and will be accessible in v8-6.7.17-4.

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz updated this revision to Diff 147031. Typz added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D32478 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format/Format

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:101 +// we check whether it starts with PROTO_HEADER_COMMENT. +bool isPrivateProtoSymbol(const NamedDecl &ND) { + const auto &SM = ND.getASTContext().getSourceManager(); sammccall wrote:

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ioeric updated this revision to Diff 147032. ioeric marked an inline comment as done. ioeric added a comment. - Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46751 Files: clangd/ClangdLSPServer.cpp clangd/SourceCode.cpp clangd/SourceCode.h clan

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ioeric added a comment. > ...I hadn't noticed the latest version. I think it's safe enough in the new > version that we don't need to discuss this much further until it becomes a > bigger problem (more libraries, etc). Sounds good, thanks! @ilya-biryukov Could you take another look at the patc

[PATCH] D46891: [StaticAnalyzer] Added a getLValue method to ProgramState for bases

Szelethus updated this revision to Diff 147033. Szelethus edited the summary of this revision. Szelethus added a comment. Added a `CXXRecordDecl` version. https://reviews.llvm.org/D46891 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h Index: include/clang/StaticAnalyze

r332448 - [diagtool] Add diagtool to install target.

Author: jdevlieghere Date: Wed May 16 03:23:25 2018 New Revision: 332448 URL: http://llvm.org/viewvc/llvm-project?rev=332448&view=rev Log: [diagtool] Add diagtool to install target. Although not very well known, diagtool is an incredibly convenient utility for dealing with diagnostics. Particular

[PATCH] D46694: [diagtool] Install diagtool

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL332448: [diagtool] Add diagtool to install target. (authored by JDevlieghere, committed by ). Changed prior to commit:

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

aemerson abandoned this revision. aemerson added a comment. In https://reviews.llvm.org/D40864#1100492, @dexonsmith wrote: > Did this eventually go in? No, this approach was superseded. I will upstream a new implementation in the near future. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D46927: Augmented Assignment for Fixed Point Types

lebedev.ri added a comment. Hi @leonardchan. Could you please prepend some appropriate tag to the subjects of all your differentials, so it is less hard to read through cfe-commits mails, please? Repository: rC Clang https://reviews.llvm.org/D46927

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 147039. yvvan marked 4 inline comments as done. yvvan added a comment. Append PrintingCodeCompleteConsumer and CompilerInvocation options, add CodeCompletion tests. https://reviews.llvm.org/D41537 Files: include/clang/Driver/CC1Options.td include/clang/S

[PATCH] D46862: Optionally add code completion results for arrow instead of dot (libclang)

yvvan updated this revision to Diff 147042. yvvan added a comment. The base revision has changed - some minor changes were also required here. https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp tools/c-index-test/c-index-test.c tools/libclan

Re: r332436 - clang-format: Allow optimizer to break template declaration.

This change broke `test/Index/overriding-ftemplate-comments.cpp` on Red Hat Fedora 28. Was this expected? > On May 16, 2018, at 4:25 AM, Francois Ferrand via cfe-commits > wrote: > > Author: typz > Date: Wed May 16 01:25:03 2018 > New Revision: 332436 > > URL: http://llvm.org/viewvc/llvm-proj

[PATCH] D46891: [StaticAnalyzer] Added a getLValue method to ProgramState for bases

Szelethus updated this revision to Diff 147045. Szelethus added a comment. Fixed a typo. https://reviews.llvm.org/D46891 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h Index: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h ==

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous added a comment. Eric, thanks for the context. I am now clarifying internally and if possible would like to simplify the whole format business by using just one delimiter everywhere. Would that make sense to you or do you think we should respect delimiter used in sources? https://revi

[PATCH] D46820: Fix __uuidof handling on non-type template parameter in C++17

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm, but: Comment at: test/SemaCXX/PR24986.cpp:12 + f<&__uuidof(0)>(); +} Maybe this test could be in test/SemaCXX/ms-uuid.cpp instead? Repository: rC

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso updated this revision to Diff 147050. CarlosAlbertoEnciso edited the summary of this revision. CarlosAlbertoEnciso added a comment. Address the issues raised by the reviewer (rsmith). https://reviews.llvm.org/D46190 Files: include/clang/Sema/Sema.h lib/Sema/Sema.cpp li

[PATCH] D46937: [Timers] TimerGroup::printJSONValue(): print doubles with no precision loss

lebedev.ri created this revision. lebedev.ri added reviewers: george.karpenkov, NoQ, alexfh, sbenza. Herald added a subscriber: llvm-commits. lebedev.ri added a dependent revision: D46938: [Timers] TimerGroup: make printJSONValues() method public. lebedev.ri added a dependency: D46936: [Timers] Ti

[PATCH] D46936: [Timers] TimerGroup::printJSONValues(): print mem timer with .mem suffix

lebedev.ri created this revision. lebedev.ri added reviewers: george.karpenkov, NoQ, alexfh, sbenza. Herald added a subscriber: llvm-commits. lebedev.ri added a dependent revision: D46937: [Timers] TimerGroup::printJSONValue(): print doubles with no precision loss. We have just used `.sys` suffix

[PATCH] D46939: [Timers] TimerGroup: add constructor from StringMap

lebedev.ri created this revision. lebedev.ri added reviewers: george.karpenkov, NoQ, alexfh, sbenza. Herald added a subscriber: llvm-commits. lebedev.ri added a dependency: D46938: [Timers] TimerGroup: make printJSONValues() method public. lebedev.ri added a dependent revision: D46602: [clang-tidy

[PATCH] D46938: [Timers] TimerGroup: make printJSONValues() method public

lebedev.ri created this revision. lebedev.ri added reviewers: george.karpenkov, NoQ, alexfh, sbenza. Herald added a subscriber: llvm-commits. lebedev.ri added a dependent revision: D46939: [Timers] TimerGroup: add constructor from StringMap. lebedev.ri added a dependency: D46937: [Timers] TimerGro

[PATCH] D46603: [Support] TimerGroup changes

lebedev.ri abandoned this revision. lebedev.ri added a comment. In https://reviews.llvm.org/D46603#1100455, @george.karpenkov wrote: > I see four separate changes: s/.sys/mem one (can be committed without > review), exposing printJSONValues and consequent adding of a lock, adding a > constructo

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:274 WorkspaceEdit WE; WE.changes = {{Params.textDocument.uri.uri(), Edits}}; reply(WE); NIT: not related to this change, but maybe use `std::move(Edits)` to avo

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ioeric updated this revision to Diff 147058. ioeric marked 3 inline comments as done. ioeric added a comment. - Merge remote-tracking branch 'origin/master' into proto - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46751 Files: clangd/index/Symbol

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r332456 - [clangd] Filter out private proto symbols in SymbolCollector.

Author: ioeric Date: Wed May 16 05:12:30 2018 New Revision: 332456 URL: http://llvm.org/viewvc/llvm-project?rev=332456&view=rev Log: [clangd] Filter out private proto symbols in SymbolCollector. Summary: This uses heuristics to identify private proto symbols. For example, top-level symbols whose

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332456: [clangd] Filter out private proto symbols in SymbolCollector. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46751

[PATCH] D45999: [clangd] Retrieve minimally formatted comment text in completion.

ilya-biryukov updated this revision to Diff 147060. ilya-biryukov added a comment. Rebase onto head, fix merge conflicts Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45999 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/CodeCompletionStrings.cpp clangd/Cod

Re: r332436 - clang-format: Allow optimizer to break template declaration.

I can also reproduce on my local machine (Debian). On Wed, May 16, 2018 at 1:01 PM David Zarzycki via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This change broke `test/Index/overriding-ftemplate-comments.cpp` on Red > Hat Fedora 28. Was this expected? > > > On May 16, 2018, at 4:25 AM, F

r332457 - [CodeComplete] Expose helpers to get RawComment of completion result.

Author: ibiryukov Date: Wed May 16 05:30:01 2018 New Revision: 332457 URL: http://llvm.org/viewvc/llvm-project?rev=332457&view=rev Log: [CodeComplete] Expose helpers to get RawComment of completion result. Summary: Used in clangd, see D45999. Reviewers: sammccall, hokein, ioeric, arphaman Revie

r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

Author: ibiryukov Date: Wed May 16 05:30:09 2018 New Revision: 332458 URL: http://llvm.org/viewvc/llvm-project?rev=332458&view=rev Log: [AST] Added a helper to extract a user-friendly text of a comment. Summary: The helper is used in clangd for documentation shown in code completion and storing t

[PATCH] D46001: [CodeComplete] Expose helpers to get RawComment of completion result.

This revision was automatically updated to reflect the committed changes. Closed by commit rC332457: [CodeComplete] Expose helpers to get RawComment of completion result. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D46001?vs=146812&id=147061#toc Re

[PATCH] D46000: [AST] Added a helper to extract a user-friendly text of a comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332458: [AST] Added a helper to extract a user-friendly text of a comment. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/

[clang-tools-extra] r332460 - [clangd] Parse all comments in Sema and completion.

Author: ibiryukov Date: Wed May 16 05:32:49 2018 New Revision: 332460 URL: http://llvm.org/viewvc/llvm-project?rev=332460&view=rev Log: [clangd] Parse all comments in Sema and completion. Summary: And add tests for the comment extraction code. clangd will now show non-doxygen comments in complet

[clang-tools-extra] r332459 - [clangd] Retrieve minimally formatted comment text in completion.

Author: ibiryukov Date: Wed May 16 05:32:44 2018 New Revision: 332459 URL: http://llvm.org/viewvc/llvm-project?rev=332459&view=rev Log: [clangd] Retrieve minimally formatted comment text in completion. Summary: Previous implementation used to extract brief text from doxygen comments. Brief text p

[PATCH] D46002: [clangd] Parse all comments in Sema and completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE332460: [clangd] Parse all comments in Sema and completion. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D46002?vs=146831&id=147064#toc Repository: rCTE

[PATCH] D45999: [clangd] Retrieve minimally formatted comment text in completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE332459: [clangd] Retrieve minimally formatted comment text in completion. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D45999?vs=147060&id=147063#toc Repo

r332463 - [analyzer] Improve the modeling of memset().

Author: henrywong Date: Wed May 16 05:37:53 2018 New Revision: 332463 URL: http://llvm.org/viewvc/llvm-project?rev=332463&view=rev Log: [analyzer] Improve the modeling of memset(). Since there is no perfect way bind the non-zero value with the default binding, this patch only considers the case

[PATCH] D44934: [analyzer] Improve the modeling of `memset()`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332463: [analyzer] Improve the modeling of memset(). (authored by henrywong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44934?vs=146816&i

Re: r332436 - clang-format: Allow optimizer to break template declaration.

OK, I'll send a fix for the index test. Please make sure you run all clang tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a patch! Thanks! On Wed, May 16, 2018 at 2:32 PM Eric Liu wrote: > I can also reproduce on my local machine (Debian). > > On Wed, May 16, 2018 at 1:

r332454 - Test commit access: remove superflous spaces

Author: martong Date: Wed May 16 04:48:11 2018 New Revision: 332454 URL: http://llvm.org/viewvc/llvm-project?rev=332454&view=rev Log: Test commit access: remove superflous spaces Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL: http://llvm.org/vie

[PATCH] D46905: [Attr] Don't print fake MSInheritance argument

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D46905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

r332465 - Fix an Index test caused by a clang-format change (r332436).

Author: ioeric Date: Wed May 16 05:58:13 2018 New Revision: 332465 URL: http://llvm.org/viewvc/llvm-project?rev=332465&view=rev Log: Fix an Index test caused by a clang-format change (r332436). Modified: cfe/trunk/test/Index/overriding-ftemplate-comments.cpp Modified: cfe/trunk/test/Index/ov

Re: r332436 - clang-format: Allow optimizer to break template declaration.

This should be fixed by r332465 On Wed, May 16, 2018 at 2:50 PM Eric Liu wrote: > OK, I'll send a fix for the index test. Please make sure you run all clang > tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a > patch! Thanks! > > On Wed, May 16, 2018 at 2:32 PM Eric Liu

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

r.stahl created this revision. r.stahl added reviewers: a.sidorin, klimek. Herald added subscribers: cfe-commits, martong. If an AST node is imported after a call to getParents in the ToCtx, it was no longer possible to retrieve its parents since the old results were cached. Valid types for getP

[PATCH] D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext

aaron.ballman added a comment. Can you roll back the changes in MatchVerifier.h? Phab is telling me that the only changes are to whitespace. Comment at: lib/AST/DeclBase.cpp:1353 +static bool shouldBeHidden(NamedDecl *D); + Rather than make a hanging forward

[PATCH] D46439: [Sema] Fix incorrect packed aligned structure layout

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D46439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions.

aaron.ballman added a comment. In https://reviews.llvm.org/D45702#1097294, @shuaiwang wrote: > Addressed review comments. This patch was approved; do you need someone to commit this for you? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45702 _

[PATCH] D46602: [clang-tidy] Store checks profiling info as YAML files

lebedev.ri updated this revision to Diff 147071. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. - Rebased - Slightly refactor how the profile storage params are computed, move that into `ClangTidyProfiling::StorageParams` helper struct. - Store timestamp in the json t

r332467 - [OPENMP, NVPTX] Add check for SPMD mode in orphaned parallel directives.

Author: abataev Date: Wed May 16 06:36:30 2018 New Revision: 332467 URL: http://llvm.org/viewvc/llvm-project?rev=332467&view=rev Log: [OPENMP, NVPTX] Add check for SPMD mode in orphaned parallel directives. If the orphaned directive is executed in SPMD mode, we need to emit the check for the SPMD

[PATCH] D46867: [ASTImporter] Add unit tests for structural equivalence

a.sidorin added a comment. Hello Gabor! Thank you for this patch! Do you plan to enable this functionality for AST import checking? Some comments are inline. Comment at: unittests/AST/Language.h:1 +//===- unittest/AST/Language.h - AST unit test support ---===// +/

[PATCH] D46942: Make sure getCanonicalName returns absolute paths even on VFS.

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added a subscriber: cfe-commits. Generally, canonical paths are expected to be absolute. This is the behavior for Windows build. But for unix, it might return relative paths when failing to resolve real path (e.g. unsupported s

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rL332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4605

r332469 - [Frontend] Avoid running plugins during code completion parse

Author: yvvan Date: Wed May 16 06:50:05 2018 New Revision: 332469 URL: http://llvm.org/viewvc/llvm-project?rev=332469&view=rev Log: [Frontend] Avoid running plugins during code completion parse The parsing that is done for code completion is a special case that will discard any generated diagnost

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rC332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D46050?vs=146999&id=147077#toc Repository:

[PATCH] D43183: clang-format: introduce `CaseBlockIndent` to control indent in switch

Typz updated this revision to Diff 147079. Typz added a comment. rebase Repository: rC Clang https://reviews.llvm.org/D43183 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cp

r332470 - Add support for __declspec(code_seg("segname"))

Author: erichkeane Date: Wed May 16 06:57:17 2018 New Revision: 332470 URL: http://llvm.org/viewvc/llvm-project?rev=332470&view=rev Log: Add support for __declspec(code_seg("segname")) Add support for __declspec(code_seg("segname")) This patch is built on the existing support for #pragma code_se

[PATCH] D43352: Add support for __declspec(code_seg("segname"))

This revision was automatically updated to reflect the committed changes. Closed by commit rC332470: Add support for __declspec(code_seg("segname")) (authored by erichkeane, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D43352?vs=1470

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Herald added subscribers: mgrang, jkorous, MaskRay, klimek. This should, arguably, give better ranking. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46943 Files: clangd/AST.cpp clangd/A

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a.sidorin added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D44100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46944: [analyzer] Use sufficiently large types for index/size calculation.

ebevhan created this revision. ebevhan added reviewers: dergachev.a, dcoughlin. Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun. Herald added a reviewer: george.karpenkov. RegionStoreManager::getSizeInElements used 'int' for size calculations, and ProgramState::assumeInBound fe

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ioeric added inline comments. Comment at: clangd/Quality.cpp:24 + if (SemaCCResult.Declaration) +AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration); if (SemaCCResult.Availability == CXAvailability_Deprecated) Could you explain why `AllDecls

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

a.sidorin added a comment. Hello Rafael, The patch is awesome. The only thing I'm uncomfortable with is that we call invalidation on every stmt import - not only during the top-level one. Fixing this requires separating entry point from internal imports and is out of scope of this patch, but a

r332473 - [OpenCL] make test independent of optimizer

Author: spatel Date: Wed May 16 07:38:07 2018 New Revision: 332473 URL: http://llvm.org/viewvc/llvm-project?rev=332473&view=rev Log: [OpenCL] make test independent of optimizer There shouldn't be any tests that run the entire optimizer here, but the last test in this file is definitely going to b

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > The deprecated enumerator is also referenced by > `tools/c-index-test/c-index-test.c` This test prompted me to keep the IncludeTagDefinition member in PrintingPolicy so that clang_PrintingPolicy_getProperty w

r332474 - [Attr] Don't print fake MSInheritance argument

Author: jdenny Date: Wed May 16 07:51:18 2018 New Revision: 332474 URL: http://llvm.org/viewvc/llvm-project?rev=332474&view=rev Log: [Attr] Don't print fake MSInheritance argument This was discovered at: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html Reviewed by: a

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Thanks for your consideration https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

r.stahl added inline comments. Comment at: lib/AST/ASTImporter.cpp:6755 + auto ToE = cast_or_null(Import(cast(FromE))); + if (ToE) +ToContext.invalidateParents(); a.sidorin wrote: > We already do the invalidation in Import(Stmt), so it looks redundant here.

[PATCH] D46944: [analyzer] Use sufficiently large types for index/size calculation.

a.sidorin added a comment. This is a nice extension of https://reviews.llvm.org/D16063. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1344 // This is a signed value, since it's used in arithmetic with signed indices. - return svalBuilder.makeIntVal(RegionSize / EleSiz

[PATCH] D46944: [analyzer] Use sufficiently large types for index/size calculation.

a.sidorin added inline comments. Comment at: test/Analysis/array-index.c:11 + +void fie() { + buf[SIZE-1] = 1; Could you please give meaningful names to the tests? Repository: rC Clang https://reviews.llvm.org/D46944 _

r332477 - [OPENMP] DO not crash on combined constructs in declare target

Author: abataev Date: Wed May 16 08:08:32 2018 New Revision: 332477 URL: http://llvm.org/viewvc/llvm-project?rev=332477&view=rev Log: [OPENMP] DO not crash on combined constructs in declare target functions. If the combined construct is specified in the declare target function and the device code

r332481 - [Attr] Don't print fake MSInheritance argument

Author: jdenny Date: Wed May 16 08:18:30 2018 New Revision: 332481 URL: http://llvm.org/viewvc/llvm-project?rev=332481&view=rev Log: [Attr] Don't print fake MSInheritance argument This was discovered at: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html Reviewed by: a

r332480 - Revert r332474: [Attr] Don't print fake MSInheritance argument

Author: jdenny Date: Wed May 16 08:18:27 2018 New Revision: 332480 URL: http://llvm.org/viewvc/llvm-project?rev=332480&view=rev Log: Revert r332474: [Attr] Don't print fake MSInheritance argument I botched the commit log attributes. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/tru

[PATCH] D46905: [Attr] Don't print fake MSInheritance argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL332481: [Attr] Don't print fake MSInheritance argument (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46905?vs=146923&id

[PATCH] D46950: Fix duplicate class template definitions problem

martong created this revision. martong added reviewers: a.sidorin, xazax.hun, szepet. Herald added subscribers: cfe-commits, dkrupp, rnkovacs. We fail to import a `ClassTemplateDecl` if the "To" context already contains a definition and then a forward decl. This is because `localUncachedLookup` d

[PATCH] D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode

alexfh created this revision. alexfh added reviewers: klimek, ilya-biryukov. Herald added a subscriber: xazax.hun. This addresses https://bugs.llvm.org/show_bug.cgi?id=37467. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46951 Files: clang-tidy/misc/UnusedParametersCheck.cpp

[PATCH] D46659: [clang-tidy/google-readability-casting] Allow C-style casts to/from Objective-C object types

benhamilton updated this revision to Diff 147102. benhamilton added a comment. - Change to simply disable check for Objective-C++ Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46659 Files: clang-tidy/google/AvoidCStyleCastsCheck.cpp test/clang-tidy/google-readability-casti

[PATCH] D46659: [clang-tidy/google-readability-casting] Disable check for Objective-C++

benhamilton added a comment. After discussion, I changed this diff to simply disable the check altogether for Objective-C++. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46659 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D46944: [analyzer] Use sufficiently large types for index/size calculation.

ebevhan added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1344 // This is a signed value, since it's used in arithmetic with signed indices. - return svalBuilder.makeIntVal(RegionSize / EleSize, false); + return svalBuilder.makeIntVal(RegionSize / El

[PATCH] D46958: [ASTImporter] Fix missing implict CXXRecordDecl

martong created this revision. martong added reviewers: xazax.hun, a.sidorin, szepet. Herald added subscribers: cfe-commits, dkrupp, rnkovacs. Implicit CXXRecordDecl is not added to its DeclContext during import, but in the original AST it is. This patch fixes this. Repository: rC Clang https

[PATCH] D46944: [analyzer] Use sufficiently large types for index/size calculation.

a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1344 // This is a signed value, since it's used in arithmetic with signed indices. - return svalBuilder.makeIntVal(RegionSize / EleSize, false); + return svalBuilder.makeIntVal(RegionSize /

  1   2   3   >