[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

2018-06-14 Thread Balogh , Ádám via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC334804: [ASTImporter] Corrected diagnostic client handling in tests. (authored by baloghadamsoftware, committed by ). Changed prior to commit: https://reviews.llvm.org/D47445?vs=149412&id=151459#toc Re

r334804 - [ASTImporter] Corrected diagnostic client handling in tests.

2018-06-14 Thread Adam Balogh via cfe-commits
Author: baloghadamsoftware Date: Thu Jun 14 23:45:39 2018 New Revision: 334804 URL: http://llvm.org/viewvc/llvm-project?rev=334804&view=rev Log: [ASTImporter] Corrected diagnostic client handling in tests. ASTImporter tests may produce source file related warnings, the diagnostic client should be

r334801 - [Format] Do not use a global static value for EOF within ScopedMacroState.

2018-06-14 Thread David L. Jones via cfe-commits
Author: dlj Date: Thu Jun 14 23:08:54 2018 New Revision: 334801 URL: http://llvm.org/viewvc/llvm-project?rev=334801&view=rev Log: [Format] Do not use a global static value for EOF within ScopedMacroState. ScopedMacroState injects its own EOF token under certain conditions, and the returned token

[PATCH] D47759: [Format] Do not use a global static value for EOF within ScopedMacroState.

2018-06-14 Thread David L. Jones via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334801: [Format] Do not use a global static value for EOF within ScopedMacroState. (authored by dlj, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[libunwind] r334798 - Creating release candidate rc3 from release_601 branch

2018-06-14 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Thu Jun 14 22:05:43 2018 New Revision: 334798 URL: http://llvm.org/viewvc/llvm-project?rev=334798&view=rev Log: Creating release candidate rc3 from release_601 branch Added: libunwind/tags/RELEASE_601/rc3/ - copied from r334797, libunwind/branches/release_60/ ___

[libcxx] r334791 - Creating release candidate rc3 from release_601 branch

2018-06-14 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Thu Jun 14 22:05:12 2018 New Revision: 334791 URL: http://llvm.org/viewvc/llvm-project?rev=334791&view=rev Log: Creating release candidate rc3 from release_601 branch Added: libcxx/tags/RELEASE_601/rc3/ (props changed) - copied from r334790, libcxx/branches/rele

[libcxxabi] r334792 - Creating release candidate rc3 from release_601 branch

2018-06-14 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Thu Jun 14 22:05:16 2018 New Revision: 334792 URL: http://llvm.org/viewvc/llvm-project?rev=334792&view=rev Log: Creating release candidate rc3 from release_601 branch Added: libcxxabi/tags/RELEASE_601/rc3/ - copied from r334791, libcxxabi/branches/release_60/ ___

[PATCH] D47759: [Format] Do not use a global static value for EOF within ScopedMacroState.

2018-06-14 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. Repository: rC Clang https://reviews.llvm.org/D47759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D48208: [Fuchsia] Enable static libc++, libc++abi, libunwind

2018-06-14 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, chrib, mgorny. Herald added a reviewer: EricWF. This is needed for building Fuchsia drivers. Repository: rC Clang https://reviews.llvm.org/D48208 Files: clang/cmake/caches/Fuchsia-stage2

[PATCH] D48206: IRgen: Mark aliases of ctors and dtors as unnamed_addr.

2018-06-14 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. pcc added a reviewer: rsmith. This is not only semantically correct but ensures that they will not be marked as address-significant once https://reviews.llvm.org/D48155 lands. https://reviews.llvm.org/D48206 Files: clang/lib/CodeGen/CGCXX.cpp clang/lib/CodeGen/Cod

[PATCH] D48205: [analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol.

2018-06-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. `nonloc::SymbolVal` that contains a pointer-type or reference-type symbol is ill-formed; our code isn't

[PATCH] D48204: [analyzer] Make getDerefExpr() skip cleanups.

2018-06-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. This is supposed to suppress a few Inlined-Defensive-Checks-related false positives that accidentally spiked up during my testing of copy elision. Repository: rC Clang https://reviews.llvm.org/D48204 ___ cfe-commits mailing

[PATCH] D48204: [analyzer] Make getDerefExpr() skip cleanups.

2018-06-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware, eraman. `ExprWithCleanups` that cleans up function arguments (or any other stuff) at the end of the fu

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

2018-06-14 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak added a comment. Sorry, I missed that. LGTM, I would consider adding ObjC method expression tests (multiline string as an argument). Will look into that next week. Repository: rL LLVM https://reviews.llvm.org/D47393 ___ cfe-commits mail

r334780 - [cmake] Add linker detection for Apple platforms

2018-06-14 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Thu Jun 14 16:26:33 2018 New Revision: 334780 URL: http://llvm.org/viewvc/llvm-project?rev=334780&view=rev Log: [cmake] Add linker detection for Apple platforms LLVM currently assumes that Apple platforms will always use ld64. In the future, LLD Mach-O might also be supporte

r334778 - Modules: Fix implicit output file for .cppm to .pcm instead of stdout

2018-06-14 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Thu Jun 14 16:09:06 2018 New Revision: 334778 URL: http://llvm.org/viewvc/llvm-project?rev=334778&view=rev Log: Modules: Fix implicit output file for .cppm to .pcm instead of stdout This code was introduced back in r178148, a change to introduce -module-file-info - which st

[PATCH] D46915: [Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals

2018-06-14 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 151433. leonardchan added a comment. - Removed the functions for performing casting between fixed point types to a common type when performing a binary operation since operations should be performed on the types as is. Also this patch is meant more for d

[PATCH] D47759: [Format] Do not use a global static value for EOF within ScopedMacroState.

2018-06-14 Thread David L. Jones via Phabricator via cfe-commits
dlj added a comment. Ping... Repository: rC Clang https://reviews.llvm.org/D47759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46915: [Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals

2018-06-14 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 151431. leonardchan added a comment. Removed FractFBits property. Fractional bits for _Fract types are now one less the _Fract width unless `SameFBits` is specified. In that case, the number of FBits in unsigned _Fract is the same as that of signed _Frac

r334773 - [X86] Rename __builtin_ia32_pslldqi128 to __builtin_ia32_pslldqi128_byteshift and similar for other sizes. Remove the multiply by 8 from the header files.

2018-06-14 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Jun 14 15:02:35 2018 New Revision: 334773 URL: http://llvm.org/viewvc/llvm-project?rev=334773&view=rev Log: [X86] Rename __builtin_ia32_pslldqi128 to __builtin_ia32_pslldqi128_byteshift and similar for other sizes. Remove the multiply by 8 from the header files. The pre

[PATCH] D47953: [builtin] Add bitfield support for __builtin_dump_struct

2018-06-14 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. This seems to be missing tests. Repository: rC Clang https://reviews.llvm.org/D47953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47953: [builtin] Add bitfield support for __builtin_dump_struct

2018-06-14 Thread Paul Semel via Phabricator via cfe-commits
paulsemel added a comment. ping :) @aaron.ballman Repository: rC Clang https://reviews.llvm.org/D47953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46915: [Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals

2018-06-14 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added inline comments. Comment at: include/clang/Basic/TargetInfo.h:89 + // corresponding unsaturated types. + unsigned char ShortAccumFBits, ShortAccumIBits; + unsigned char AccumFBits, AccumIBits; ebevhan wrote: > leonardchan wrote: > > ebevhan w

r334763 - [c++17] If a class inherits virtual functions from a base class, it is

2018-06-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 14 13:03:22 2018 New Revision: 334763 URL: http://llvm.org/viewvc/llvm-project?rev=334763&view=rev Log: [c++17] If a class inherits virtual functions from a base class, it is not an aggregtae. Modified: cfe/trunk/lib/AST/DeclCXX.cpp cfe/trunk/test/CXX/dcl.decl

[PATCH] D48188: [SPIR] Prevent SPIR targets from using half conversion intrinsics

2018-06-14 Thread Stephen McGroarty via Phabricator via cfe-commits
smcgro created this revision. smcgro added reviewers: SjoerdMeijer, rsmith. Herald added a subscriber: cfe-commits. The SPIR target currently allows for half precision floating point types to use the LLVM intrinsic functions to convert to floats and doubles. This is illegal in SPIR as the only i

[PATCH] D48187: [Intrinsics] Add/move some builtin declarations in intrin.h to get ms-intrinsics.c to not issue warnings

2018-06-14 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added a reviewer: rnk. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. __ud2 and __int2c were missing declarations entirely. And the bitscans were only under __x86_64__, but they seem to be in BuiltinsARM.def as well

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

2018-06-14 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D41168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r334741 - [X86] Lowering Mask Scalar intrinsics to native IR (Clang part)

2018-06-14 Thread Tomasz Krupa via cfe-commits
Author: tkrupa Date: Thu Jun 14 10:36:23 2018 New Revision: 334741 URL: http://llvm.org/viewvc/llvm-project?rev=334741&view=rev Log: [X86] Lowering Mask Scalar intrinsics to native IR (Clang part) Summary: Lowering add, sub, mul, and div mask scalar intrinsic calls to native IR. Reviewers: craig

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

2018-06-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334751: [X86] Add inline assembly versions of _InterlockedExchange_HLEAcquire/Release… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r334751 - [X86] Add inline assembly versions of _InterlockedExchange_HLEAcquire/Release and _InterlockedCompareExchange_HLEAcquire/Release for MSVC compatibility.

2018-06-14 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Jun 14 11:43:52 2018 New Revision: 334751 URL: http://llvm.org/viewvc/llvm-project?rev=334751&view=rev Log: [X86] Add inline assembly versions of _InterlockedExchange_HLEAcquire/Release and _InterlockedCompareExchange_HLEAcquire/Release for MSVC compatibility. Clang/LLV

r334747 - [CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2

2018-06-14 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Jun 14 11:20:04 2018 New Revision: 334747 URL: http://llvm.org/viewvc/llvm-project?rev=334747&view=rev Log: [CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2 On MacOS, if CMAKE_OSX_SYSROOT is used and the user has command line tools installed

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

2018-06-14 Thread Tomasz Krupa via Phabricator via cfe-commits
tkrupa updated this revision to Diff 151382. tkrupa added a comment. Fixed rounding mode calls. Repository: rC Clang https://reviews.llvm.org/D41168 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c test/CodeGen/avx512f-builtins.c test/CodeGen/avx512vl-builtins.c test/Co

[PATCH] D48100: Append new attributes to the end of an AttributeList.

2018-06-14 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur marked an inline comment as done. Meinersbur added a comment. In https://reviews.llvm.org/D48100#1132208, @aaron.ballman wrote: > Can you also simplify `hasSameOverloadableAttrs()` in ASTReaderDecl.cpp > similar to what you did in SemaOverload.cpp (the copy seems spurious)? Changed

[PATCH] D47979: [X86] Lowering Mask Scalar add/sub/mul/div intrinsics to native IR (Clang part)

2018-06-14 Thread Tomasz Krupa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC334741: [X86] Lowering Mask Scalar intrinsics to native IR (Clang part) (authored by tkrupa, committed by ). Changed prior to commit: https://reviews.llvm.org/D47979?vs=150617&id=151381#toc Repository:

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

2018-06-14 Thread Ben Hamilton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334739: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for… (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D48100: Append new attributes to the end of an AttributeList.

2018-06-14 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur updated this revision to Diff 151378. Meinersbur marked an inline comment as done. Meinersbur added a comment. - Remove FIXME - Add comment about O(n^2) execution time when adding attributes - Do not store enable_if attributes in temporary list Repository: rC Clang https://reviews.

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

2018-06-14 Thread Yunlian Jiang via Phabricator via cfe-commits
yunlian added a comment. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

2018-06-14 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added a comment. I'll just land it for you. Repository: rC Clang https://reviews.llvm.org/D47393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46915: [Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals

2018-06-14 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added inline comments. Comment at: lib/Sema/SemaExpr.cpp:1248 + bool RHSFixed = RHSType->isFixedPointType(); + + if (LHSFixed && RHSFixed) { ebevhan wrote: > leonardchan wrote: > > ebevhan wrote: > > > leonardchan wrote: > > > > ebevhan wrote: > > > > >

[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Oops, forgot to link to the bundling patch: https://reviews.llvm.org/D47957 We should expect some conflicts one way or the other. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48163 ___ cfe-commits mailin

[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:187 + // Whether or not this candidate is in a completion where index is allowed. + // This can affect how items are built (e.g. indent label to align with visual + // indicator in index results). --

[PATCH] D47935: [clangd] Boost completion score according to file proximity.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clangd/Quality.cpp:185 + } + if (F == Fs.begin() && T == Ts.begin()) // No common directory. +return 0; sammccall wrote: > why is this a special case? > - /x/a/b vs /x/a/c is 1 up + 1 down --> 0.59 > - /a/b vs /a/

[PATCH] D47935: [clangd] Boost completion score according to file proximity.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 151358. ioeric marked 6 inline comments as done. ioeric added a comment. - addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47935 Files: clangd/CodeComplete.cpp clangd/Quality.cpp clangd/Quality.h unittests/cl

[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clangd/CodeComplete.cpp:278 +if (AllowIndexCompletion) + I.label = (InsertingInclude ? "+" : " ") + I.label; I.scoreInfo = Scores; sammccall wrote: > I think we should avoid tokens that occur commonly in C++

[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 151357. ioeric added a comment. - s/+/•/ and make the icon an code completion option to avoid hardcodes in multiple places. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48163 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clan

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

2018-06-14 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:9222 +if (CC != 4) + return nullptr; +Value *A = Builder.CreateExtractElement(Ops[0], (uint64_t)0); What does returning nullptr here do? Comment at: lib/Code

Re: r330382 - [CFG] [analyzer] Add construction contexts for loop condition variables.

2018-06-14 Thread Alexander Kornienko via cfe-commits
This commit seems to have introduced https://bugs.llvm.org/show_bug.cgi?id=37769. Could you take a look? On Fri, Apr 20, 2018 at 1:33 AM Artem Dergachev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dergachev > Date: Thu Apr 19 16:30:15 2018 > New Revision: 330382 > > URL: http:/

[PATCH] D48171: [clangd] Do not report comments that only have special chars.

2018-06-14 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric, hokein. Herald added subscribers: jkorous, MaskRay. Like the following: // --- // === // *** It does not cover all the cases, but those are definitely not very useful. Repository: rCTE Cl

[PATCH] D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents

2018-06-14 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334718: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their… (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r334718 - [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents

2018-06-14 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 14 07:53:51 2018 New Revision: 334718 URL: http://llvm.org/viewvc/llvm-project?rev=334718&view=rev Log: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents This diff includes changes for the remaining _Fract and _

[PATCH] D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents

2018-06-14 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC334718: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their… (authored by leonardchan, committed by ). Repository: rL LLVM https://reviews.llvm.org/D46911 Files: include/c

[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Ooh, bikeshed first! Comment at: clangd/CodeComplete.cpp:278 +if (AllowIndexCompletion) + I.label = (InsertingInclude ? "+" : " ") + I.label; I.scoreInfo = Scores; I think we should avoid tokens that occur commonly in C+

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

2018-06-14 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I'm not really happy with gcc's redundant declaration warnings; I think they're "nannying" rather than useful. That being said, why not just remove the declaration in `__locale`? `__locale` includes `string`, which includes `stdexcept`. Repository: rCXX libc++ h

[clang-tools-extra] r334712 - [clangd] FuzzyMatch: forbid tail-tail matches after a miss: [pat] !~ "panther"

2018-06-14 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Jun 14 06:50:30 2018 New Revision: 334712 URL: http://llvm.org/viewvc/llvm-project?rev=334712&view=rev Log: [clangd] FuzzyMatch: forbid tail-tail matches after a miss: [pat] !~ "panther" Summary: This is a small code change but vastly reduces noise in code completion r

[PATCH] D47950: [clangd] FuzzyMatch: forbid tail-tail matches after a miss: [pat] !~ "panther"

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rL334712: [clangd] FuzzyMatch: forbid tail-tail matches after a miss: [pat] !~ "panther" (authored by sammccall, committed by ). Herald added a subscriber: llvm-co

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

2018-06-14 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:10107-10112 +case 0x0b: // FALSE_OQ +case 0x1b: // FALSE_OS + return llvm::Constant::getNullValue(ConvertType(E->getType())); +case 0x0f: // TRUE_UQ +case 0x1f: // TRUE_US + return llvm:

[PATCH] D48083: [clangd] Boost keyword completions.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334711: [clangd] Boost keyword completions. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48083 Files: clang-tools-ex

[clang-tools-extra] r334711 - [clangd] Boost keyword completions.

2018-06-14 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Jun 14 06:42:21 2018 New Revision: 334711 URL: http://llvm.org/viewvc/llvm-project?rev=334711&view=rev Log: [clangd] Boost keyword completions. Summary: These have few signals other than being keywords, so the boost is high. Reviewers: ilya-biryukov Subscribers: ioer

r334709 - clang-format: Fix documentation generation

2018-06-14 Thread Francois Ferrand via cfe-commits
Author: typz Date: Thu Jun 14 06:32:14 2018 New Revision: 334709 URL: http://llvm.org/viewvc/llvm-project?rev=334709&view=rev Log: clang-format: Fix documentation generation Summary: It seems that the changes done to `ClangFormatStyleOptions.rst` @334408 are causing the generation of the documen

[PATCH] D48161: clang-format: Fix documentation generation

2018-06-14 Thread Francois Ferrand via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334709: clang-format: Fix documentation generation (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48161 Files: cfe/trunk/do

[PATCH] D48161: clang-format: Fix documentation generation

2018-06-14 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 151342. Typz added a comment. rebase Repository: rC Clang https://reviews.llvm.org/D48161 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ===

[PATCH] D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE

2018-06-14 Thread Vladimir Stefanovic via Phabricator via cfe-commits
vstefanovic created this revision. vstefanovic added reviewers: sdardis, bogden. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, atanasyan, kristof.beyls, arichardson. '-mcrc' is shared with ARM. '-mno-crc' is Mips-only (ARM uses '-mnocrc'). Repository: rC Clang h

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

2018-06-14 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D45679#1132086, @JonasToth wrote: > It might be the case, that the test is run with -no-stdinc (or similar), > so the standard library is not available. Tests should be self-contained and must not depend on any system headers. Standard libra

[PATCH] D46915: [Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals

2018-06-14 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added inline comments. Comment at: include/clang/Basic/TargetInfo.h:89 + // corresponding unsaturated types. + unsigned char ShortAccumFBits, ShortAccumIBits; + unsigned char AccumFBits, AccumIBits; leonardchan wrote: > ebevhan wrote: > > leonardchan w

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

2018-06-14 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. @dblaikie is @rsmith back from the standards meeting yet? I hate to be a pest but this is blocking other work Carlos has in progress. https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47935: [clangd] Boost completion score according to file proximity.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks, just details now! Comment at: clangd/Quality.cpp:185 + } + if (F == Fs.begin() && T == Ts.begin()) // No common directory. +return 0; why is this a special case? - /x/a/b vs /x/a/c is 1 up + 1 down --> 0.59 - /a/b vs /

[PATCH] D48100: Append new attributes to the end of an AttributeList.

2018-06-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this odd detail of attributes! Can you also simplify `hasSameOverloadableAttrs()` in ASTReaderDecl.cpp similar to what you did in SemaOverload.cpp (the copy seems spurious)?

[PATCH] D47935: [clangd] Boost completion score according to file proximity.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clangd/Quality.h:71 +class SymbolRelevanceContext { + public: sammccall wrote: > This is ambiguously a couple of different (and good!) things: > - an encapsulation of the proximitypaths state and logic > - a grouping

[PATCH] D47935: [clangd] Boost completion score according to file proximity.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 151322. ioeric added a comment. - Rebase... Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47935 Files: clangd/CodeComplete.cpp clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests.cpp unittests/clangd/TestFS.cpp uni

[PATCH] D47935: [clangd] Boost completion score according to file proximity.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 151321. ioeric marked 2 inline comments as done. ioeric added a comment. - addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47935 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/CodeComplete.cpp c

[PATCH] D47935: [clangd] Boost completion score according to file proximity.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks, this looks much clearer/more modular/more extensible to me! A couple of notes on the abstractions before digging into details again. Comment at: clangd/Quality.h:71 +class SymbolRelevanceContext { + public: This is ambiguou

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

2018-06-14 Thread Carlos Alberto Enciso via Phabricator via cfe-commits
CarlosAlbertoEnciso added a comment. Ping. The review https://reviews.llvm.org/D44826 is already approved and it is dependent on this patch being reviewed. @rsmith Is there anything I can add to this patch? Thanks https://reviews.llvm.org/D46190 __

[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

2018-06-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, jkorous, MaskRay. For completion items that would trigger include insertions (i.e. index symbols that are not #included yet), add a visual indicator "+" before the complet

[PATCH] D46651: [OpenCL] Support new/delete in Sema

2018-06-14 Thread Sven van Haastregt via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC334700: [OpenCL] Support new/delete in Sema (authored by svenvh, committed by ). Repository: rC Clang https://reviews.llvm.org/D46651 Files: lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaExprCXX.cpp lib

r334700 - [OpenCL] Support new/delete in Sema

2018-06-14 Thread Sven van Haastregt via cfe-commits
Author: svenvh Date: Thu Jun 14 02:51:54 2018 New Revision: 334700 URL: http://llvm.org/viewvc/llvm-project?rev=334700&view=rev Log: [OpenCL] Support new/delete in Sema Reject uses of the default new/delete operators with a diagnostic instead of a crash in OpenCL C++ mode and accept user-defined

[PATCH] D47957: [clangd] Add option to fold overloads into a single completion item.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Plan regarding hiding signatures, and configuration: - internally, keep these options independent (programmatic users know what they're doing) - as a CLI flag, make it a tristate (detailed/bundled/simple), because !Bundle && !Signatures doesn't make sense. Not 100% s

[PATCH] D47957: [clangd] Add option to fold overloads into a single completion item.

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 151316. sammccall added a comment. Give ScoredBundleGreater a better name/location. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47957 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/tool/ClangdMain.cpp unittests/cla

[PATCH] D47957: [clangd] Prototype of overload folding

2018-06-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 151315. sammccall added a comment. Turn prototype into something we could ship: - move bundling behind an option (off by default) - don't fold together items if they may insert different headers - clean up code and add tests Repository: rCTE Clang Tools

[PATCH] D46651: [OpenCL] Support new/delete in Sema

2018-06-14 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D46651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D48161: clang-format: Fix documentation generation

2018-06-14 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 151313. Typz added a comment. Add missing block, for consistency Repository: rC Clang https://reviews.llvm.org/D48161 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ===

[PATCH] D48161: Fix documentation generation

2018-06-14 Thread Francois Ferrand via Phabricator via cfe-commits
Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. It seems that the changes done to `ClangFormatStyleOptions.rst` @334408 are causing the generation of the documentation to fail, with the following error: Warning, treated as error: /llvm/tools/clang/docs/Clan

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

2018-06-14 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: tools/clang-format/clang-format-diff.py:1 -#!/usr/bin/env python +#!/usr/bin/env python3 # lebedev.ri wrote: > Why do you need to *switch* the default? > What's wrong with [at least starting with] just making sure it w

r334696 - [AArch64] reverting rC334693 due to build failures

2018-06-14 Thread Luke Geeson via cfe-commits
Author: lukegeeson Date: Thu Jun 14 01:59:33 2018 New Revision: 334696 URL: http://llvm.org/viewvc/llvm-project?rev=334696&view=rev Log: [AArch64] reverting rC334693 due to build failures Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/aarch64-v8.2a-neon-intrinsics.c

r334694 - Removed trunk-Codegen directory added in error

2018-06-14 Thread Luke Geeson via cfe-commits
Author: lukegeeson Date: Thu Jun 14 01:51:52 2018 New Revision: 334694 URL: http://llvm.org/viewvc/llvm-project?rev=334694&view=rev Log: Removed trunk-Codegen directory added in error Removed: cfe/trunk/CodeGen/ ___ cfe-commits mailing list cfe-com

r334693 - [AArch64] Added support for the vcvta_u16_f16 instrinsic for FP16 Armv8.2-A

2018-06-14 Thread Luke Geeson via cfe-commits
Author: lukegeeson Date: Thu Jun 14 01:28:56 2018 New Revision: 334693 URL: http://llvm.org/viewvc/llvm-project?rev=334693&view=rev Log: [AArch64] Added support for the vcvta_u16_f16 instrinsic for FP16 Armv8.2-A Added: cfe/trunk/CodeGen/ Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

2018-06-14 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334692: [clang-format] Add SpaceBeforeCpp11BracedList option. (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46024?vs=1509

r334692 - [clang-format] Add SpaceBeforeCpp11BracedList option.

2018-06-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jun 14 01:01:09 2018 New Revision: 334692 URL: http://llvm.org/viewvc/llvm-project?rev=334692&view=rev Log: [clang-format] Add SpaceBeforeCpp11BracedList option. WebKit C++ style for object initialization is as follows: Foo foo { bar }; Yet using clang-format -style=web

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

2018-06-14 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:10107-10112 +case 0x0b: // FALSE_OQ +case 0x1b: // FALSE_OS + return llvm::Constant::getNullValue(ConvertType(E->getType())); +case 0x0f: // TRUE_UQ +case 0x1f: // TRUE_US + return llvm

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

2018-06-14 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. It might be the case, that the test is run with -no-stdinc (or similar), so the standard library is not available. Am 13.06.2018 um 23:08 schrieb Shuai Wang via Phabricator: > shuaiwang added a comment. > > In https://reviews.llvm.org/D45679#1131115, @aaron.ballman wr