[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

2018-06-16 Thread Xing via Phabricator via cfe-commits
Higuoxing added inline comments. Comment at: lib/Sema/SemaExpr.cpp:12304-12309 // Diagnose "arg1 & arg2 | arg3" if ((Opc == BO_Or || Opc == BO_Xor) && !OpLoc.isMacroID()/* Don't warn in macros. */) { DiagnoseBitwiseOpInBitwiseOp(Self, Opc, OpLoc, LHSExpr);

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

2018-06-16 Thread Xing via Phabricator via cfe-commits
Higuoxing updated this revision to Diff 151633. https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c === --- test/Sema/parentheses.c +++ test/Sema/parentheses.c @@ -

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

2018-06-16 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: lib/Sema/SemaExpr.cpp:12304-12309 // Diagnose "arg1 & arg2 | arg3" if ((Opc == BO_Or || Opc == BO_Xor) && !OpLoc.isMacroID()/*

[PATCH] D48259: [clang-format] Fix bug with UT_Always when there is less than one full tab

2018-06-16 Thread Guillaume Reymond via Phabricator via cfe-commits
guigu created this revision. guigu added reviewers: klimek, djasper. guigu added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. There's a bug in the `WhitespaceManager` that prevents correct alignment when using tab. This patch fix a test condition t

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

2018-06-16 Thread Whisperity via Phabricator via cfe-commits
whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Ah, and the function names in the test files have been made more logical. Let's roll. 😉 https://reviews.llvm.org/D45532 ___ cfe-commits

[libcxx] r334894 - Remove P0771, which was not passed in Rapperswil

2018-06-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Jun 16 11:03:29 2018 New Revision: 334894 URL: http://llvm.org/viewvc/llvm-project?rev=334894&view=rev Log: Remove P0771, which was not passed in Rapperswil Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.

[PATCH] D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers

2018-06-16 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1647 + } +} + rjmccall wrote: > Prazek wrote: > > rjmccall wrote: > > > Incidentally, how do you protect against code like this? > > > > > > A *ptr; > > > reinterpret_cast(

r334891 - [analyzer] Add method to the generic SMT API to dump the SMT formula

2018-06-16 Thread Mikhail R. Gadelha via cfe-commits
Author: mramalho Date: Sat Jun 16 07:36:17 2018 New Revision: 334891 URL: http://llvm.org/viewvc/llvm-project?rev=334891&view=rev Log: [analyzer] Add method to the generic SMT API to dump the SMT formula Summary: New method dump the SMT formula and the Z3 implementation. There is no test because

[PATCH] D48221: [analyzer] Add method to the generic SMT API to dump the SMT formula

2018-06-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC334891: [analyzer] Add method to the generic SMT API to dump the SMT formula (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D48221: [analyzer] Add method to the generic SMT API to dump the SMT formula

2018-06-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334891: [analyzer] Add method to the generic SMT API to dump the SMT formula (authored by mramalho, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r334886 - Add RUN line for amdgcn to lit test conditional-temporaries.cpp

2018-06-16 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Sat Jun 16 05:28:51 2018 New Revision: 334886 URL: http://llvm.org/viewvc/llvm-project?rev=334886&view=rev Log: Add RUN line for amdgcn to lit test conditional-temporaries.cpp This is partial re-commit of r332982. Modified: cfe/trunk/test/CodeGenCXX/conditional-temporari