stephanemoore accepted this revision.
stephanemoore added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D48432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
apazos updated this revision to Diff 152416.
apazos added a comment.
Herald added subscribers: brucehoult, MartinMosbeck.
Hi Simon, I have added a warning for repeated interrupt attributes.
https://reviews.llvm.org/D48412
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Author: chandlerc
Date: Thu Jun 21 16:52:36 2018
New Revision: 335310
URL: http://llvm.org/viewvc/llvm-project?rev=335310=rev
Log:
[x86] Fix a tiny bug in my test case in r335309 by marking that we don't
expect any diagnostics.
Modified:
cfe/trunk/test/Sema/builtins-x86.cpp
Modified:
Author: chandlerc
Date: Thu Jun 21 16:46:09 2018
New Revision: 335309
URL: http://llvm.org/viewvc/llvm-project?rev=335309=rev
Log:
[x86] Teach the builtin argument range check to allow invalid ranges in
dead code.
This is important for C++ templates that essentially compute the valid
input in a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335309: [x86] Teach the builtin argument range check to
allow invalid ranges in (authored by chandlerc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48464?vs=152404=152411#toc
Author: ctopper
Date: Thu Jun 21 16:39:47 2018
New Revision: 335308
URL: http://llvm.org/viewvc/llvm-project?rev=335308=rev
Log:
[X86] Update handling in CGBuiltin to be tolerant of out of range immediates.
D48464 contains changes that will loosen some of the range checks in
SemaChecking to a
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D48464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D48462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
chandlerc created this revision.
chandlerc added reviewers: craig.topper, rsmith.
Herald added subscribers: llvm-commits, atanasyan, kbarton, nemanjai, mcrosier,
sanjoy.
Herald added a reviewer: javed.absar.
This is important for C++ templates that essentially compute the valid
input in a way
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335305: Ignore blacklist when generating __cfi_check_fail.
(authored by eugenis, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: eugenis
Date: Thu Jun 21 16:22:37 2018
New Revision: 335305
URL: http://llvm.org/viewvc/llvm-project?rev=335305=rev
Log:
Ignore blacklist when generating __cfi_check_fail.
Summary: Fixes PR37898.
Reviewers: pcc, vlad.tsyrklevich
Subscribers: cfe-commits
Differential Revision:
dblaikie added a comment.
In https://reviews.llvm.org/D48426#1139823, @rnk wrote:
> `LangOpts.ModulesCodegen` is very related in spirit to this, but I think we
> need a distinct option because that was designed to handle all inline
> functions (too much), not just dllexport inline functions. +
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:9322
unsigned Index = BuiltinID == X86::BI__builtin_ia32_storelps ? 0 : 1;
-llvm::Value *Idx = llvm::ConstantInt::get(SizeTy, Index);
-Ops[1] = Builder.CreateExtractElement(Ops[1], Idx,
craig.topper created this revision.
craig.topper added reviewers: chandlerc, RKSimon, spatel.
Chandler is working changes that will loosen some of the range checks in
SemaChecking to only be warning that can be disabled.
This patch adds explicit masking to avoid using the upper bits of
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
eugenis added a comment.
Yes, that's better.
https://reviews.llvm.org/D48454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated this revision to Diff 152395.
eugenis added a comment.
Simplify code.
https://reviews.llvm.org/D48454
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/cfi-check-fail2.c
Index: clang/test/CodeGen/cfi-check-fail2.c
Author: emmettneyman
Date: Thu Jun 21 15:08:20 2018
New Revision: 335299
URL: http://llvm.org/viewvc/llvm-project?rev=335299=rev
Log:
Test commit, made a minor change to a comment
Modified:
cfe/trunk/tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
Modified:
pcc added a comment.
__cfi_check_fail certainly seems like a special case in that its behaviour is
controlled only by flags and not the blacklist.
Maybe a simpler fix would be to add this to the top of `EmitCfiCheckFail`?
SanOpts = CGM.getLangOpts().Sanitize;
ormris added a comment.
In https://reviews.llvm.org/D47044#1130339, @NoQ wrote:
> I'm still curious whether this also works:
>
> void foo() {
> const A = B();
> bar();
> }
>
> void bar() {
> for (int i = 0; i < 10; ++i) {}
> }
>
>
> Though we can land this patch and deal
juliehockett added a comment.
So on seeing this, all of the plumbing needed to get that particular value
where you need it is a bit ugly. I'm inclined to suggest wrapping it in a
`ClangDocContext`, containing it and the `ExecutionContext` in the `ClangDoc.h`
file:
struct ClangDocContext {
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
`const` methods shouldn't invalidate the object unless mutable fields kick in.
They sometimes were
dschuff added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1849
+ if (!AttrOnCallSite && !Fn->hasPrototype())
+FuncAttrs.addAttribute("no-prototype");
AddAttributesFromFunctionProtoType(
dschuff wrote:
> aheejin wrote:
> > Is there a
dschuff added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1849
+ if (!AttrOnCallSite && !Fn->hasPrototype())
+FuncAttrs.addAttribute("no-prototype");
AddAttributesFromFunctionProtoType(
aheejin wrote:
> Is there a reason why this is
srhines created this revision.
Herald added a subscriber: mgorny.
If we ignore these variables, we end up always using the host
information for libxml2, when it is not appropriate. This makes builds
less hermetic than they should ideally be.
Repository:
rC Clang
leonardchan updated this revision to Diff 152385.
Repository:
rC Clang
https://reviews.llvm.org/D48456
Files:
include/clang/AST/ASTContext.h
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/TargetInfo.h
Author: bruno
Date: Thu Jun 21 14:45:24 2018
New Revision: 335295
URL: http://llvm.org/viewvc/llvm-project?rev=335295=rev
Log:
Re-apply: Add python tool to dump and construct header maps
Header maps are binary files used by Xcode, which are used to map
header names or paths to other locations.
leonardchan abandoned this revision.
leonardchan added a comment.
The logic in this patch is moved to https://reviews.llvm.org/D48456
Repository:
rC Clang
https://reviews.llvm.org/D46926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:2907-2909
+const Token Next = GetLookAheadToken(2);
+const Token After = GetLookAheadToken(3);
+const Token Last = GetLookAheadToken(4);
Please don't request the additional
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, rsmith, ebevhan.
leonardchan added a project: clang.
leonardchan added a dependency: D46917: [Fixed Point Arithmetic] Comparison and
Unary Operations for Fixed Point Types.
Add support for casting
Author: tobiasvk
Date: Thu Jun 21 14:24:30 2018
New Revision: 335291
URL: http://llvm.org/viewvc/llvm-project?rev=335291=rev
Log:
Revert "[LTO] Enable module summary emission by default for regular LTO"
This is breaking a couple of buildbots. We need to run the
NameAnonGlobal pass for regular
aheejin added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1849
+ if (!AttrOnCallSite && !Fn->hasPrototype())
+FuncAttrs.addAttribute("no-prototype");
AddAttributesFromFunctionProtoType(
Is there a reason why this is not something like
rsmith accepted this revision.
rsmith added a comment.
Please also change the `EnterExpressionEvaluationContext` in
`TreeTransform::TransformTemplateArgument` to specify `EK_TemplateArgument`
(though that doesn't actually matter for the lambda diagnostics because we'll
find all the problems in
ashi1 created this revision.
ashi1 added a reviewer: yaxunl.
ashi1 added projects: clang, AMDGPU.
Herald added a subscriber: cfe-commits.
Removing hip.amdgcn.bc and hc.amdgcn.bc from HIP ToolChains. These need to be
removed in VDI build.
Repository:
rC Clang
https://reviews.llvm.org/D48455
eugenis created this revision.
eugenis added reviewers: pcc, vlad.tsyrklevich.
Fixes PR37898.
https://reviews.llvm.org/D48454
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/cfi-check-fail2.c
Index: clang/test/CodeGen/cfi-check-fail2.c
eugenis added a comment.
Another option is to add a special case to blacklist logic to make it not apply
to __cfi_check_fail.
Yet another option is to make blacklist not apply to functions without a source
location, but that seems to be done intentionally here:
dschuff added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1850
+FuncAttrs.addAttribute("no-prototype");
AddAttributesFromFunctionProtoType(
getContext(), FuncAttrs, Fn->getType()->getAs());
Would it make sense to put this in
Rakete updated this revision to Diff 152374.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In any case, this looks good to me. It'll look even better with the
`FK_AddressOfUnaddressableFunction` case fixed :)
https://reviews.llvm.org/D39679
rsmith added a comment.
In https://reviews.llvm.org/D39679#1037591, @Rakete wrote:
> Note: I didn't change `Args[0]` to `OnlyArg` in
> `FK_AddressOfUnaddressableFunction`, because I'm pretty sure that C++ doesn't
> have unaddressable functions and thus there is no need to decompose an
>
Rakete updated this revision to Diff 152370.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D39679
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/references.cpp
Index: test/SemaCXX/references.cpp
Author: kzhuravl
Date: Thu Jun 21 13:27:47 2018
New Revision: 335287
URL: http://llvm.org/viewvc/llvm-project?rev=335287=rev
Log:
AMDGPU: Remove amdgpu-debugger-reserve-regs feature
Modified:
cfe/trunk/lib/Driver/ToolChains/AMDGPU.cpp
cfe/trunk/test/Driver/amdgpu-features.c
Modified:
Author: abataev
Date: Thu Jun 21 13:26:33 2018
New Revision: 335285
URL: http://llvm.org/viewvc/llvm-project?rev=335285=rev
Log:
[OPENMP, NVPTX] Fix globalization of the variables passed to orphaned
parallel region.
If the current construct requires sharing of the local variable in the
inner
rnk added a subscriber: dblaikie.
rnk added a comment.
`LangOpts.ModulesCodegen` is very related in spirit to this, but I think we
need a distinct option because that was designed to handle all inline functions
(too much), not just dllexport inline functions. + @dblaikie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335284: [LTO] Enable module summary emission by default for
regular LTO (authored by tobiasvk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: tobiasvk
Date: Thu Jun 21 13:20:41 2018
New Revision: 335284
URL: http://llvm.org/viewvc/llvm-project?rev=335284=rev
Log:
[LTO] Enable module summary emission by default for regular LTO
Summary:
With D33921, we gained the ability to have module summaries in regular
LTO modules without
yaxunl added a comment.
In https://reviews.llvm.org/D48419#1139749, @Anastasia wrote:
> In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
>
> > Did you notice the bug that C++ silently allows implicit casting of a
> > pointer to a pointer type with different address space?
> >
> > Do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335282: [bindings] Fix most Python binding unittests on
Windows (authored by jbcoe, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47864
Files:
Author: jbcoe
Date: Thu Jun 21 13:07:03 2018
New Revision: 335282
URL: http://llvm.org/viewvc/llvm-project?rev=335282=rev
Log:
[bindings] Fix most Python binding unittests on Windows
Summary:
This fixes all but one of the test cases for Windows. TestCDB will
take more work to debug, as
Rakete added a comment.
@rsmith Should I only check for an identifier, like only "int" and nothing
else? Because parsing a full type specifier might be a bit expensive, no?
https://reviews.llvm.org/D36357
___
cfe-commits mailing list
dblaikie added a comment.
Yeah, I know nothing about this dump feature or what's being fixed here - test
cases would be great to help motivate/explain.
Repository:
rC Clang
https://reviews.llvm.org/D47953
___
cfe-commits mailing list
rnk added a comment.
Yikes.
Repository:
rL LLVM
https://reviews.llvm.org/D48448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jvesely
Date: Thu Jun 21 12:27:39 2018
New Revision: 335280
URL: http://llvm.org/viewvc/llvm-project?rev=335280=rev
Log:
atom: Use volatile pointers for
cl_khr_{global,local}_int32_{base,extended}_atomics
int64 versions were switched to volatile pointers in cl1.1
cl1.1 also renamed
Author: jvesely
Date: Thu Jun 21 12:27:33 2018
New Revision: 335279
URL: http://llvm.org/viewvc/llvm-project?rev=335279=rev
Log:
atom: Consolidate cl_khr_{local,global}_int32_{base,extended}_atomics
implementation
These are just atomic_* wrappers.
Switch inc, dec to use atomic_* wrappers as
Author: jvesely
Date: Thu Jun 21 12:27:07 2018
New Revision: 335274
URL: http://llvm.org/viewvc/llvm-project?rev=335274=rev
Log:
atomic: Move define cleanup to shared include
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Modified:
Author: jvesely
Date: Thu Jun 21 12:27:26 2018
New Revision: 335278
URL: http://llvm.org/viewvc/llvm-project?rev=335278=rev
Log:
atomic: Provide function implementation of atomic_{dec,inc}
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Added:
Author: jvesely
Date: Thu Jun 21 12:27:12 2018
New Revision: 335275
URL: http://llvm.org/viewvc/llvm-project?rev=335275=rev
Log:
atomic: Cleanup atomic_cmpxchg header
It's easier to just list the four function declarations
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan
Author: jvesely
Date: Thu Jun 21 12:27:18 2018
New Revision: 335276
URL: http://llvm.org/viewvc/llvm-project?rev=335276=rev
Log:
atom: Consolidate cl_khr_{local,global}_int32_{base,extended}_atomics
declarations
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Author: jvesely
Date: Thu Jun 21 12:27:23 2018
New Revision: 335277
URL: http://llvm.org/viewvc/llvm-project?rev=335277=rev
Log:
atom: Consolidate cl_khr_int64_{base,extended}_atomics declarations
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Added:
ethanhs added a comment.
In https://reviews.llvm.org/D47864#1139750, @jbcoe wrote:
> Would you like me to commit this for you?
Sure, that would be great! I don't have commit rights so I was waiting for
someone to do it. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47864
jbcoe added a comment.
Would you like me to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D47864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
> Did you notice the bug that C++ silently allows implicit casting of a pointer
> to a pointer type with different address space?
>
> Do you have a fix for that?
I didn't think it did because if I run
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335270: [X86] Correct the inline assembly implementations of
__movsb/w/d/q and… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: ctopper
Date: Thu Jun 21 11:56:30 2018
New Revision: 335270
URL: http://llvm.org/viewvc/llvm-project?rev=335270=rev
Log:
[X86] Correct the inline assembly implementations of __movsb/w/d/q and
__stosw/d/q to mark registers/memory as modified
The inline assembly for these didn't mark that
craig.topper created this revision.
craig.topper added reviewers: rnk, echristo.
The inline assembly for these didn't mark that edi, esi, ecx are modified by
movs/stos instruction. It also didn't mark that memory is modified.
This issue was reported to llvm-dev last year
yaxunl added a comment.
Did you notice the bug that C++ silently allows implicit casting of a pointer
to a pointer type with different address space?
Do you have a fix for that?
https://reviews.llvm.org/D48419
___
cfe-commits mailing list
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D48438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jgravelle-google added a comment.
Looks very reasonable and straightforward. LGTM in spirit, but I'll wait for
someone who knows Clang better.
Repository:
rC Clang
https://reviews.llvm.org/D48443
___
cfe-commits mailing list
Szelethus updated this revision to Diff 152343.
Szelethus added a comment.
Moved `LC = LC ->getParent()` to the `while` statement's argument to avoid a
potential infinite loop. Whoops :)
https://reviews.llvm.org/D48436
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
thakis added inline comments.
Comment at: lib/AST/ASTContext.cpp:9563
+if (getExternalSource()->DeclIsFromPCHWithObjectFile(D))
+ return false;
+ }
It'd be good to add a comment (and a test) explaining why / how _referenced_
inline functions still get
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335259: [Intrinsics] Add/move some builtin declarations in
intrin.h to get ms… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: ctopper
Date: Thu Jun 21 10:07:04 2018
New Revision: 335259
URL: http://llvm.org/viewvc/llvm-project?rev=335259=rev
Log:
[Intrinsics] Add/move some builtin declarations in intrin.h to get
ms-intrinsics.c to not issue warnings
ud2 and int2c were missing declarations entirely. And the
sbc100 updated this revision to Diff 152335.
sbc100 added a comment.
wrong test
Repository:
rC Clang
https://reviews.llvm.org/D48443
Files:
lib/CodeGen/CGCall.cpp
test/CodeGen/no-prototype.c
Index: test/CodeGen/no-prototype.c
sbc100 created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, dschuff.
The WebAssembly backend in particular benefits from being
able to distinguish between varargs functions (...) and prototype-less
C functions.
Repository:
rC Clang
https://reviews.llvm.org/D48443
Author: gramanas
Date: Thu Jun 21 09:53:48 2018
New Revision: 335255
URL: http://llvm.org/viewvc/llvm-project?rev=335255=rev
Log:
[DebugInfo] Inline for without DebugLocation
Summary:
This test is a strip down version of a function inside the
amalgamated sqlite source. When converted to IR clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335255: [DebugInfo] Inline for without DebugLocation
(authored by gramanas, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47720
Files:
ioeric updated this revision to Diff 152331.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- store scope in completion item. Add splitQualifiedName for NamedDecl.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48425
Files:
clangd/CodeComplete.cpp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D48187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric added inline comments.
Comment at: clangd/Protocol.h:743
+ /// FIXME: find a more precise way to identify a completion item.
+ std::string QualifiedSymbolName;
};
sammccall wrote:
> So this is always set to scope + filterText (except for non-decl
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D45718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335253: [X86] Rewrite the add/mul/or/and reduction
intrinsics to make better use of… (authored by ctopper, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48346
Files:
Author: ctopper
Date: Thu Jun 21 09:41:28 2018
New Revision: 335253
URL: http://llvm.org/viewvc/llvm-project?rev=335253=rev
Log:
[X86] Rewrite the add/mul/or/and reduction intrinsics to make better use of
other intrinsics and remove undef shuffle indices.
Similar to what was done to max/min
bruno added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
sammccall updated this revision to Diff 152326.
sammccall added a comment.
Document some more stuff, and clang-format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48441
Files:
clangd/CMakeLists.txt
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, mgorny.
We now compute a distance from the main file to the symbol header, which
is a weighted count of:
- some number of #include traversals from source
craig.topper added a comment.
Ping
https://reviews.llvm.org/D48187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jmorse added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D48072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Thu Jun 21 09:14:27 2018
New Revision: 335252
URL: http://llvm.org/viewvc/llvm-project?rev=335252=rev
Log:
[clang-tidy] Remove the google-readability-redundant-smartptr-get alias
I don't remember why I added it, but it's definitely not needed, since the check
doesn't have
alexfh added a comment.
Please take another look.
Repository:
rC Clang
https://reviews.llvm.org/D45718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh updated this revision to Diff 152317.
alexfh added a comment.
Herald added subscribers: mikhail.ramalho, mgorny.
- Added a test.
Repository:
rC Clang
https://reviews.llvm.org/D45718
Files:
include/clang/StaticAnalyzer/Frontend/AnalysisConsumer.h
Anastasia created this revision.
Anastasia added a reviewer: yaxunl.
This allows to reuse the same diagnostic for OpenCL or CUDA.
For OpenCL this will be tested in
`test/SemaOpenCL/address-spaces-conversions-cl2.0.cl` that I plan to enable
with `-cl-std=c++` after fixing other issues.
hans added a comment.
In https://reviews.llvm.org/D48426#1139318, @thakis wrote:
> PCHs aren't compatible with themselves if only the compiler revision changes,
> so I'm not sure changing that field should be worse than a regular compiler
> revision update (which happens at every commit). But
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
As of now, all constructor calls are ignored that are being called by a
constructor. The point of this
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:246
assert(bool(SemaResult) == bool(SemaCCS));
+assert(bool(SemaResult) || bool(IndexResult));
+
can skip the bool() here if you like
Comment at:
Author: ro
Date: Thu Jun 21 06:40:50 2018
New Revision: 335234
URL: http://llvm.org/viewvc/llvm-project?rev=335234=rev
Log:
[liblang] Remove DOS line endings in libclang.exports
Undefined first referenced
symbol in file
clang_getCompletionFixIt
thakis added a comment.
PCHs aren't compatible with themselves if only the compiler revision changes,
so I'm not sure changing that field should be worse than a regular compiler
revision update (which happens at every commit). But I don't know what this
field is for. I don't remember any
jolesiak created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48432
Files:
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
---
chill added a comment.
Ping?
https://reviews.llvm.org/D46013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
I think you revved the PCH version last. Did you have to do anything special,
e.g. will it break vendors who ship PCH files as part of SDKs and such? Or are
things generally set up to handle this?
https://reviews.llvm.org/D48426
klimek added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:678
// Indent with tabs only when there's at least one full tab.
-if (FirstTabWidth + Style.TabWidth <= Spaces) {
+if (Style.TabWidth <= Spaces) {
Spaces -= FirstTabWidth;
1 - 100 of 133 matches
Mail list logo
