[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

hokein added subscribers: bkramer, hokein. hokein added a comment. I'm not familiar with this part of code, but the change looks fine to me. I think @bkramer is the right person to review it. Please make sure the style align with LLVM code style. Comment at: lib/Basic/Virtual

[PATCH] D48427: [Analyzer] Fix for D47417 to make the tests pass

baloghadamsoftware updated this revision to Diff 154066. baloghadamsoftware added a comment. Adding of transition removed since it is part of https://reviews.llvm.org/D47417. https://reviews.llvm.org/D48427 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp Index: lib/StaticAnalyzer/Ch

[clang-tools-extra] r336246 - [clangd] FileDistance: missing constexpr

Author: sammccall Date: Wed Jul 4 01:52:13 2018 New Revision: 336246 URL: http://llvm.org/viewvc/llvm-project?rev=336246&view=rev Log: [clangd] FileDistance: missing constexpr Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp

[PATCH] D48880: [Sema] Fix crash in getConstructorName.

This revision was automatically updated to reflect the committed changes. Closed by commit rC336244: [Sema] Fix crash in getConstructorName. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D48880?vs=154063&id=154064#toc Repository: rC Clang https://

r336244 - [Sema] Fix crash in getConstructorName.

Author: ibiryukov Date: Wed Jul 4 01:50:12 2018 New Revision: 336244 URL: http://llvm.org/viewvc/llvm-project?rev=336244&view=rev Log: [Sema] Fix crash in getConstructorName. Summary: Can happen when getConstructorName is called on invalid decls, specifically the ones that do not have the inject

[PATCH] D48917: [SemaCodeComplete] Make sure visited contexts are passed to completion results handler.

ilya-biryukov added a comment. Generally LG, just one comment. Comment at: lib/Sema/SemaCodeComplete.cpp:3744 AddMacroResults(PP, Results, false, PreferredTypeIsPointer); - HandleCodeCompleteResults(this, CodeCompleter, -CodeCompletionContext(CodeCompleti

[PATCH] D48880: [Sema] Fix crash in getConstructorName.

ilya-biryukov added a comment. Thanks for taking a look! Repository: rC Clang https://reviews.llvm.org/D48880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48880: [Sema] Fix crash in getConstructorName.

ilya-biryukov updated this revision to Diff 154063. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Better recovery for invalid decls that do have an injected class name - Move the test to SemaCXX Repository: rC Clang https://reviews.llvm.org/D48880 Files:

r336243 - NFC - typo fix in test/CodeGen/avx512f-builtins.c

Author: gbuella Date: Wed Jul 4 01:32:02 2018 New Revision: 336243 URL: http://llvm.org/viewvc/llvm-project?rev=336243&view=rev Log: NFC - typo fix in test/CodeGen/avx512f-builtins.c Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c URL:

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

chill added inline comments. Comment at: test/CodeGen/clang-sections-attribute.c:1 +// RUN: %clang_cc1 -emit-llvm -triple arm-none-eabi -o - %s | FileCheck %s + Isn't it possible for the test to fail if the Arm target is not configured? Repository: rC Clang

[clang-tools-extra] r336242 - [clangd] FileDistance: don't add duplicate edges

Author: sammccall Date: Wed Jul 4 01:27:28 2018 New Revision: 336242 URL: http://llvm.org/viewvc/llvm-project?rev=336242&view=rev Log: [clangd] FileDistance: don't add duplicate edges Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp Modified: clang-tools-extra/trunk/clangd/FileDist

[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

ebevhan added inline comments. Comment at: lib/Basic/FixedPoint.cpp:40 + if (DstWidth > Val.getBitWidth()) +Val = Val.extend(DstWidth); + if (Upscaling) leonardchan wrote: > ebevhan wrote: > > It should be possible to replace this with `extOrTrunc` and move

[PATCH] D48917: [SemaCodeComplete] Make sure visited contexts are passed to completion results handler.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48917 Files: lib/Sema/SemaCodeComplete.cpp unittests/Sema/CodeCompleteTest.cpp Index: unittests/Sema/CodeCompleteTest.cpp ==

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

petpav01 created this revision. petpav01 added reviewers: javed.absar, chill, rnk. Herald added subscribers: cfe-commits, kristof.beyls. Code in `CodeGenModule::SetFunctionAttributes()` can set an empty attribute `implicit-section-name` on a function that is affected by `#pragma clang text="sect

[PATCH] D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring.

CarlosAlbertoEnciso added a comment. Hi, It seems that your patch is causing an error in the tests for http://lab.llvm.org:8011/builders/clang-x64-ninja-win7 http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11510/steps/ninja%20check%201/logs/FAIL%3A%20Extra%20Tools%20Unit%20Tests%3

<    1   2