[PATCH] D47111: : Implement monotonic_buffer_resource.

2018-07-07 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 154486. Quuxplusone added a comment. Oops, my previous diff had a stray `)` in it, somehow. Repository: rCXX libc++ https://reviews.llvm.org/D47111 Files: include/experimental/memory_resource src/experimental/memory_resource.cpp test/libcxx/ex

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

2018-07-07 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 154490. lebedev.ri added a comment. Rebased, just to control bitrot, no changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D36892 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check_clang_tidy.py =

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

2018-07-07 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 154491. lebedev.ri added a comment. Rebased, just to control bitrot, no changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D36836 Files: LICENSE.TXT clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/sonars

[PATCH] D48521: [analyzer] Highlight container object destruction in MallocChecker

2018-07-07 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs added a comment. No crashes on Harfbuzz, ICU, Bitcoin, and LLVM. I'll commit. https://reviews.llvm.org/D48521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r336487 - [X86] Fix various type mismatches in intrinsic headers and intrinsic tests that cause extra bitcasts to be emitted in the IR.

2018-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Jul 7 10:03:32 2018 New Revision: 336487 URL: http://llvm.org/viewvc/llvm-project?rev=336487&view=rev Log: [X86] Fix various type mismatches in intrinsic headers and intrinsic tests that cause extra bitcasts to be emitted in the IR. Found via imprecise grepping of the

r336488 - [X86] Change _mm512_shuffle_pd and _mm512_shuffle_ps to use target specific shuffle builtins instead of generic __builtin_shufflevector.

2018-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Jul 7 10:03:34 2018 New Revision: 336488 URL: http://llvm.org/viewvc/llvm-project?rev=336488&view=rev Log: [X86] Change _mm512_shuffle_pd and _mm512_shuffle_ps to use target specific shuffle builtins instead of generic __builtin_shufflevector. I added the builtins for

[PATCH] D48521: [analyzer] Highlight container object destruction in MallocChecker

2018-07-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336489: [analyzer] Highlight container object destruction in MallocChecker. (authored by rkovacs, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D48522: [analyzer] Highlight c_str() call in DanglingInternalBuffer checker

2018-07-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336495: [analyzer] Highlight c_str() call in DanglingInternalBufferChecker. (authored by rkovacs, committed by ). Changed prior to commit: https://reviews.llvm.org/D48522?vs=152719&id=154499#toc Reposi

[PATCH] D48532: [analyzer] Add support for std::basic_string::data() in DanglingInternalBufferChecker

2018-07-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336497: [analyzer] Add support for data() in DanglingInternalBufferChecker. (authored by rkovacs, committed by ). Changed prior to commit: https://reviews.llvm.org/D48532?vs=152737&id=154501#toc Reposi

[PATCH] D49054: [MinGW] Treat any -lucrt* as replacing -lmsvcrt

2018-07-07 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: rnk, martell, compnerd, smeenai. Since SVN r314138, we check if the user has specified any particular alternative msvcrt/ucrt version, and skip the default -lmsvcrt in those cases. In addition to the existing names checked, we should also

r336500 - [X86] Remove __builtin_ia32_vfnmsubsd3_mask3 and __builtin_ia32_vfnmsubss3_mask3 from clang.

2018-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Jul 7 15:03:20 2018 New Revision: 336500 URL: http://llvm.org/viewvc/llvm-project?rev=336500&view=rev Log: [X86] Remove __builtin_ia32_vfnmsubsd3_mask3 and __builtin_ia32_vfnmsubss3_mask3 from clang. They are no longer used by clang. Modified: cfe/trunk/include/cl

r336498 - [X86] Fix a few intrinsics that were ignoring their rounding mode argument and hardcoded _MM_FROUND_CUR_DIRECTION internally.

2018-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Jul 7 15:03:16 2018 New Revision: 336498 URL: http://llvm.org/viewvc/llvm-project?rev=336498&view=rev Log: [X86] Fix a few intrinsics that were ignoring their rounding mode argument and hardcoded _MM_FROUND_CUR_DIRECTION internally. I believe these have been broken sin

r336499 - [X86] Remove some unnecessarily escaped new lines from avx512fintrin.h

2018-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Jul 7 15:03:19 2018 New Revision: 336499 URL: http://llvm.org/viewvc/llvm-project?rev=336499&view=rev Log: [X86] Remove some unnecessarily escaped new lines from avx512fintrin.h Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modified: cfe/trunk/lib/Headers/avx512f

r336493 - [analyzer] Fix -Wcovered-switch-default warning in MallocChecker.

2018-07-07 Thread Reka Kovacs via cfe-commits
Author: rkovacs Date: Sat Jul 7 11:37:37 2018 New Revision: 336493 URL: http://llvm.org/viewvc/llvm-project?rev=336493&view=rev Log: [analyzer] Fix -Wcovered-switch-default warning in MallocChecker. Remove unnecessary default case that caused buildbot failures. Modified: cfe/trunk/lib/Stati

r336489 - [analyzer] Highlight container object destruction in MallocChecker.

2018-07-07 Thread Reka Kovacs via cfe-commits
Author: rkovacs Date: Sat Jul 7 10:22:45 2018 New Revision: 336489 URL: http://llvm.org/viewvc/llvm-project?rev=336489&view=rev Log: [analyzer] Highlight container object destruction in MallocChecker. Extend MallocBugVisitor to place a note at the point where objects with AF_InternalBuffer alloc

r336497 - [analyzer] Add support for data() in DanglingInternalBufferChecker.

2018-07-07 Thread Reka Kovacs via cfe-commits
Author: rkovacs Date: Sat Jul 7 13:29:24 2018 New Revision: 336497 URL: http://llvm.org/viewvc/llvm-project?rev=336497&view=rev Log: [analyzer] Add support for data() in DanglingInternalBufferChecker. DanglingInternalBufferChecker now tracks use-after-free problems related to the incorrect usage

r336495 - [analyzer] Highlight c_str() call in DanglingInternalBufferChecker.

2018-07-07 Thread Reka Kovacs via cfe-commits
Author: rkovacs Date: Sat Jul 7 12:27:18 2018 New Revision: 336495 URL: http://llvm.org/viewvc/llvm-project?rev=336495&view=rev Log: [analyzer] Highlight c_str() call in DanglingInternalBufferChecker. Add a bug visitor to DanglingInternalBufferChecker that places a note at the point where the da

[libcxx] r336502 - type_traits: aligned_union is NOT the same as __uncvref [NFC]

2018-07-07 Thread Casey Carter via cfe-commits
Author: caseycarter Date: Sat Jul 7 17:06:27 2018 New Revision: 336502 URL: http://llvm.org/viewvc/llvm-project?rev=336502&view=rev Log: type_traits: aligned_union is NOT the same as __uncvref [NFC] Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL:

[PATCH] D45712: Diagnose invalid cv-qualifiers for friend decls.

2018-07-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Can we avoid the duplication by putting this check in `Sema::ParsedFreeStandingDeclSpec` instead? Repository: rC Clang https://reviews.llvm.org/D45712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

r336507 - [X86] Add new scalar fma intrinsics with rounding mode that use f32/f64 types.

2018-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Jul 7 18:10:47 2018 New Revision: 336507 URL: http://llvm.org/viewvc/llvm-project?rev=336507&view=rev Log: [X86] Add new scalar fma intrinsics with rounding mode that use f32/f64 types. This allows us to handle masking in a very similar way to the default rounding vers

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

2018-07-07 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: test/SemaObjC/property-in-class-extension-1.m:18 -@property (assign, readonly) NSString* changeMemoryModel; // expected-note {{property declared here}} +@property (unsafe_unretained, readonly) NSString* changeMemoryModel; // expecte