[PATCH] D49063: [libclang] Add support for ObjCObjectType

yvvan added inline comments. Comment at: include/clang-c/Index.h:35 #define CINDEX_VERSION_MAJOR 0 #define CINDEX_VERSION_MINOR 49 Please, increment the minor version (you are adding new functions) Comment at: include/clang-c/Index.h:3644 +

[PATCH] D48266: [Driver] Add -fno-digraphs

jtbandes updated this revision to Diff 155116. jtbandes marked an inline comment as done. jtbandes added a comment. - include %:%: in help text Repository: rC Clang https://reviews.llvm.org/D48266 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp lib/Frontend/Compi

[PATCH] D48266: [Driver] Add -fno-digraphs

jtbandes marked 2 inline comments as done. jtbandes added a comment. If I understood your comment correctly, you meant to remove the diagnostic completely (regardless of whether `-fdigraphs` or `-fno-digraphs` is given, and regardless of whether digraphs were enabled for the selected language)?

[PATCH] D48266: [Driver] Add -fno-digraphs

jtbandes updated this revision to Diff 155115. jtbandes added a comment. - remove diagnostic; fix formatting Repository: rC Clang https://reviews.llvm.org/D48266 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp lib/Frontend/CompilerInvocation.cpp test/Lexer/digr

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang updated this revision to Diff 155112. mgrang added a reviewer: hfinkel. mgrang added a comment. Added tests for C++ headers search. https://reviews.llvm.org/D48862 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/Driver/Inputs/openembedded_aarch64_linux_tr

[libcxx] r336880 - Turns out that wide literals U"xxx" and u"xxx" are c++11 and later.

Author: marshall Date: Wed Jul 11 19:55:01 2018 New Revision: 336880 URL: http://llvm.org/viewvc/llvm-project?rev=336880&view=rev Log: Turns out that wide literals U"xxx" and u"xxx" are c++11 and later. Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp Mod

[PATCH] D49215: [analyzer] Admit that some copy/move constructors have more than one argument.

NoQ updated this revision to Diff 155105. NoQ added a comment. Actually verify the CFG in the test. https://reviews.llvm.org/D49215 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp Index: test/Analysis/cfg-rich-constructors.cpp ==

[PATCH] D49215: [analyzer] Admit that some copy/move constructors have more than one argument.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. Copy/move constructors may have additional default arguments and still be treated as normal copy/move c

[PATCH] D49058: [analyzer] Move DanglingInternalBufferChecker out of alpha

george.karpenkov added a comment. @rnkovacs Do you have evaluation statistics handy for this checker? How many bugs it finds, on which projects? How many of those are real bugs? https://reviews.llvm.org/D49058 ___ cfe-commits mailing list cfe-commi

[PATCH] D49213: [analyzer] pr38072: Suppress an assertion failure for eliding the same destructor twice due to the default argument problem.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:432-433 ConstructedObjectKey Key(Item, LC->getCurrentStackFrame()); // FIXME: Currently the state might already contain the marker due to // incorrect handling of temporaries bound to default p

[PATCH] D49213: [analyzer] pr38072: Suppress an assertion failure for eliding the same destructor twice due to the default argument problem.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. @alexfh provided an example that demonstrates that elided copy constructors may get agglutinated due to

[PATCH] D27202: [analyzer] Do not conjure a symbol for return value of a conservatively evaluated function

NoQ abandoned this revision. NoQ added a comment. Herald added subscribers: mikhail.ramalho, rnkovacs, szepet. Herald added a reviewer: george.karpenkov. Outdated by https://reviews.llvm.org/D44131. https://reviews.llvm.org/D27202 ___ cfe-commits ma

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

NoQ added inline comments. Comment at: test/Analysis/nullability_nullonly.mm:103 void testObjCARCExplicitZeroInitialization() { - TestObject * _Nonnull explicitlyZeroInitialized = nil; // expected-warning {{nil assigned to a pointer which is expected to have non-null value}} +

[PATCH] D49210: [CFG] [analyzer] NFC: Enumerate construction context layer kinds and re-use their code for ExprEngine keys.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. This is a refactoring patch; no functional change intended. `ConstructionContext` is composed of `Const

[PATCH] D49209: CodeGen: specify alignment for automatic variable initialization

efriedma added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:902 +Builder.CreateAlignedStore( +Init, Loc, Loc->getPointerAlignment(CGM.getDataLayout()), isVolatile); return; llvm::Value::getPointerAlignment is not the right way to compute t

[PATCH] D48681: [CFG] [analyzer] Add construction contexts for function arguments.

NoQ updated this revision to Diff 155091. NoQ added a comment. Address my own comments. https://reviews.llvm.org/D48681 Files: include/clang/Analysis/CFG.h include/clang/Analysis/ConstructionContext.h lib/Analysis/CFG.cpp lib/Analysis/ConstructionContext.cpp lib/StaticAnalyzer/Core/Ex

[PATCH] D49209: CodeGen: specify alignment for automatic variable initialization

jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith. Automatic variable initialization was generating default-aligned stores (which are deprecated) instead of using the known alignment from the alloca. Repository: rC Clang https://reviews.llvm.org/D49209 Files: li

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

vsk added a subscriber: klimek. vsk added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1694 // handle things like function to ptr-to-function decay etc. Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) { Expr *E = CE->getSubExpr(); lebedev.

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- marked an inline comment as done. 0x8000- added a comment. Remove extraneous .html. Sorry for not seeing it earlier. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- updated this revision to Diff 155089. 0x8000- added a comment. Fix typo Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/MagicNumbersCheck.cpp clang-tidy/readability/MagicNumbersCheck.

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:158 +- New :doc:`readability-magic-numbers + ` check. + .html is not needed. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 __

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- marked 3 inline comments as done. 0x8000- added a comment. Thank you for your review @Eugene.Zelenko Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- updated this revision to Diff 155084. 0x8000- added a comment. Update documentation to clean up formatting Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/MagicNumbersCheck.cpp clang-

r336867 - Fix deduction for conversion function templates converting to reference

Author: rsmith Date: Wed Jul 11 16:19:41 2018 New Revision: 336867 URL: http://llvm.org/viewvc/llvm-project?rev=336867&view=rev Log: Fix deduction for conversion function templates converting to reference types. We previously tried to use the "parameter is a reference" logic here, but that doesn'

[PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX336866: [libc++] Take 2: Replace uses of _LIBCPP_ALWAYS_INLINE by… (authored by ldionne, committed by ). Changed prior

[PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336866: [libc++] Take 2: Replace uses of _LIBCPP_ALWAYS_INLINE by… (authored by ldionne, committed by ). Changed prior to

[PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

ldionne added a comment. Pushing since I got an offline O.K. from Eric. Repository: rL LLVM https://reviews.llvm.org/D48892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r336866 - [libc++] Take 2: Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

Author: ldionne Date: Wed Jul 11 16:14:33 2018 New Revision: 336866 URL: http://llvm.org/viewvc/llvm-project?rev=336866&view=rev Log: [libc++] Take 2: Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY Summary: We never actually mean to always inline a function -- all the uses of

[PATCH] D48764: [Analyzer] Hotfix for iterator checkers: Mark left-hand side of `SymIntExpr` objects as live in the program state maps.

NoQ added a comment. Looks good with minor comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:493 +for (auto i = Offset->symbol_begin(); i != Offset->symbol_end(); ++i) + SR.markLive(*i); } Let's only mark `SymbolData`-type symbol

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:158 +- New :doc:`readability-magic-numbers + ` check. + Please make link short. See other links as examples.

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- updated this revision to Diff 155078. 0x8000- edited the summary of this revision. 0x8000- added a comment. Updated examples code and added several references Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Quuxplusone added inline comments. Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:11 + + double circleArea = 3.1415926535 * radius * radius; + 0x8000- wrote: > Quuxplusone wrote: > > 0x8000- wrote: > > > Eugene.Zelenko wrote: > > > > J

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- added inline comments. Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:11 + + double circleArea = 3.1415926535 * radius * radius; + Quuxplusone wrote: > 0x8000- wrote: > > Eugene.Zelenko wrote: > > > JonasToth wrote: > > > > Thi

r336863 - os_log: When there are multiple privacy annotations in the format

Author: ahatanak Date: Wed Jul 11 15:19:14 2018 New Revision: 336863 URL: http://llvm.org/viewvc/llvm-project?rev=336863&view=rev Log: os_log: When there are multiple privacy annotations in the format string, choose the strictest one instead of the last. Also fix an undefined behavior. Move the p

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D49114#1159327, @0x8000- wrote: > In https://reviews.llvm.org/D49114#1159211, @Eugene.Zelenko wrote: > > > C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic > > constants > >

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- added a comment. In https://reviews.llvm.org/D49114#1159211, @Eugene.Zelenko wrote: > C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic > constants > , > so I think check

[PATCH] D47632: [ASTImporter] Refactor Decl creation

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thank you Gabor! I apologize for the delay in reviewing patches. Repository: rC Clang https://reviews.llvm.org/D47632 ___ cfe-commits m

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. After looking at a few more use cases of the in-memory file system, I think a problem we need to address is the consistency of file paths you get from clang when using in-mem vfs. The clang-move tests that you have mitigated in https://reviews.llvm.org/D48951 could be a

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

ldionne added a comment. I forgot to mention it in my initial review, but it also seems like you forgot to update all the synopsis in the comments at the beginning of headers. https://reviews.llvm.org/D46845 ___ cfe-commits mailing list cfe-commits

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

ahatanak added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r336856 - Same reversed ifdef happened twice. Test fix only, NFC to the library.

Author: marshall Date: Wed Jul 11 14:22:13 2018 New Revision: 336856 URL: http://llvm.org/viewvc/llvm-project?rev=336856&view=rev Log: Same reversed ifdef happened twice. Test fix only, NFC to the library. Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp

[libcxx] r336855 - Fix a test #ifdef that was reversed. NFC to the library.

Author: marshall Date: Wed Jul 11 14:20:42 2018 New Revision: 336855 URL: http://llvm.org/viewvc/llvm-project?rev=336855&view=rev Log: Fix a test #ifdef that was reversed. NFC to the library. Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp Modified: lib

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

george.karpenkov added a comment. > The imprecision in the built in solver might result in failure to constrain a > value to zero while the Z3 might be able to do that. Ah right, that's a good point, we only throw a null-pointer deref/division by zero when the pointer/value is definitely zero.

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1694 // handle things like function to ptr-to-function decay etc. Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) { Expr *E = CE->getSubExpr(); vsk wrote: > lebedev.ri wrote: >

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri updated this revision to Diff 155064. lebedev.ri added a comment. Add some more tricky tests where maintaining just the `CastExpr` part of AST stack would break them. Repository: rC Clang https://reviews.llvm.org/D48958 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanit

r336852 - Fix determination of whether one set of cvr-qualifiers is compatible

Author: rsmith Date: Wed Jul 11 14:07:04 2018 New Revision: 336852 URL: http://llvm.org/viewvc/llvm-project?rev=336852&view=rev Log: Fix determination of whether one set of cvr-qualifiers is compatible with another in template argument deduction. We happened to typically get away with getting thi

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Generally looks pretty good, but I have a couple questions/suggestions. Comment at: libcxx/include/__hash_table:2165 +#if _LIBCPP_STD_VER > 14 +template +templat

[clang-tools-extra] r336850 - [Documentation] Fix incorrect documentation references, new checks order in Release Notes

Author: eugenezelenko Date: Wed Jul 11 13:56:26 2018 New Revision: 336850 URL: http://llvm.org/viewvc/llvm-project?rev=336850&view=rev Log: [Documentation] Fix incorrect documentation references, new checks order in Release Notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modif

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Quuxplusone added inline comments. Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:11 + + double circleArea = 3.1415926535 * radius * radius; + 0x8000- wrote: > Eugene.Zelenko wrote: > > JonasToth wrote: > > > This example is good, but righ

[clang-tools-extra] r336849 - [Documentation] Link format and order of Clang-tidy changes in Release Notes

Author: eugenezelenko Date: Wed Jul 11 13:41:16 2018 New Revision: 336849 URL: http://llvm.org/viewvc/llvm-project?rev=336849&view=rev Log: [Documentation] Link format and order of Clang-tidy changes in Release Notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-too

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

simark updated this revision to Diff 155057. simark added a comment. This is an update of my work in progress. I haven't done any sharing with SymbolCollector, as it's not clear to me how to proceed with that. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48687 Files: clang

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Eugene.Zelenko added a comment. C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic constants , so I think check should be moved into cppcoreguidelines module. Repository: rCTE Clan

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

This revision was automatically updated to reflect the committed changes. Closed by commit rC336842: Fix setting of empty implicit-section-name attribute (authored by petr.pavlu, committed by ). Repository: rC Clang https://reviews.llvm.org/D48916 Files: lib/CodeGen/CodeGenModule.cpp test

r336842 - Fix setting of empty implicit-section-name attribute

Author: petr.pavlu Date: Wed Jul 11 13:17:54 2018 New Revision: 336842 URL: http://llvm.org/viewvc/llvm-project?rev=336842&view=rev Log: Fix setting of empty implicit-section-name attribute Code in `CodeGenModule::SetFunctionAttributes()` could set an empty attribute `implicit-section-name` on a

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

vsk added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1694 // handle things like function to ptr-to-function decay etc. Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) { Expr *E = CE->getSubExpr(); lebedev.ri wrote: > vsk wrote: > > I thi

r336840 - [NFC] typo

Author: jfb Date: Wed Jul 11 12:51:40 2018 New Revision: 336840 URL: http://llvm.org/viewvc/llvm-project?rev=336840&view=rev Log: [NFC] typo Modified: cfe/trunk/lib/CodeGen/ConstantEmitter.h Modified: cfe/trunk/lib/CodeGen/ConstantEmitter.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

alexshap added a comment. > Are you talking about a more conservative warning or a more conservative > fixit? If it doesn't make sense for us to have a fixit for a particular > capture, does it make sense for us to have a warning for that >capture in the > first place? to be honest i'm more co

[PATCH] D49199: [analyzer][UninitializedObjectChecker] Pointer/reference objects are dereferenced according to dynamic type

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:591-609 +// TODO: This function constructs an incorrect string if a void pointer is a +// part of the chain: +// +// struct B { int x; } +// +// struct A { +// void *vp

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

xazax.hun added a comment. In https://reviews.llvm.org/D49074#1159095, @george.karpenkov wrote: > > This may remove false-positives (like the example above), but we surely > > cannot find new errors where multiplicative operations are used. > > Do you have examples of those? In my understanding,

r336836 - [NFC] Replace usage of QualType.getTypePtr()-> with operator->

Author: erichkeane Date: Wed Jul 11 12:09:21 2018 New Revision: 336836 URL: http://llvm.org/viewvc/llvm-project?rev=336836&view=rev Log: [NFC] Replace usage of QualType.getTypePtr()-> with operator-> Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: ht

[PATCH] D49057: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC336835: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker. (authored by rkovacs, committed by ). Repository: rC Clang https://reviews.llvm.org/D49057 Files: lib/StaticAn

r336835 - [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker.

Author: rkovacs Date: Wed Jul 11 12:08:02 2018 New Revision: 336835 URL: http://llvm.org/viewvc/llvm-project?rev=336835&view=rev Log: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker. Previously, the checker only tracked one raw pointer symbol for each container obje

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark added inline comments. Comment at: lib/Basic/FileManager.cpp:395 + SmallString<128> RealPathName; + if (!FS->getRealPath(InterndFileName, RealPathName)) +UFE->RealPathName = RealPathName.str(); ioeric wrote: > It seems that at this point, we have fai

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

arphaman added a comment. Thanks for working on this! Please upload the patch with the full context (git diff -U9). It helps the reviewers :) In https://reviews.llvm.org/D48845#1158103, @alexshap wrote: > I'm kind of interested in this fixit, but one thought which i have - probably > it sh

Re: r336807 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

fyi, I've reverted this commit with r336831 due to some other issues. On Wed, Jul 11, 2018 at 8:23 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Simon, > > This commit added broken tests to one of our builders: > > http://lab.llvm.org:8011/builders/llvm-clang-ll

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

george.karpenkov added a comment. > What issues could it cause since it is guarded by an option? I've meant the rearrangement. Actually, I would like to apologize for that point, I thought it was causing some issues, but it wasn't, we've just checked it yesterday. > As far as I know the purpos

Re: r336776 - [AST] Structural equivalence of methods

Hi, I am aware of the problem, there should be already a commit to (hopefully) correct the failure. Balázs Kéri Galina Kistanova ezt írta (időpont: 2018. júl. 11., Sze, 20:01): > Hello Balazs, > > This commit broke at least one of our builders: > > http://lab.llvm.org:8011/builders/llvm-clang-x

[PATCH] D49199: [analyzer][UninitializedObjectChecker] Pointer/reference objects are dereferenced according to dynamic type

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. This diff fixes a long debated issues with pointers/references not being dereferenced according to their

r336831 - Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name"

Author: ioeric Date: Wed Jul 11 11:43:07 2018 New Revision: 336831 URL: http://llvm.org/viewvc/llvm-project?rev=336831&view=rev Log: Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name" This reverts commit r336807. This breaks users of ClangTool::mapVi

[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

mstorsjo abandoned this revision. mstorsjo added a comment. Herald added a subscriber: chrib. FWIW, I'm not going to put any more effort into this one at the moment, I managed to fix my use case in a much simpler way by providing a Windows Store compatible version of EnumProcessModules, see htt

[PATCH] D44493: [libunwind] Add a cmake option for disabling the use of the dynamic linker

mstorsjo abandoned this revision. mstorsjo added a comment. Herald added a subscriber: chrib. I choose not to commit this one after all, I managed to work around the issue with Windows Store apps in a much simpler way by providing a Windows Store compatible version of EnumProcessModules, see ht

[PATCH] D47632: [ASTImporter] Refactor Decl creation

martong added a comment. Hi Aleksei, could you pleas take an other quick look, there were only minor changes since your last comments. Thanks! Repository: rC Clang https://reviews.llvm.org/D47632 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85 OMPRTL_NVPTX__kmpc_data_sharing_init_stack, + /// Call to void __kmpc_data_sharing_init_stack_spmd(); + OMPRTL_NVPTX__kmpc_data_sharing_init_stac

[PATCH] D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters

martong added a comment. @gerazo, Do you have commit rights, or should I help with the commit? https://reviews.llvm.org/D47946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

ioeric added inline comments. Comment at: lib/Basic/FileManager.cpp:395 + SmallString<128> RealPathName; + if (!FS->getRealPath(InterndFileName, RealPathName)) +UFE->RealPathName = RealPathName.str(); It seems that at this point, we have failed to find `Fil

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. In https://reviews.llvm.org/D48903#1159046, @simark wrote: > In https://reviews.llvm.org/D48903#1159023, @ioeric wrote: > > > Would you mind reverting this patch for now so that we can come up with a > > solution to address those use cases? > > > > Sorry again about missi

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

simark added a comment. In https://reviews.llvm.org/D48903#1159023, @ioeric wrote: > Would you mind reverting this patch for now so that we can come up with a > solution to address those use cases? > > Sorry again about missing the discussion earlier! Of course, feel free to revert if needed (

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

gtbercea updated this revision to Diff 155037. gtbercea added a comment. Add test for spmd stack init function. Repository: rC Clang https://reviews.llvm.org/D49188 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_data_sharing_spmd.cpp

Re: r336807 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

Hello Simon, This commit added broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/18386/steps/test/logs/stdio . . . Failing Tests (4): Clang :: PCH/case-insensitive-include.c Clang-Unit :: Basic/./BasicTests.exe/In

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. In https://reviews.llvm.org/D48903#1159023, @ioeric wrote: > In https://reviews.llvm.org/D48903#1155403, @ilya-biryukov wrote: > > > In https://reviews.llvm.org/D48903#1154846, @simark wrote: > > > > > With the `InMemoryFileSystem`, this now returns a non-real path. The

Re: r336776 - [AST] Structural equivalence of methods

Hello Balazs, This commit broke at least one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10897 . . . Failing Tests (1): Clang-Unit :: AST/./ASTTests.exe/StructuralEquivalenceRecordTest.Name Please have a look? It is not good idea to keep t

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. In https://reviews.llvm.org/D48903#1155403, @ilya-biryukov wrote: > In https://reviews.llvm.org/D48903#1154846, @simark wrote: > > > With the `InMemoryFileSystem`, this now returns a non-real path. The > > result is that we fill `RealPathName` with that non-real path. I

[PATCH] D49190: [clang-tidy/ObjC] Add SQL to list of acronyms

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark added a comment. Background: I'm trying to fix the cases why we receive a FileEntry without a real path computed in clangd, so we can avoid having to compute it ourselves. Repository: rC Clang https://reviews.llvm.org/D49197 ___ cfe-comm

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark added a comment. I'm not sure who should review this patch, please add anybody you think is qualified/responsible. Repository: rC Clang https://reviews.llvm.org/D49197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark updated this revision to Diff 155027. simark added a comment. Update commit message. Repository: rC Clang https://reviews.llvm.org/D49197 Files: lib/Basic/FileManager.cpp unittests/Basic/FileManagerTest.cpp Index: unittests/Basic/FileManagerTest.cpp =

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark created this revision. Herald added a subscriber: cfe-commits. I noticed that when getVirtualFile is called for a file, subsequent calls to getFile will return a FileEntry without the RealPathName computed: const FileEntry *VFE = Mgr->getVirtualFile("/foo/../bar", ...); const FileEntry

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. (removing from my dashboard) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42682 ___ cfe-commits mailing list cfe-com

[PATCH] D33537: [clang-tidy] Exception Escape Checker

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one comment. Comment at: test/clang-tidy/bugprone-exception-escape.cpp:178 +void indirect_implicit() noexcept { + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning:

[PATCH] D48395: Added PublicOnly flag

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Remember to mark comments as done when they are. Otherwise, LGTM unless @ioeric has any concerns. https://reviews.llvm.org/D48395 __

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As per the previous comment: I have no concerns as long as the documentation is updated and at least one existing test is changed to use this feature (see the list in the previous co

[PATCH] D48559: [clangd] refactoring for XPC transport layer [NFCI]

jkorous added a comment. Ping. Added reviewers suggestion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47894: [clang]: Add support for "-fno-delete-null-pointer-checks"

manojgupta added a comment. @efriedma @jyknight Does the change match your expectations where warnings are still generated but codeGen does not emit nonnull attribute? Comment at: test/Sema/nonnull.c:2 // RUN: %clang_cc1 -fsyntax-only -verify %s +// RUN: %clang_cc1 -fsyntax-o

r336817 - [AST] Fix for structural equivalence tests in rL336776.

Author: balazske Date: Wed Jul 11 08:26:26 2018 New Revision: 336817 URL: http://llvm.org/viewvc/llvm-project?rev=336817&view=rev Log: [AST] Fix for structural equivalence tests in rL336776. Modified: cfe/trunk/unittests/AST/StructuralEquivalenceTest.cpp Modified: cfe/trunk/unittests/AST/Str

[PATCH] D49112: [Sema] Implement -Wmemset-transposed-args

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm assuming you ran this on some large code base to make sure it doesn't have false positives. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:659 +def warn_s

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85 OMPRTL_NVPTX__kmpc_data_sharing_init_stack, + /// Call to void __kmpc_data_sharing_init_stack_spmd(); + OMPRTL_NVPTX__kmpc_data_sharing_init_stack_spmd, /// Call to void* __kmpc_data_sh

[PATCH] D49190: [clang-tidy/ObjC] Add SQL to list of acronyms

benhamilton created this revision. benhamilton added reviewers: Wizard, hokein. Herald added a subscriber: cfe-commits. SQL is a common acronym. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49190 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp Index: clang-tidy/objc/P

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

gtbercea updated this revision to Diff 155002. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D49188 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp Index: test/OpenMP/nvptx_data_sharing.cpp =

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

ABataev added a comment. What about the check for the new function call? Repository: rC Clang https://reviews.llvm.org/D49188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

ABataev added a comment. Tests? Repository: rC Clang https://reviews.llvm.org/D49188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >