[PATCH] D49305: [analyzer] Fix the Z3 backend always generating unsigned APSInt

This revision was automatically updated to reflect the committed changes. Closed by commit rC337169: [analyzer] Fix the Z3 backend always generating unsigned APSInt (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r337169 - [analyzer] Fix the Z3 backend always generating unsigned APSInt

Author: mramalho Date: Mon Jul 16 06:32:22 2018 New Revision: 337169 URL: http://llvm.org/viewvc/llvm-project?rev=337169=rev Log: [analyzer] Fix the Z3 backend always generating unsigned APSInt Summary: In `toAPSInt`, the Z3 backend was not checking the variable `Int`'s type and was always

[PATCH] D49296: [ASTImporter] Fix import of unnamed structs

martong added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:913 - if (D1->isAnonymousStructOrUnion() && D2->isAnonymousStructOrUnion()) { + if (!D1->getDeclName() && !D2->getDeclName()) { // If both anonymous structs/unions are in a record context,

[PATCH] D49296: [ASTImporter] Fix import of unnamed structs

martong updated this revision to Diff 155660. martong marked 6 inline comments as done. martong added a comment. Address review comments Repository: rC Clang https://reviews.llvm.org/D49296 Files: lib/AST/ASTStructuralEquivalence.cpp unittests/AST/ASTImporterTest.cpp

r337167 - [analyzer] Fix constraint being dropped when analyzing a program without taint tracking enabled

Author: mramalho Date: Mon Jul 16 06:14:46 2018 New Revision: 337167 URL: http://llvm.org/viewvc/llvm-project?rev=337167=rev Log: [analyzer] Fix constraint being dropped when analyzing a program without taint tracking enabled Summary: This patch removes the constraint dropping when taint

[PATCH] D49356: [clang-tidy: modernize] Fix modernize-use-equals-default with {} brackets list initialization: patch

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a formatting nit. Comment at: clang-tidy/modernize/UseEqualsDefaultCheck.cpp:100 AccessToFieldInParam, +

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Yes. https://github.com/JonasToth/clang-tools-extra/tree/check_const This is the branch i work on. I got it up to date with the current master for CTE. :) Am 14.07.2018 um 20:59 schrieb Florin Iucha via Phabricator: > 0x8000- added a comment. > > In

[PATCH] D49245: [ASTImporter] Import implicit methods of existing class.

This revision was automatically updated to reflect the committed changes. Closed by commit rC337162: [ASTImporter] Import implicit methods of existing class. (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D49245?vs=155625=155648#toc Repository: rC

r337162 - [ASTImporter] Import implicit methods of existing class.

Author: balazske Date: Mon Jul 16 05:16:39 2018 New Revision: 337162 URL: http://llvm.org/viewvc/llvm-project?rev=337162=rev Log: [ASTImporter] Import implicit methods of existing class. Summary: When an already existing class is encountered during import, check if it has implicit methods that

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. In https://reviews.llvm.org/D49074#1160793, @NoQ wrote: > I'd also rather stick to integer arithmetic and avoid using floats even in > intermediate calculations. It'd be hard to make sure that no rounding errors > kick in if we use floats. Yes, I agree. I

[PATCH] D48562: [clangd] XPC transport layer

sammccall added a comment. Just an initial couple of thoughts here, haven't yet been through in detail. Mostly I wonder if we can use slightly different abstractions in https://reviews.llvm.org/D48559 to so the JSON/XPC parts get the code reuse we want but the work required to call one vs the

r337152 - [Sema] Reword warning for constant captures that are not required

Author: d0k Date: Mon Jul 16 02:52:02 2018 New Revision: 337152 URL: http://llvm.org/viewvc/llvm-project?rev=337152=rev Log: [Sema] Reword warning for constant captures that are not required This is one of the darker corners of C++, make it clear that this is about constants and rephrase it a

[PATCH] D48560: [clangd] JSON <-> XPC conversions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry it took so long for these to get attention. Starting here because it's simple and helps me understand the bigger patches This one looks good, really just nits.

[PATCH] D48764: [Analyzer] Hotfix for iterator checkers: Mark left-hand side of `SymIntExpr` objects as live in the program state maps.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337151: [Analyzer] Mark `SymbolData` parts of iterator position as live in program… (authored by baloghadamsoftware, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r337151 - [Analyzer] Mark `SymbolData` parts of iterator position as live in program state maps

Author: baloghadamsoftware Date: Mon Jul 16 02:27:27 2018 New Revision: 337151 URL: http://llvm.org/viewvc/llvm-project?rev=337151=rev Log: [Analyzer] Mark `SymbolData` parts of iterator position as live in program state maps Marking a symbolic expression as live is non-recursive. In our

[PATCH] D49235: [ASTImporter] Import described template (if any) of function.

balazske updated this revision to Diff 155630. balazske added a comment. - Removed setDescribedFunctionTemplate call. Repository: rC Clang https://reviews.llvm.org/D49235 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48395: Added PublicOnly flag

ioeric added a comment. In https://reviews.llvm.org/D48395#1158869, @juliehockett wrote: > Remember to mark comments as done when they are. Otherwise, LGTM unless > @ioeric has any concerns. No concern if this looks good to Julie. Comment at:

[PATCH] D49235: [ASTImporter] Import described template (if any) of function.

balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:2715 +if (auto *ToFT = dyn_cast(Importer.Import(FromFT))) + ToFunction->setDescribedFunctionTemplate(ToFT); +else a_sidorin wrote: > The function template should be already set

[PATCH] D49293: [ASTImporter] Add support for import of CXXInheritedCtorInitExpr.

balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:6741 + + auto *Ctor = dyn_cast(Importer.Import( + E->getConstructor())); a_sidorin wrote: > cast_or_null? dyn_cast_or_null: Import may return nullptr, but if not, the cast should succeed

[PATCH] D49245: [ASTImporter] Import implicit methods of existing class.

balazske updated this revision to Diff 155625. balazske added a comment. - Small style and comment changes. Repository: rC Clang https://reviews.llvm.org/D49245 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

This revision was automatically updated to reflect the committed changes. Closed by commit rC337148: [Sema] Add fixit for unused lambda captures (authored by alexshap, committed by ). Changed prior to commit: https://reviews.llvm.org/D48845?vs=155616=155624#toc Repository: rC Clang

r337148 - [Sema] Add fixit for unused lambda captures

Author: alexshap Date: Mon Jul 16 00:23:47 2018 New Revision: 337148 URL: http://llvm.org/viewvc/llvm-project?rev=337148=rev Log: [Sema] Add fixit for unused lambda captures This diff adds a fixit to suggest removing unused lambda captures in the appropriate diagnostic. Patch by Andrew

[PATCH] D49296: [ASTImporter] Fix import of unnamed structs

balazske added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:913 - if (D1->isAnonymousStructOrUnion() && D2->isAnonymousStructOrUnion()) { + if (!D1->getDeclName() && !D2->getDeclName()) { // If both anonymous structs/unions are in a record context,

<    1   2