[PATCH] D21767: Fix instantiation of friend function templates

sepavloff updated this revision to Diff 160290. sepavloff added a comment. Rebased the patch, it is still actual. Repository: rC Clang https://reviews.llvm.org/D21767 Files: include/clang/AST/ASTLambda.h include/clang/AST/Decl.h include/clang/Sema/Sema.h lib/AST/Decl.cpp lib/Sema/S

[PATCH] D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer

shuaiwang created this revision. shuaiwang added reviewers: aaron.ballman, JonasToth. Herald added subscribers: cfe-commits, a.sidorin, xazax.hun. Herald added a reviewer: george.karpenkov. - If a function is unresolved, assume it mutates its arguments - Follow unresolved member expressions for ne

[PATCH] D50618: Refactor Darwin driver to refer to runtimes by component

beanz created this revision. beanz added reviewers: phosek, bruno, arphaman. In r335809, Petr Hosek lays out support for what he calls the multiarch runtimes layout. This new way of laying out the directories for runtime libraries is workable for all platforms. Petr did some of the common infrastr

[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL339530: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

r339530 - [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

Author: shuaiwang Date: Sun Aug 12 16:30:05 2018 New Revision: 339530 URL: http://llvm.org/viewvc/llvm-project?rev=339530&view=rev Log: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50605 Modifi

[PATCH] D50617: [ASTMatchers] Let hasObjectExpression also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

shuaiwang created this revision. shuaiwang added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50617 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarro

[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D50605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D50616: [Fixed Point Arithmetic] FixedPointCast

leonardchan created this revision. leonardchan added reviewers: ebevhan, phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. This patch is a part of https://reviews.llvm.org/D48456 in an attempt to split them up. This contains the code for casting between fixed point types and oth

[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

shuaiwang updated this revision to Diff 160273. shuaiwang marked 3 inline comments as done. shuaiwang added a comment. arg_const_range -> const_arg_range Repository: rC Clang https://reviews.llvm.org/D50605 Files: docs/LibASTMatchersReference.html include/clang/AST/ExprCXX.h include/cl

[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

aaron.ballman added inline comments. Comment at: include/clang/AST/ExprCXX.h:3436 using const_arg_iterator = const Expr* const *; + using arg_const_range = llvm::iterator_range; shuaiwang wrote: > aaron.ballman wrote: > > Please name this `const_arg_range`

r339527 - Renaming arg_const_range to const_arg_range; NFC.

Author: aaronballman Date: Sun Aug 12 14:19:22 2018 New Revision: 339527 URL: http://llvm.org/viewvc/llvm-project?rev=339527&view=rev Log: Renaming arg_const_range to const_arg_range; NFC. This form makes more sense (it is a range over constant arguments) and is most consistent with const_arg_it

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 160272. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

shuaiwang updated this revision to Diff 160265. shuaiwang added a comment. update ast matchers doc Repository: rC Clang https://reviews.llvm.org/D50605 Files: docs/LibASTMatchersReference.html include/clang/AST/ExprCXX.h include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/A

[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

shuaiwang marked an inline comment as done. shuaiwang added inline comments. Comment at: include/clang/AST/ExprCXX.h:3436 using const_arg_iterator = const Expr* const *; + using arg_const_range = llvm::iterator_range; aaron.ballman wrote: > Please name this

[PATCH] D50606: [ASTMatchers] Add matchers unresolvedMemberExpr, cxxDependentScopeMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL339522: [ASTMatchers] Add matchers unresolvedMemberExpr, cxxDependentScopeMemberExpr (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews

r339522 - [ASTMatchers] Add matchers unresolvedMemberExpr, cxxDependentScopeMemberExpr

Author: shuaiwang Date: Sun Aug 12 10:34:36 2018 New Revision: 339522 URL: http://llvm.org/viewvc/llvm-project?rev=339522&view=rev Log: [ASTMatchers] Add matchers unresolvedMemberExpr, cxxDependentScopeMemberExpr Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50606 Mo

[PATCH] D50606: [ASTMatchers] Add matchers unresolvedMemberExpr, cxxDependentScopeMemberExpr

shuaiwang updated this revision to Diff 160263. shuaiwang marked 2 inline comments as done. shuaiwang added a comment. undo unrelated changes in doc Repository: rC Clang https://reviews.llvm.org/D50606 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! An attribute really is the right way to go for this sort of thing, and it sounds like you've got a base of users looking for the functionality. Repository: rCTE Clang To

[PATCH] D50214: Add inherited attributes before parsed attributes.

aaron.ballman added subscribers: rsmith, echristo, dlj, nicholas. aaron.ballman edited reviewers, added: rsmith; removed: nicholas, dlj, echristo. aaron.ballman added a comment. In general, I think this is the right way to go. I've added @rsmith to the reviewers because I'm curious what his thoug

[PATCH] D50526: Model type attributes as regular Attrs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for this fantastic work! Comment at: include/clang/Basic/Attr.td:1510 + let Spellings = [Keyword<"__unsafe_unretained">]; + let Documentation

[clang-tools-extra] r339517 - Adding the readability module to the list of dependencies for the C++ Core Guidelines module. Amends r339516 for a failing bot.

Author: aaronballman Date: Sun Aug 12 07:47:16 2018 New Revision: 339517 URL: http://llvm.org/viewvc/llvm-project?rev=339517&view=rev Log: Adding the readability module to the list of dependencies for the C++ Core Guidelines module. Amends r339516 for a failing bot. Modified: clang-tools-ext

[PATCH] D50467: [SEMA] add more -Wfloat-conversion to compound assigment analysis

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D50467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch and great discussion! I've commit in r339516. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 ___ cfe-commits mailing list cfe-commits@l

[clang-tools-extra] r339516 - Add a new check to the readability module that flags uses of "magic numbers" (both floating-point and integral).

Author: aaronballman Date: Sun Aug 12 07:35:13 2018 New Revision: 339516 URL: http://llvm.org/viewvc/llvm-project?rev=339516&view=rev Log: Add a new check to the readability module that flags uses of "magic numbers" (both floating-point and integral). Patch by Florin Iucha Added: clang-too

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

lebedev.ri added a comment. > We are aware that this test will cause warnings on users code through their > dependencies on abseil. > However, from what we know it seems like these warnings are normally > suppressed. > If anyone has a good idea on how to avoid this/has insight on whether this

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24 + + // TODO(hugoeg): refactor matcher to be configurable or just match on any internal access from outside the enclosing namespace. + JonasToth wrote: > Nit: This co

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23 + + Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"), + this); I think this needs a `not(isExpansionInSystemHeader())` in there

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- added a comment. In https://reviews.llvm.org/D49114#1196480, @aaron.ballman wrote: > Alex has had plenty of time to respond, so I'm fine handling any concerns he > has post-commit. Do you need me to commit this on your behalf? Yes, please! Thank you! Author: "Florin Iucha " Repo

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Alex has had plenty of time to respond, so I'm fine handling any concerns he has post-commit. Do you need me to commit this on your behalf? Repository: rCTE Clang Tools Extra

[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Please be sure to regenerate the AST matcher documentation as well, as I'd expect to see some documentation changes from this. Comment at: include/cl

[PATCH] D50606: [ASTMatchers] Add matchers unresolvedMemberExpr, cxxDependentScopeMemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please split out the unrelated changes into their own commit. Comment at: docs/LibASTMatchersReference.html:1168-1173 +Matcher

[PATCH] D50606: [ASTMatchers] Add matchers unresolvedMemberExpr, cxxDependentScopeMemberExpr

shuaiwang created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50606 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/ASTMatchersInternal.cpp lib/ASTMatchers/Dynamic/Registry.cpp