BillyONeal added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
dvyukov wrote:
> BillyONeal wrote:
> >
riccibruno added a comment.
I don't like these bit-field abuses too much but this is
used all over the place in clang and so if this breaks so
many things are going to break.
Repository:
rC Clang
https://reviews.llvm.org/D50643
___
cfe-commits ma
BillyONeal added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:75
assert(G::op_run);
assert(G::n_alive == 1);
}
Actually I just realized that this assert is bogus too;
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, though you don't need review for fixing bots.
Repository:
rC Clang
https://reviews.llvm.org/D50647
___
cfe-commits mailing
deannagarcia updated this revision to Diff 160399.
deannagarcia marked 7 inline comments as done.
https://reviews.llvm.org/D50580
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoNamespaceCheck.cpp
clang-tidy/abseil/NoNamespaceCheck.h
do
deannagarcia added inline comments.
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23
+
+ Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"),
+ this);
aaron.ballman wrote:
> hokein wrote:
> > aaron.ballman wrote:
> >
Szelethus updated this revision to Diff 160398.
Szelethus added a comment.
Moved the checker files to `lib/StaticAnalyzer/Checkers/UninitializedObject/`.
https://reviews.llvm.org/D50504
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/UninitializedObject/Uniniti
Author: eugenezelenko
Date: Mon Aug 13 10:55:48 2018
New Revision: 339590
URL: http://llvm.org/viewvc/llvm-project?rev=339590&view=rev
Log:
[Documentation] Remove unnecessary placeholder, grammar fix in Release Notes.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-to
Author: szelethus
Date: Mon Aug 13 10:55:52 2018
New Revision: 339591
URL: http://llvm.org/viewvc/llvm-project?rev=339591&view=rev
Log:
[analyzer][UninitializedObjectChecker] Refactoring p1.: ImmutableList factory
is no longer static
This patch is the first part of a series of patches to refacto
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339591: [analyzer][UninitializedObjectChecker] Refactoring
p1.: ImmutableList factory… (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
Author: nickdesaulniers
Date: Mon Aug 13 11:07:50 2018
New Revision: 339593
URL: http://llvm.org/viewvc/llvm-project?rev=339593&view=rev
Log:
[Sema] fix -Wfloat-conversion test case.
Summary:
Fixes r339581 ("[SEMA] add more -Wfloat-conversion to
compound assigment analysis").
This test case was
juliehockett closed this revision.
juliehockett added a comment.
Closed in https://reviews.llvm.org/rL339592.
https://reviews.llvm.org/D48908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
erik.pilkington added a comment.
The build came back clean!
https://reviews.llvm.org/D50527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339593: [Sema] fix -Wfloat-conversion test case. (authored
by nickdesaulniers, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50647
Files:
cfe
kbobyrev planned changes to this revision.
kbobyrev added a comment.
As discussed offline, I should update the patch to reflect changes accepted in
https://reviews.llvm.org/D50517.
https://reviews.llvm.org/D50337
___
cfe-commits mailing list
cfe-co
Author: szelethus
Date: Mon Aug 13 11:17:05 2018
New Revision: 339595
URL: http://llvm.org/viewvc/llvm-project?rev=339595&view=rev
Log:
[analyzer][UninitializedObjectChecker] Refactoring p2.: Moving pointer chasing
to a separate file
In this patch, the following classes and functions have been m
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339595: [analyzer][UninitializedObjectChecker] Refactoring
p2.: Moving pointer chasing… (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50504
Files:
lib/Static
leonardchan updated this revision to Diff 160403.
leonardchan marked an inline comment as done.
leonardchan added a comment.
- Checks for sugared types and expressions wrapped in parenthesis
Repository:
rC Clang
https://reviews.llvm.org/D49511
Files:
include/clang/AST/Type.h
include/clan
tra added inline comments.
Comment at: test/SemaCUDA/call-host-fn-from-device.cu:88
__host__ __device__ void class_specific_delete(T *t, U *u) {
- delete t; // ok, call sized device delete even though host has preferable
non-sized version
+ delete t; // expected-error {{refer
Author: szelethus
Date: Mon Aug 13 11:22:22 2018
New Revision: 339596
URL: http://llvm.org/viewvc/llvm-project?rev=339596&view=rev
Log:
[analyzer][UninitializedObjectChecker] Refactoring p3.: printTail moved out
from FieldChainInfo
This is a standalone part of the effort to reduce FieldChainInfo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339596: [analyzer][UninitializedObjectChecker] Refactoring
p3.: printTail moved out… (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50505?vs=159891&id=160406#
ldionne created this revision.
ldionne added reviewers: EricWF, mclow.lists, dexonsmith, hans, rnk.
Herald added subscribers: cfe-commits, christof.
This led to symbol size problems in Chromium, and we expect this may be
the case in other projects built in debug mode too. Instead, unless users
exp
ldionne added a comment.
I opened a straw man proposal to fix this at https://reviews.llvm.org/D50652.
Repository:
rCXX libc++
https://reviews.llvm.org/D49240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
ldionne added a comment.
The intent is for this patch to be cherry-picked onto the LLVM 7 release.
This is a straw man proposal to fix issues raised in
https://reviews.llvm.org/D49240. The idea is that in the future, we would
probably want the non-`internal_linkage` case to be the default. By i
Author: erichkeane
Date: Mon Aug 13 11:33:20 2018
New Revision: 339597
URL: http://llvm.org/viewvc/llvm-project?rev=339597&view=rev
Log:
Enforce instantiation of template multiversion functions
Multiversioned member functions inside of a template type were
not properly being emitted. The soluti
ldionne updated this revision to Diff 160414.
ldionne added a comment.
Update documentation for _LIBCPP_HIDE_FROM_ABI
Repository:
rCXX libc++
https://reviews.llvm.org/D50652
Files:
libcxx/docs/DesignDocs/VisibilityMacros.rst
libcxx/include/__config
Index: libcxx/include/__config
==
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:14249
+
+if (Sema::TypeHasNoDeref(Inner))
+ DeclRef = E;
The sugar was stripped off at the pointer level, but not at the pointee level.
e.g.,
```
typedef int (bobble);
typedef bobble
hugoeg added inline comments.
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23
+
+ Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"),
+ this);
deannagarcia wrote:
> aaron.ballman wrote:
> > hokein wrote:
> > > aaro
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339599: [analyzer][UninitializedObjectChecker] Refactoring
p4.: Wrap FieldRegions and… (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50506?vs=159896&id=16041
Author: szelethus
Date: Mon Aug 13 11:43:08 2018
New Revision: 339599
URL: http://llvm.org/viewvc/llvm-project?rev=339599&view=rev
Log:
[analyzer][UninitializedObjectChecker] Refactoring p4.: Wrap FieldRegions and
reduce weight on FieldChainInfo
Before this patch, FieldChainInfo used a spaghetti
Author: szelethus
Date: Mon Aug 13 11:48:34 2018
New Revision: 339601
URL: http://llvm.org/viewvc/llvm-project?rev=339601&view=rev
Log:
[analyzer][UninitializedObjectChecker] Refactoring p5.: Handle pedantic mode in
the checker class only
Differential Revision: https://reviews.llvm.org/D50508
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339601: [analyzer][UninitializedObjectChecker] Refactoring
p5.: Handle pedantic mode in… (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50508?vs=159901&id=160
lebedev.ri added a comment.
I suspect this might deserve a wider discussion. At least cfe-dev, perhaps?
Repository:
rCXX libc++
https://reviews.llvm.org/D50652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1016
+ if (DstScale > SrcScale) {
+// Need to allocate space before shifting left
+ResultWidth = SrcWidth + DstScale - SrcScale;
In IR, this isn't really "allocating" space.
=
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks. I appreciate the fact that you spelled it all out in the test, too.
LGTM.
Comment at: lib/CodeGen/CGObjCGNU.cpp:3547
+ allSelectors.push_back(entry.first);
Author: abataev
Date: Mon Aug 13 12:04:24 2018
New Revision: 339603
URL: http://llvm.org/viewvc/llvm-project?rev=339603&view=rev
Log:
[OPENMP] Fix emission of the loop doacross constructs.
The number of loops associated with the OpenMP loop constructs should
not be considered as the number loops
leonardchan added a comment.
@rsmith
Comment at: lib/Sema/SemaExpr.cpp:14249
+
+if (Sema::TypeHasNoDeref(Inner))
+ DeclRef = E;
aaron.ballman wrote:
> The sugar was stripped off at the pointer level, but not at the pointee
> level. e.g.,
> ```
> typed
rjmccall added a comment.
We should absolutely have static assertions to check that these bit-field types
don't get larger than 32 bits. A lot of the subclass layouts have been tweaked
to fit that (packing into the tail padding of `Type` on 64-bit targets), so
accidentally overflowing to use m
rnk added a comment.
I'd prefer not to do this, since internal_linkage generates smaller, more
debuggable code by default. I think the symbol table size increase may be
specific to MachO, and it may be possible to work around this by changing ld64
to pool strings for symbols by default. I don't
rjmccall added a comment.
Oh, I missed that there was a separate review for this. A lot of the important
subclasses that need extra storage have been designed with the expectation that
these bit-fields fit within 32 bits. For example, `FunctionType` starts with a
bunch of bit-fields because t
ldionne added a comment.
In https://reviews.llvm.org/D50652#1197775, @rnk wrote:
> I'd prefer not to do this, since internal_linkage generates smaller, more
> debuggable code by default. I think the symbol table size increase may be
> specific to MachO, and it may be possible to work around thi
rjmccall added a comment.
Shouldn't there just be a link in the AST from the instantiated
`FunctionTemplateDecl ` back to the original pattern? Maybe a generalization
of `InstantiatedFromMember` in `RedeclarablableTemplateDecl`?
Repository:
rC Clang
https://reviews.llvm.org/D21767
_
elsteveogrande abandoned this revision.
elsteveogrande added a comment.
Dropped in favor of other fix as mentioned above
Repository:
rC Clang
https://reviews.llvm.org/D38320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Looks like this patch:
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/13867/steps/ninja%20check%201/logs/stdio
FAIL: Clang :: Sema/conversion.c (12530 of 44133)
TEST 'Clang :: Sema/conversion.c' FAILED
Script:
--
: 'RUN: at line 1';
/ho
https://reviews.llvm.org/D50647
On Mon, Aug 13, 2018 at 12:50 PM Vitaly Buka wrote:
>
> Looks like this patch:
>
> http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/13867/steps/ninja%20check%201/logs/stdio
>
>
> FAIL: Clang :: Sema/conversion.c (12530 of 44133)
> ***
riccibruno added a comment.
@rjmccall
I would argue that we should make these bit-fields take 8 bytes for the
following reasons:
1. On 64 bits archs, this is free since we have already 8 bytes of padding here.
2. On 32 bits archs, this a priori increase the size of each Type by 4 bytes.
Howeve
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2
+// RUN: %check_clang_tidy %s abseil-no-internal-deps %t
+
+
hugoeg wrote:
> JonasToth wrote:
> > hugoeg wrote:
> > > hokein wrote:
> > > > nit: please make sure the code f
JonasToth added inline comments.
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23
+
+ Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"),
+ this);
hugoeg wrote:
> deannagarcia wrote:
> > aaron.ballman wrote:
> > > h
cdavis5x added a comment.
Ping.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:14249
+
+if (Sema::TypeHasNoDeref(Inner))
+ DeclRef = E;
leonardchan wrote:
> aaron.ballman wrote:
> > The sugar was stripped off at the pointer level, but not at the pointee
> > lev
mikhail.ramalho added a comment.
I can't comment on the code but it works correctly for me.
I wish I had it a couple of months ago :)
https://reviews.llvm.org/D50594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yup, i hope it'll be comfy now.
https://reviews.llvm.org/D50594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
rnk added a comment.
In https://reviews.llvm.org/D50652#1197780, @ldionne wrote:
> One thing to keep in mind is that we do not have a solution that allows
> removing both `internal_linkage` and `always_inline`. It's either
> `internal_linkage` or `always_inline`, but you can't get rid of both u
hugoeg updated this revision to Diff 160432.
hugoeg marked an inline comment as done.
hugoeg added a comment.
applied corrections from comments
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCh
steveire created this revision.
Herald added a subscriber: cfe-commits.
Migrate callers to print().
dump() should be useful to downstreams and third parties as a debugging
aid. Everyone trips up on this and creates confusing output.
Repository:
rC Clang
https://reviews.llvm.org/D50661
File
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.cpp
Index: lib/Basic/SourceLocation.cpp
==
riccibruno added a comment.
Also I don't understand to comment about the bit-fields of FunctionType fitting
in the padding of Type:
If we have something like
struct Base {
void *p1;
void *p2;
unsigned x;
};
struct Der : Base {
unsigned x;
};
Then on my machine (64 bi
saar.raz updated this revision to Diff 160437.
saar.raz added a comment.
Address Arthur's comments, add missing CorrectDelayedTyposInExpr
Repository:
rC Clang
https://reviews.llvm.org/D41217
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/ExprCXX.h
include/clang/AST/Recursive
bogner added a comment.
The cmake and lit bits all look correct
https://reviews.llvm.org/D50594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne updated this revision to Diff 160440.
ldionne added a comment.
Rewrite all XFAILs in light of issues brought up by Marshall.
Repository:
rCXX libc++
https://reviews.llvm.org/D50341
Files:
libcxx/test/libcxx/memory/aligned_allocation_macro.pass.cpp
libcxx/test/std/language.suppor
mstorsjo created this revision.
mstorsjo added reviewers: rnk, compnerd, phosek, smeenai.
Herald added subscribers: chrib, mgorny.
This is essential when building with -nodefaultlibs.
In some CMake versions (noticed in 3.5.1), the same libraries are picked up
from CMAKE_REQUIRED_LIBRARIES in som
ldionne added a comment.
This works with all the dylibs I have locally, with various combinations of
availability enabled/disabled and all standards. I've asked Marshall to check
on his system, where he initially reported some failures.
Repository:
rCXX libc++
https://reviews.llvm.org/D5034
ldionne added a comment.
In https://reviews.llvm.org/D50652#1197830, @rnk wrote:
> In https://reviews.llvm.org/D50652#1197780, @ldionne wrote:
>
> > One thing to keep in mind is that we do not have a solution that allows
> > removing both `internal_linkage` and `always_inline`. It's either
> >
steveire added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:3063
SourceRange getSourceRange() const override LLVM_READONLY {
-return SourceRange(getLocation(), getLocation());
+return SourceRange(getLocation(), getConstraintExpr()->getLocEnd());
}
-
Author: ahatanak
Date: Mon Aug 13 13:59:57 2018
New Revision: 339613
URL: http://llvm.org/viewvc/llvm-project?rev=339613&view=rev
Log:
Convert if/else to a switch. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.cpp
Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp
URL:
http://llvm.org/viewvc/llvm
saar.raz added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:3063
SourceRange getSourceRange() const override LLVM_READONLY {
-return SourceRange(getLocation(), getLocation());
+return SourceRange(getLocation(), getConstraintExpr()->getLocEnd());
}
-
Meinersbur added inline comments.
Comment at: lib/AST/DeclBase.cpp:854-859
+ auto I = Attrs.begin(), E = Attrs.end();
+ for (; I != E; ++I) {
+if (!(*I)->isInherited())
+ break;
+ }
+ Attrs.insert(I, A);
aaron.ballman wrote:
> The unfortunate part ab
rjmccall added a comment.
In https://reviews.llvm.org/D50630#1197795, @riccibruno wrote:
> @rjmccall
>
> I would argue that we should make these bit-fields take 8 bytes for the
> following reasons:
>
> 1. On 64 bits archs, this is free since we have already a little less than 8
> bytes of paddi
Author: juliehockett
Date: Mon Aug 13 14:39:03 2018
New Revision: 339617
URL: http://llvm.org/viewvc/llvm-project?rev=339617&view=rev
Log:
[clang-doc] Updating BitcodeReader to use llvm::Error
Modified:
clang-tools-extra/trunk/clang-doc/BitcodeReader.cpp
clang-tools-extra/trunk/clang-doc/
juliehockett closed this revision.
juliehockett added a comment.
Closed in https://reviews.llvm.org/rL339617.
https://reviews.llvm.org/D48909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
steveire created this revision.
steveire added reviewers: rsmith, dblaikie, klimek.
Herald added a subscriber: cfe-commits.
A CXXBindTemporaryExpr can appear inside an ImplicitCastExpr, and was
not ignored previously.
Fixes the case reported in PR37327.
Repository:
rC Clang
https://reviews.l
leonardchan updated this revision to Diff 160451.
leonardchan marked 3 inline comments as done.
leonardchan added a comment.
- Remove sugar from pointee types
Repository:
rC Clang
https://reviews.llvm.org/D49511
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/
leonardchan added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:14249
+
+if (Sema::TypeHasNoDeref(Inner))
+ DeclRef = E;
aaron.ballman wrote:
> leonardchan wrote:
> > aaron.ballman wrote:
> > > The sugar was stripped off at the pointer level, but no
Author: juliehockett
Date: Mon Aug 13 14:51:48 2018
New Revision: 339620
URL: http://llvm.org/viewvc/llvm-project?rev=339620&view=rev
Log:
Revert "[clang-doc] Updating BitcodeReader to use llvm::Error"
This reverts commit r339617 for breaking bots.
Modified:
clang-tools-extra/trunk/clang-doc
ldionne updated this revision to Diff 160457.
ldionne added a comment.
Switch from XFAIL to UNSUPPORTED, per Marshall's offline comment.
Repository:
rCXX libc++
https://reviews.llvm.org/D50341
Files:
libcxx/test/libcxx/memory/aligned_allocation_macro.pass.cpp
libcxx/test/std/language.su
Author: rsmith
Date: Mon Aug 13 15:07:11 2018
New Revision: 339624
URL: http://llvm.org/viewvc/llvm-project?rev=339624&view=rev
Log:
Fix Clang warnings and bad #include filenames in r339595 and r339599.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
Author: rsmith
Date: Mon Aug 13 15:07:09 2018
New Revision: 339623
URL: http://llvm.org/viewvc/llvm-project?rev=339623&view=rev
Log:
Model type attributes as regular Attrs.
Specifically, AttributedType now tracks a regular attr::Kind rather than
having its own parallel Kind enumeration, and Attri
This revision was automatically updated to reflect the committed changes.
rsmith marked an inline comment as done.
Closed by commit rC339623: Model type attributes as regular Attrs. (authored by
rsmith, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50526?vs=160207&id=160463
lebedev.ri updated this revision to Diff 160458.
lebedev.ri added a comment.
Ping.
Rebased, now that the https://reviews.llvm.org/D50465 has landed, and we are
now able to properly optimize the ugliest case:
> This comes with `Implicit Conversion Sanitizer - integer sign change`
> (https://rev
mclow.lists added inline comments.
Comment at: libcxx/test/libcxx/memory/aligned_allocation_macro.pass.cpp:18
+// XFAIL: macosx10.8
+// XFAIL: macosx10.7
These should probably be `UNSUPPORTED` as well.
Comment at:
libcxx/test/std/language.su
arphaman updated this revision to Diff 160464.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50571
Files:
clangd/ClangdLSPServer.cpp
clangd/Diagnostics.cpp
clangd/Diagnostics.h
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/AST/Stmt.cpp:121-122
- if (auto *bte = dyn_cast(s))
-s = bte->getSubExpr();
+if (auto *ewc = dyn_cast(s))
+ s = ewc->getSubExpr();
-
ldionne updated this revision to Diff 160465.
ldionne marked an inline comment as done.
ldionne added a comment.
Replace more XFAILs by UNSUPPORTEDs, per Marshall's comment.
Repository:
rCXX libc++
https://reviews.llvm.org/D50341
Files:
libcxx/test/libcxx/memory/aligned_allocation_macro.pa
ldionne added inline comments.
Comment at: libcxx/test/libcxx/memory/aligned_allocation_macro.pass.cpp:18
+// XFAIL: macosx10.8
+// XFAIL: macosx10.7
mclow.lists wrote:
> These should probably be `UNSUPPORTED` as well.
I think the correct thing for those is `XF
arphaman added a comment.
Thanks for fixing this!
You're right we should try to fix it properly to avoid such mistakes in the
future. Checking for stderr from Clangd might work, but I don't think it's the
most optimal solution. What do you think about Clangd exiting with failure on
malformed J
riccibruno added a comment.
In https://reviews.llvm.org/D50630#1197930, @rjmccall wrote:
> In https://reviews.llvm.org/D50630#1197795, @riccibruno wrote:
>
> > @rjmccall
> >
> > I would argue that we should make these bit-fields take 8 bytes for the
> > following reasons:
> >
> > 1. On 64 bits a
emmettneyman created this revision.
emmettneyman added reviewers: morehouse, kcc.
Herald added a subscriber: cfe-commits.
Extended `cxx_loop_proto` to have multiple for loops. Modified
`loop_proto_to_llvm` and `loop_proto_to_cxx` to handle the new protos. In
`loop_proto_to_llvm`, I only translat
Eugene.Zelenko added a comment.
You could use //Differential revision: // in commit description to
close review automatically.
https://reviews.llvm.org/D48909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
morehouse added a comment.
Does having multiple loops one after another change any coverage in the
vectorizer?
Repository:
rC Clang
https://reviews.llvm.org/D50670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
ldionne created this revision.
ldionne added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
These #includes are quite important, since otherwise any
#if TEST_STD_VER > 14 && defined(TEST_HAS_C11_FEATURES)
checks are always
a_sidorin updated this revision to Diff 160477.
a_sidorin edited the summary of this revision.
a_sidorin added a comment.
All declarations are reordered now, not only fields. Also some review comments
were addressed.
Repository:
rC Clang
https://reviews.llvm.org/D44100
Files:
lib/AST/ASTI
a_sidorin marked 2 inline comments as done.
a_sidorin added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1029
+
+ RecordDecl *ToRD = cast(Importer.Import(cast(FromDC)));
+
martong wrote:
> Can't we just import the `FromRD`, why we need that cast at the e
rsmith added a comment.
(Just writing up my archaeology and research so no-one else needs to do it...)
We used to intentionally keep the `Type` bitfields 32 bits long. However, these
commits (accidentally, as far as I can tell) took us past 32 bits for the type
bitfields: https://reviews.llvm.o
Author: george.karpenkov
Date: Mon Aug 13 16:12:43 2018
New Revision: 339629
URL: http://llvm.org/viewvc/llvm-project?rev=339629&view=rev
Log:
[analyzer] [NFC] Introduce separate targets for testing the analyzer:
check-clang-analyzer and check-clang-analyzer-z3
Current testing setup for analyzer
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339629: [analyzer] [NFC] Introduce separate targets for
testing the analyzer: check… (authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50594?vs=160388&id=
Author: george.karpenkov
Date: Mon Aug 13 16:32:15 2018
New Revision: 339631
URL: http://llvm.org/viewvc/llvm-project?rev=339631&view=rev
Log:
[analyzer] Fix UninitializedObjectChecker to not crash on uninitialized "id"
fields
Differential Revision: https://reviews.llvm.org/D50673
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339631: [analyzer] Fix UninitializedObjectChecker to not
crash on uninitialized "id"… (authored by george.karpenkov, committed
by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
htt
dvyukov added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
BillyONeal wrote:
> dvyukov wrote:
> > Bi
craig.topper created this revision.
craig.topper added reviewers: chandlerc, rsmith, rnk.
Herald added a subscriber: eraman.
Another piece of my ongoing to work for prefer-vector-width.
min-legal-vector-width will eventually be used by the X86 backend to know
whether it needs to make 512 bits ty
chandlerc added a comment.
This makes sense to me, but definitely wait for someone more familiar w/
Clang's IR gen to review...
https://reviews.llvm.org/D50678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
101 - 200 of 222 matches
Mail list logo
