[PATCH] D50559: [gnu-objc] Make selector order deterministic.

theraven updated this revision to Diff 160312. theraven added a comment. - Add a test case. Repository: rC Clang https://reviews.llvm.org/D50559 Files: lib/CodeGen/CGObjCGNU.cpp test/CodeGenObjC/gnu-deterministic-selectors.m Index: test/CodeGenObjC/gnu-deterministic-selectors.m ===

[PATCH] D50517: [clangd] Generate incomplete trigrams for the Dex index

This revision was automatically updated to reflect the committed changes. Closed by commit rL339548: [clangd] Generate incomplete trigrams for the Dex index (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50517?vs

[clang-tools-extra] r339548 - [clangd] Generate incomplete trigrams for the Dex index

Author: omtcyfz Date: Mon Aug 13 01:57:06 2018 New Revision: 339548 URL: http://llvm.org/viewvc/llvm-project?rev=339548&view=rev Log: [clangd] Generate incomplete trigrams for the Dex index This patch handles trigram generation "short" identifiers and queries. Trigram generator produces incomplet

[PATCH] D48072: Sema: Fix PR12350 destructor name lookup, addressing (some of) DR244

jmorse added a comment. ping Repository: rC Clang https://reviews.llvm.org/D48072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.h:40 DiagnosticsEngine::Level Severity = DiagnosticsEngine::Note; + unsigned Category; // Since File is only descriptive, we store a separate flag to distinguish Maybe store the string nam

[clang-tools-extra] r339547 - [clangd] Introduce scoring mechanism for SignatureInformations.

Author: kadircet Date: Mon Aug 13 01:40:05 2018 New Revision: 339547 URL: http://llvm.org/viewvc/llvm-project?rev=339547&view=rev Log: [clangd] Introduce scoring mechanism for SignatureInformations. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: mgrang, ioeric, MaskRay, jkorou

[PATCH] D50555: [clangd] Introduce scoring mechanism for SignatureInformations.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE339547: [clangd] Introduce scoring mechanism for SignatureInformations. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D50555?vs=160306&id=160307#toc Reposit

[PATCH] D50555: [clangd] Introduce scoring mechanism for SignatureInformations.

kadircet updated this revision to Diff 160306. kadircet marked 2 inline comments as done. kadircet added a comment. - Rebase & Resolve discussions. - Resolve discussions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50555 Files: clangd/CodeComplete.cpp clangd/Quality.cpp

[PATCH] D50449: [clangd] Support textEdit in addition to insertText.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339543: [clangd] Support textEdit in addition to insertText. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50449 Files:

[clang-tools-extra] r339543 - [clangd] Support textEdit in addition to insertText.

Author: kadircet Date: Mon Aug 13 01:23:01 2018 New Revision: 339543 URL: http://llvm.org/viewvc/llvm-project?rev=339543&view=rev Log: [clangd] Support textEdit in addition to insertText. Summary: Completion replies contains textEdits as well. Note that this change relies on https://reviews.llvm.

[PATCH] D50449: [clangd] Support textEdit in addition to insertText.

kadircet updated this revision to Diff 160303. kadircet added a comment. - Rebase. - Resolve discussions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50449 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/SourceCode.cpp clangd/SourceCode.h unittests/clan

[PATCH] D50517: [clangd] Generate incomplete trigrams for the Dex index

kbobyrev updated this revision to Diff 160302. kbobyrev marked an inline comment as done. kbobyrev edited the summary of this revision. kbobyrev added a comment. Address the post-LGTM comment. https://reviews.llvm.org/D50517 Files: clang-tools-extra/clangd/index/dex/Iterator.h clang-tools-e

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone added a comment. Long-delayed ping! Repository: rCXX libc++ https://reviews.llvm.org/D47111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50443: [clang] Store code completion token range in preprocessor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339540: [clang] Store code completion token range in preprocessor. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50443 F

r339540 - [clang] Store code completion token range in preprocessor.

Author: kadircet Date: Mon Aug 13 01:13:35 2018 New Revision: 339540 URL: http://llvm.org/viewvc/llvm-project?rev=339540&view=rev Log: [clang] Store code completion token range in preprocessor. Summary: This change is to support a new fature in clangd, tests will be send toclang-tools-extra with

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hokein added inline comments. Comment at: docs/clang-tidy/checks/abseil-no-internal-deps.rst:6 + +Gives a warning if code using Abseil depends on internal details. If something is in a namespace or filename/path that includes the word “internal”, code is not allowed to depend u

[PATCH] D50443: [clang] Store code completion token range in preprocessor.

kadircet updated this revision to Diff 160299. kadircet added a comment. - Resolve discussions. - Fix typo. Repository: rC Clang https://reviews.llvm.org/D50443 Files: include/clang/Lex/Preprocessor.h lib/Lex/Preprocessor.cpp Index: lib/Lex/Preprocessor.cpp

[PATCH] D21508: Diagnose friend function template redefinitions

sepavloff updated this revision to Diff 160298. sepavloff added a comment. Rebased the patch Repository: rC Clang https://reviews.llvm.org/D21508 Files: include/clang/AST/DeclBase.h lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/Modules/friend-definition.cpp te

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

hokein added a comment. The check is missing its document, please add one in `docs/clang-tidy/checks/`. Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23 + + Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"), + this);

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:24 + + const auto IsDuration = + expr(hasType(cxxRecordDecl(hasName("::absl::Duration"; maybe call it `DurationExpr` since you have declared the variable as `expr(...

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

Merged both of these to 7.0 in r339538. On Sat, Aug 11, 2018 at 10:34 AM, David Chisnall via cfe-commits wrote: > Thanks, > > That fix looks exactly what is needed - and is something I didn’t realise > FileCheck could do! The order of those matters in the linked binary, but not > in the IR - t

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Thank you very much :) Am 12.08.2018 um 00:17 schrieb Shuai Wang via Phabricator: > shuaiwang added a comment. > > In https://reviews.llvm.org/D45444#1196271, @JonasToth wrote: > >> Always the same with the templates ;) So uninstantiated templates should >> >> jus

<    1   2   3