QF5690 added a comment.
In https://reviews.llvm.org/D44539#1207982, @rjmccall wrote:
> LGTM.
Thanks! What I should do next? Haven't found any info in docs about it :)
Repository:
rC Clang
https://reviews.llvm.org/D44539
___
cfe-commits mailing
Dmitry.Kozhevnikov added a comment.
In https://reviews.llvm.org/D50993#1207757, @jfb wrote:
> Isn't this duplicating code in lib/Support/Unix/Threading.inc with a
> different implementation?
It's definitely duplicating how the thread is created, however, here it's a bit
more complicated as so
Author: omtcyfz
Date: Wed Aug 22 00:17:59 2018
New Revision: 340388
URL: http://llvm.org/viewvc/llvm-project?rev=340388&view=rev
Log:
[clangd] Cleanup after D50897
The wrong diff that was uploaded to Phabricator was building the wrong
index.
Modified:
clang-tools-extra/trunk/clangd/index/dex
rjmccall added a comment.
In https://reviews.llvm.org/D44539#1208780, @QF5690 wrote:
> In https://reviews.llvm.org/D44539#1207982, @rjmccall wrote:
>
> > LGTM.
>
>
> Thanks! What I should do next? Haven't found any info in docs about it :)
https://llvm.org/docs/Contributing.html
It's up to you
ilya-biryukov added a comment.
LG, just a few last nits
Comment at: clangd/Cancellation.cpp:30
+
+TaskHandle createTaskHandle() { return std::make_shared(); }
+
NIT: maybe consider inlining it? Since Task has a public default constructor, I
don't think having
QF5690 added a comment.
> you can ask for commit privileges yourself.
Ok, how do I do it?
Repository:
rC Clang
https://reviews.llvm.org/D44539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
hokein updated this revision to Diff 161891.
hokein added a comment.
Use the std::equal to replace the memcmp.
Repository:
rC Clang
https://reviews.llvm.org/D50967
Files:
lib/Frontend/PrecompiledPreamble.cpp
Index: lib/Frontend/PrecompiledPreamble.cpp
JonasToth added a comment.
Sure, thanks for the fast fix :)
Am 22.08.2018 um 00:04 schrieb Shuai Wang via Phabricator:
> shuaiwang added a comment.
>
> In https://reviews.llvm.org/D50619#1207785, @JonasToth wrote:
>
>> @shuaiwang Unfortunatly the analysis does not pass and fails on an assertio
hokein updated this revision to Diff 161893.
hokein added a comment.
Remove redundant CPlusPlus2a.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51041
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls-cxx17.cpp
Index: test/clang-tid
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:35
+ // it is not ture in C++17's template argument deduction.
+ if (!getLangOpts().CPlusPlus || getLangOpts().CPlusPlus17 ||
+ getLangOpts().CPlusP
JonasToth added a comment.
LGTM
https://reviews.llvm.org/D50862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added a comment.
Please make sure the code follows the LLVM code style, e.g. the variable name
format "CamelName".
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall added a comment.
Please read the developer policy: https://llvm.org/docs/DeveloperPolicy.html
The information is on that page.
Repository:
rC Clang
https://reviews.llvm.org/D44539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov created this revision.
ilya-biryukov added reviewers: ioeric, kbobyrev.
Herald added subscribers: kadircet, jfb, arphaman, jkorous, MaskRay.
Replace them with suffix mappings.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51088
Files:
clangd/index/CanonicalIncl
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks! Looks good.
Comment at: clangd/ClangdServer.cpp:73
+
+ void onPreambleAST(PathRef Path, ASTContext &Ctx,
+ std::shared_ptr PP) override {
---
ilya-biryukov added a comment.
Herald added a subscriber: kadircet.
Sorry for the delay with this one
Comment at: unittests/clangd/ClangdTests.cpp:1002
+
+ auto MainFileCI = buildCompilerInvocation(PI);
+ auto AST =
Just reuse `PreambleCI`?
ilya-biryukov added a comment.
Maybe add tests? Lit tests for code completion (`clang/test/CodeCompletion`)
should be a good fit
Comment at: include/clang/Parse/Parser.h:2971
+ /// signature help working even when it is triggered inside a token.
+ bool CalledOverloadCompleti
a.sidorin added subscribers: NoQ, a.sidorin.
a.sidorin added a comment.
Accidentally noticed about this review via cfe-commits. @NoQ, the change in the
ExprEngine looks a bit dangerous to me. Could you please check?
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:419
+
peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
Looks good to me now that LLVM support has been approved in
https://reviews.llvm.org/D49673
https://reviews.llvm.org/D49674
___
cfe-co
nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D50771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51077
___
cfe-commits mailing list
cfe-commits@lists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340390: [clang-tblgen] Add -print-records and -dump-json
modes. (authored by statham, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50771
Files
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny.
This patch introduces index benchmarks on top of the proposed LLVM benchmark
pull.
The
kbobyrev planned changes to this revision.
kbobyrev added a comment.
The current diff is rather messy and it is also blocked by the parent revision
(https://reviews.llvm.org/D50894). It is likely to change if the parent CMake
structure is changed.
https://reviews.llvm.org/D51090
___
Author: smaksimovic
Date: Wed Aug 22 02:26:25 2018
New Revision: 340391
URL: http://llvm.org/viewvc/llvm-project?rev=340391&view=rev
Log:
[clang][mips] Set __mips_fpr correctly for -mfpxx
Set __mips_fpr to 0 if o32 ABI is used with either -mfpxx
or none of -mfp32, -mfpxx, -mfp64 being specified.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340391: [clang][mips] Set __mips_fpr correctly for -mfpxx
(authored by smaksimovic, committed by ).
Herald added subscribers: llvm-commits, jrtc27.
Changed prior to commit:
https://reviews.llvm.org/D505
ilya-biryukov added a comment.
WRT to the configuration argument, using stack size suggested by @arphaman
seems like a better option. So let's not add any extra options to clangd.
Comment at: clangd/Threading.cpp:76
+
+ if (::pthread_attr_setstacksize(&Attr, 8 * 1024 * 1024)
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D50967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
QF5690 added a comment.
In https://reviews.llvm.org/D44539#1208838, @rjmccall wrote:
> Please read the developer policy: https://llvm.org/docs/DeveloperPolicy.html
>
> The information is on that page.
> We grant commit access to contributors with a track record of submitting high
> quality p
kadircet updated this revision to Diff 161908.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
clangd/Cancellation.h
cla
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:73
+
+ void onPreambleAST(PathRef Path, ASTContext &Ctx,
+ std::shared_ptr PP) override {
hokein wrote:
> ilya-biryukov wrote:
> > hokein wrote:
> > > I think `Ctx` shou
kbobyrev updated this revision to Diff 161909.
kbobyrev marked 4 inline comments as done.
kbobyrev added a subscriber: sammccall.
kbobyrev added a comment.
- Add more comments explaining the difference between `consume()` and
`consumeAndBoost()` and their potential usecases for the clients
- Move
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
owenpan added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:1066-1072
+if (Style.isCpp()) {
+ nextToken();
+ if (FormatTok->Tok.is(tok::kw_namespace)) {
+parseNamespace();
+return;
+ }
+}
owenpan wrote:
> `
JonasToth added a comment.
The fix was effective, the assertion does not fire anymore on the
`ItaniumDemangle.cpp` file
Repository:
rC Clang
https://reviews.llvm.org/D50617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: rksimon
Date: Wed Aug 22 03:08:53 2018
New Revision: 340394
URL: http://llvm.org/viewvc/llvm-project?rev=340394&view=rev
Log:
Fix Wdocumentation warnings. NFCI.
Modified:
cfe/trunk/include/clang/Lex/Lexer.h
cfe/trunk/include/clang/Lex/TokenLexer.h
Modified: cfe/trunk/include/clan
ilya-biryukov added a comment.
Summarizing the offline discussion with @kbobyrev, @ioeric and @sammccall in
two comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:96
+ /// shouldn't apply any boosting to the consumed item.
+ virtual float boost(DocID ID) con
samparker created this revision.
samparker added reviewers: erichkeane, t.p.northover, SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
__ARM_FEATURE_DSP is already set for targets with the +dsp feature. In the
backend, this target feature is als
jrtc27 added a comment.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D43630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: lib/Basic/SourceManager.cpp:1705
// If we haven't found what we want yet, try again, but this time stat()
// each of the files in case the files have changed since we originally
arphaman wrote:
> ioeric wrote:
> >
ioeric added inline comments.
Comment at: clangd/index/CanonicalIncludes.h:44
/// Maps all files matching \p RE to \p CanonicalPath
- void addRegexMapping(llvm::StringRef RE, llvm::StringRef CanonicalPath);
+ void addSuffixMapping(llvm::StringRef Suffix, llvm::StringRef Cano
dmgreen added a comment.
Thanks
https://reviews.llvm.org/D49674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340398: [AArch64] Add Tiny Code Model for AArch64 (authored
by dmgreen, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49674
Files:
include/clang/Driver/CC1Options.td
lib/CodeGen/B
Author: dmgreen
Date: Wed Aug 22 04:34:28 2018
New Revision: 340398
URL: http://llvm.org/viewvc/llvm-project?rev=340398&view=rev
Log:
[AArch64] Add Tiny Code Model for AArch64
Adds a tiny code model to Clang along side rL340397.
Differential Revision: https://reviews.llvm.org/D49674
Modified:
Author: statham
Date: Wed Aug 22 02:20:39 2018
New Revision: 340390
URL: http://llvm.org/viewvc/llvm-project?rev=340390&view=rev
Log:
[clang-tblgen] Add -print-records and -dump-json modes.
Currently, if clang-tblgen is run without a mode option, it defaults
to the first mode in its 'enum Action'
Author: ibiryukov
Date: Wed Aug 22 04:39:16 2018
New Revision: 340401
URL: http://llvm.org/viewvc/llvm-project?rev=340401&view=rev
Log:
[clangd] Add callbacks on parsed AST in addition to parsed preambles
Summary:
Will be used for updating the dynamic index on updates to the open files.
Currently
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340401: [clangd] Add callbacks on parsed AST in addition to
parsed preambles (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340402: Fix import of class templates partial specialization
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50451?vs=16
Author: martong
Date: Wed Aug 22 04:52:14 2018
New Revision: 340402
URL: http://llvm.org/viewvc/llvm-project?rev=340402&view=rev
Log:
Fix import of class templates partial specialization
Summary:
Currently there are several issues with the import of class template
specializations. (1) Different
ilya-biryukov updated this revision to Diff 161924.
ilya-biryukov added a comment.
- Rebase onto head
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50889
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
Index: cl
samparker updated this revision to Diff 161925.
samparker added a comment.
Added test for armv8m.main+dsp.
https://reviews.llvm.org/D51093
Files:
lib/Basic/Targets/ARM.cpp
test/Preprocessor/arm-acle-6.4.c
Index: test/Preprocessor/arm-acle-6.4.c
hokein updated this revision to Diff 161927.
hokein added a comment.
Herald added a subscriber: kadircet.
Update the patch based on our offline discussion
- only one single clang intefaces implementation, and move finding references
to current symbol collector;
- store references in SymbolSlab;
Author: hokein
Date: Wed Aug 22 05:34:04 2018
New Revision: 340403
URL: http://llvm.org/viewvc/llvm-project?rev=340403&view=rev
Log:
[Preamble] Fix an undefined behavior when checking an empty preamble can be
reused.
Summary: Passing nullptr to memcmp is UB.
Reviewers: ilya-biryukov
Reviewed B
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340403: [Preamble] Fix an undefined behavior when checking
an empty preamble can be… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340404: [clangd] Make FileIndex aware of the main file
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50889?vs=161924&id=161930#toc
Repository:
rCTE Clan
Author: ibiryukov
Date: Wed Aug 22 05:43:17 2018
New Revision: 340404
URL: http://llvm.org/viewvc/llvm-project?rev=340404&view=rev
Log:
[clangd] Make FileIndex aware of the main file
Summary:
It was previously only indexing the preamble decls. The new
implementation will index both the preamble a
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/index/CanonicalIncludes.h:44
/// Maps all files matching \p RE to \p CanonicalPath
- void addRegexMapping(llvm::StringRef RE, llvm::StringRef CanonicalPath);
+ void addSuf
ilya-biryukov updated this revision to Diff 161932.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- s/addSuffixMapping/addFileSuffixMapping
- Document the intention of MaxSuffixComponents
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51088
File
JonasToth added inline comments.
Comment at: clang-tidy/abseil/StrCatAppendCheck.cpp:28
+ for (;;) {
+if (const auto *MTE = dyn_cast(E)) {
+ E = MTE->getTemporary();
You can ellide the braces for the single stmt ifs
Comment at: clang-
kbobyrev updated this revision to Diff 161936.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Address remaining comments.
https://reviews.llvm.org/D50970
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tool
ioeric updated this revision to Diff 161937.
ioeric added a comment.
- minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.cpp
clang
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/CanonicalIncludes.cpp:24
+ int Components = 0;
+ for (auto It = llvm::sys::path::begin(Suffix),
+End = llvm::sys::path::end(Suffix)
hokein added a comment.
Looks good mostly, a few nits. We should make sure all related comments are
updated accordingly
Comment at: clangd/CodeComplete.cpp:198
+static std::vector
+getVirtualNonOverridenMethods(const DeclContext *DC, Sema *S) {
+ const auto *CR = llvm::dyn_ca
MTC added a comment.
In https://reviews.llvm.org/D48027#1207645, @xazax.hun wrote:
> Sorry for the delay, I think this is OK to commit.
> As a possible improvement, I can imagine making it slightly stricter, e.g.
> you could only skip QualifiedNames for inline namespaces and the beginning.
> M
Author: ericwf
Date: Wed Aug 22 06:29:52 2018
New Revision: 340406
URL: http://llvm.org/viewvc/llvm-project?rev=340406&view=rev
Log:
Attempt to unbreak filesystem tests on certain linux distros.
On some platforms clock_gettime is in librt, which we don't
link by default when building the tests. H
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340407: [analyzer] Improve `CallDescription` to handle c++
method. (authored by henrywong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48027?vs=161217&id=161938#toc
Repository:
Author: henrywong
Date: Wed Aug 22 06:30:46 2018
New Revision: 340407
URL: http://llvm.org/viewvc/llvm-project?rev=340407&view=rev
Log:
[analyzer] Improve `CallDescription` to handle c++ method.
Summary:
`CallDecription` can only handle function for the time being. If we want to
match c++ method
ilya-biryukov added inline comments.
Comment at: clangd/index/Index.cpp:139
+std::sort(Occurrences.begin(), Occurrences.end(),
+ [](const SymbolOccurrence &L, const SymbolOccurrence &R) {
+return L < R;
NIT: remove the lambda? usi
deannagarcia updated this revision to Diff 161939.
deannagarcia marked 2 inline comments as done.
https://reviews.llvm.org/D50580
Files:
clang-tidy/abseil/AbseilMatcher.h
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoNamespaceCheck.cpp
clang
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: ahatanak
Date: Wed Aug 22 06:41:19 2018
New Revision: 340408
URL: http://llvm.org/viewvc/llvm-project?rev=340408&view=rev
Log:
[CodeGen] Look at the type of a block capture field rather than the type
of the captured variable when determining whether the capture needs
special handing when t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340408: [CodeGen] Look at the type of a block capture field
rather than the type (authored by ahatanak, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
deannagarcia created this revision.
deannagarcia added reviewers: aaron.ballman, hokein.
deannagarcia added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Adds the Abseil prefix to the list of prefixes in the documentation
https://reviews.llvm.org/D51100
Files:
docs/clang
Author: omtcyfz
Date: Wed Aug 22 06:44:15 2018
New Revision: 340409
URL: http://llvm.org/viewvc/llvm-project?rev=340409&view=rev
Log:
[clangd] Implement BOOST iterator
This patch introduces BOOST iterator - a substantial block for efficient
and high-quality symbol retrieval. The concept of boosti
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340409: [clangd] Implement BOOST iterator (authored by
omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50970?vs=161936&id=161944#toc
Repository:
rCTE Clang Tools Extra
ilya-biryukov updated this revision to Diff 161945.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Use std::distance instead of an explicit loop
- Merge break into loop condition
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51088
Files:
cla
ilya-biryukov added inline comments.
Comment at: clangd/index/CanonicalIncludes.cpp:24
+ int Components = 0;
+ for (auto It = llvm::sys::path::begin(Suffix),
+End = llvm::sys::path::end(Suffix);
ioeric wrote:
> Would `int Components = begin(Suffix)
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D51100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
stryku updated this revision to Diff 161943.
stryku added a comment.
@Rakete Thank you for the comments. You're perfectly right, there was an
issue in my code. I've fixed it and also E1 and E2 will be sequenced only in
C++ >= 17.
https://reviews.llvm.org/D50766
Files:
lib/Sema/SemaCheck
Author: ibiryukov
Date: Wed Aug 22 06:51:19 2018
New Revision: 340410
URL: http://llvm.org/viewvc/llvm-project?rev=340410&view=rev
Log:
[clangd] Get rid of regexes in CanonicalIncludes
Summary: Replace them with suffix mappings.
Reviewers: ioeric, kbobyrev
Reviewed By: ioeric
Subscribers: Mask
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340410: [clangd] Get rid of regexes in CanonicalIncludes
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51088?vs=161945&id=161946#toc
Repository:
rCTE Cl
lebedev.ri added a comment.
Test coverage?
Also, please always upload all patches with full context (`-U9`)
https://reviews.llvm.org/D50766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Hi Richard,
> This is incorrect. Implicit function declarations declare unprototyped
> functions, which are *not* variadic, and are in fact supported by Clang's
> OpenCL language mode.
We have removed the support for the unprototyped functions from the OpenCL as
well. See commit: https://revie
Author: hokein
Date: Wed Aug 22 06:58:25 2018
New Revision: 340411
URL: http://llvm.org/viewvc/llvm-project?rev=340411&view=rev
Log:
[clang-tidy] Abseil: faster strsplit delimiter check
This check is an abseil specific check that checks for code using single
character string literals as delimite
kbobyrev updated this revision to Diff 161947.
kbobyrev edited the summary of this revision.
kbobyrev added a reviewer: sammccall.
kbobyrev added a comment.
Rebase on top of BOOST iterator patch, update tests.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/Iterator.
ilya-biryukov added a comment.
Sorry, missed the dependent revision adding tests to clangd at first. Having
another test in sema would still be great, to make sure we guard against
regressions if someone does not have clang-tools-extra checked out.
Repository:
rC Clang
https://reviews.llvm.
hokein closed this revision.
hokein added a comment.
Committed in https://reviews.llvm.org/rL340411.
https://reviews.llvm.org/D50862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Wed Aug 22 07:03:30 2018
New Revision: 340412
URL: http://llvm.org/viewvc/llvm-project?rev=340412&view=rev
Log:
[clang-tidy] Add Abseil prefix to documentation
Summary: Adds the Abseil prefix to the list of prefixes in the documentation
Patch by Deanna Garcia!
Reviewers: aa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340412: [clang-tidy] Add Abseil prefix to documentation
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51100?vs=161940&i
kbobyrev updated this revision to Diff 161952.
kbobyrev added a comment.
Use better wording for internal `LimitIterator` documentation, perform minor
code cleanup.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/dex/Iter
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, ioeric, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
We were handling the EnableFunctionArgSnippets only when we are producing LSP
response. Move that code into CompletionItem generation so that
stryku added a comment.
Thanks for the advice. Should I update a new diff with `-U9`?
About tests. I've probably missed something but I looked through the project
and didn't find any tests for unsequenced operations. If you know a place where
such tests are placed, please point it and I'll
troyj added a comment.
Hi, I got here via llvm-dev => https://reviews.llvm.org/D9375 =>
https://reviews.llvm.org/D9403 (this) and have read through everything. I see
that this patch has been stalled for about a year and I would like to know its
status. Is it waiting on a resolution in LLVM fo
Dmitry.Kozhevnikov updated this revision to Diff 161954.
Dmitry.Kozhevnikov added a comment.
I've moved the platform-specific implementation to LLVM/Support/Threading and
created https://reviews.llvm.org/D51103.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50993
Files:
cla
melver updated this revision to Diff 161960.
melver marked 8 inline comments as done.
melver added a comment.
Many thanks for the suggestions!
PTAL.
Repository:
rC Clang
https://reviews.llvm.org/D51036
Files:
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/NamespaceEndCommen
hokein updated this revision to Diff 161962.
hokein marked 6 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
Files:
clangd/index/FileIndex.cpp
clangd/index/Index.cpp
clangd/index/Index.h
clan
kadircet updated this revision to Diff 161963.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Resolve discussions.
- Fix a bug inside summarizeOverride.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
Files:
clangd/CodeComplete.cpp
clangd/CodeCo
kadircet updated this revision to Diff 161966.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Resolve discussions.
- Add tests.
- Fix a bug noticed by lit tests.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/Par
hugoeg updated this revision to Diff 161970.
hugoeg marked 11 inline comments as done.
hugoeg added a comment.
applied corrections from comments
https://reviews.llvm.org/D51061
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/StrCatAppendChe
hugoeg added inline comments.
Comment at: test/clang-tidy/abseil-str-cat-append.cpp:91
+
+void bar() {
+ std::string a, b;
JonasToth wrote:
> What happens if `StrCat` is used e.g. in an `std::accumulate` call as the
> binary operator? (https://en.cppreference.c
1 - 100 of 201 matches
Mail list logo
