r340696 - [index] Introduce 'ProtocolInterface' as part of SymbolPropertySet

2018-08-25 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Sat Aug 25 23:27:23 2018 New Revision: 340696 URL: http://llvm.org/viewvc/llvm-project?rev=340696&view=rev Log: [index] Introduce 'ProtocolInterface' as part of SymbolPropertySet This is useful to directly infer that a method or property is from a protocol interface at t

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

2018-08-25 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray created this revision. lichray added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added a subscriber: christof. Avoid buffer overflow by replacing the pointer interface with an array reference interface in C++2a. Tentatively ready on Batavia2018. https://wg21.

[PATCH] D51265: Headers: fix collisions with .h files of other projects

2018-08-25 Thread Andrew Kelley via Phabricator via cfe-commits
andrewrk updated this revision to Diff 162574. andrewrk added a comment. Addressed review feedback Repository: rC Clang https://reviews.llvm.org/D51265 Files: lib/Headers/stdarg.h lib/Headers/stddef.h Index: lib/Headers/stddef.h =

[PATCH] D51265: Headers: fix collisions with .h files of other projects

2018-08-25 Thread Josh Junon via Phabricator via cfe-commits
Qix- added inline comments. Comment at: lib/Headers/stdarg.h:30 #ifndef _VA_LIST +#ifndef _VA_LIST_T typedef __builtin_va_list va_list; Super nit-picky but you could condense this a bit by using ``` #if !defined(_VA_LIST) && !defined(_VA_LIST_T) ``` and a sin

[PATCH] D51265: Headers: fix collisions with .h files of other projects

2018-08-25 Thread Andrew Kelley via Phabricator via cfe-commits
andrewrk created this revision. andrewrk added reviewers: eli.friedman, krememek, ddunbar, lattner. andrewrk added a project: clang. Herald added a subscriber: cfe-commits. stdarg.h: - va_list - macos _va_list.h was duplicately defining va_list. Fixed by this ifndef _VA_LIST_T - additionally def

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2018-08-25 Thread Ryan Stringham via Phabricator via cfe-commits
stringham added a comment. @djasper can you give some direction here? Would you be okay with me extending the BracketAlignmentStyle option? What do I need to do to get this change merged? https://reviews.llvm.org/D33029 ___ cfe-commits mailing list

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2018-08-25 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. @stringham Here is what I did to run the unit tests: cd build make FormatTests tools/clang/unittests/Format/FormatTests https://reviews.llvm.org/D33029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

2018-08-25 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D37624#1211748, @apazos wrote: > Hello folks, is there a plan to merge this feature still? There's still a desire for the underlying functionality. We still need, as I recall, to figure out what's supposed to happen for C++ functions. http

[PATCH] D51187: Thread safety analysis: Warn on double (un-)lock of scoped capability

2018-08-25 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert updated this revision to Diff 162562. aaronpuchert added a comment. Use Locked flag to determine whether to unlock on destruction Instead of unlocking the mutexes that are still available while not complaining about those that aren't, we use the status of the scoped capability to d

[PATCH] D51262: Implement P0553 and P0556

2018-08-25 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I should also mention that as a conforming extension, I have implemented the non-numeric bit operations for `std::byte` https://reviews.llvm.org/D51262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D51262: Implement P0553 and P0556

2018-08-25 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists created this revision. mclow.lists added reviewers: EricWF, ldionne. Herald added a subscriber: christof. LWG adopted https://wg21.link/P0553 in Rapperswil, and suggested minor changes to https://wg21.link/P0556. They kind of go together; for example, `ispow2` is easily implemented u

[PATCH] D50101: [asan] Update a vector's storage annotation during destruction.

2018-08-25 Thread Ben via Phabricator via cfe-commits
bobsayshilol added a comment. Pinging this as it's been "Ready to Land" for a while and I want to check that that's not because I've forgotten to do something? Repository: rCXX libc++ https://reviews.llvm.org/D50101 ___ cfe-commits mailing list

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

2018-08-25 Thread Francois JEAN via Phabricator via cfe-commits
Wawha added a comment. Hi klimek, do you have time to take a look again to this patch? Is my last patch ok for you? best regards, François Repository: rC Clang https://reviews.llvm.org/D44609 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2018-08-25 Thread Thomas via Phabricator via cfe-commits
zroug added a comment. I'd also like to note that this is the code style preferred by most modern code formatters that I know of and use: - rustfmt for rust code - prettier for javascript code - black for python code https://reviews.llvm.org/D33029 __

[PATCH] D51261: Add preload option to clang-query

2018-08-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. This allows loading a file with pre-defined let commands for example. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51261 Files: clang-query/tool/ClangQuery.cpp Index: clang-query/tool/ClangQuery.cpp =

[PATCH] D51260: Extract runCommandsInFile method

2018-08-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51260 Files: clang-query/tool/ClangQuery.cpp Index: clang-query/tool/ClangQuery.cpp === --- c

[PATCH] D51258: Extract parseBindID method

2018-08-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51258 Files: include/clang/ASTMatchers/Dynamic/Parser.h lib/ASTMatchers/Dynamic/Parser.cpp Index: lib/ASTMatchers/Dynamic/Parser.cpp =

[PATCH] D51259: Allow binding to NamedValue resulting from let expression

2018-08-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51259 Files: lib/ASTMatchers/Dynamic/Parser.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp Index: unittests/ASTMatchers/Dynamic/ParserTest.cpp

[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

2018-08-25 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340681: [CUDA/OpenMP] Define only some host macros during device compilation (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r340681 - [CUDA/OpenMP] Define only some host macros during device compilation

2018-08-25 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Sat Aug 25 06:42:40 2018 New Revision: 340681 URL: http://llvm.org/viewvc/llvm-project?rev=340681&view=rev Log: [CUDA/OpenMP] Define only some host macros during device compilation When compiling CUDA or OpenMP device code Clang parses header files that expect certain prede

[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

2018-08-25 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In https://reviews.llvm.org/D50845#1212643, @tra wrote: > Please keep an eye on CUDA buildbot > http://lab.llvm.org:8011/builders/clang-cuda-build. > It runs fair amount of tests with libc++ and handful of libstdc++ versions > and may a canary if these changes break s

[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

2018-08-25 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 162543. Hahnfeld added a comment. Based on libc++ I guessed some more macros that may be needed on macOS and Windows. As I can't test myself if somebody else could report if this change is regressing CUDA support on these platforms. https://reviews.llvm.o