Sorry about that. I wasn't familiar with the python bindings.
Your bisect is correct, we changed the behavior that test is testing: now
an approximate match will be returned.
I guess either:
- just remove that test (depending on how we feel about smoke-testing vs
exhaustively testing wrapperl lik
xbolva00 added a comment.
As noted, this in under LiteralConversion (-Wconversion). GCC has it too under
-Wconversion, so I think it is fine as is, or?
@rsmith
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny added a comment.
Unless my bisect is mistaken, this broke Clang Python binding test:
https://github.com/llvm-mirror/clang/blob/master/bindings/python/tests/cindex/test_cdb.py#L34
The test apparently assumes that compilation database will not return anything
for a file that does not exist.
ahatanak added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov added a comment.
@Szelethus I take it this is mostly formed from @NoQ email? Language could use
polishing in quite a few places, could I just commandeer this revision and try
to fix it?
Comment at: www/analyzer/open_projects.html:29
+Implement a dataflow
NoQ added a comment.
> is it though?
If we simply add a new menu point, it'll require us to modify a huge number of
files. We might get away with good comments that explain the situation and
making sure that all changes are done with sed, but i guess we'll still be
stuck forever.
> HTML files
george.karpenkov added a comment.
> This too will most likely require server maintainers to intervene, so i think
> fixing SSI is more realistic.
Not really.
The way it is done e.g. for
http://clang.llvm.org/docs/LibASTMatchersReference.html is the HTML files are
in the repo, there is a script
NoQ added a comment.
> we probably also should be moving towards an auto-generated model anyway, if
> we want to e.g. automatically build sections of a website from the code.
This too will most likely require server maintainers to intervene, so i think
fixing SSI is more realistic.
https://re
george.karpenkov added a comment.
> inline the header into every page, which is horrible
is it though?
we probably also should be moving towards an auto-generated model anyway, if we
want to e.g. automatically build sections of a website from the code.
https://reviews.llvm.org/D52984
_
Author: george.karpenkov
Date: Thu Oct 11 17:52:13 2018
New Revision: 344322
URL: http://llvm.org/viewvc/llvm-project?rev=344322&view=rev
Log:
[analyzer] Fix a bug in unexplored_first_location_queue iteration order.
Pointed out by Artem in post-commit review for https://reviews.llvm.org/D53058
M
NoQ added a comment.
In https://reviews.llvm.org/D52984#1260761, @george.karpenkov wrote:
> @Szelethus @xazax.hun Since you guys are looking into the website, do you
> know why the top bar has disappeared from all pages? (E.g.
> http://clang-analyzer.llvm.org/available_checks.html )
The relev
Author: rsmith
Date: Thu Oct 11 16:48:11 2018
New Revision: 344319
URL: http://llvm.org/viewvc/llvm-project?rev=344319&view=rev
Log:
Update user's manual documentation of profile remapping file to match
llvm-cxxmap documentation.
Add a hint as to how to perform off-line profile data remapping.
M
Szelethus updated this revision to Diff 169342.
Szelethus edited the summary of this revision.
Szelethus added a comment.
- Removed osx.cocoa.Loops, will be placed in implicit_checks.html
I still didn't add more description to objc checkers for the reasons stated
above.
https://reviews.llvm.or
rsmith abandoned this revision.
rsmith added a comment.
Herald added a subscriber: dang.
The constituent pieces have all landed.
https://reviews.llvm.org/D51240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: george.karpenkov
Date: Thu Oct 11 15:59:59 2018
New Revision: 344313
URL: http://llvm.org/viewvc/llvm-project?rev=344313&view=rev
Log:
[analyzer] Experiment with an iteration order only based on location, and not
using the stack frame
Differential Revision: https://reviews.llvm.org/D5305
Author: george.karpenkov
Date: Thu Oct 11 15:59:38 2018
New Revision: 344312
URL: http://llvm.org/viewvc/llvm-project?rev=344312&view=rev
Log:
[analyzer] Avoid unneeded invalidation in RetainCountChecker
Differential Revision: https://reviews.llvm.org/D53168
Modified:
cfe/trunk/lib/StaticAn
Author: george.karpenkov
Date: Thu Oct 11 15:59:16 2018
New Revision: 344311
URL: http://llvm.org/viewvc/llvm-project?rev=344311&view=rev
Log:
[analyzer] Retain count checker for OSObject: recognize OSDynamicCast
For now, tresting the cast as a no-op, and disregarding the case where
the output be
NoQ added a comment.
> In addition 2018 Bay Area LLVM Developers' Meetings may bring some new open
> projects :)
Actually, let's commit this before the conference, even if it's not perfect, so
that people who suddenly get inspired to work on Static Analyzer already had an
updated list :)
==
rsmith added inline comments.
Comment at: lib/Sema/SemaType.cpp:2231
}
+
+ if (isa(ArraySize))
xbolva00 wrote:
> @rsmith what about this place for check?
This is still evaluating the expression twice. To avoid that, you need to
change the existing co
Author: eugenezelenko
Date: Thu Oct 11 14:40:32 2018
New Revision: 344299
URL: http://llvm.org/viewvc/llvm-project?rev=344299&view=rev
Log:
[Documentation] Rephrase modernize-deprecated-ios-base-aliases description. Add
clangd and clang-doc placeholders in Release Notes.
Modified:
clang-tool
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:205
+ llvm::cl::OptionCategory &Category) {
+ auto OptionsParser =
+ CommonOptionsParser::create(argc, argv, Category, llvm::cl::ZeroOrMore);
--
nruslan added a comment.
@hans, @craig.topper : If everything is fine, can someone check in the clang
and llvm patches on my behalf? I do not have commit access.
https://reviews.llvm.org/D53102
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: danalbert
Date: Thu Oct 11 14:28:42 2018
New Revision: 344297
URL: http://llvm.org/viewvc/llvm-project?rev=344297&view=rev
Log:
Revert "[Driver] Default Android toolchains to libc++."
Breaks some of the Android bots because they aren't expecting to need
to explicitly set -stdlib.
This re
juliehockett updated this revision to Diff 169304.
https://reviews.llvm.org/D53170
Files:
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
===
--- clang-tools-extra/clang-
leonardchan added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:90-92
+static llvm::cl::opt
+ClangDocExecutorName("doc-executor", llvm::cl::desc("The name of the
executor to use in clang-doc."),
+ llvm::cl::init("all-TUs"));
-
juliehockett created this revision.
juliehockett added reviewers: ioeric, leonardchan, jakehehrlich, lebedev.ri,
phosek.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
Since we generally want to document a whole project, not just one file.
@ioeric,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344296: [Driver] Default Android toolchains to libc++.
(authored by danalbert, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53109
Files:
cfe
Author: danalbert
Date: Thu Oct 11 13:58:43 2018
New Revision: 344296
URL: http://llvm.org/viewvc/llvm-project?rev=344296&view=rev
Log:
[Driver] Default Android toolchains to libc++.
Reviewers: srhines, pirama, EricWF
Reviewed By: srhines
Subscribers: cfe-commits
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344295: [Driver] Default to `-z now` and `-z relro` on
Android. (authored by danalbert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53117?vs=169133&id=169300#toc
Repository:
rC
Author: danalbert
Date: Thu Oct 11 13:57:54 2018
New Revision: 344295
URL: http://llvm.org/viewvc/llvm-project?rev=344295&view=rev
Log:
[Driver] Default to `-z now` and `-z relro` on Android.
Summary:
RTLD_LAZY is not supported on Android (though failing to use `-z now`
will work since it is assu
xbolva00 added a comment.
In https://reviews.llvm.org/D52750#1261746, @Rakete wrote:
> Nah, you don't even need to call `EvaluateForOverflow` I believe. :) Have a
> look overflow evaluation is done.
Well..
if (!getLangOpts().CPlusPlus11 && E->isIntegerConstantExpr(Context)) {
if (Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344293: [Driver] Fix --hash-style choice for Android.
(authored by danalbert, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53118
Files:
cfe/
Author: danalbert
Date: Thu Oct 11 13:39:32 2018
New Revision: 344293
URL: http://llvm.org/viewvc/llvm-project?rev=344293&view=rev
Log:
[Driver] Fix --hash-style choice for Android.
Summary:
Android supports GNU style hashes as of Marshmallow, so we should be
generating both styles for pre-M targ
russellmcc added a comment.
Sorry for dropping this for so long! Stuff got busy at work and I've been
happily using my fork with this change for some time. I would really like this
to get in, and promise to be responsive to feedback.
Comment at: lib/Format/ContinuationInden
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344288: [python] [tests] Fix calling tests on Windows
(authored by mgorny, committed by ).
Herald added a subscriber: llvm
Author: mgorny
Date: Thu Oct 11 13:26:55 2018
New Revision: 344288
URL: http://llvm.org/viewvc/llvm-project?rev=344288&view=rev
Log:
[python] [tests] Fix calling tests on Windows
Fix passing arguments to the Python test command to use 'env' builtin
CMake command, in order to fix compatibility wit
rsmith added a comment.
In https://reviews.llvm.org/D50766#1262460, @stryku wrote:
> @rsmith Of course. Not sure what's better: to submit one patch per case or
> submit all of them in one patch (didn't deal much with them, not sure how big
> will the change be)?
It's really up to you. I don't
danalbert updated this revision to Diff 169291.
danalbert added a comment.
Addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D53121
Files:
lib/Driver/ToolChains/Arch/ARM.cpp
test/Driver/arm-mfpu.c
Index: test/Driver/arm-mfpu.c
danalbert added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:360
+ unsigned ArchVersion;
+ if (ArchName.empty())
peter.smith wrote:
> Do you need to parse the arch version here? I would expect the -march=armv7
> to be reflected in getARMSu
philip.pfaffe added a comment.
You're right, my bad; I missed the fact that it's EP_OptimizerLast, which has
no equivalent in the new PM. Your implementation is actually correct here.
Did you run your test in a debug build?
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
ymandel added a comment.
Thank you for the detailed comments! They were quite helpful, especially as
this is my first llvm/clang review.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:25
+
+// Finds the location of the relevant "const" token in `Def`.
+llvm::Opt
ymandel updated this revision to Diff 169290.
ymandel marked 11 inline comments as done.
ymandel added a comment.
Comment fix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
russellmcc updated this revision to Diff 169288.
russellmcc added a comment.
Added suggested for loops to the test
https://reviews.llvm.org/D40988
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
unittests/
rnk added a comment.
lgtm
The cmake builtin tools are pretty useful. =)
Repository:
rC Clang
https://reviews.llvm.org/D53151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ymandel updated this revision to Diff 169282.
ymandel added a comment.
Spacing fix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tidy/readability/ConstValueReturnCh
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/readability-const-value-return.rst:7
+Checks for functions with a ``const``-qualified return type and recommends
+removal of the ``const`` keyword. Such use of ``const`` is superfluous, and
+prevents valuab
ymandel updated this revision to Diff 169280.
ymandel added a comment.
comment tweak
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tidy/readability/ConstValueReturnC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344285: [HIP] Remove unused irif bitcode from test (authored
by aaronenyeshi, committed by ).
Herald added subscribers: llvm-commits, jvesely.
Changed prior to commit:
https://reviews.llvm.org/D52673?vs
Author: aaronenyeshi
Date: Thu Oct 11 12:52:32 2018
New Revision: 344285
URL: http://llvm.org/viewvc/llvm-project?rev=344285&view=rev
Log:
[HIP] Remove unused irif bitcode from test
This is part of previous commit [HIP] Replace irif library with hip.amdgcn.bc
Reviewers: yaxunl
Differential Revi
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10881-10882
+S.DiagRuntimeBehavior(
+E->getExprLoc(), E,
+S.PDiag(diag::warn_impcast_literal_float_to_integer)
+<< E->getType() << T << PrettySourceValue << Prett
ymandel updated this revision to Diff 169277.
ymandel added a comment.
Adusted code in respone to comments.
Major differences are:
- more warning in situations where a FixIt can't be suggested.
- more tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10881-10882
+S.DiagRuntimeBehavior(
+E->getExprLoc(), E,
+S.PDiag(diag::warn_impcast_literal_float_to_integer)
+<< E->getType() << T << PrettySourceValue << Prett
stryku added a comment.
@rsmith Of course I would like. Not sure what's better: to submit one patch per
case or submit all of them in one patch (didn't deal much with them, not sure
how big will the change be)?
https://reviews.llvm.org/D50766
___
Author: aaronenyeshi
Date: Thu Oct 11 12:41:54 2018
New Revision: 344281
URL: http://llvm.org/viewvc/llvm-project?rev=344281&view=rev
Log:
[HIP] Replace irif library with hip.amdgcn.bc
No longer use irif amdgcn library, instead we will use the previous fence
functions from new hip.amdgcn.bc bitc
stryku marked an inline comment as done.
stryku added inline comments.
Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wno-unused %s
+
lebedev.ri wrote:
> Rakete wrote:
> > lebedev.ri wrote:
> > > On
kpn added a comment.
I forgot to address the template question. I've spend the past 18 years doing
SystemZ backend work on multiple {,JIT} compilers. I'm not really in a position
to answer your question about how to handle getting these FP bits down into C++
templates. I hope that won't hold up
lebedev.ri added inline comments.
Comment at: include/clang/AST/Expr.h:1791
+ // otherwise.
+ unsigned FPFeatures : 3;
+
Why as the first one, and not after `CanOverflow` ...
Comment at: include/clang/AST/Expr.h:1809
+Opc(opc), CanOve
kpn updated this revision to Diff 169266.
kpn added a comment.
Address review comments.
Add a test case. The test depends on https://reviews.llvm.org/D53157, but it
reads easily enough. Richard, does this work for you?
https://reviews.llvm.org/D52839
Files:
include/clang/AST/Expr.h
lib/AS
Author: sfertile
Date: Thu Oct 11 11:40:35 2018
New Revision: 344276
URL: http://llvm.org/viewvc/llvm-project?rev=344276&view=rev
Log:
Revert "clang-cl: Add /showFilenames option (PR31957)"
This reverts https://reviews.llvm.org/rL344234 which is causing failures on
several bots due to invalid llv
Author: abataev
Date: Thu Oct 11 11:30:31 2018
New Revision: 344273
URL: http://llvm.org/viewvc/llvm-project?rev=344273&view=rev
Log:
[OPENMP][NVPTX]Reduce memory use for globalized vars in
target/teams/distribute regions.
Previously introduced globalization scheme that uses memory coalescing
sch
jfb added a comment.
Overall this seems fine, but I'm no ObjC expert either so I'll defer to
@rjmccall
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:7193
+ if (!GV || GV->getType() != ObjCTypes.ClassnfABITy->getPointerTo()) {
+auto *NewGV = new llvm::GlobalVariable(ObjCType
erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, ahatanak, jfb.
Herald added a subscriber: dexonsmith.
Some ObjC users declare a `extern` variable named `OBJC_CLASS_$_Foo`, then use
it's address as a `Class`. I.e., one could define `isInstanceOfF`:
BOOL isInsta
ABataev added a comment.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D51554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder created this revision.
scott.linder added reviewers: yaxunl, arsenm, kzhuravl, Anastasia.
Herald added subscribers: cfe-commits, wdng.
The rationale for this is that OpenCL provides programmatic access to these
symbols, but not to e.g. non-kernel functions. These symbols should have
mgorny created this revision.
mgorny added a reviewer: rnk.
Fix passing arguments to the pytest command to use 'env' builtin CMake
command, in order to fix compatibility with Windows.
NB: I don't have a Windows environment to test it
Repository:
rC Clang
https://reviews.llvm.org/D53151
File
Author: ioeric
Date: Thu Oct 11 10:50:04 2018
New Revision: 344267
URL: http://llvm.org/viewvc/llvm-project?rev=344267&view=rev
Log:
Revert "[Lex] TokenConcatenation now takes const Preprocessor"
This reverts commit r344262. This was an unintentional commit.
Modified:
cfe/trunk/lib/StaticAn
Author: ioeric
Date: Thu Oct 11 10:49:20 2018
New Revision: 344266
URL: http://llvm.org/viewvc/llvm-project?rev=344266&view=rev
Log:
clang-cl: set output of lit-test to a tmp file after r344234
Some test frameworks do not allow output file in CWD.
Modified:
cfe/trunk/test/Driver/cl-showfilen
Author: mgorny
Date: Thu Oct 11 10:45:35 2018
New Revision: 344263
URL: http://llvm.org/viewvc/llvm-project?rev=344263&view=rev
Log:
[python] [tests] Retab CMakeLists.txt for consistency (NFC)
Modified:
cfe/trunk/bindings/python/tests/CMakeLists.txt
Modified: cfe/trunk/bindings/python/tests/
ymandel added a comment.
Hi,
It looks like this change has disabled FileCheck for all clang-tidy lit tests
that don't use check-prefixes. So, they all trivially pass even if their
CHECK... lines are wrong. An easy repro is just to randomly modify any CHECK
line in a lit file (e.g.
llvm/tool
Author: ioeric
Date: Thu Oct 11 10:35:29 2018
New Revision: 344262
URL: http://llvm.org/viewvc/llvm-project?rev=344262&view=rev
Log:
[Lex] TokenConcatenation now takes const Preprocessor
Differential Revision: https://reviews.llvm.org/D52502
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/U
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mgorny
Date: Thu Oct 11 10:25:05 2018
New Revision: 344260
URL: http://llvm.org/viewvc/llvm-project?rev=344260&view=rev
Log:
[tests] Remove Python tests from check-all due to breakage
Remove the Python tests from default target in order to fix two
kinds of breakage uncovered by enabling t
EricWF added a comment.
Also I'm not sure we want to commit to this ABI where the representation of
types like `day`, `month`, and `year` are smaller than the integer types they
can be constructed from.
https://reviews.llvm.org/D51762
___
cfe-comm
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Have you run `git clang-format` over this change set?
The blocking issues I see are:
- The literal's need to be guarded against older clang dialects. So do their
tests.
- There are
thiagomacieira updated this revision to Diff 169236.
thiagomacieira added a comment.
Updated to check for /etc/os-release first and /usr/lib/os-release if that fails
https://reviews.llvm.org/D53125
Files:
include/clang/Driver/Distro.h
lib/Driver/Distro.cpp
lib/Driver/ToolChains/Linux.cpp
EricWF added a comment.
There also seem to be some non-ASCII characters in this changeset. Could you
hunt them out and destroy them?
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
thiagomacieira added inline comments.
Comment at: lib/Driver/Distro.cpp:139
+ File = VFS.getBufferForFile("/usr/lib/os-release");
+ if (File) {
mgorny wrote:
> Technically speaking, the spec says you are supposed to read
> `/etc/os-release` first and fall ba
patricklyster closed this revision.
patricklyster added a comment.
Closed by commit https://reviews.llvm.org/rL344249 sha:
851f70b951e5e068b0afa6f69ec58e0e80b0a1a4
Repository:
rC Clang
https://reviews.llvm.org/D53079
___
cfe-commits mailing list
sammccall created this revision.
Herald added a subscriber: cfe-commits.
Prototype implementation, no tests yet.
See http://lists.llvm.org/pipermail/cfe-dev/2018-October/059752.html
Repository:
rC Clang
https://reviews.llvm.org/D53145
Files:
include/clang/Tooling/CompilationDatabase.h
in
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:558
+if (const auto *NS = dyn_cast(Ctx))
+ return NS->getQualifiedNameAsString() + "::";
+ return llvm::None;
sammccall wrote:
> does this do the right thing if it's anonymous or inline,
ioeric updated this revision to Diff 169231.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53131
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clan
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Committed in r344259 on @erik.pilkington 's LGTM. Self-accepting so I can close
the review.
https://reviews.llvm.org/D52400
___
cf
Author: aaronballman
Date: Thu Oct 11 09:40:18 2018
New Revision: 344259
URL: http://llvm.org/viewvc/llvm-project?rev=344259&view=rev
Log:
Improve -Wshadow warnings with enumerators.
Addresses PR24718 by checking for enumerators that shadow other enumerators.
Catches issues like:
enum E1{e1};
v
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344258: [tests] Include Python binding tests in CMake rules
(authored by mgorny, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52840
Files:
CMakeLists.txt
bindings/python/tests/CM
This is a patch to fix bug 26547
(https://bugs.llvm.org/show_bug.cgi?id=26547)
This is my first patch, so please give feedback! This should be correct
though, and I've tested it on both Windows x86 (where it does nothing), and
Linux x86 (where it correctly returns alignof(double) = 4, __alignof(do
Author: mgorny
Date: Thu Oct 11 09:32:54 2018
New Revision: 344258
URL: http://llvm.org/viewvc/llvm-project?rev=344258&view=rev
Log:
[tests] Include Python binding tests in CMake rules
Add a new CMake rule check-clang-python to run the Python bindings'
test suite, and include it in check-all.
Di
Author: brad
Date: Thu Oct 11 09:13:44 2018
New Revision: 344257
URL: http://llvm.org/viewvc/llvm-project?rev=344257&view=rev
Log:
Some improvements to the OpenBSD driver.
- OpenBSD has switched to compiler_rt / libcxx
- Fix sysroot and lib path handling
- Some cleaning up
Added:
cfe/trunk/t
nruslan updated this revision to Diff 169224.
nruslan marked 3 inline comments as done.
nruslan added a comment.
@hans , @craig.topper : Updated the patch with all requested changes
https://reviews.llvm.org/D53102
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.
nruslan added inline comments.
Comment at: docs/ClangCommandLineReference.rst:2241
+
+Enable or disable direct TLS access through segment registers
+
hans wrote:
> This file is automatically generated based on the options .td files, so no
> need to update it her
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344256: [clang-move] Remove clang:: qualifier (authored by
MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53060
Files:
clang-tools-ex
Author: maskray
Date: Thu Oct 11 09:09:26 2018
New Revision: 344256
URL: http://llvm.org/viewvc/llvm-project?rev=344256&view=rev
Log:
[clang-move] Remove clang:: qualifier
Summary:
The use sites are enclosed by `namespace clang`, so clang:: is not
necessary. Many unqualified names have already be
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I'm not a CMake expert, but when I apply this patch locally, I'm able to run
cmake to completion without errors, so LGTM!
https://reviews.llvm.org/D52840
juliehockett updated this revision to Diff 169221.
juliehockett added a comment.
Switching to raw strings.
https://reviews.llvm.org/D53085
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp
Index: clang-tools-extra/unittest
peter.smith added a comment.
On reflection after looking at what would be needed for the linker
tools::gnutools::Linker::ConstructJob() I think it may be better to move the
triple detection into a separate function. I'll work on that and will hopefully
post an update soon.
https://reviews.llv
mgorny requested review of this revision.
mgorny added a comment.
Please review the new version, addressing the issue caught by buildbots.
https://reviews.llvm.org/D52840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
hans added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:11976
+
+while (FD && !getDLLAttr(FD) &&
+ !FD->hasAttr() &&
takuto.ikuta wrote:
> hans wrote:
> > takuto.ikuta wrote:
> > > hans wrote:
> > > > Why does this need to be a loop? I d
mgorny updated this revision to Diff 169219.
mgorny added a comment.
v3: one more correction for stand-alone builds.
https://reviews.llvm.org/D52840
Files:
CMakeLists.txt
bindings/python/tests/CMakeLists.txt
Index: bindings/python/tests/CMakeLists.txt
=
mgorny updated this revision to Diff 169218.
mgorny added a comment.
v2: fixed appending to check-all to make it compatible both with in-tree and
standalone builds
https://reviews.llvm.org/D52840
Files:
CMakeLists.txt
bindings/python/tests/CMakeLists.txt
Index: bindings/python/tests/CMak
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/clang/Driver/Job.h:33
// Re-export this as clang::driver::ArgStringList.
-using llvm::opt::ArgStringList;
+using ArgStringList = llvm:
takuto.ikuta added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:11976
+
+while (FD && !getDLLAttr(FD) &&
+ !FD->hasAttr() &&
hans wrote:
> takuto.ikuta wrote:
> > hans wrote:
> > > Why does this need to be a loop? I don't think FunctionD
1 - 100 of 158 matches
Mail list logo
