orivej added a comment.
I don't have the complete picture yet. (This is why the summary is so short.)
I have looked up that `IK_DirectList` `Kind` was known not to carry a valid
`ParenRange` since
https://github.com/llvm-mirror/clang/commit/188158db29f50443b6e412f2a40c800b2669c957,
and that `Pe
Hahnfeld added a comment.
If I read that patch correctly, this will render `-fuse-ld` with non-absolute
paths useless if a toolchain has `DefaultLinker != "ld"`. I don't think that's
what we want to do if the user explicitly sets a different linker.
In https://reviews.llvm.org/D53250#1264626, @
Hahnfeld added a comment.
As said on https://reviews.llvm.org/D53250 I think this is the right way to fix
these tests: We already do the same for `-stdlib=platform` and
`-rtlib=platform`.
Repository:
rC Clang
https://reviews.llvm.org/D53249
___
JonasToth added a comment.
I am in contact with the guy that actually discovered this breakage. It seems
to be a weird and hard to reproduce error, but happens on x86 as well. So it is
a compile/header something combination that results in the error. I am pretty
sure that will take a while unti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344482: [Hexagon] Update tests account for non-hardcoded
linker name. (authored by sidneym, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53219?vs=169491&id=169608#toc
Repository:
Author: sidneym
Date: Sun Oct 14 10:51:36 2018
New Revision: 344482
URL: http://llvm.org/viewvc/llvm-project?rev=344482&view=rev
Log:
[Hexagon] Update tests account for non-hardcoded linker name.
Tests should not assume the linker's name, CLANG_DEFAULT_LINKER could
change it.
Differential Revisi
phosek added a comment.
In https://reviews.llvm.org/D53250#1264708, @Hahnfeld wrote:
> If I read that patch correctly, this will render `-fuse-ld` with non-absolute
> paths useless if a toolchain has `DefaultLinker != "ld"`. I don't think
> that's what we want to do if the user explicitly sets
phosek added a comment.
The way we addressed this for other targets in the past is to explicitly set
`-fuse-ld=ld` for all tests, I made that change in
https://reviews.llvm.org/D53249.
Repository:
rL LLVM
https://reviews.llvm.org/D53219
___
cfe
bobsayshilol created this revision.
bobsayshilol added reviewers: sberg, ahatanak.
Herald added subscribers: cfe-commits, jfb.
`FunctionDecl::Create()` takes as its `T` parameter the type of function that
should be created, not the return type. Passing in the return type looks to
have been copyp
a_sidorin added a comment.
Hi Balázs,
Finally, I have completed the review. Despite the fact that this patch is huge,
I found only a few issues.
Comment at: lib/AST/ASTImporter.cpp:4604
+ if (Error Err = ImportDeclContext(D))
+// FIXME: Really ignore the error?
+cons
sidneym added a comment.
https://reviews.llvm.org/D53219 added a check for either hexagon-ld or ld. I
merged that change earlier today. I can change the test to pass -fuse-ld, let
me know. Thanks,
Repository:
rC Clang
https://reviews.llvm.org/D53249
___
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Comment at: test/CoverageMapping/macros.c:60
+// CHECK-NEXT: func6
+void func6(unsigned count) { // CHECK-NEXT: File 0, [[@LINE]]:28 ->
[[@LINE+4]]:2 = #0
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp:2
+//===-- clang-doc/BitcodeTest.cpp
+//--===//
+//
Nit: I think this should be on the previous line.
https://reviews.llvm.or
jyknight updated this revision to Diff 169641.
jyknight marked 11 inline comments as done.
jyknight added a comment.
Address most comments.
https://reviews.llvm.org/D52939
Files:
clang/include/clang/AST/Expr.h
clang/lib/AST/ExprConstant.cpp
Index: clang/lib/AST/ExprConstant.cpp
===
jyknight added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:12-32
// Constant expression evaluation produces four main results:
//
// * A success/failure flag indicating whether constant folding was
successful.
//This is the 'bool' return value used by mo
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:27
+comments::FullComment *
+getComment(const NamedDecl *D) const {
+ if (RawComment *Comment = D->getASTContext().getRawCommentForDeclNoCache(D))
{
Nit: this func
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp:362
+} // namespace clang
\ No newline at end of file
Nit: this is relevant.
https://reviews.llvm.org/D53085
___
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
NoQ added inline comments.
Herald added a subscriber: donat.nagy.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1756-1760
+ auto stateFound = state->BindExpr(CE, LCtx, RetVal);
+ auto stateNotFound = state->BindExpr(CE, LCtx, SecondParam);
+
+ C.addTransition(sta
NoQ added a comment.
In https://reviews.llvm.org/D32906#1264452, @baloghadamsoftware wrote:
> Unfortunately, we are at the beginning of a long road. I will post several
> new patches that we already test internally. However the only checker with
> acceptable false-positive rate is the `invalida
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D50616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Instead of parsing into structs that mirror LSP, simply parse into a flat struct
that contains the info we need.
This is an exception to
sammccall added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:338
+ Command Cmd;
+ if (Action.command && Action.edit)
+return llvm::None;
kadircet wrote:
> What would you think about emitting two commands in this case? First the edit
> and then t
sammccall updated this revision to Diff 169650.
sammccall marked an inline comment as done.
sammccall added a comment.
update comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53213
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
clan
sammccall added a comment.
Thanks for cleaning this up!
Comment at: clangd/ClangdLSPServer.cpp:433
reparseOpenedFiles();
}
This isn't needed, the compilation database can only be set during
initialization.
Comment at: clangd/Clangd
takuto.ikuta updated this revision to Diff 169652.
takuto.ikuta retitled this revision from "[WIP] Add /Zc:DllexportInlines option
to clang-cl" to "Add /Zc:DllexportInlines option to clang-cl".
takuto.ikuta added a comment.
Export function inside explicit template instantiation definition
https
sammccall added a comment.
(This looks good, of course the Sema patch needs to land first!)
Comment at: clangd/CodeComplete.cpp:643
case CodeCompletionContext::CCC_Recovery:
+ // TODO: Provide identifier based completions for the following two contexts:
+ case CodeCompleti
27 matches
Mail list logo