[PATCH] D53231: [Sema] Fix PR38987: keep end location of a direct initializer list

orivej added a comment. I don't have the complete picture yet. (This is why the summary is so short.) I have looked up that `IK_DirectList` `Kind` was known not to carry a valid `ParenRange` since https://github.com/llvm-mirror/clang/commit/188158db29f50443b6e412f2a40c800b2669c957, and that `Pe

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

Hahnfeld added a comment. If I read that patch correctly, this will render `-fuse-ld` with non-absolute paths useless if a toolchain has `DefaultLinker != "ld"`. I don't think that's what we want to do if the user explicitly sets a different linker. In https://reviews.llvm.org/D53250#1264626, @

[PATCH] D53249: Force Hexagon to use default (hexagon-link) linker

Hahnfeld added a comment. As said on https://reviews.llvm.org/D53250 I think this is the right way to fix these tests: We already do the same for `-stdlib=platform` and `-rtlib=platform`. Repository: rC Clang https://reviews.llvm.org/D53249 ___

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

JonasToth added a comment. I am in contact with the guy that actually discovered this breakage. It seems to be a weird and hard to reproduce error, but happens on x86 as well. So it is a compile/header something combination that results in the error. I am pretty sure that will take a while unti

[PATCH] D53219: Update hexagon driver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL344482: [Hexagon] Update tests account for non-hardcoded linker name. (authored by sidneym, committed by ). Changed prior to commit: https://reviews.llvm.org/D53219?vs=169491&id=169608#toc Repository:

r344482 - [Hexagon] Update tests account for non-hardcoded linker name.

Author: sidneym Date: Sun Oct 14 10:51:36 2018 New Revision: 344482 URL: http://llvm.org/viewvc/llvm-project?rev=344482&view=rev Log: [Hexagon] Update tests account for non-hardcoded linker name. Tests should not assume the linker's name, CLANG_DEFAULT_LINKER could change it. Differential Revisi

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

phosek added a comment. In https://reviews.llvm.org/D53250#1264708, @Hahnfeld wrote: > If I read that patch correctly, this will render `-fuse-ld` with non-absolute > paths useless if a toolchain has `DefaultLinker != "ld"`. I don't think > that's what we want to do if the user explicitly sets

[PATCH] D53219: Update hexagon driver tests

phosek added a comment. The way we addressed this for other targets in the past is to explicitly set `-fuse-ld=ld` for all tests, I made that change in https://reviews.llvm.org/D53249. Repository: rL LLVM https://reviews.llvm.org/D53219 ___ cfe

[PATCH] D53263: [CodeGen] Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol created this revision. bobsayshilol added reviewers: sberg, ahatanak. Herald added subscribers: cfe-commits, jfb. `FunctionDecl::Create()` takes as its `T` parameter the type of function that should be created, not the return type. Passing in the return type looks to have been copyp

[PATCH] D51633: [ASTImporter] Added error handling for AST import.

a_sidorin added a comment. Hi Balázs, Finally, I have completed the review. Despite the fact that this patch is huge, I found only a few issues. Comment at: lib/AST/ASTImporter.cpp:4604 + if (Error Err = ImportDeclContext(D)) +// FIXME: Really ignore the error? +cons

[PATCH] D53249: Force Hexagon to use default (hexagon-link) linker

sidneym added a comment. https://reviews.llvm.org/D53219 added a check for either hexagon-ld or ld. I merged that change earlier today. I can change the test to pass -fuse-ld, let me know. Thanks, Repository: rC Clang https://reviews.llvm.org/D53249 ___

[PATCH] D53244: [Coverage] Fix PR39258: support coverage regions that start deeper than they end

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Comment at: test/CoverageMapping/macros.c:60 +// CHECK-NEXT: func6 +void func6(unsigned count) { // CHECK-NEXT: File 0, [[@LINE]]:28 -> [[@LINE+4]]:2 = #0

[PATCH] D53082: [clang-doc] Add unit tests for bitcode

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp:2 +//===-- clang-doc/BitcodeTest.cpp +//--===// +// Nit: I think this should be on the previous line. https://reviews.llvm.or

[PATCH] D52939: ExprConstant: Propagate correct return values from constant evaluation.

jyknight updated this revision to Diff 169641. jyknight marked 11 inline comments as done. jyknight added a comment. Address most comments. https://reviews.llvm.org/D52939 Files: clang/include/clang/AST/Expr.h clang/lib/AST/ExprConstant.cpp Index: clang/lib/AST/ExprConstant.cpp ===

[PATCH] D52939: ExprConstant: Propagate correct return values from constant evaluation.

jyknight added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12-32 // Constant expression evaluation produces four main results: // // * A success/failure flag indicating whether constant folding was successful. //This is the 'bool' return value used by mo

[PATCH] D53081: [clang-doc] Add unit tests for serialization

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:27 +comments::FullComment * +getComment(const NamedDecl *D) const { + if (RawComment *Comment = D->getASTContext().getRawCommentForDeclNoCache(D)) { Nit: this func

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp:362 +} // namespace clang \ No newline at end of file Nit: this is relevant. https://reviews.llvm.org/D53085 ___

[PATCH] D53150: [clang-doc] Limit integration tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D53150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D32905: [Analyzer] Iterator Checker - Part 9: Evaluation of std::find-like calls

NoQ added inline comments. Herald added a subscriber: donat.nagy. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1756-1760 + auto stateFound = state->BindExpr(CE, LCtx, RetVal); + auto stateNotFound = state->BindExpr(CE, LCtx, SecondParam); + + C.addTransition(sta

[PATCH] D32905: [Analyzer] Iterator Checker - Part 9: Evaluation of std::find-like calls

NoQ added a comment. In https://reviews.llvm.org/D32906#1264452, @baloghadamsoftware wrote: > Unfortunately, we are at the beginning of a long road. I will post several > new patches that we already test internally. However the only checker with > acceptable false-positive rate is the `invalida

[PATCH] D50616: [Fixed Point Arithmetic] FixedPointCast

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D50616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D53266: [clangd] Simplify client capabilities parsing.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Instead of parsing into structs that mirror LSP, simply parse into a flat struct that contains the info we need. This is an exception to

[PATCH] D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)

sammccall added inline comments. Comment at: clangd/ClangdLSPServer.cpp:338 + Command Cmd; + if (Action.command && Action.edit) +return llvm::None; kadircet wrote: > What would you think about emitting two commands in this case? First the edit > and then t

[PATCH] D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)

sammccall updated this revision to Diff 169650. sammccall marked an inline comment as done. sammccall added a comment. update comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53213 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Protocol.cpp clan

[PATCH] D53220: Remove possibility to change compile database path at runtime

sammccall added a comment. Thanks for cleaning this up! Comment at: clangd/ClangdLSPServer.cpp:433 reparseOpenedFiles(); } This isn't needed, the compilation database can only be set during initialization. Comment at: clangd/Clangd

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta updated this revision to Diff 169652. takuto.ikuta retitled this revision from "[WIP] Add /Zc:DllexportInlines option to clang-cl" to "Add /Zc:DllexportInlines option to clang-cl". takuto.ikuta added a comment. Export function inside explicit template instantiation definition https

[PATCH] D53192: [clangd] Do not query index for new name completions.

sammccall added a comment. (This looks good, of course the Sema patch needs to land first!) Comment at: clangd/CodeComplete.cpp:643 case CodeCompletionContext::CCC_Recovery: + // TODO: Provide identifier based completions for the following two contexts: + case CodeCompleti