juliehockett updated this revision to Diff 169754.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM, I'd file a bug about SmallString not taking const char* in its
constructor and I'd also put a TODO somewhere to fix that once that's resolved.
https://reviews.llvm.org/D5308
jakehehrlich accepted this revision.
jakehehrlich added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/unittests/clang-doc/MergeTest.cpp:222
+
+ Expected->DefLoc = Location(10, llvm::SmallString<16>("test.cpp"));
+ Expected->Loc.
jakehehrlich added a comment.
This just seems like a lit test in unit test form, why does this need to use
unit tests and not lit tests?
https://reviews.llvm.org/D53084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: phosek
Date: Mon Oct 15 14:30:32 2018
New Revision: 344556
URL: http://llvm.org/viewvc/llvm-project?rev=344556&view=rev
Log:
[Driver] Support direct split DWARF emission for Fuchsia
This enables the driver support for direct split DWARF emission for
Fuchsia in addition to Linux.
Differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344556: [Driver] Support direct split DWARF emission for
Fuchsia (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53248?vs
george.karpenkov added a comment.
I have tried to clean up the list.
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov updated this revision to Diff 169758.
https://reviews.llvm.org/D53024
Files:
clang/www/analyzer/open_projects.html
Index: clang/www/analyzer/open_projects.html
===
--- clang/www/analyzer/open_projects.html
+++ cla
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
+1, I think this is a great addition!
BTW in theory it should be possible to go wild on compile-time programming, and
generate the entire description string at co
george.karpenkov added a comment.
OK that makes sense to me, just let's be careful not to crash in places where
we weren't crashing before.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:354
+StringRef AnalyzerOptions::getOptionAsString(Optional &V,
+
Szelethus added a comment.
Cheers, thanks for the review!
In https://reviews.llvm.org/D53296#1265927, @george.karpenkov wrote:
> Also, that's a lot of code for printing options. I understand it's hard to do
> wrapping properly, but I'm not sure whether it makes sense for half of the
> `Checker
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great!
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
george.karpenkov added a comment.
@Szelethus thanks! BTW if you really want to invest into maintaining the
website,
I think it's totally worth it to change all contents to markdown,
and then have a script to generate HTML from that.
Committers would be expected to manually run that script.
This w
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:354
+StringRef AnalyzerOptions::getOptionAsString(Optional &V,
+ StringRef Name,
geo
Szelethus added a comment.
I dislike web development, but that would indeed be invaluable. I'll take a
look.
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
https://reviews.llvm.org/D51464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: atanasyan
Date: Mon Oct 15 15:43:23 2018
New Revision: 344570
URL: http://llvm.org/viewvc/llvm-project?rev=344570&view=rev
Log:
[mips] Fix handling of GNUABIN32 environment in a target triple
The `GNUABIN32` environment in a target triple implies using the N32
ABI. This patch adds support
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344570: [mips] Fix handling of GNUABIN32 environment in a
target triple (authored by atanasyan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51464?vs=168116&id=169763#toc
Reposito
NoQ added inline comments.
Comment at: clang/www/analyzer/open_projects.html:27-32
+New checkers which were contributed to the analyzer,
+but have not passed a rigorous evaluation process,
+are committed as "alpha checkers" (from "alpha version"),
+and are not ena
NoQ added a comment.
The current text looks great.
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello Alexey,
It looks like this commit broke tests on one of our builders.
This failure did not manifest, but masked by another build failures.
Please have a look?
Thanks
Galina
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/13262
. . .
Failing Tests (10):
modocache added a comment.
Oh, I'm sorry I let this languish! I'll address your comments later this week,
@vsk. Thanks so much for the review!
Repository:
rC Clang
https://reviews.llvm.org/D44672
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: abataev
Date: Mon Oct 15 17:09:06 2018
New Revision: 344574
URL: http://llvm.org/viewvc/llvm-project?rev=344574&view=rev
Log:
[OPENMP][NVPTX]Increment iterator only when it is used, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMP
Hi Galina, thanks for letting me know. Committed rL344574 to fix this problem.
Best regards,
Alexey Bataev
15 окт. 2018 г., в 19:03, Galina Kistanova
mailto:gkistan...@gmail.com>> написал(а):
Hello Alexey,
It looks like this commit broke tests on one of our builders.
This failure did not manif
NoQ added a comment.
There seem to be more buildbots failing even after
https://reviews.llvm.org/rL344535, eg.
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/50318/console
Failing Tests (3):
libc++ ::
std/utilities/time/time.cal/time.cal.day/time.cal.day.nonmembers/liter
leonardchan created this revision.
leonardchan added reviewers: ebevhan, rjmccall, bjope.
leonardchan added a project: clang.
This patch is a part of https://reviews.llvm.org/D48456 in an attempt to split
the casting logic up into smaller patches. This contains the code for casting
from fixed po
phosek added a comment.
In https://reviews.llvm.org/D53249#1264900, @sidneym wrote:
> https://reviews.llvm.org/D53219 added a check for either hexagon-ld or ld. I
> merged that change earlier today. I can change the test to pass -fuse-ld,
> let me know. Thanks,
Passing `-fuse-ld=ld` is les
Hi Sam,
The test you added in this commit is timing out when run on the PS4 Windows bot:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20724/steps/test/logs/stdio
command timed out: 1200 seconds without output running ['ninja', '-j', '36',
'check-all'
alexshap added a comment.
I see, many thanks. I've cherry-picked this patch locally and played with GDB -
it appears to work fine with it.
I'm also interested and support this change since this would simplify the
adoption of Fission by some build systems.
@dblaikie, @echristo - are there any pa
phosek added a comment.
In https://reviews.llvm.org/D45639#1243010, @ldionne wrote:
> Sorry, my comment was wrong. You're right, using new libc++ headers and
> linking against an old `libc++.dylib` is a supported use case, and in fact
> this is exactly what happens whenever you use new libc++ h
NoQ added a comment.
Had to revert. Sorry! https://reviews.llvm.org/rL344580.
This failure was masked by another error, so i guess it was missed.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
mclow.lists added a comment.
In https://reviews.llvm.org/D51762#1266086, @NoQ wrote:
> Had to revert. Sorry! https://reviews.llvm.org/rL344580.
>
> This failure was masked by another error, so i guess it was missed.
This was supposed to be fixed by commit r344535.
https://reviews.llvm.org/D51
NoQ added a comment.
Well, i guess something went wrong, because the job behind the link is in fact
the first job on this buildbot that included r344535.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
NoQ added a comment.
Also i should not have reverted r344546, it was completely unrelated >_<
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thiagomacieira updated this revision to Diff 169779.
thiagomacieira added a comment.
Update detection: as of Clear Linux 25620, /usr/lib/os-relaese contains
ID_LIKE=clear-linux-os, which allows detecting not only Clear itself, but also
Linux distributions derived from it (Clear Linux mixes).
h
NoQ added a comment.
Re-applied https://reviews.llvm.org/rL344546 as
https://reviews.llvm.org/rL344582.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
atanasyan added a comment.
Could you please rebase this patch against the trunk?
Comment at: lib/Driver/ToolChains/Linux.cpp:717
+ const StringRef MIPS64R6ELMultiarchIncludeDirs[] = {
+ "/usr/include/mipsisa64r6el-linux-gnu",
+ "/usr/include/mipsisa64r6el-linux-gnuab
Author: atanasyan
Date: Mon Oct 15 22:18:36 2018
New Revision: 344583
URL: http://llvm.org/viewvc/llvm-project?rev=344583&view=rev
Log:
[mips] Group similar commands in the test case. NFC
Modified:
cfe/trunk/test/CodeGen/target-data.c
Modified: cfe/trunk/test/CodeGen/target-data.c
URL:
http
takuto.ikuta updated this revision to Diff 169783.
takuto.ikuta added a comment.
Remove unnecessary attr creation
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
clang/include/clang
Author: sammccall
Date: Mon Oct 15 23:32:14 2018
New Revision: 344586
URL: http://llvm.org/viewvc/llvm-project?rev=344586&view=rev
Log:
[clangd] Disable timeouting test while investigating
Modified:
clang-tools-extra/trunk/unittests/clangd/BackgroundIndexTests.cpp
Modified: clang-tools-extra
101 - 140 of 140 matches
Mail list logo
