hokein accepted this revision.
hokein added a comment.
looks good! didn't know this API before.
Comment at: clangd/XRefs.cpp:592
-auto DeclT = UnwrapReferenceOrPointer(D->getType());
-const AutoType *AT = dyn_cast(DeclT.getTypePtr());
-if (AT && !AT->getDeducedTyp
whisperity added a comment.
Looks good.
What happens if the macro is to stringify a partially string argument?
#define BOOYAH(x) #x ";
...
std::string foo = BOOYAH(blabla)
std::string foo2 = BOOYAH("blabla)
int x = 2;
Not sure if these cases are even valid C(XX), but if they ar
whisperity added a comment.
With regards to https://reviews.llvm.org/D53352: you can change the diff
related to a patch whilst keeping discuccion and metadata of the diff.
Please add a generic description to the diff for an easy skimming on what you
are accomplishing.
If I get this right, your
Author: tikuta
Date: Tue Oct 16 21:29:56 2018
New Revision: 344668
URL: http://llvm.org/viewvc/llvm-project?rev=344668&view=rev
Log:
NFC: Remove trailing space from CodeGenModule.cpp
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL:
htt
hwright added inline comments.
Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:27
+ double value = FloatLiteral.getValueAsApproximateDouble();
+ if (std::fmod(value, 1) == 0) {
+bool is_negative = false;
alexfh wrote:
> Probably doesn't matter m
hwright updated this revision to Diff 169946.
hwright marked 8 inline comments as done.
hwright added a comment.
Addressed review comments
https://reviews.llvm.org/D53339
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationFactoryFloatC
mgorny added a comment.
Thanks for the review. I'm going to be away most of the day today, so if it
breaks something (worse), feel free to revert.
Repository:
rL LLVM
https://reviews.llvm.org/D53326
___
cfe-commits mailing list
cfe-commits@lists
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344666: [python] [tests] Disable on known-broken arches
(authored by mgorny, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53326?vs=169832&i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344666: [python] [tests] Disable on known-broken arches
(authored by mgorny, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53326
Files:
bindings/python/tests/CMakeLists.txt
Index:
Author: mgorny
Date: Tue Oct 16 20:05:39 2018
New Revision: 344666
URL: http://llvm.org/viewvc/llvm-project?rev=344666&view=rev
Log:
[python] [tests] Disable on known-broken arches
Disable the Python binding tests on AArch64, Hexagon and SystemZ
following reports on test failures. The first two
Author: yaxunl
Date: Tue Oct 16 19:32:26 2018
New Revision: 344665
URL: http://llvm.org/viewvc/llvm-project?rev=344665&view=rev
Log:
AMDGPU: add __builtin_amdgcn_update_dpp
Emit llvm.amdgcn.update.dpp for both __builtin_amdgcn_mov_dpp and
__builtin_amdgcn_update_dpp. The first argument to
llvm.am
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344665: AMDGPU: add __builtin_amdgcn_update_dpp (authored by
yaxunl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52320?vs=169882&id=169942#toc
Repository:
rC Clang
https://rev
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks reasonable.
Repository:
rC Clang
https://reviews.llvm.org/D53348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:93
+Diagnostics << FixItHint::CreateRemoval(
+CharSourceRange::getTokenRange(*PrevLoc, *PrevLoc));
+ } else {
JonasToth wrote:
> ymandel wrote:
>
ymandel updated this revision to Diff 169941.
ymandel added a comment.
Changed check result into struct (was pair).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tid
mwasplund added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:1467-1470
+ // FIXME: The Modules TS does not specify how to handle inplicit types
+ // For now we will simply ignore the implicit global types
+ if (Old->isImplicit())
+return false;
rsmit
george.karpenkov added a comment.
Herald added a subscriber: dkrupp.
@Szelethus Also you have without a doubt noticed that a "Download" section on
the index page could be improved :P
https://reviews.llvm.org/D53069
___
cfe-commits mailing list
cfe-
ymandel updated this revision to Diff 169938.
ymandel marked 5 inline comments as done.
ymandel added a comment.
Refactors generation of clang-tidy fixits and notes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy
Author: george.karpenkov
Date: Tue Oct 16 18:15:53 2018
New Revision: 344664
URL: http://llvm.org/viewvc/llvm-project?rev=344664&view=rev
Log:
[analyzer] [www] Minor improvements to the text in open_projects
Modified:
cfe/trunk/www/analyzer/open_projects.html
Modified: cfe/trunk/www/analyzer
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344663: [analyzer] [www] Updated a list of open projects
(authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53024?vs=169920&id=169933#toc
Repository:
rC
Author: george.karpenkov
Date: Tue Oct 16 18:06:20 2018
New Revision: 344663
URL: http://llvm.org/viewvc/llvm-project?rev=344663&view=rev
Log:
[analyzer] [www] Updated a list of open projects
Differential Revision: https://reviews.llvm.org/D53024
Modified:
cfe/trunk/www/analyzer/open_project
Eugene.Zelenko added a comment.
By the word, why this check could not be generalized to any function/method
which have floating-point and integer variants?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53339
___
cfe-commits mailin
Szelethus updated this revision to Diff 169927.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Added a test.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyze
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:24
+// Returns an integer if the fractional part of a `FloatingLiteral` is 0.
+llvm::Optional
+TruncateIfIntegral(const FloatingLiteral &FloatLiteral) {
Please use s
Szelethus updated this revision to Diff 169925.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Herald added a subscriber: nhaehnle.
Using `llvm::formatted_raw_ostream` to drastically simplify the previous
solution.
The actual output changed a little bit too, now I'm pr
alexfh added a comment.
LG In general, but see a few comments inline.
Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:25
+llvm::Optional
+TruncateIfIntegral(const FloatingLiteral &FloatLiteral) {
+ double value = FloatLiteral.getValueAsApproximateDouble();
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, it bugs me that some part in the documentation says it doesn't go through
decltype(`This looks through declarators like pointer types, but not through
decltype or typedefs`) but sinc
ilya-biryukov added a comment.
A drive-by NIT ;-)
Comment at: clangd/CodeComplete.cpp:643
case CodeCompletionContext::CCC_Recovery:
+ // TODO: Provide identifier based completions for the following two contexts:
+ case CodeCompletionContext::CCC_Name:
samm
NoQ accepted this revision.
NoQ added a comment.
Ok, let's see if this actually works :)
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet added a comment.
In https://reviews.llvm.org/D52301#1263275, @aaron.ballman wrote:
> Can you give a bit more background on what problem you're trying to solve
> with this patch?
Sorry for the lack of context, it was about an offline discussion on
`Sema::DeduceVariableDeclarationType`
george.karpenkov updated this revision to Diff 169920.
https://reviews.llvm.org/D53024
Files:
clang/www/analyzer/open_projects.html
Index: clang/www/analyzer/open_projects.html
===
--- clang/www/analyzer/open_projects.html
+++ cla
efriedma created this revision.
efriedma added reviewers: olista01, SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
"aarch64-none-elf" is commonly used for AArch64 baremetal toolchains.
Repository:
rC Clang
https://reviews.llvm.org/D53348
Files:
ilya-biryukov created this revision.
ilya-biryukov added reviewers: kadircet, hokein.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric.
Use helper from clang. Also fixes some weird corner cases, e.g.
auto (*foo)() = bar;
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.o
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:727
+
+static std::string getExpandedMacroImpl(TokenPrinter &Printer,
+SourceLocation MacroLoc,
Whoa, that's so easy!
Co
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344654: [clang-doc] Add unit tests for Markdown generation
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53085?vs=169752&id=169911#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344653: [clang-doc] Add unit tests for YAML generation
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53084?vs=169751&id=169910#toc
Repository:
rCTE C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344654: [clang-doc] Add unit tests for Markdown generation
(authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53085?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344652: [clang-doc] Add unit tests for merging (authored by
juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53083?vs=169014&id=1
nickdesaulniers added a comment.
Thanks again for this patch!
Repository:
rC Clang
https://reviews.llvm.org/D52784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: juliehockett
Date: Tue Oct 16 16:07:16 2018
New Revision: 344653
URL: http://llvm.org/viewvc/llvm-project?rev=344653&view=rev
Log:
[clang-doc] Add unit tests for YAML generation
Adds unit tests for the YAML generator library.
This is part of a move to convert clang-doc's tests to a more
Author: juliehockett
Date: Tue Oct 16 16:07:26 2018
New Revision: 344654
URL: http://llvm.org/viewvc/llvm-project?rev=344654&view=rev
Log:
[clang-doc] Add unit tests for Markdown generation
Add unit tests for Markdown generation.
This is part of a move to convert clang-doc's tests to a more
main
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344650: [clang-doc] Add unit tests for serialization
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53081?vs=169754&id=169907#toc
Repository:
rCTE Cla
Author: juliehockett
Date: Tue Oct 16 16:07:04 2018
New Revision: 344652
URL: http://llvm.org/viewvc/llvm-project?rev=344652&view=rev
Log:
[clang-doc] Add unit tests for merging
Adds unit tests for the merging logic in Respresentation.cpp.
This is part of a move to convert clang-doc's tests to a
Author: juliehockett
Date: Tue Oct 16 16:06:42 2018
New Revision: 344650
URL: http://llvm.org/viewvc/llvm-project?rev=344650&view=rev
Log:
[clang-doc] Add unit tests for serialization
Adds unit tests for the Serialize library.
This is part of a move to convert clang-doc's tests to a more
maintai
danalbert created this revision.
danalbert added a reviewer: srhines.
Android does not allow shared text relocations. Enable the linker
warning to detect them by default.
Repository:
rC Clang
https://reviews.llvm.org/D53344
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/linux-ld.c
In
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:469
+DisplayMacroExpansions =
+getBooleanOption("expand-macros", /*Default=*/false);
+ return DisplayMacroExpansions.getValue();
Should we say something about plists i
xbolva00 added a comment.
Reping :)
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danalbert created this revision.
danalbert added a reviewer: srhines.
Android does not support executable stacks.
Repository:
rC Clang
https://reviews.llvm.org/D53343
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChain
JDevlieghere added a comment.
The patch looks fine but since I don't know much about opencl I'll leave the
LGTM to someone that actually knows this code.
Comment at: test/Headers/opencl-pragma-extension-begin.h:1
+
+#pragma OPENCL EXTENSION cl_my_ext : begin
I
yaxunl added a comment.
Brian checked the extra argument for dpp mov should be the first one. so
mov_dpp(x,...) --> update_dpp(undef, x, ...). I will fix that when committing.
https://reviews.llvm.org/D52320
___
cfe-commits mailing list
cfe-commits
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
erichkeane abandoned this revision.
erichkeane added a comment.
Herald added a subscriber: nhaehnle.
Superseding with a version that seems to work
Repository:
rC Clang
https://reviews.llvm.org/D52000
___
cfe-commits mailing list
cfe-commits@lists
erichkeane created this revision.
erichkeane added reviewers: rsmith, aaron.ballman, echristo.
Herald added subscribers: nhaehnle, arphaman.
As brought up by Richard Smith on https://reviews.llvm.org/D51650:
Sorry, I don't think it's acceptable from a design perspective to have
mutable state
NoQ added inline comments.
Comment at: clang/www/analyzer/open_projects.html:27-32
+New checkers which were contributed to the analyzer,
+but have not passed a rigorous evaluation process,
+are committed as "alpha checkers" (from "alpha version"),
+and are not ena
hwright created this revision.
hwright added reviewers: alexfh, alexfh_.
Herald added a subscriber: mgorny.
This check finds cases where calls to an absl::Duration factory could use the
more efficient integer overload.
For example:
// Original - Providing a floating-point literal.
absl::Duration
kadircet updated this revision to Diff 169885.
kadircet added a comment.
Herald added a subscriber: nhaehnle.
rebase
Repository:
rC Clang
https://reviews.llvm.org/D52301
Files:
include/clang/AST/PrettyPrinter.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/
yaxunl updated this revision to Diff 169882.
yaxunl edited the summary of this revision.
yaxunl added a comment.
emit llvm.amdgcn.update.dpp for __builtin_amdgcn_mov_dpp.
https://reviews.llvm.org/D52320
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOp
george.karpenkov added inline comments.
Herald added a subscriber: dkrupp.
Comment at: clang/www/analyzer/open_projects.html:27-32
+New checkers which were contributed to the analyzer,
+but have not passed a rigorous evaluation process,
+are committed as "alpha checke
xbolva00 updated this revision to Diff 169881.
xbolva00 added a comment.
- Added missing test file
https://reviews.llvm.org/D52835
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema
mwasplund added a comment.
Can you see the full change? I am only seeing that latest commit after running:
"git show HEAD -U99 > mypatch.patch".
It was working fine with I ran "git diff master..mybranch > mybranch.diff"
however that does not give the full context.
Repository:
rC Clang
mwasplund added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:1464
if (NewM == OldM)
return false;
rsmith wrote:
> Somewhere up here we're calling `getOwningModule()` but should be calling
> `getOwningModuleForLinkage()`. (Please upload patches with
mwasplund updated this revision to Diff 169879.
mwasplund marked 2 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D52973
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/Sema/SemaDecl.cpp
test/Modules/msvc-compat-implitic-types.cpp
Index: test/
mate1214 abandoned this revision.
mate1214 marked 24 inline comments as done.
mate1214 added a comment.
Herald added subscribers: dkrupp, nhaehnle, donat.nagy.
Hi!
Sorry for the delay. After considering the amount of requested tests and
investigating the possibly reviewer friendly ways to split
vsapsai added a comment.
Sorry about the delay. The change seems to be correct but `ninja check-clang`
reveals the test "Misc/caret-diags-macros.c" is failing. Can you please look
into that?
Appreciate your contribution, Xing, and thanks for verifying your change with
tests.
===
efriedma added a comment.
Herald added a subscriber: nhaehnle.
Looks like the latest update is missing a test file?
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the change!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53266
___
cfe-commits mailing list
cfe-commits@l
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class MacroArgMap : public std::map {
+public:
Szelethus wrote:
> george.karpenkov wrote:
> > Plea
Author: krasimir
Date: Tue Oct 16 11:44:41 2018
New Revision: 344637
URL: http://llvm.org/viewvc/llvm-project?rev=344637&view=rev
Log:
Revert "[clangd] Refactor JSON-over-stdin/stdout code into Transport
abstraction."
This reverts commit r344620.
Breaks upstream bots.
Removed:
clang-tools-e
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class MacroArgMap : public std::map {
+public:
george.karpenkov wrote:
> Please don't do this, inh
Szelethus added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
clang_version
-clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
80e1678b9f598ca78bb3b71cf546a63414a37b11) (https://github.com/llvm-mirro
Szelethus updated this revision to Diff 169871.
Szelethus added a comment.
Herald added a subscriber: dkrupp.
This patch didn't really work, sometimes it printed extra spaces, sometimes
printed the hash tokens, and so on, so I refactored the whole project to deal
with this issue almost out of th
george.karpenkov added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
clang_version
-clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
80e1678b9f598ca78bb3b71cf546a63414a37b11) (https://github.com/llv
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class Ma
Szelethus updated this revision to Diff 169869.
Szelethus added a comment.
Herald added a subscriber: dkrupp.
Rebased to part 3.
https://reviews.llvm.org/D52986
Files:
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist
t
whisperity accepted this revision.
whisperity added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: donat.nagy.
Remove the custom file paths and URLs but other than that this is pretty
trivial.
https://reviews.llvm.org/D52790
___
yaxunl updated this revision to Diff 169864.
yaxunl retitled this revision from "[OpenCL] Mark load of block invoke function
as invariant" to "Mark store and load of block invoke function as
invariant.group".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Herald added a subsc
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1032
+ // them.
+ return Builder.CreateIsNotNull(Src);
+}
ebevhan wrote:
> Is this comment true? I don't think EmitFixedPointConversion does this.
>
> Maybe I'm misin
leonardchan updated this revision to Diff 169863.
leonardchan marked 3 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D53308
Files:
clang/include/clang/AST/OperationKinds.def
clang/lib/AST/Expr.cpp
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGExpr.cpp
cl
whisperity created this revision.
whisperity added reviewers: rsmith, doug.gregor.
whisperity added a project: clang.
Herald added subscribers: Szelethus, dkrupp, rnkovacs.
The current version only emits the below error for a module (attempted to be
loaded) from the `prebuilt-module-path`:
er
Szelethus updated this revision to Diff 169862.
Szelethus added a comment.
Herald added a subscriber: donat.nagy.
- Removed the version entry from the plist file,
- Now using `TokenConcatenation` to print spaces only when needed (this needed
for https://reviews.llvm.org/D52988),
- A bit more doc,
Szelethus updated this revision to Diff 169858.
Szelethus added a comment.
Removed the version entry from the plist file.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/BugRepor
vsapsai marked 3 inline comments as done.
vsapsai added a comment.
In https://reviews.llvm.org/D50539#1241034, @bruno wrote:
> > - Current way of working with modules in VFS "root" is clunky and
> > error-prone.
>
> Why?
Mostly because when you approach it in a straightforward way, you cannot
vsapsai marked 5 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/Basic/VirtualFileSystem.cpp:934
RedirectingFileSystem &FS;
RedirectingDirectoryEntry::iterator Current, End;
+ bool IsExternalFSCurrent;
bruno wrote:
> Can you a
leonardchan added a comment.
@philip.pfaffe @fedor.sergeev Do you have any more comments on this patch?
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344630: Disable code object version 3 for HIP toolchain
(authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53325?vs=169831&i
Author: yaxunl
Date: Tue Oct 16 10:36:23 2018
New Revision: 344630
URL: http://llvm.org/viewvc/llvm-project?rev=344630&view=rev
Log:
Disable code object version 3 for HIP toolchain
AMDGPU backend will switch to code object version 3 by default.
Since HIP runtime is not ready, disable it until the
AlexeySachkov updated this revision to Diff 169851.
AlexeySachkov added a comment.
Added test
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
test/Headers/opencl-pragma-extension-begin.cl
test/Headers/opencl-pragma-extension-begin.h
Index: test/Headers/opencl-prag
yonghong-song added a comment.
In the above `/virtual/main.c` is a memory mapped file. The
`invocation0.getPreprocessorOpts().addRemappedFile(...)` adds the mapping
for the compilation.
Repository:
rC Clang
https://reviews.llvm.org/D53329
___
cf
vsapsai updated this revision to Diff 169849.
vsapsai added a comment.
Herald added a subscriber: hiraditya.
- Rebase on top of the latest changes in trunk.
- Address review comments.
I expect diff between diffs to be noisy due to rebase.
https://reviews.llvm.org/D50539
Files:
clang/lib/Fron
yonghong-song added a comment.
We already have `-main-file-name` in cc1.
`clang -cc1 -triple x86_64-unknown-linux-gnu ... -main-file-name main.c ... -o
main.bc -x c /virtual/main.c -faddrsig`
Is this expected?
BTW, we just pass the normal C flags to the driver like
vector flags_cstr({"-O0", "
b-sumner added a comment.
Ping. There's quite a bit of interest in getting this exposed by clang.
https://reviews.llvm.org/D52320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added a comment.
Couldn't you just pass `-main-file-name` to cc1 instead?
Repository:
rC Clang
https://reviews.llvm.org/D53329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
yonghong-song added a comment.
Hi, @vsk @HsiangKai @ABataev I found a bug in clang when trying to use "-g
-gdwarf-5 -gembed-source" for
bcc MCJIT based clang/llvm compilation. This patch fixed the issue but I am not
sure whether this is the
correct fix or not. Please help take a look and advise
yonghong-song created this revision.
yonghong-song added reviewers: vsk, HsiangKai, ABataev.
yonghong-song added a project: debug-info.
Herald added subscribers: cfe-commits, JDevlieghere, aprantl.
A llvm segfault happens when I tried to add "-g -gdwarf-5 -gembed-source"
in bcc in order to get sor
This revision was automatically updated to reflect the committed changes.
sammccall marked 5 inline comments as done.
Closed by commit rL344620: [clangd] Refactor JSON-over-stdin/stdout code into
Transport abstraction. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits
Author: sammccall
Date: Tue Oct 16 09:48:06 2018
New Revision: 344620
URL: http://llvm.org/viewvc/llvm-project?rev=344620&view=rev
Log:
[clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.
Summary:
This paves the way for alternative transports (mac XPC, maybe messagepack?),
a
sammccall updated this revision to Diff 169839.
sammccall added a comment.
Rebase to include CodeAction literal support
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53266
Files:
clangd/ClangdLSPServer.cpp
clangd/Protocol.cpp
clangd/Protocol.h
Index: clangd/Protocol.h
=
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/JSONRPCDispatcher.h:70
/// A handler responds to requests for a particular method name.
+ /// It returns true if the server should now shut down.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344617: [clangd] Send CodeAction responses to
textDocument/codeAction (LSP 3.8) (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
1 - 100 of 161 matches
Mail list logo
