SquallATF updated this revision to Diff 170330.
SquallATF added a comment.
- add test
Repository:
rC Clang
https://reviews.llvm.org/D53397
Files:
lib/Driver/ToolChains/MinGW.cpp
test/Driver/fopenmp.c
Index: test/Driver/fopenmp.c
=
SquallATF created this revision.
Herald added subscribers: cfe-commits, guansong.
clang-cl driver has -fopenmp related code, but -fopenmp not alloewd press to
clang-cl driver, this patch fixed it and allowed link to multiarch openmp
library.
Repository:
rC Clang
https://reviews.llvm.org/D53
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM, I can commit it for you on Monday, after giving others a chance to
comment.
Repository:
rC Clang
https://reviews.llvm.org/D53397
__
Szelethus updated this revision to Diff 170333.
Szelethus added a comment.
Split `ANALYZER_OPTION_WITH_FN` up to
- `ANALYZER_OPTION_GEN_FN`
- `ANALYZER_OPTION_GEN_FN_DEPENDS_ON_USER_MODE`
and added some `#error` directives to make it harder to misuse the .def file.
https://reviews.llvm.org/D53
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:386
+
+ANALYZER_OPTION_WITH_FN(StringRef, ModelPath, "model-path", "", "",
+getModelPath)
Szelethus wrote:
> Found the use for this here:
>
DaanDeMeyer created this revision.
DaanDeMeyer added reviewers: clang-tools-extra, sammccall.
DaanDeMeyer added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
This is useful when using clangd with CMake based proje
Szelethus updated this revision to Diff 170343.
Szelethus added a comment.
Added default value to `ANALYZER_OPTION` and split it upto
- `ANALYZER_OPTION` and
- `ANALYZER_OPTION_DEPENDS_ON_USER_MODE`.
The `TYPE` entry only holds `bool`, `unsigned` and `StringRef now. These things
will make follo
vglavnyy created this revision.
vglavnyy added reviewers: djasper, krasimir.
Herald added a subscriber: cfe-commits.
Twice running clang-format may give unstable result for some code samples, for
example: https://bugs.llvm.org/show_bug.cgi?id=23728
This commit adds stability check to clang-format
Author: szelethus
Date: Sun Oct 21 11:19:32 2018
New Revision: 344870
URL: http://llvm.org/viewvc/llvm-project?rev=344870&view=rev
Log:
[analyzer][NFC] Fix inconsistencies in AnalyzerOptions
I'm in the process of refactoring AnalyzerOptions. The main motivation behind
here is to emit warnings if
This revision was automatically updated to reflect the committed changes.
Szelethus marked 3 inline comments as done.
Closed by commit rL344870: [analyzer][NFC] Fix inconsistencies in
AnalyzerOptions (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to
JonasToth added a comment.
In https://reviews.llvm.org/D53339#1269998, @hwright wrote:
> Ping.
>
> What are the next steps here?
Please mark all comments you consider resolved as 'Done', i think alex already
kinda accepted it, but given there were more comments he should take another
look.
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
LGTM, but could you please add a short notice in the release notes?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53454
_
vmiklos added a comment.
In https://reviews.llvm.org/D53454#1270298, @JonasToth wrote:
> LGTM, but could you please add a short notice in the release notes?
Sure, I will do that.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53454
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344871: [clang-tidy] add IgnoreMacros option to
readability-redundant-smartptr-get (authored by vmiklos, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
Author: vmiklos
Date: Sun Oct 21 12:16:25 2018
New Revision: 344871
URL: http://llvm.org/viewvc/llvm-project?rev=344871&view=rev
Log:
[clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get
And also enable it by default to be consistent with e.g. modernize-use-using.
This help
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, rnkovacs, xazax.hun, MTC.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, szepet, whisperity.
Herald added a reviewer: teemperor.
One of the reasons why `AnalyzerOptions` is s
Author: szelethus
Date: Sun Oct 21 15:10:15 2018
New Revision: 344878
URL: http://llvm.org/viewvc/llvm-project?rev=344878&view=rev
Log:
[analyzer][www] Update alpha_checks.html
I added some missing doc. I have not developed any of these checkers, it might
worth really inspecting whether I wrote
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344878: [analyzer][www] Update alpha_checks.html (authored
by Szelethus, committed by ).
Herald added subscribers: llvm-commits, dkrupp, donat.nagy.
Changed prior to commit:
https://reviews.llvm.org/D52
Szelethus added a comment.
Herald added a subscriber: dkrupp.
Ping^5 :)
https://reviews.llvm.org/D51531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Ugh, i was sure i scanned through all of them, sorry! Pls let me recall what's
going on><
https://reviews.llvm.org/D51531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
hgabii updated this revision to Diff 170360.
hgabii added a comment.
Warning messages changed.
Tests updated.
Comments changed based on the recommendations.
Documentation refactored and reformatted.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48866
Files:
clang-tidy/misc/C
Szelethus added a comment.
As I understood it, your objection was that we could collect already reported
regions in a global set stored in the checker objects, but I suspect it's
impossible to implement (very difficult to see when a pointer is dangling etc).
https://reviews.llvm.org/D51531
NoQ added a comment.
`MemRegion`s have lifetime of `ExprEngine`, i.e. a single analysis of top-level
function. You'll need to clean them up in `checkEndAnalysis()`.
https://reviews.llvm.org/D51531
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: szelethus
Date: Sun Oct 21 16:30:01 2018
New Revision: 344879
URL: http://llvm.org/viewvc/llvm-project?rev=344879&view=rev
Log:
[analyzer][UninitializedObjectChecker] No longer using nonloc::LazyCompoundVal
As rightly pointed out by @NoQ, nonloc::LazyCompoundVals were only used to
acquir
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344879: [analyzer][UninitializedObjectChecker] No longer
using nonloc::LazyCompoundVal (authored by Szelethus, committed by ).
Herald added subscribers: llvm-commits, dkrupp, donat.nagy.
Changed prior to
lebedev.ri added a comment.
@rsmith ping.
Repository:
rC Clang
https://reviews.llvm.org/D50250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vmiklos
Date: Sun Oct 21 23:36:30 2018
New Revision: 344885
URL: http://llvm.org/viewvc/llvm-project?rev=344885&view=rev
Log:
ReleaseNotes: move readability-redundant-smartptr-get part down below new checks
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for the fix!
Comment at: clangd/tool/ClangdMain.cpp:261
} else {
-CompileCommandsDirPath = CompileCommandsDir;
+// If the compile-commands-dir arg pat
28 matches
Mail list logo
