sammccall added a comment.
BTW I'm holding off submitting this until we decide the fate of
https://reviews.llvm.org/D53688.
If we're going to add that extension, I'd like to land the two patches together
so the former user of this extension can rely on *one* of them being available.
Repository
Author: ctopper
Date: Wed Oct 24 22:04:35 2018
New Revision: 345237
URL: http://llvm.org/viewvc/llvm-project?rev=345237&view=rev
Log:
[CodeGen] Always emit the 'min-legal-vector-width' attribute even when the
value is 0.
The X86 backend will need to see the attribute to make decisions. If it isn
Charusso added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:202
+ void finalizeConstraints() {
+Constraints.clear();
+ }
george.karpenkov wrote:
> These constraints are conceptually part of the visitor, n
Author: sammccall
Date: Wed Oct 24 21:22:52 2018
New Revision: 345235
URL: http://llvm.org/viewvc/llvm-project?rev=345235&view=rev
Log:
[clangd] Clean up LSP structs around configuration. NFC, no protocol changes.
- align struct names/comments with LSP, remove redundant "clangd" prefixes.
- don
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This allows customizing the flags used when no compile database is
available. It addresses some uses of the old extraFlags extension.
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
The new implementation is a GlobalCompilationDatabase that overlays a base.
Normally this is the directory-based CDB.
To preserve the be
tlively added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85
+BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc")
+
aheejin wrote:
> Do you think we need to provide this builtin also for other vector types?
This builtin is inter
aheejin added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85
+BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc")
+
Do you think we need to provide this builtin also for other vector types?
Repository:
rC Clang
https://revi
Author: sammccall
Date: Wed Oct 24 19:25:44 2018
New Revision: 345233
URL: http://llvm.org/viewvc/llvm-project?rev=345233&view=rev
Log:
[clangd] Remove unused CDB function. NFC
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
clang-tools-extra/trunk/clangd/GlobalComp
Author: sammccall
Date: Wed Oct 24 19:22:53 2018
New Revision: 345232
URL: http://llvm.org/viewvc/llvm-project?rev=345232&view=rev
Log:
[clangd] Fix -compile-commands-dir flag, broken in r345031
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/trunk/clangd/Cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345231: [clangd] Don't invalidate LSP-set compile
commands when closing a file. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53642?vs=170861&id=171033#toc
Author: sammccall
Date: Wed Oct 24 19:04:30 2018
New Revision: 345231
URL: http://llvm.org/viewvc/llvm-project?rev=345231&view=rev
Log:
[clangd] Don't invalidate LSP-set compile commands when closing a file.
Summary:
It doesn't make much sense: setting them is not coupled to opening the file,
it'
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100.
Repository:
rC Clang
https://reviews.llvm.org/D53685
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeG
Author: dyung
Date: Wed Oct 24 18:21:08 2018
New Revision: 345229
URL: http://llvm.org/viewvc/llvm-project?rev=345229&view=rev
Log:
Fix test to work on Windows.
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdUnitTests.cpp
Modified: clang-tools-extra/trunk/unittests/clangd/ClangdUni
rjmccall added inline comments.
Comment at: include/clang/AST/Stmt.h:956
+ // with a range. Present if and only if caseStmtIsGNURange() is true.
+ enum { LHS, SUBSTMT, RHS, ELLIPSISLOC };
+ enum { NumMandatoryStmtPtr = 2 };
ELLIPSISLOC is dead.
Much like th
Author: rtrieu
Date: Wed Oct 24 18:08:00 2018
New Revision: 345228
URL: http://llvm.org/viewvc/llvm-project?rev=345228&view=rev
Log:
[Sema] Fix -Wcomma for C89
There is a small difference in the scope flags for C89 versus the other C/C++
dialects. This change ensures that the -Wcomma warning won
yinma created this revision.
Herald added subscribers: cfe-commits, chrib, kristof.beyls, javed.absar.
ARM64 setjmp expects sp on entry instead of framepointer.
Repository:
rC Clang
https://reviews.llvm.org/D53684
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-setjmp.c
Index: test/Co
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:2480
+ SuppressResultRetain);
}
This switch is just checking what you already computed as
`SuppressResultRetain`. Please just assert in the second case that th
rjmccall added a comment.
Yeah, I agree that changing child order is problematic.
Repository:
rC Clang
https://reviews.llvm.org/D53607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rjmccall added inline comments.
Comment at: include/clang/AST/Expr.h:1687
+ // "Stmt *" for the predefined identifier. It is present if and only if
+ // hasFunctionName() is true and is in fact a "StringLiteral *".
+
"always" would be clearer than "in fact".
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
aaronpuchert updated this revision to Diff 171026.
aaronpuchert added a comment.
Negative capabilities don't need a LockKind.
Repository:
rC Clang
https://reviews.llvm.org/D52578
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-t
Author: ericwf
Date: Wed Oct 24 16:47:04 2018
New Revision: 345225
URL: http://llvm.org/viewvc/llvm-project?rev=345225&view=rev
Log:
Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"
This reverts commit 6f47cdd51341344c0e32630e19e72c94cd25f34e.
Removed:
cfe/trunk/
rnk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:2395
+
+ llvm::CallInst *Result = Builder.CreateCall(FuncToReturn, Args);
+
rnk wrote:
> erichkeane wrote:
> > erichkeane wrote:
> > > rnk wrote:
> > > > This approach is... not going to work
Author: compnerd
Date: Wed Oct 24 16:28:28 2018
New Revision: 345222
URL: http://llvm.org/viewvc/llvm-project?rev=345222&view=rev
Log:
Driver,CodeGen: introduce support for Swift CFString layout
Add a new driver level flag `-fcf-runtime-abi=` that allows one to specify the
runtime ABI for CoreFou
aaronpuchert updated this revision to Diff 171019.
aaronpuchert added a comment.
Introduced helper functions to clarify lock handling.
The previous version was too tightly coupled, and the introduction of AddCp and
RemoveCp didn't help readability.
Repository:
rC Clang
https://reviews.llvm.
NoQ added inline comments.
Comment at: test/Analysis/simple-stream-checks.c:96
+ fp = 0;
+} // expected-warning {{Opened file is never closed; potential resource leak}}
george.karpenkov wrote:
> Woo-hoo, were we losing this case before?
Yes, this is the whole po
george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Analysis/self-assign.cpp:42
str = rhs.str;
- rhs.str = nullptr; // FIXME: An improved leak checker should warn here
+ rhs.str =
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/Environment.cpp:180
- for (; SI != SE; ++SI)
-SymReaper.maybeDead(*SI);
}
zaks.anna wrote:
> We are removing this because the maybeDead is no longer used, correct?
Yup.
===
NoQ updated this revision to Diff 171006.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Herald added subscribers: dkrupp, donat.nagy, Szelethus, mikhail.ramalho.
Rebase!
Changes on large codebase runs still look mild and reasonable, with much less
slowdown than before. Even if there
On Wed, 24 Oct 2018 at 15:40, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Oct 24 15:38:49 2018
> New Revision: 345211
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345211&view=rev
> Log:
> [SemaCXX] Unconfuse Clang when std::align_val_t is uns
vsapsai added a comment.
Thanks for the review.
Repository:
rC Clang
https://reviews.llvm.org/D53228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345212: [VFS] Remove
'ignore-non-existent-contents' attribute for YAML-based VFS.
(authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53228?vs=169520&id=171010#toc
Author: vsapsai
Date: Wed Oct 24 15:39:38 2018
New Revision: 345212
URL: http://llvm.org/viewvc/llvm-project?rev=345212&view=rev
Log:
[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
'ignore-non-existent-contents' stopped working after r342232 in a way
that the actual att
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345211: [SemaCXX] Unconfuse Clang when std::align_val_t is
unscoped in C++03 (authored by EricWF, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53508
Files:
lib/Sema/SemaExprCXX.cpp
Author: ericwf
Date: Wed Oct 24 15:38:49 2018
New Revision: 345211
URL: http://llvm.org/viewvc/llvm-project?rev=345211&view=rev
Log:
[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03
Summary:
When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t
as an
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting. This is a good candidate for post-commit review.
Repository:
rC Clang
https://reviews.llvm.org/D53508
___
cfe-commits mailing list
craig.topper abandoned this revision.
craig.topper added a comment.
Abandoning after an internal conversation.
https://reviews.llvm.org/D53665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ubsan updated this revision to Diff 170994.
ubsan added a comment.
Add ABI breakage information and reflow
Repository:
rC Clang
https://reviews.llvm.org/D53207
Files:
docs/ReleaseNotes.rst
include/clang/AST/Stmt.h
include/clang/ASTMatchers/ASTMatchers.h
include/clang/Basic/Diagnostic
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
All of the target specific stuff looks fine to me. I'm going to defer to rnk
about the windows side of things and aaron for the attributes.
https://reviews.llvm.org/D53586
vsapsai created this revision.
vsapsai added reviewers: ahatanak, rjmccall.
Herald added a subscriber: dexonsmith.
Failed assertion is
> Assertion failed: ((ND->isUsed(false) || !isa(ND) ||
> !E->getLocation().isValid()) && "Should not use decl without marking it
> used!"), function EmitDeclRef
mstorsjo updated this revision to Diff 170989.
mstorsjo added a comment.
Changed so that we only rewrite paths if targeting a non-windows OS, or
cygwin/mingw. Since convert_to_slash is a no-op when running on anything else
than windows, this should hit exactly the cases where converting to forwa
erichkeane updated this revision to Diff 170987.
erichkeane added a comment.
did everything suggested by @rnk as far as I know. Thanks again for the
reviews!
https://reviews.llvm.org/D53586
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/TargetInfo.h
li
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks! Can you also write something for the release notes
(docs/ReleaseNotes.rst) describing the ABI change?
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5478
de
Author: tpr
Date: Wed Oct 24 14:19:02 2018
New Revision: 345198
URL: http://llvm.org/viewvc/llvm-project?rev=345198&view=rev
Log:
Add gfx909 to GPU Arch
Subscribers: jholewinski, cfe-commits
Differential Revision: https://reviews.llvm.org/D53558
Modified:
cfe/trunk/include/clang/Basic/Cuda.
rnk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:2391-2393
+ llvm::SmallVector Args;
+ llvm::for_each(Resolver->args(),
+ [&](llvm::Argument &Arg) { Args.push_back(&Arg); });
erichkeane wrote:
> rnk wrote:
> > Surely this w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345198: Add gfx909 to GPU Arch (authored by tpr, committed
by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53558
Files:
cfe/trunk/include/clang/Basic/Cud
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D53441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Szelethus planned changes to this revision.
Szelethus added a comment.
Since I've dug myself quite deep into the refactoring effort, I realized that
there are more elegant ways of achieving this, should I hammer
`AnalyzerOptions` for long enough. I'll probably change everything but the
revision
efriedma added a comment.
Yes, that looks right.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D53608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345194: [clang-query] Refactor Output settings to booleans
(authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53501?vs=170
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345194: [clang-query] Refactor Output settings to booleans
(authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53501?vs=170431&id=170975#toc
Repository:
rL LLV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345193: [clang-query] Add 'detailed-ast' output as
an alias for 'dump' (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345193: [clang-query] Add 'detailed-ast' output
as an alias for 'dump' (authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53500?vs=170427&id=170973#toc
Reposito
Author: steveire
Date: Wed Oct 24 13:33:45 2018
New Revision: 345193
URL: http://llvm.org/viewvc/llvm-project?rev=345193&view=rev
Log:
[clang-query] Add 'detailed-ast' output as an alias for 'dump'
Summary: Future development can then dump other content than AST.
Reviewers: aaron.ballman
Subscr
Author: steveire
Date: Wed Oct 24 13:33:55 2018
New Revision: 345194
URL: http://llvm.org/viewvc/llvm-project?rev=345194&view=rev
Log:
[clang-query] Refactor Output settings to booleans
Summary: This will make it possible to add non-exclusive mode output.
Reviewers: aaron.ballman
Subscribers: c
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345192: [clang-query] Re-word command help (authored by
steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53498?vs=170419&id=170972#toc
Repository:
rCTE Clang Tools Extra
Author: steveire
Date: Wed Oct 24 13:33:14 2018
New Revision: 345192
URL: http://llvm.org/viewvc/llvm-project?rev=345192&view=rev
Log:
[clang-query] Re-word command help
Summary:
This will make it possible to easily
* Add new commands which accept parameters
* Extend the list of features
Revie
manojgupta added a comment.
Took another look and seems like long double is hardcoded in many of the
builtins. So I think the current patch needs to rename a lot of places using
long double to __float128 type.
Some examples where I think __float128 type (propagating the type in fp_lib.h)
shoul
Author: aheejin
Date: Wed Oct 24 13:31:58 2018
New Revision: 345191
URL: http://llvm.org/viewvc/llvm-project?rev=345191&view=rev
Log:
[clant-tidy] abseil: Add clangTooling to CMakeLists.txt
Without this, builds with `-DBUILD_SHARED_LIBS=ON` fail.
Modified:
clang-tools-extra/trunk/clang-tidy/
xbolva00 updated this revision to Diff 170963.
https://reviews.llvm.org/D53666
Files:
test/CodeGen/tbaa-struct.cpp
Index: test/CodeGen/tbaa-struct.cpp
===
--- test/CodeGen/tbaa-struct.cpp
+++ test/CodeGen/tbaa-struct.cpp
@@ -17,7
xbolva00 added inline comments.
Comment at: test/CodeGenOpenCL/amdgpu-nullptr.cl:513
// CHECK-LABEL: test_memset_private
-// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5)* align 8 {{.*}}, i8
0, i64 40, i1 false)
+// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5
efriedma added inline comments.
Comment at: test/CodeGenOpenCL/amdgpu-nullptr.cl:513
// CHECK-LABEL: test_memset_private
-// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5)* align 8 {{.*}}, i8
0, i64 40, i1 false)
+// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5
kzhuravl added a comment.
ping
https://reviews.llvm.org/D53223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 created this revision.
Herald added subscribers: cfe-commits, nhaehnle, jvesely.
Repository:
rC Clang
https://reviews.llvm.org/D53666
Files:
test/CodeGen/tbaa-struct.cpp
test/CodeGenOpenCL/amdgpu-nullptr.cl
Index: test/CodeGenOpenCL/amdgpu-nullptr.cl
Author: rksimon
Date: Wed Oct 24 12:31:24 2018
New Revision: 345184
URL: http://llvm.org/viewvc/llvm-project?rev=345184&view=rev
Log:
Fix MSVC "truncation from 'double' to 'float'" warnings. NFCI.
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Q
lebedev.ri updated this revision to Diff 170952.
lebedev.ri marked 4 inline comments as done.
lebedev.ri added a comment.
In https://reviews.llvm.org/D50250#1273415, @rsmith wrote:
> Just some minor nits.
YES! Thank you for the [long-awaited] review!
Addressed review notes.
The compiler-rt par
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1036
+return;
+ // That's it. We can't rule out any more cases with the data we have.
+
rsmith wrote:
> lebedev.ri wrote:
> > rsmith wrote:
> > > rsmith wrote:
> > > > lebedev.ri wrot
lebedev.ri updated this revision to Diff 170953.
lebedev.ri added a comment.
Herald added a subscriber: cfe-commits.
Rebased.
The clang part https://reviews.llvm.org/D50250 finally got reviewed, so i'm
wondering if someone could review this, please? :)
Repository:
rCTE Clang Tools Extra
http
kzhuravl added a comment.
In https://reviews.llvm.org/D53558#1272673, @kzhuravl wrote:
> Are changes for
> https://github.com/llvm-mirror/clang/blob/master/lib/Basic/Targets/AMDGPU.cpp#L137
> in a separate review? (I could not locate it).
https://reviews.llvm.org/rC345181
Repository:
rC C
Author: kzhuravl
Date: Wed Oct 24 12:07:56 2018
New Revision: 345181
URL: http://llvm.org/viewvc/llvm-project?rev=345181&view=rev
Log:
AMDGPU: Handle gfx909 in AMDGPUTargetInfo::initFeatureMap
+ add required tests
Modified:
cfe/trunk/lib/Basic/Targets/AMDGPU.cpp
cfe/trunk/test/Driver/amd
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345180: Do not always request an implicit taskgroup region
inside the kmpc_taskloop… (authored by ABataev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53636
Files:
lib/CodeGen/CGO
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: www/analyzer/available_checks.html:1119
+
+
+
george.karpenkov wrote:
> Top of the checker file has a somewhat reasonable description:
>
> // A checker for detecting leaks r
Author: abataev
Date: Wed Oct 24 12:06:37 2018
New Revision: 345180
URL: http://llvm.org/viewvc/llvm-project?rev=345180&view=rev
Log:
Do not always request an implicit taskgroup region inside the kmpc_taskloop
function
Summary:
For the following code:
```
int i;
#pragma omp taskloop
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
This adds a common-avx512 CPU to target the avx512 features common between
skylake-avx512 and knl.
This is the clang version of https://reviews.llvm.org/D53663
https://reviews.llvm.org/D53665
Files:
include/c
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:727
- // Skip all operator new/delete methods.
- if (isa(FD))
-return false;
-
- // Return true if tested operator is a standard placement nothrow operator.
- if (FD->getNumParams() ==
NoQ updated this revision to Diff 170946.
NoQ added a comment.
Address comments!
https://reviews.llvm.org/D53543
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/NewDelete-custom.cpp
test/Analysis/NewDelete-sized-deallocation.cpp
Index: test/Analysis/NewDelete-sized-dea
bryanpkc added a comment.
In https://reviews.llvm.org/D53633#1274621, @t.p.northover wrote:
> I think this is reasonable.
Thanks Tim. Could you also review https://reviews.llvm.org/D53632, which is the
LLVM part of this implementation?
Repository:
rC Clang
https://reviews.llvm.org/D53633
Author: abataev
Date: Wed Oct 24 11:53:12 2018
New Revision: 345177
URL: http://llvm.org/viewvc/llvm-project?rev=345177&view=rev
Log:
[OPENMP]Fix PR39366: do not try to private field if it is not captured.
The compiler is crashing if we trying to post-capture the fields
implicitly captured inside
Author: ctopper
Date: Wed Oct 24 11:45:44 2018
New Revision: 345176
URL: http://llvm.org/viewvc/llvm-project?rev=345176&view=rev
Log:
[CodeGen] Update test checks missed in r345168.
These tests don't run unless the aarch64 target is registered and my testing
had been on an x86 only build directo
alexfh added a comment.
In https://reviews.llvm.org/D53339#1274561, @hwright wrote:
> @JonasToth I don't actually have commit privileges, so somebody else will
> have to commit for me. :)
You should definitely ask commit access.
Repository:
rL LLVM
https://reviews.llvm.org/D53339
ABataev added a comment.
In https://reviews.llvm.org/D53636#1274673, @smateo wrote:
> Hi Alexey,
>
> Thanks for the prompt review!
>
> I don't have commit access yet, do you mind to commit it for me?
>
> Thanks!
Sure, no problems, thanks for the patch!
Repository:
rC Clang
https://reviews.
smateo added a comment.
Hi Alexey,
Thanks for the prompt review!
I don't have commit access yet, do you mind to commit it for me?
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D53636
___
cfe-commits mailing list
cfe-commits@lists.llvm.
mstorsjo added a comment.
In https://reviews.llvm.org/D53066#1274288, @zturner wrote:
> It seems like some combination of checking the target triple, host triple,
> and driver mode and putting the conversions behind those checks could work?
Sounds ok, I can give it a shot. There's probably no
george.karpenkov added a comment.
I'll try to take a look this week.
Repository:
rC Clang
https://reviews.llvm.org/D53206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tekknolagi added a comment.
Ping @NoQ @george.karpenkov
Repository:
rC Clang
https://reviews.llvm.org/D53206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kparzysz
Date: Wed Oct 24 10:55:18 2018
New Revision: 345170
URL: http://llvm.org/viewvc/llvm-project?rev=345170&view=rev
Log:
[Hexagon] Flip hexagon-autohvx to be true by default
This will allow other generators of LLVM IR to use the auto-vectorizer
without having to change that flag.
N
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
I think this is reasonable.
Repository:
rC Clang
https://reviews.llvm.org/D53633
___
cfe-commits mailing list
cfe-commits@lists.
JonasToth added a comment.
Thanks for the patch!
Repository:
rL LLVM
https://reviews.llvm.org/D53339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345167: [clang-tidy] Add the abseil-duration-factory-float
check (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53339
Author: jonastoth
Date: Wed Oct 24 10:40:50 2018
New Revision: 345167
URL: http://llvm.org/viewvc/llvm-project?rev=345167&view=rev
Log:
[clang-tidy] Add the abseil-duration-factory-float check
Summary:
This check finds cases where calls to an absl::Duration factory could use the
more efficient i
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:80
typedef llvm::ImmutableMap GenericDataMap;
hwright added a comment.
In https://reviews.llvm.org/D53339#1274478, @JonasToth wrote:
> I think accepted now? :)
> If you want I can commit for you and monitor the buildbot, if there are
> bigger problems I would come back to you.
@JonasToth I don't actually have commit privileges, so somebo
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Good to go provided you will add an example.
If we want to be serious about this page, it really has to be auto-generated
(like clang-tidy one), but I understand t
Szelethus added a comment.
I can't add anything meaningful to the conversation, but I spotted some nits,
so here they are.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1150
+/// \endcode
+/// fieldDecl()
+/// matches 'a'.
Did you mean to write `indire
Author: compnerd
Date: Wed Oct 24 09:56:36 2018
New Revision: 345160
URL: http://llvm.org/viewvc/llvm-project?rev=345160&view=rev
Log:
CodeGen: extract some local variables in CFConstantString creation (NFC)
Extract the reference to the ASTContext and Triple and use them throughout the
function.
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Good catch!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53642
___
cfe-commits mailing list
cfe-commits@li
tejohnson added a comment.
In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote:
> In https://reviews.llvm.org/D53524#1271357, @pcc wrote:
>
> > The reason why LTO unit is always enabled is so that you can link
> > translation units compiled with `-fsanitize=cfi` and/or
> > `-fwhole-pro
ilya-biryukov added inline comments.
Comment at: lib/Sema/CodeCompleteConsumer.cpp:557
+ if (!Tags.empty())
+OS << " (" << llvm::join(Tags, ",") << ")";
+ if (CodeCompletionString *CCS = Results[I].CreateCodeCompletionString(
ioeric wrote:
> ily
1 - 100 of 238 matches
Mail list logo
