lebedev.ri created this revision.
lebedev.ri added reviewers: JonasToth, aaron.ballman, alexfh, hokein, xazax.hun.
lebedev.ri added a project: clang-tools-extra.
Herald added subscribers: chrib, rnkovacs, kristof.beyls.
The previous, clearly broken output:
/tmp/test.cpp:4:17: warning: integer l
erichkeane added a comment.
In https://reviews.llvm.org/D40925#1276114, @rnk wrote:
> My coworker, @zturner, asked if I knew a way to force emit all constants, and
> I mentioned this flag, but we noticed it doesn't work on cases when the
> constant is implicitly static, like this:
>
> const i
erichkeane created this revision.
erichkeane added reviewers: rnk, zturner, eandrews.
To be more in line with what GCC does, switch the condition to be based
on the Static Storage duration instead of the storage class.
Repository:
rC Clang
https://reviews.llvm.org/D53718
Files:
lib/Code
vsapsai added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:2480
+ SuppressResultRetain);
}
rjmccall wrote:
> This switch is just checking what you already computed as
> `SuppressResultRetain`. Please just assert in the
Charusso added inline comments.
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1853
+
+const auto *Cond = cast(PS->getStmt());
+auto Piece = VisitTrueTest(Cond, tag == tags.first, BRC, BR, N);
george.karpenkov wrote:
> How do we know that it'
Author: compnerd
Date: Thu Oct 25 10:52:13 2018
New Revision: 345291
URL: http://llvm.org/viewvc/llvm-project?rev=345291&view=rev
Log:
CodeGen: alter CFConstantString class name for swift 5.0
Swift 5.0 has changed the name decoration for swift symbols, using a 'S' sigil
rather than 's' as in 4.2.
rnk added a subscriber: zturner.
rnk added a comment.
My coworker, @zturner, asked if I knew a way to force emit all constants, and I
mentioned this flag, but we noticed it doesn't work on cases when the constant
is implicitly static, like this:
const int foo = 42;
If I add `static` to it, i
Szelethus updated this revision to Diff 171141.
Szelethus added a comment.
- Added description as @george.karpenkov mentioned.
Thanks! I guess it's up to @NoQ whether he and @dcoughlin are okay with making
some options checker options.
https://reviews.llvm.org/D53276
Files:
include/clang/St
riccibruno created this revision.
riccibruno added a reviewer: rjmccall.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
riccibruno added a dependency: D53716: [AST] Only store data for the NRVO
candidate in ReturnStmt if needed..
Don't store the init statement and cond
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Minor nitpicks, otherwise makes sense!
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:746
+ /// exploring a top level function
Author: mramalho
Date: Thu Oct 25 10:27:36 2018
New Revision: 345283
URL: http://llvm.org/viewvc/llvm-project?rev=345283&view=rev
Log:
[analyzer] Fixed bitvector from model always being unsigned
Summary:
Getting an `APSInt` from the model always returned an unsigned integer because
of the unused
Author: mramalho
Date: Thu Oct 25 10:27:42 2018
New Revision: 345284
URL: http://llvm.org/viewvc/llvm-project?rev=345284&view=rev
Log:
[analyzer] Move canReasonAbout from Z3ConstraintManager to SMTConstraintManager
Summary:
This patch moves the last method in `Z3ConstraintManager` to
`SMTConstra
ubsan added a comment.
I don't actually know how to send this upstream, since it's been accepted...
How should I proceed?
Repository:
rC Clang
https://reviews.llvm.org/D53207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Szelethus updated this revision to Diff 171130.
Szelethus added a comment.
`RetainCountChecker` now gets it's option when registering, like every other
checker.
`RetainCountChecker` stored a reference to `AnalyzerOptions`, evaluated an
option during construction, and one later down the line. Th
riccibruno created this revision.
riccibruno added a reviewer: rjmccall.
riccibruno added a project: clang.
Herald added subscribers: cfe-commits, javed.absar.
Only store the NRVO candidate if needed in `ReturnStmt`.
A good chuck of all of the `ReturnStmt` have no NRVO candidate.
For all of them t
pcc added a comment.
In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote:
> In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote:
>
> > In https://reviews.llvm.org/D53524#1271357, @pcc wrote:
> >
> > > The reason why LTO unit is always enabled is so that you can link
> > > trans
kadircet added a comment.
Moving forward with priorities then.
Comment at: clangd/index/Background.cpp:89
}
- QueueCV.notify_all();
+ QueueCV.notify_one();
}
sammccall wrote:
> I always forget the details of how these work :-\
> Is it possible for the "on
erichkeane updated this revision to Diff 171128.
erichkeane added a comment.
Update the 2 failing tests. Would love some help looking at the Analysis fix,
it seems to no longer have to 'assume' stuff due to the this now being defined
behavior.
Additionally, the other test is just an AST change
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Thanks a lot, this is almost ready!
I think it should be good to go after this round of nitpicks.
Comment at:
include/clang/StaticAnalyzer/Core
dblaikie added a comment.
In https://reviews.llvm.org/D38061#1275845, @twoh wrote:
> @dblaikie I see. The problem we're experiencing is that with Clang's naming
> scheme we end up having different function name between the original source
> and the preprocessed source (as macro expansion change
riccibruno created this revision.
riccibruno added a reviewer: rjmccall.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
Don't store the data for the condition variable if not needed.
This cuts the size of `WhileStmt` by up to a pointer.
The order of the children is kept
riccibruno created this revision.
riccibruno added a reviewer: rjmccall.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
Don't store the data for the init statement and condition variable
if not needed. This cuts the size of `SwitchStmt` by up to 2 pointers.
The order of
gtbercea updated this revision to Diff 171127.
gtbercea added a comment.
Simplify code.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOp
vsk added a comment.
In https://reviews.llvm.org/D52034#1246379, @calixte wrote:
> I reported a bug for gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87442
Thank you!
> @vsk I'd like to add documentation in Docs/UsersManual.rst, but I've no idea
> on what's a good place for this (I look f
vsk added a comment.
In https://reviews.llvm.org/D52034#1268277, @calixte wrote:
> @vsk, gcc guys are ok for -fprofile-filter-files and
> -fprofile-exclude-files, are you ok with that ?
That sounds fine to me.
> Should these options prefixed by -Xclang or not ?
I don't think they should be.
riccibruno updated this revision to Diff 171125.
riccibruno added a comment.
rebased
Repository:
rC Clang
https://reviews.llvm.org/D53610
Files:
test/Import/switch-stmt/Inputs/F.cpp
test/Import/switch-stmt/test.cpp
Index: test/Import/switch-stmt/test.cpp
===
erichkeane added a comment.
Woops, apparently a couple of tests fail on this that I somehow missed the 1st
time. Looking into it.
Repository:
rC Clang
https://reviews.llvm.org/D53713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
riccibruno updated this revision to Diff 171124.
riccibruno added a comment.
Reworked so that the order of the children is kept the same.
Repository:
rC Clang
https://reviews.llvm.org/D53609
Files:
include/clang/AST/Stmt.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt.cpp
lib/Sema/SemaStmt.cp
Szelethus added a comment.
What are the feelings on moving some functions to the header file? That's the
one thing I'm unsure about regarding this patch. I could've moved them to
`CompilerInvocation.cpp`, but I since I plan on making `ConfigTable` private,
`CompilerInvocation` needs to be a fri
riccibruno updated this revision to Diff 171121.
riccibruno edited the summary of this revision.
riccibruno added a comment.
Reworked so that the order of the children is kept the same.
Repository:
rC Clang
https://reviews.llvm.org/D53607
Files:
include/clang/AST/Stmt.h
lib/AST/ASTImport
erichkeane created this revision.
erichkeane added reviewers: rsmith, aaron.ballman.
Core issue 1013 suggests that having an uninitialied std::nullptr_t be
UB is a bit foolish, since there is only a single valid value. This DR
reports that DR616 fixes it, which does so by making lvalue-to-rvalue
c
filcab added a comment.
In https://reviews.llvm.org/D52615#1272725, @rjmccall wrote:
> In https://reviews.llvm.org/D52615#1266320, @filcab wrote:
>
> > In https://reviews.llvm.org/D52615#1254567, @rsmith wrote:
> >
> > > This seems like an unreasonably long flag name. Can you try to find a
> > >
JonasToth added a comment.
> I'm not sure I understand what you're trying to break in the check. If you're
> thinking of whether the code trips up on the lexical issues, I'm pretty sure
> that won't apply here. Once the const-ness is hidden behind a template, the
> check doesn't try to fix it;
Szelethus planned changes to this revision.
Szelethus added a comment.
Hmm, I'll investigate the `assert` issue @NoQ mentioned before moving forward.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:502
+
+ auto AssertM = callExpr(cal
ABataev added a comment.
What about collapsed loops?
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3390
// UB = min(UB, GlobalUB);
-EmitIgnoredExpr(isOpenMPLoopBoundSharingDirective(S.getDirectiveKind())
+EmitIgnoredExpr(StaticChunked ||
+
JonasToth added a comment.
That one looks interesting :)
Am 25.10.18 um 17:13 schrieb Guillaume Chatelet via Phabricator:
> gchatelet added a comment.
>
> In https://reviews.llvm.org/D53488#1275786, @hokein wrote:
>
>> In https://reviews.llvm.org/D53488#1275750, @gchatelet wrote:
>>
>>> In ht
erichkeane updated this revision to Diff 171118.
erichkeane added a comment.
ACTUALLY add the test this time :/ sorry about that!
https://reviews.llvm.org/D53586
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/TargetInfo.h
lib/AST/Decl.cpp
lib/Basic/Ta
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs, mgorny.
Herald added a reviewer: a.sidorin.
There are certain cases when normal C/C++ lookup (localUncachedLookup)
does not find AST nodes. E.g.:
Example 1:
t
gtbercea updated this revision to Diff 171116.
gtbercea marked an inline comment as done.
gtbercea added a comment.
Refactor static chunk schedules. Fix tests.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
lib/AST/StmtOpenMP.cpp
lib/CodeGe
bjope created this revision.
bjope added reviewers: leonardchan, ebevhan.
- Added names for some emitted values (such as "tobool" for the result of a
cast to boolean).
- Replaced explicit IRBuilder request for doing sext/zext/trunc by using
CreateIntCast instead.
- Simplify code for emitting sat
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D53688#1275793, @sammccall wrote:
> It's hard to reason about UX outside of concrete tools - the only use I know
> of (atom-ide-cpp) never needs to ch
Author: abataev
Date: Thu Oct 25 08:35:27 2018
New Revision: 345277
URL: http://llvm.org/viewvc/llvm-project?rev=345277&view=rev
Log:
[OPENMP]Fix PR39422: variables are not firstprivatized in task context.
According to the OpenMP standard, In a task generating construct, if no
default clause is p
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/ClangdLSPServer.cpp:670
+ /*Output=*/"");
+ if (Old != New)
+CDB->setCompileCommand(File, std::move(New));
---
twoh added a comment.
@dblaikie I see. The problem we're experiencing is that with Clang's naming
scheme we end up having different function name between the original source and
the preprocessed source (as macro expansion changes the column number). This
doesn't work well for me if I want to us
LukeCheeseman closed this revision.
LukeCheeseman added a comment.
This was committed under 345273. (Forgot to mention the revision in the commit
message)
https://reviews.llvm.org/D51429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
Considering that this is
svenvh created this revision.
svenvh added reviewers: Anastasia, rjmccall.
Herald added subscribers: cfe-commits, yaxunl.
In OpenCL C++ mode, the "program scope variable must reside ..."
diagnostic is firing early in some cases, potentially confusing the
user. It is the first diagnostic reported
Author: lukecheeseman
Date: Thu Oct 25 08:23:49 2018
New Revision: 345273
URL: http://llvm.org/viewvc/llvm-project?rev=345273&view=rev
Log:
[AArch64] Branch Protection and Return Address Signing B Key Support
- Add support for -mbranch-protection=[+]* where
- ::= [standard, none, bti, pac-ret[
ymandel added a comment.
In https://reviews.llvm.org/D53025#1271367, @JonasToth wrote:
> In https://reviews.llvm.org/D53025#1270784, @ymandel wrote:
>
> > Correction: the code *catches* the trailing return cases, I just couldn't
> > find a way to *fix* them; specifically, I was not able to get t
gchatelet added a comment.
In https://reviews.llvm.org/D53488#1275786, @hokein wrote:
> In https://reviews.llvm.org/D53488#1275750, @gchatelet wrote:
>
> > In https://reviews.llvm.org/D53488#1274205, @JonasToth wrote:
> >
> > > Did you run this code over a real-world code-base and did you find ne
ymandel updated this revision to Diff 171105.
ymandel added a comment.
Formatting & comment tweaks.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tidy/readability/Co
ymandel updated this revision to Diff 171103.
ymandel added a comment.
Fix bug in const-token finding and add tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-ti
sammccall added a comment.
In https://reviews.llvm.org/D53688#1275586, @ilya-biryukov wrote:
> This feels like a configuration option that might be changed in the course of
> running clangd.
> Are there any strong reasons to make it work only upon initialization? My
> guess is that it keeps th
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D53617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
hokein added a comment.
In https://reviews.llvm.org/D53488#1275750, @gchatelet wrote:
> In https://reviews.llvm.org/D53488#1274205, @JonasToth wrote:
>
> > Did you run this code over a real-world code-base and did you find new
> > stuff and/or false positives or the like?
>
>
> Yes I did run it
kadircet updated this revision to Diff 171099.
kadircet marked an inline comment as done.
kadircet added a comment.
- Use addConstructorResult.
Repository:
rC Clang
https://reviews.llvm.org/D53654
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
test/CodeC
sammccall updated this revision to Diff 171098.
sammccall marked an inline comment as done.
sammccall added a comment.
Switch boolean parameters to positive sense, rebase.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53687
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLS
sammccall marked 2 inline comments as done.
sammccall added a comment.
In https://reviews.llvm.org/D53687#1275580, @ilya-biryukov wrote:
> FWIW, the old implementation of the CDB looked simpler (which makes sense,
> since it only allowed the in-memory compile commands, but the new
> implementat
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
During method import we check for structural eq of two methods.
In the structural eq check we check for their isVirtual() flag
Szelethus updated this revision to Diff 171094.
Szelethus edited the summary of this revision.
https://reviews.llvm.org/D53692
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/Frontend/CompilerInvocation.cpp
lib/StaticAna
gchatelet marked 2 inline comments as done.
gchatelet added a comment.
In https://reviews.llvm.org/D53488#1274205, @JonasToth wrote:
> Did you run this code over a real-world code-base and did you find new stuff
> and/or false positives or the like?
Yes I did run it over our code base. I didn'
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
FunctionDecl import starts with a lookup and then we create a new Decl.
Then in case of CXXConstructorDecl we further import o
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: NoQ.
baloghadamsoftware added a project: clang.
Herald added subscribers: donat.nagy, Szelethus, mikhail.ramalho, a.sidorin,
rnkovacs, szepet, whisperity.
Herald added a reviewer: george.karpenkov.
Currently iterator c
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, echristo, dblaikie.
Herald added a subscriber: krytarowski.
Currently, we only accept `clang` as the scoped attribute identifier for double
square bracket attributes provided by Clang, but this has the potential to
confl
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE345268: [clangd] workspace/symbol should be async, it
reads from the index. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews
Author: sammccall
Date: Thu Oct 25 07:19:14 2018
New Revision: 345268
URL: http://llvm.org/viewvc/llvm-project?rev=345268&view=rev
Log:
[clangd] workspace/symbol should be async, it reads from the index.
Summary:
To enable this, TUScheduler has to provide a way to run async tasks without
needing
Author: sylvestre
Date: Thu Oct 25 07:19:06 2018
New Revision: 345267
URL: http://llvm.org/viewvc/llvm-project?rev=345267&view=rev
Log:
update the clang doc about contributions
Modified:
cfe/trunk/www/hacking.html
Modified: cfe/trunk/www/hacking.html
URL:
http://llvm.org/viewvc/llvm-project
erichkeane updated this revision to Diff 171088.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Added test as requested by @rnk. How's it look? I hope I got the balance of
check-lines right.
https://reviews.llvm.org/D53586
Files:
include/clang/AST/Decl.h
include
sammccall added a comment.
In https://reviews.llvm.org/D53651#1275517, @ilya-biryukov wrote:
> It's fine to spend one thread spinning on background tasks, but if we're
> going to do a threadpool, we should be more careful to not hurt the
> performance of foreground tasks. To do that, we should
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
FunctionType::ExtInfo holds such properties of a function which are needed
mostly for code gen. We should not compare these bi
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:904
+ ///
+ virtual bool isStaticChunked(OpenMPDistScheduleClauseKind ScheduleKind,
+ bool Chunked) const;
gtbercea wrote:
> ABataev wrote:
> > I'd rename thi
gtbercea marked 3 inline comments as done.
gtbercea added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:904
+ ///
+ virtual bool isStaticChunked(OpenMPDistScheduleClauseKind ScheduleKind,
+ bool Chunked) const;
ABataev
gtbercea updated this revision to Diff 171084.
gtbercea marked an inline comment as done.
gtbercea added a comment.
Use NumIterations.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib
gtbercea updated this revision to Diff 171081.
gtbercea added a comment.
Refactor chunk one checking.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
li
kadircet updated this revision to Diff 171077.
kadircet marked 7 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D53654
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletio
ilya-biryukov added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:5101
+const auto *ND = Base.getType()->getAsCXXRecordDecl();
+if (isa(ND) ||
+isa(ND)) {
kadircet wrote:
> kadircet wrote:
> > ilya-biryukov wrote:
> > > Why special-ca
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:5101
+const auto *ND = Base.getType()->getAsCXXRecordDecl();
+if (isa(ND) ||
+isa(ND)) {
kadircet wrote:
> ilya-biryukov wrote:
> > Why special-case the template specializat
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:5101
+const auto *ND = Base.getType()->getAsCXXRecordDecl();
+if (isa(ND) ||
+isa(ND)) {
ilya-biryukov wrote:
> Why special-case the template specializations?
> Are we tryin
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs.
martong added a dependency: D53693: [ASTImporter] Typedef import brings in the
complete type.
If one definition is currently being defined, we do not compare for
return created this revision.
return added reviewers: chandlerc, joerg.
return added a project: clang.
Herald added a subscriber: cfe-commits.
This patch addresses a compilation error with clang when running in Haiku being
unable to compile code using __float128 (throws compilation error such as
Szelethus added a comment.
The reason why I removed the getter functions and went ahead with the gigantic
refactor is that getter functions actually changed the state of
`AnalyzerOptions`, as they were responsible with the initialization of each
option. Now, in the .def file, not all options ha
ilya-biryukov added a comment.
Another annoyance to fix:
- 'using namespace' are shown as ''
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
ilya-biryukov added a comment.
This feels like a configuration option that might be changed in the course of
running clangd.
Are there any strong reasons to make it work only upon initialization? My guess
is that it keeps the code simpler, but if we approached it purely from the UX
perspective,
ilya-biryukov added a comment.
FWIW, the old implementation of the CDB looked simpler (which makes sense,
since it only allowed the in-memory compile commands, but the new
implementation also falls back to the base CDB, i.e. it's now doing two things).
However, if we can't avoid this protocol ex
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
When we already have an incomplete underlying type of a typedef in the
"To" context, and the "From" context has the same typed
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, NoQ, george.karpenkov, MTC, rnkovacs.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, mgrang, szepet, whisperity.
Szelethus added a dependency: D53483: [analyzer] Restrict AnalyzerOptions'
ilya-biryukov updated this revision to Diff 171067.
ilya-biryukov added a comment.
- Improve traversal of the AST.
- Update the tests.
- Add a fallback to SymbolInformation (flat structure) if the client does not
support the hierarhical reponse.
Still some work left to do:
- Do not drop the qua
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345258: [ms] Prevent explicit constructor name lookup if
scope is missing (authored by lantictac, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53441
Files:
lib/Parse/ParseExpr.cpp
Author: lantictac
Date: Thu Oct 25 04:45:32 2018
New Revision: 345258
URL: http://llvm.org/viewvc/llvm-project?rev=345258&view=rev
Log:
[ms] Prevent explicit constructor name lookup if scope is missing
MicrosoftExt allows explicit constructor calls. Prevent lookup of constructor
name unless the
Szelethus marked 3 inline comments as done.
Szelethus added a comment.
Changing asserts to warnings will be delivered in a followup patch.
https://reviews.llvm.org/D53483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Szelethus updated this revision to Diff 171060.
Szelethus edited the summary of this revision.
Szelethus added a comment.
This diff has numerous changed to the last, but it's all "cosmetic", the actual
logic is untouched.
- Added documentation as @xazax.hun suggested
- Removed `getIntegerOption`
ilya-biryukov added a comment.
It's fine to spend one thread spinning on background tasks, but if we're going
to do a threadpool, we should be more careful to not hurt the performance of
foreground tasks. To do that, we should at least:
- share the semaphore for the number of actively running t
JonasToth added a comment.
ping :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D52695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
Great idea, this will definitely improve the UX of completion!
NIT: a typo in the change description: 'bas' should be 'base'.
Pedantic NIT (sorry!): in the change description, we should probably use
'initializers' instead of 'initializations'
Co
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D51429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ilya-biryukov added inline comments.
Comment at: unittests/clangd/TUSchedulerTests.cpp:541
+ std::atomic Counter(0);
+ S.run("add 1", [&] { Counter.fetch_add(1); });
+ S.run("add 2", [&] { Counter.fetch_add(2); });
NIT: maybe simplify to `++Counter`?
Reposit
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
steveire updated this revision to Diff 171046.
steveire added a comment.
New command design
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QueryParser.h
unittests/clang-quer
krasimir added a comment.
The problem with this is that I believe fixing this issue is not worth it,
hence this patch is unnecessary. Feel free to reach out to djasper@ for a
second opinion. For completeness, was the unstability a problem just in
FormatTest.cpp, how about the other FormatTest*.
101 - 200 of 204 matches
Mail list logo
