[PATCH] D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter

2018-10-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345242: [clang-format] Break before next parameter after a formatted multiline raw… (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r345242 - [clang-format] Break before next parameter after a formatted multiline raw string parameter

2018-10-25 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Thu Oct 25 00:39:30 2018 New Revision: 345242 URL: http://llvm.org/viewvc/llvm-project?rev=345242=rev Log: [clang-format] Break before next parameter after a formatted multiline raw string parameter Summary: Currently clang-format breaks before the next parameter after

[PATCH] D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter

2018-10-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 171041. krasimir marked an inline comment as done. krasimir added a comment. - Address review comment Repository: rC Clang https://reviews.llvm.org/D52448 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestRawStrings.cpp Index:

[PATCH] D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter

2018-10-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1594 StartColumn + NewPrefixSize - Style.ColumnLimit : 0; - return Fixes.second + PrefixExcessCharacters * Style.PenaltyExcessCharacter; + unsigned

[PATCH] D53641: [clangd] Remove didOpen extraFlags extension.

2018-10-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. BTW I'm holding off submitting this until we decide the fate of https://reviews.llvm.org/D53688. If we're going to add that extension, I'd like to land the two patches together so the former user of this extension can rely on *one* of them being available.

<    1   2   3