Re: r349010 - Portable Python script across Python version

On Thu, Dec 13, 2018 at 10:48 AM Serge Guelton via cfe-commits wrote: > > Author: serge_sans_paille > Date: Wed Dec 12 23:45:55 2018 > New Revision: 349010 > > URL: http://llvm.org/viewvc/llvm-project?rev=349010&view=rev > Log: > Portable Python script across Python version > > SocketServer has be

r349010 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 12 23:45:55 2018 New Revision: 349010 URL: http://llvm.org/viewvc/llvm-project?rev=349010&view=rev Log: Portable Python script across Python version SocketServer has been renamed socketserver in Python3. Differential Revision: https://reviews.llvm.org/D552

r349009 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 12 23:44:19 2018 New Revision: 349009 URL: http://llvm.org/viewvc/llvm-project?rev=349009&view=rev Log: Portable Python script across Python version Queue module as been renamed into queue in Python3 Differential Revision: https://reviews.llvm.org/D55202

[PATCH] D55202: Python 2/3 compat - Queue

This revision was automatically updated to reflect the committed changes. Closed by commit rC349009: Portable Python script across Python version (authored by serge_sans_paille, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

r349008 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 12 23:42:30 2018 New Revision: 349008 URL: http://llvm.org/viewvc/llvm-project?rev=349008&view=rev Log: Portable Python script across Python version Use higher-level and more compatible threading module to start a new thread. Differential Revision: https:/

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/abseil/MakeUniqueCheck.h:29 +/// \endcode +class MakeUniqueCheck : public modernize::MakeSmartPtrCheck { +public: ---

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

NoQ added a comment. I poked Devin offline. It kinda seems to both of us that Sphinx is great for documentation that is updated regularly, but our fancy front page should probably stay. Similarly to how we still have the llvm.org front page, despite all the documentation. It's kinda atmospheric

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

jyknight added a comment. That example cannot be expected to ever evaluate the expression as "1" -- it doesn't in GCC, nor should it in Clang. An asm constraint of "n" or "i" (but not, e.g., "nr") must require a constant expression, and evaluating the argument as a constant expression necessari

[PATCH] D55616: Emit ASM input in a constant context

jyknight added a comment. This seems like a good start, but not complete. "n" and "i" both should require that their argument is a constant expression. For "n", it actually must be an immediate constant integer, so setRequiresImmediate() should be used there. For "i", you may use an lvalue con

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai added a comment. In D55543#1328034 , @smeenai wrote: > I'd tried this exact same patch back in https://reviews.llvm.org/D44619, but > I was running into a bunch of check-clang failures with it, and I was never > able to figure them out. It looks

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai added a comment. In D55543#1328025 , @rjmccall wrote: > Nice catch. This also fixes problems where there might be cleanups entered > by `EmitParmDecl`, e.g. in ObjC++ with a parameter of type `struct A { > __strong id x; }`; could you please add

[PATCH] D55546: [clang] Add AST matcher for block expressions 🔍

This revision was automatically updated to reflect the committed changes. Closed by commit rL349004: [clang] Add AST matcher for block expressions 🔍 (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55546?vs=1

[PATCH] D55544: Warning: objc-encodings-larger-than=

stephanemoore added a comment. In D55544#1326606 , @stephanemoore wrote: > FYI: > I have a clang-tidy check almost ready for review that aims to flag large > Objective-C type encodings. https://reviews.llvm.org/D55640 Repository: rC Clang CHANGES

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

stephanemoore created this revision. Herald added subscribers: cfe-commits, jfb, xazax.hun, mgorny. Objective-C type encodings are normally pretty small but they it is pretty easy for them to bloat to undesirable levels. Bloated Objective-C type encodings are particularly common for Objective-C me

[PATCH] D54681: [Driver] Avoid including -lm on the link line with -nostdlib++

phosek added a comment. In D54681#1329240 , @thakis wrote: > -lm is kind of the reason -nostdlib++ exists at all -- if you don't want > _any_ stdlibs, you can just -nostdlib, no? We still want standard libraries like `-lc` and compiler builtins, `-nostd

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

EricWF marked an inline comment as done. EricWF added a comment. I'm not sure how you're building this, but it doesn't link for me. We need to add a dependency on `clangTidyModernizeModule` since we're deriving from its `MakeSmartPtrCheck`. Comment at: clang-tidy/abseil/MakeU

[PATCH] D54681: [Driver] Avoid including -lm on the link line with -nostdlib++

thakis added a comment. -lm is kind of the reason -nostdlib++ exists at all -- if you don't want _any_ stdlibs, you can just -nostdlib, no? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54681/new/ https://reviews.llvm.org/D54681 __

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright marked 2 inline comments as done. hwright added inline comments. Comment at: test/clang-tidy/abseil-duration-subtraction.cpp:12 + // CHECK-FIXES: absl::ToDoubleSeconds(d - absl::Seconds(1)) + x = absl::ToDoubleSeconds(d) - absl::ToDoubleSeconds(d1); + // CHECK-MESSAGES

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/MakeUniqueCheck.cpp:28 + recordType(hasDeclaration(classTemplateSpecializationDecl( + hasName("::std::unique_ptr"), templateArgumentCountIs(2), + hasTemplateArgument( EricW

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

EricWF added inline comments. Comment at: clang-tidy/abseil/MakeUniqueCheck.cpp:28 + recordType(hasDeclaration(classTemplateSpecializationDecl( + hasName("::std::unique_ptr"), templateArgumentCountIs(2), + hasTemplateArgument( Does this cat

r349001 - Remove unused Args parameter from EmitFunctionBody, NFC

Author: rnk Date: Wed Dec 12 17:33:20 2018 New Revision: 349001 URL: http://llvm.org/viewvc/llvm-project?rev=349001&view=rev Log: Remove unused Args parameter from EmitFunctionBody, NFC Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp cfe/trunk/lib/CodeGen/CodeGenFunction.h Modified:

[PATCH] D54921: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

NoQ added a comment. Added a test in rC349000 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54921/new/ https://reviews.llvm.org/D54921 ___ cfe-commits mailing list cfe-commits@lis

r349000 - [analyzer] RunLoopAutoreleaseLeakChecker: Come up with a test for r348822.

Author: dergachev Date: Wed Dec 12 17:30:47 2018 New Revision: 349000 URL: http://llvm.org/viewvc/llvm-project?rev=349000&view=rev Log: [analyzer] RunLoopAutoreleaseLeakChecker: Come up with a test for r348822. Statement memoization was removed in r348822 because it was noticed to cause memory co

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

justice_adams added a comment. @cfe-commits Re-pinging this group to request a review on this patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/ https://reviews.llvm.org/D50563 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:93 + + Checks for instances of initializing a `unique_ptr` with a direct call to + `new` and suggests using `absl::make_unique` instead. Please use double `, not single ones to hightlight l

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 177972. axzhang added a comment. Per the suggestions of reviewers, change the check so that it uses modernize-make-smart-pointer instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/

[PATCH] D55628: Add support for "labels" on push/pop directives in #pragma clang attribute

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, aaron.ballman. Herald added subscribers: dexonsmith, jkorous. One problem with defining macros that expand to _Pragma("clang attribute")` is that they don't nest very well: // In some header... #define ASSUME_X

r348991 - Emit a proper diagnostic when attempting to forward inalloca arguments

Author: rnk Date: Wed Dec 12 15:46:06 2018 New Revision: 348991 URL: http://llvm.org/viewvc/llvm-project?rev=348991&view=rev Log: Emit a proper diagnostic when attempting to forward inalloca arguments The previous assertion was relatively easy to trigger, and likely will be easy to trigger going

[PATCH] D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type

rjmccall added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3441 + Value); +} APSInt LHS = HandleIntToIntCast(Info, E, PromotedLHSType, cpplearner wrote: > rjmccall wrote: > > Can we more fundamentally rest

r348982 - Revert "Declares __cpu_model as dso local"

Author: hhb Date: Wed Dec 12 14:39:51 2018 New Revision: 348982 URL: http://llvm.org/viewvc/llvm-project?rev=348982&view=rev Log: Revert "Declares __cpu_model as dso local" This reverts r348978 Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/builtin-cpu-is.c cfe

[PATCH] D55616: Emit ASM input in a constant context

void added a comment. Addressed Eli's comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D55616: Emit ASM input in a constant context

void updated this revision to Diff 177936. void marked an inline comment as done. void added a comment. Don't look at the optimization level here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616 Files: include/clang/AST

[PATCH] D55616: Emit ASM input in a constant context

efriedma added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:1825 +bool Success = false; +if (CGM.getCodeGenOpts().OptimizationLevel > 0) + Success = InputExpr->EvaluateAsInt(Result, getContext()); Checking the optimization level here doesn't m

[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

Szelethus added a comment. >> The deadline is around the creation of the 8.0.0. release branch, right? > > I'd feel slightly more comfortable if some sort of fix gets in before the > Christmas break. Sure! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53280/

[libunwind] r348981 - Avoid code duplication in the SEH version of UnwindCursor::getRegisterName. NFC.

Author: mstorsjo Date: Wed Dec 12 14:24:42 2018 New Revision: 348981 URL: http://llvm.org/viewvc/llvm-project?rev=348981&view=rev Log: Avoid code duplication in the SEH version of UnwindCursor::getRegisterName. NFC. This requires making Registers_*::getRegisterName static. Differential Revision:

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

Szelethus added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:601 +static bool compareToks(Token &T1, Token &T2, const SourceManager &SM) { + if (T1.getLength() != T2.getLength()) Szelethus wrote: > alexfh wrote: > > Should this fun

[PATCH] D55620: [ThinLTO] Clang changes to utilize new pass to handle chains of aliases

tejohnson created this revision. tejohnson added reviewers: pcc, davidxl. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. As with NameAnonGlobals, invoke the new CanonicalizeAliases via clang when using the new PM. Depends on D54507 . Re

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

Szelethus added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:601 +static bool compareToks(Token &T1, Token &T2, const SourceManager &SM) { + if (T1.getLength() != T2.getLength()) alexfh wrote: > Should this function compare token k

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void added a comment. In D54355#1328786 , @jyknight wrote: > In D54355#1328557 , @void wrote: > > > The issue is that "`n`" is expecting an immediate value, but the result of > > the ternary operator isn't calculat

[PATCH] D53850: Declares __cpu_model as dso local

This revision was automatically updated to reflect the committed changes. Closed by commit rL348978: Declares __cpu_model as dso local (authored by hhb, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53850?vs=171789&id=177915#toc Rep

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

jyknight added a comment. In D54355#1328557 , @void wrote: > The issue is that "`n`" is expecting an immediate value, but the result of > the ternary operator isn't calculated by the front-end, because it doesn't > "know" that the evaluation of `__builti

[PATCH] D55616: Emit ASM input in a constant context

void created this revision. void added a reviewer: rsmith. Herald added a subscriber: cfe-commits. void added subscribers: jyknight, craig.topper. void added a comment. As a side note, the number of ways to evaluate a constant expression are legion in clang. They should really be unified... Som

[PATCH] D55616: Emit ASM input in a constant context

void added a comment. As a side note, the number of ways to evaluate a constant expression are legion in clang. They should really be unified... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616 _

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348977: [AST] Store "UsesADL" information in CallExpr. (authored by EricWF, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55534/new/ https://reviews.llvm.o

r348977 - [AST] Store "UsesADL" information in CallExpr.

Author: ericwf Date: Wed Dec 12 13:50:55 2018 New Revision: 348977 URL: http://llvm.org/viewvc/llvm-project?rev=348977&view=rev Log: [AST] Store "UsesADL" information in CallExpr. Summary: Currently the Clang AST doesn't store information about how the callee of a CallExpr was found. Specificall

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF updated this revision to Diff 177907. EricWF marked an inline comment as done. EricWF added a comment. Address final review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55534/new/ https://reviews.llvm.org/D55534 Files: docs/LibASTMatchersReference.html include/cla

[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

NoQ added a comment. In D53280#1325375 , @Szelethus wrote: > I guess the solution would be to check whether there are any user supplied > flags with "analyze" substring, and add the compatibility flag then. It is > possible if not probable that a non-sta

r348969 - Teach __builtin_unpredictable to work through implicit casts.

Author: erichkeane Date: Wed Dec 12 12:30:53 2018 New Revision: 348969 URL: http://llvm.org/viewvc/llvm-project?rev=348969&view=rev Log: Teach __builtin_unpredictable to work through implicit casts. The __builtin_unpredictable implementation is confused by any implicit casts, which happen in C++.

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/ASTMatchers/ASTMatchers.h:1276 +/// y(42); // Doesn't match +/// } +/// \endcode I think it would be useful to add to the

[PATCH] D55039: [sema] Warn of mangling change if function parameters are noexcept.

mattd marked 2 inline comments as done. mattd added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10266 auto *FPT = NewFD->getType()->castAs(); - bool AnyNoexcept = HasNoexcept(FPT->getReturnType()); - for (QualType T : FPT->param_types()) -AnyNoexce

[PATCH] D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3453 Value) && handleFloatFloatBinOp(Info, E, Value, Opcode, RHS.getFloat()) && HandleFloatToFloatCast(Info, E, PromotedLHSType, SubobjType, Value);

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void added a comment. The issue is that "`n`" is expecting an immediate value, but the result of the ternary operator isn't calculated by the front-end, because it doesn't "know" that the evaluation of `__builtin_constant_p` shouldn't be delayed (it being compiled at `-O0`). I suspect that this

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

shafik added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:302 +/// is inspired by ASTContext::mergeFunctionTypes(), we compare calling +/// conventions bits but must not compare some other bits, e.g. the noreturn +/// bit. This comment is con

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

shafik added a comment. Sounds good! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53755/new/ https://reviews.llvm.org/D53755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r348950 - Change CallGraph print to show the fully qualified name

Author: erichkeane Date: Wed Dec 12 10:11:36 2018 New Revision: 348950 URL: http://llvm.org/viewvc/llvm-project?rev=348950&view=rev Log: Change CallGraph print to show the fully qualified name CallGraph previously would just show the normal name of a function, which gets really confusing when usi

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added a comment. In D54862#1328290 , @mikael wrote: > Seems like my this commit broke: > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/33176 > > But since I don't really know what anything about lldb, I probably wo

[PATCH] D49281: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348944: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes. (authored by Meinersbur, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

r348944 - [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes.

Author: meinersbur Date: Wed Dec 12 09:32:52 2018 New Revision: 348944 URL: http://llvm.org/viewvc/llvm-project?rev=348944&view=rev Log: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes. When multiple loop transformation are defined in a loop's metadata, their order of ex

[PATCH] D55525: [Driver] Add support for -fembed-bitcode for assembly file

This revision was automatically updated to reflect the committed changes. Closed by commit rC348943: [Driver] Add support for -fembed-bitcode for assembly file (authored by steven_wu, committed by ). Changed prior to commit: https://reviews.llvm.org/D55525?vs=177563&id=177867#toc Repository:

r348943 - [Driver] Add support for -fembed-bitcode for assembly file

Author: steven_wu Date: Wed Dec 12 09:30:16 2018 New Revision: 348943 URL: http://llvm.org/viewvc/llvm-project?rev=348943&view=rev Log: [Driver] Add support for -fembed-bitcode for assembly file Summary: Handle -fembed-bitcode for assembly inputs. When the input file is assembly, write a marker a

r348942 - Make clang::CallGraph look into template instantiations

Author: erichkeane Date: Wed Dec 12 09:22:52 2018 New Revision: 348942 URL: http://llvm.org/viewvc/llvm-project?rev=348942&view=rev Log: Make clang::CallGraph look into template instantiations Clang's CallGraph analysis doesn't use the RecursiveASTVisitor's setting togo into template instantiatio

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

riccibruno added inline comments. Comment at: include/clang/AST/Type.h:3692 FunctionType::ExceptionType, Expr *, FunctionDecl *, - FunctionType::ExtParameterInfo> { friend class ASTContext; // ASTContext creates these. You can use `Function

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet planned changes to this revision. courbet marked an inline comment as done. courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:136 +static_assert(std::is_const::value, "message"); +// expected-error@-1{{static_assert failed due to requirement 'std:

[PATCH] D55586: Basic: make `int_least64_t` and `int_fast64_t` match on Darwin

compnerd closed this revision. compnerd added a comment. SVN r348939 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55586/new/ https://reviews.llvm.org/D55586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

r348939 - Basic: make `int_least64_t` and `int_fast64_t` match on Darwin

Author: compnerd Date: Wed Dec 12 09:05:20 2018 New Revision: 348939 URL: http://llvm.org/viewvc/llvm-project?rev=348939&view=rev Log: Basic: make `int_least64_t` and `int_fast64_t` match on Darwin The Darwin targets use `int64_t` and `uint64_t` to define the `int_least64_t` and `int_fast64_t` ty

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

JonasToth added inline comments. Comment at: test/clang-tidy/abseil-duration-subtraction.cpp:12 + // CHECK-FIXES: absl::ToDoubleSeconds(d - absl::Seconds(1)) + x = absl::ToDoubleSeconds(d) - absl::ToDoubleSeconds(d1); + // CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtra

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rL348938: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element… (authored by hubert.reinterpretcast, committed by ). Herald a

r348938 - [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

Author: hubert.reinterpretcast Date: Wed Dec 12 08:53:43 2018 New Revision: 348938 URL: http://llvm.org/viewvc/llvm-project?rev=348938&view=rev Log: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types Summary: `memchr` and `memcmp` operate upon the character units

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

Naysh marked an inline comment as done. Naysh added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail aaron.ballman

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

benhamilton added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:115 diag(MatchedDecl->getLocation(), - "function name %0 not using function naming conventions described by " - "Google Objective-C style guide") - << MatchedDecl << gener

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet added a comment. I agree. I'll have a look at it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

JonasToth added a comment. In D55595#1328263 , @steveire wrote: > Can you say where else it is common in LLVM? I'm curious. Maybe those places > could be changed too. My "is common" is not quantified, I have seen it before :) From grepping "extern vola

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan abandoned this revision. atanasyan added a comment. Commits rL348934 and rL348935 enable using of integrated assembler for MIPS targets in all cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

r348935 - [mips] Enable using of integrated assembler in all cases.

Author: atanasyan Date: Wed Dec 12 07:32:25 2018 New Revision: 348935 URL: http://llvm.org/viewvc/llvm-project?rev=348935&view=rev Log: [mips] Enable using of integrated assembler in all cases. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cp

r348932 - Remove TODO leftover from my devleopment branch

Author: erichkeane Date: Wed Dec 12 07:13:00 2018 New Revision: 348932 URL: http://llvm.org/viewvc/llvm-project?rev=348932&view=rev Log: Remove TODO leftover from my devleopment branch Accidentially checked in a TODO line from r348899. This removes it. Change-Id: I74b59c0ecfe147af8a08dd7fd10893a

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

erichkeane updated this revision to Diff 177853. erichkeane added a comment. As mentioned, the @rsmith comments that I thought were doable without feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55527/new/ https://reviews.llvm.org/D55527 Files: include/clang/AST/GlobalDecl.h

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

erichkeane marked 7 inline comments as done. erichkeane added a comment. I got a couple of @rsmith's requests done. Most importantly I suspect is `MultiVersionFuncs`, though `NotForDefinition` vs `ForDefinition` is perhpas something you'll find important. Comment at: lib/Cod

r348931 - Revert "[OpenCL] Add generic AS to 'this' pointer"

Author: mikael Date: Wed Dec 12 07:06:16 2018 New Revision: 348931 URL: http://llvm.org/viewvc/llvm-project?rev=348931&view=rev Log: Revert "[OpenCL] Add generic AS to 'this' pointer" Reverting because the patch broke lldb. Removed: cfe/trunk/test/CodeGenOpenCLCXX/addrspace-of-this.cl Modif

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael added a comment. Seems like my this commit broke: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/33176 But since I don't really know what anything about lldb, I probably won't be able to fix it fast enough. /lldb-buildbot/buildServerSlave/lldb-android-b

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348930: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support. (authored by ABataev, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION http

r348930 - [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

Author: abataev Date: Wed Dec 12 06:52:27 2018 New Revision: 348930 URL: http://llvm.org/viewvc/llvm-project?rev=348930&view=rev Log: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support. Summary: Added support for the -gline-directives-only option + fixed logic of the debug info for CUDA

[PATCH] D55546: [clang] Add AST matcher for block expressions 🔍

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55546/new/ https://reviews.llvm.org/D55546 ___

[PATCH] D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type

cpplearner marked an inline comment as done. cpplearner added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3441 + Value); +} APSInt LHS = HandleIntToIntCast(Info, E, PromotedLHSType, rjmccall wrote: > Can w

Re: r348915 - Add explicit dependency on clangSerialization for a bunch of components to fix -DBUILD_SHARED_LIBS=on build

On Wed, 12 Dec 2018 at 08:05, Fangrui Song via cfe-commits wrote: > > Author: maskray > Date: Wed Dec 12 00:02:18 2018 > New Revision: 348915 > > URL: http://llvm.org/viewvc/llvm-project?rev=348915&view=rev > Log: > Add explicit dependency on clangSerialization for a bunch of components to > fix

r348929 - [clang-fuzzer] Add explicit dependency on clangSerialization for clangHandleCXX after rC348907

Author: asb Date: Wed Dec 12 06:33:24 2018 New Revision: 348929 URL: http://llvm.org/viewvc/llvm-project?rev=348929&view=rev Log: [clang-fuzzer] Add explicit dependency on clangSerialization for clangHandleCXX after rC348907 This library was breaking my -DBUILD_SHARED_LIBS=1 build. rC348915 seem

[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

steveire added a comment. Can you say where else it is common in LLVM? I'm curious. Maybe those places could be changed too. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55595/new/ https://reviews.llvm.org/D55595 ___

r348927 - [OpenCL] Add generic AS to 'this' pointer

Author: mikael Date: Wed Dec 12 06:11:59 2018 New Revision: 348927 URL: http://llvm.org/viewvc/llvm-project?rev=348927&view=rev Log: [OpenCL] Add generic AS to 'this' pointer Address spaces are cast into generic before invoking the constructor. Added support for a trailing Qualifiers object in F

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rC348927: [OpenCL] Add generic AS to 'this' pointer (authored by mikael, committed by ). Changed prior to commit: https://reviews.llvm.org/D54862?vs=177477&id=177846#toc Repository: rC Clang CHANGES S

Re: r348276 - [AST][NFC] Make ArrayTypeTraitExpr non polymorphic

On 12/12/2018 13:25, Mikael Holmén wrote: > > > On 12/12/18 2:17 PM, Bruno Ricci wrote: >> >> >> On 12/12/2018 07:27, Mikael Holmén wrote: >>> Hi, >>> >>> On 12/11/18 5:49 PM, Bruno Ricci wrote: Hi Mikael, I can indeed reproduce this with gcc 5.5.0 when doing a Release build

Re: r348276 - [AST][NFC] Make ArrayTypeTraitExpr non polymorphic

On 12/12/18 2:17 PM, Bruno Ricci wrote: > > > On 12/12/2018 07:27, Mikael Holmén wrote: >> Hi, >> >> On 12/11/18 5:49 PM, Bruno Ricci wrote: >>> Hi Mikael, >>> >>> I can indeed reproduce this with gcc 5.5.0 when doing a Release >>> build with assertions. I cannot reproduce this with gcc 6.5.0 >

Re: r348276 - [AST][NFC] Make ArrayTypeTraitExpr non polymorphic

On 12/12/2018 07:27, Mikael Holmén wrote: > Hi, > > On 12/11/18 5:49 PM, Bruno Ricci wrote: >> Hi Mikael, >> >> I can indeed reproduce this with gcc 5.5.0 when doing a Release >> build with assertions. I cannot reproduce this with gcc 6.5.0 >> (also with a Release build with assertions), nor can

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU); -

[PATCH] D54309: [AST] Allow limiting the scope of common AST traversals (getParents, RAV).

JonasToth added a comment. > Sounds like we might not correctly set the parent map for CXXConstructorDecl > then? I unfortunatly don't know where to start to look for. Could you give me a hint what to inspect to figure that out? Repository: rC Clang CHANGES SINCE LAST ACTION https://revi

[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

JonasToth added a comment. In D55595#1328154 , @steveire wrote: > FYI, CMake target property `INTERFACE_SOURCES` is designed to make this easy. > > For each module you would generate a file containing > > extern volatile int ${MODULE_NAME}ModuleAnchorSou

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348923: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull (authored by martong, committed by ). Hera

r348923 - [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

Author: martong Date: Wed Dec 12 03:22:55 2018 New Revision: 348923 URL: http://llvm.org/viewvc/llvm-project?rev=348923&view=rev Log: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull Summary: a_sidorin Reviewers: a.sidorin Subscribers: rnkovacs, dkrupp, Szelethus, cfe-com

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong added a comment. @shafik > We need to make sure we are running the lldb test suite before committing and > watching the bots to make sure the commit does not break them. I just have tested this patch on macOS and there seems to be no regression. Linux also seems to be without any regr

[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

steveire added a comment. FYI, CMake target property `INTERFACE_SOURCES` is designed to make this easy. For each module you would generate a file containing extern volatile int ${MODULE_NAME}ModuleAnchorSource; static int LLVM_ATTRIBUTE_UNUSED ${MODULE_NAME}ModuleAnchorDestination = ${

[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thanks, LG. You probably may want to wait a bit (a day?) in case others want to comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55595/new/ https://reviews.llvm.org/D555

[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

yvvan updated this revision to Diff 177832. yvvan marked an inline comment as done. yvvan added a comment. Add standard prologue to the new header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55595/new/ https://reviews.llvm.org/D55595 Files: clang-tidy/ClangTidyForceLinker.h clang

  1   2   >