[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: include/clang/Driver/Distro.h:118 } bool IsUbuntu() const { phosek wrote: > Shall we also introduce the `IsGentoo()` predicate for convenience? Hmm, I originally thought th

[PATCH] D39588: Distro: initial support for alpine

mgorny added a comment. Herald added a subscriber: llvm-commits. I'm sorry for being late to the party but could you update `unittests/Driver/DistroTest.cpp` as well? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D39588/new/ https://reviews.llvm.org/D39588

[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

mgorny updated this revision to Diff 179413. mgorny added a comment. Now with `IsGentoo()` predicate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56024/new/ https://reviews.llvm.org/D56024 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp unittests/Driver/DistroTest.cp

[PATCH] D56000: [compiler-rt] [xray] Disable alignas() for thread_local objects on NetBSD

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lib/xray/xray_defs.h:22 +#if !SANITIZER_NETBSD +#define XRAY_TLS_ALIGNAS(x) alignas(x) dberris wrote: > krytarowski wrote: > > I would switch the order, in order to remove unneed

[PATCH] D56000: [compiler-rt] [xray] Disable alignas() for thread_local objects on NetBSD

mgorny updated this revision to Diff 179414. mgorny marked 2 inline comments as done. mgorny added a comment. Reordered. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56000/new/ https://reviews.llvm.org/D56000 Files: lib/xray/xray_basic_logging.cc lib/xray/xray_defs.h lib/xray/xr

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

mgorny created this revision. mgorny added reviewers: pcc, dyung, phosek. Gentoo supports combining clang toolchain with GNU binutils, and many users actually do that. As -faddrsig is not supported by GNU strip, this results in a lot of warnings. Disable it by default and let users enable it exp

[PATCH] D56049: [compiler-rt] [xray] Detect MPROTECT and error out when it's enabled (on NetBSD)

mgorny created this revision. mgorny added reviewers: krytarowski, dberris. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Add a CheckMPROTECT() routine to detect when pax MPROTECT is enabled on NetBSD, and error xray out when it is. The solution is adapted from existing CheckASL

[PATCH] D56049: [compiler-rt] [xray] Detect MPROTECT and error out when it's enabled (on NetBSD)

krytarowski accepted this revision. krytarowski added inline comments. This revision is now accepted and ready to land. Comment at: lib/xray/xray_init.cc:70 + // XRAY is not compatible with pax MPROTECT + CheckMPROTECT(); PaX Repository: rCRT Compiler Run

[PATCH] D56050: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

riccibruno created this revision. riccibruno added a reviewer: efriedma. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. When the type of the base expression after `IgnoreParenCasts` is incomplete, it is still possible to diagnose an array access which precedes the array

r350003 - [AST] Store the arguments of CXXConstructExpr in a trailing array

Author: brunoricci Date: Sat Dec 22 06:39:30 2018 New Revision: 350003 URL: http://llvm.org/viewvc/llvm-project?rev=350003&view=rev Log: [AST] Store the arguments of CXXConstructExpr in a trailing array Store the arguments of CXXConstructExpr in a trailing array. This is very similar to the CallE

[PATCH] D56022: [AST] Store the arguments of CXXConstructExpr in a trailing array

This revision was automatically updated to reflect the committed changes. Closed by commit rL350003: [AST] Store the arguments of CXXConstructExpr in a trailing array (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

thakis accepted this revision. thakis added a comment. Still looks fine to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55382/new/ https://reviews.llvm.org/D55382 ___ cfe-commits mailing list cfe-commits@lists.l

r350004 - Improving this fatal diagnostic to help checker developers figure out what's actually gone wrong when they hit it.

Author: aaronballman Date: Sat Dec 22 07:31:57 2018 New Revision: 350004 URL: http://llvm.org/viewvc/llvm-project?rev=350004&view=rev Log: Improving this fatal diagnostic to help checker developers figure out what's actually gone wrong when they hit it. Modified: cfe/trunk/utils/TableGen/Cla

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

Quuxplusone added a comment. > - using CTAD on arbitrary class templates that weren't designed for it > creates a source compatibility problem that the class template author has no > control over nor say in > - using CTAD on class templates that were designed for it does not create a > new sour

[PATCH] D56054: [gn build] Add build files for clang/tools/{clang-diff, clang-import-test, diagtool and clang/lib/Tooling, clang/lib/Tooling/ASTDiff

thakis created this revision. thakis added a reviewer: phosek. Needed by check-clang. https://reviews.llvm.org/D56054 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/ASTDiff/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/BUILD.gn llvm/utils/gn/secon

[PATCH] D56055: [gn build] Add build files for clang/tools/{clang-refactor, clang-rename}, clang/utils/hmaptool, clang/lib/Tooling/Refactoring

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: jfb. Needed for check-clang. https://reviews.llvm.org/D56055 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/Refactoring/BUILD.gn llvm/utils/gn/secondary/clang/tools

[PATCH] D56056: [gn build] Add build files for clang/tools/{arcmt-test, clang-check, clang-func-mapping}

thakis created this revision. thakis added a reviewer: phosek. Needed for check-clang. https://reviews.llvm.org/D56056 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/tools/arcmt-test/BUILD.gn llvm/utils/gn/secondary/clang/tools/clang-check/BUILD.gn llvm/utils/gn/s

[PATCH] D56055: [gn build] Add build files for clang/tools/{clang-refactor, clang-rename}, clang/utils/hmaptool, clang/lib/Tooling/Refactoring

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56055/new/ https://reviews.llvm.org/D56055 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56054: [gn build] Add build files for clang/tools/{clang-diff, clang-import-test, diagtool and clang/lib/Tooling, clang/lib/Tooling/ASTDiff

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56054/new/ https://reviews.llvm.org/D56054 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56056: [gn build] Add build files for clang/tools/{arcmt-test, clang-check, clang-func-mapping}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56056/new/ https://reviews.llvm.org/D56056 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

phosek added a comment. Just a comment regarding the description, are you sure it's GNU strip and not as? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56047/new/ https://reviews.llvm.org/D56047 ___ cfe-commits mail

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

mgorny added a comment. In D56047#1340303 , @phosek wrote: > Just a comment regarding the description, are you sure it's GNU strip and not > as? Yes. https://bugs.gentoo.org/667854 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.ll