[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. I found an easy way to reproduce the issue and also did some preliminary analysis. I have filed a bug https://bugs.llvm.org/show_bug.cgi?id=40170. The reproducible case and my analysis is below: -bash-4.4$ cat ttest2.c #include "ttest.h"

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: arphaman. Also add a build file for clang/lib/ASTMatchers/Dynamic, which is only needed by tests (and clang/tools/extra). With this, the build files for //clang are complete. - I'm sending this out

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

vitalybuka added a comment. In D47817#1341490 , @krytarowski wrote: > Looks good to me, but I will let a Linux person to accept it. LGTM as well, but would be nice to have input from @ygribov who added this code. CHANGES SINCE LAST ACTION

Re: r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

Should this be in -Wextra-semi? It seems weird to have to pass both -Wextra-semi and -Wextra-semi-stmt. (Also, we generally try to not add DefaultIgnore warnings. I think this is a useful warning though, and other than others in this thread I think it'd be good to have -Wextra-semi in -Wall. But

[PATCH] D56095: [gn build] Add check-clang target and make it work

This revision was automatically updated to reflect the committed changes. Closed by commit rL350108: [gn build] Add check-clang target and make it work (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56112: [clang-offload-bundler] Added install component

chandlerc edited reviewers, added: ABataev, hfinkel; removed: chandlerc. chandlerc added a comment. Adding likely more useful reviewers... Not really interesting from a CMake perspective. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56112/new/

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added inline comments. Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5698 +#if SANITIZER_NETBSD + if (fp->_bf._base) +COMMON_INTERCEPTOR_INITIALIZE_RANGE(fp->_bf._base, maybe `if (fp->_bf._base && fp->_bf._size)` CHANGES

[PATCH] D56112: [clang-offload-bundler] Added install component

vzakhari created this revision. vzakhari added a reviewer: chandlerc. Herald added subscribers: cfe-commits, mgorny. Allow selective install of clang-offload-bundler Repository: rC Clang https://reviews.llvm.org/D56112 Files: CMakeLists.txt Index: CMakeLists.txt

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

krytarowski added a comment. Looks good to me, but I will let a Linux person to accept it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added a comment. As a subtask please add missing calls to `unpoison_file` in interceptors (in sanitizer_common_interceptors.inc) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___

[PATCH] D56095: [gn build] Add check-clang target and make it work

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56095/new/ https://reviews.llvm.org/D56095 ___ cfe-commits mailing list

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179570. mgorny marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added inline comments. Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:2249 +CHECK_SIZE_AND_OFFSET(FILE, _offset); +CHECK_SIZE_AND_OFFSET(FILE, _flags); + krytarowski wrote: > Duplicate with L2231 Fixed. CHANGES SINCE LAST ACTION

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added inline comments. Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:2249 +CHECK_SIZE_AND_OFFSET(FILE, _offset); +CHECK_SIZE_AND_OFFSET(FILE, _flags); + Duplicate with L2231 Repository: rCRT Compiler Runtime CHANGES SINCE

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

rnk added inline comments. Comment at: test/Driver/cl-options.c:177 // RUN: %clang_cl --target=i686-pc-win32 -Werror /Oy- /O2 -### -- %s 2>&1 | FileCheck -check-prefix=Oy_2 %s -// Oy_2: -momit-leaf-frame-pointer +// Oy_2: -mdisable-fp-elim // Oy_2: -O2

[PATCH] D56095: [gn build] Add check-clang target and make it work

thakis updated this revision to Diff 179563. thakis added a comment. s/missing/unimplemented/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56095/new/ https://reviews.llvm.org/D56095 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/test/BUILD.gn

[PATCH] D56095: [gn build] Add check-clang target and make it work

thakis marked an inline comment as done. thakis added inline comments. Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10 +} else { + assert(false, "missing host_cpu " + host_cpu) } phosek wrote: > I don't think `host_cpu` would ever be missing since it's

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

mgorny updated this revision to Diff 179556. mgorny retitled this revision from "[compiler-rt] [sanitizer_common] Fix using libtirpc on Linux" to "[compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h". mgorny edited the summary of this revision. mgorny added reviewers:

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

ken-cunningham-webuse added a comment. Herald added subscribers: llvm-commits, jsji. @iains - I have interest in resolving this issue, and also a couple of other lingering bugs in the PPC32Darwin ABI realm. If you have your WIP available anywhere, I'd be happy to have a go at bringing it up to

Re: r350092 - [objc-gnustep] Fix a copy-and-paste error.

test? On Thu, Dec 27, 2018 at 5:47 PM David Chisnall via cfe-commits wrote: > > Author: theraven > Date: Thu Dec 27 06:44:36 2018 > New Revision: 350092 > > URL: http://llvm.org/viewvc/llvm-project?rev=350092=rev > Log: > [objc-gnustep] Fix a copy-and-paste error. > > We were emitting the null

r350092 - [objc-gnustep] Fix a copy-and-paste error.

Author: theraven Date: Thu Dec 27 06:44:36 2018 New Revision: 350092 URL: http://llvm.org/viewvc/llvm-project?rev=350092=rev Log: [objc-gnustep] Fix a copy-and-paste error. We were emitting the null class symbol in the wrong section, which meant that programs that contained no Objective-C

[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao added a comment. In D21856#1338687 , @thakis wrote: > Sorry about the years-later question, but what's the motivation for shelling > out to an external command here? In general, LLVM tries to use a > library-based approach, and LLVM went e.g.

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

theraven added a comment. Please can we either merge this or revert the original change that introduced the bug that this is fixing? It's now been 6 months since blocks generated invalid ELF symbols. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54539/new/