[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone added a comment. @EricWF ping! and oops, I never submitted these comments, I guess. Comment at: include/experimental/memory_resource:427 +{ +static const size_t __default_buffer_capacity = 1024; +static const size_t __default_buffer_alignment = 16;

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 179718. Quuxplusone added a comment. Updated and addressed review comments. `test/std/experimental/memory/memory.resource.monotonic.buffer/monotonic.buffer.mem/allocate_overaligned_request.pass.cpp` is now XFAILed on OSX platforms, using code

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

krytarowski added a comment. Shouldn't this follow SANITIZER_INTERCEPT_FOPENCOOKIE and implement a wrapper for operations? Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56158/new/ https://reviews.llvm.org/D56158

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56158 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56154: [sanitizer_common] Add tests for NetBSD funopen*()

mgorny updated this revision to Diff 179713. mgorny added a comment. Added assertions for `fileno()` returning -1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56154/new/ https://reviews.llvm.org/D56154 Files: test/sanitizer_common/TestCases/NetBSD/funopen.cc

[PATCH] D56153: [sanitizer_common] Add test for popen()

mgorny updated this revision to Diff 179712. mgorny added a comment. Added assertion verifying that `fileno(fp)` works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56153/new/ https://reviews.llvm.org/D56153 Files: test/sanitizer_common/TestCases/Posix/popen.cc Index:

[PATCH] D56152: [sanitizer_common] Add tests for more *putc and *getc variants

mgorny updated this revision to Diff 179711. mgorny retitled this revision from "[sanitizer_common] Add tests for remaining *putc and *getc variants" to "[sanitizer_common] Add tests for more *putc and *getc variants". mgorny edited the summary of this revision. mgorny added a comment. Updated

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. In D55326#1342412 , @nemanjai wrote: > A couple of questions since I am not all that familiar with clang and am > certainly not familiar with this unusual SUSE 32-bit situation: > > - We seem to be changing the set of aliases

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. In D56152#1342372 , @mgorny wrote: > In D56152#1342331 , @krytarowski > wrote: > > > Are all the

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

krytarowski added a subscriber: dvyukov. krytarowski added a comment. Looks good to me, but it would be nice to have opinion of @vitalybuka and/or @dvyukov (TSan). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone updated this revision to Diff 179710. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47344/new/ https://reviews.llvm.org/D47344 Files: src/experimental/memory_resource.cpp Index: src/experimental/memory_resource.cpp

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Implement the interceptors for popen(), pclose() and popenve() functions. The first two are POSIX, the third one is specific to NetBSD. popen() spawns a

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. A couple of questions since I am not all that familiar with clang and am certainly not familiar with this unusual SUSE 32-bit situation: - We seem to be changing the set of

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

ken-cunningham-webuse added a comment. I saw that idea floated but didn't see that it was accepted. I don't know exactly how much interest there is in darwin PPC. There are new tickets about Darwin PPC within the past few months. I see plenty of questions about it on the MacPorts boards. I

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

mgorny updated this revision to Diff 179707. mgorny added a comment. Updated variable style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc Index:

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone added a comment. @EricWF ping! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47344/new/ https://reviews.llvm.org/D47344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

mgorny added a comment. In D56152#1342331 , @krytarowski wrote: > Are all the functions available for FreeBSD, NetBSD, Linux, Android, Solaris > an Darwin? I don't know. I suppose the easiest way to check would be to commit it and see what happens.

[PATCH] D53072: [clang-format] Introduce the flag which allows not to shrink lines

djasper added a comment. I don't quite understand. What you are describing should already be the behavior with ColumnLimit=0 and I think your test should pass without the new option. Doesn't it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53072/new/ https://reviews.llvm.org/D53072

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

iains added a comment. Since that's my understanding too - I am (slowly) bringing my patches forward to 7.0 - at the moment testing the MC layer changes on powerpc-darwin9 (looking reasonable, as an assembler for GCC, so far). When things are "ready" (at least not broken as far as I can

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

nemanjai added a comment. In D33499#1341236 , @ken-cunningham-webuse wrote: > @iains - I have interest in resolving this issue, and also a couple of other > lingering bugs in the PPC32Darwin ABI realm. If you have your WIP available > anywhere, I'd be

[PATCH] D53072: [clang-format] Introduce the flag which allows not to shrink lines

krasimir added a comment. In D53072#1268883 , @yvvan wrote: > Do you know the better way to accomplish my aim than adding an option to > libFormat? For example making a dependent library which serves a little > different purpose than libFormat itself or

[PATCH] D56153: [sanitizer_common] Add test for popen()

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. But of course new code can be added as a new revision. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56153/new/

[PATCH] D56154: [sanitizer_common] Add tests for NetBSD funopen*()

krytarowski accepted this revision. krytarowski added inline comments. This revision is now accepted and ready to land. Comment at: test/sanitizer_common/TestCases/NetBSD/funopen2.cc:2 +// RUN: %clangxx -g %s -o %t && %run %t | FileCheck %s + +// CHECK: READ CALLED;

[PATCH] D56154: [sanitizer_common] Add tests for NetBSD funopen*()

krytarowski added inline comments. Comment at: test/sanitizer_common/TestCases/NetBSD/funopen2.cc:2 +// RUN: %clangxx -g %s -o %t && %run %t | FileCheck %s + +// CHECK: READ CALLED; len={{[0-9]*}} // UNSUPPORTED: linux, freebsd, solaris, darwin Repository:

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

krytarowski added a comment. Does this depend on D56109 ? It looks like we shall install interceptors for a lot of routines that are FILE* users. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56152/new/

[PATCH] D56154: [sanitizer_common] Add tests for NetBSD funopen*()

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56154 Files: test/sanitizer_common/TestCases/NetBSD/funopen.cc

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

krytarowski added a comment. Are all the functions available for FreeBSD, NetBSD, Linux, Android, Solaris an Darwin? I would include a test for `getchar_unlocked()` anyway, even if it's an alias in most/all implementations. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION

[PATCH] D56153: [sanitizer_common] Add test for popen()

krytarowski added a comment. It looks fine, but we don't have interceptors for popen(3), popenve(3), pclose(3). Could you include them together with this patch? Add add a test for popenve(3). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56153/new/

[PATCH] D56153: [sanitizer_common] Add test for popen()

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56153 Files: test/sanitizer_common/TestCases/Posix/popen.cc Index:

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Subject: [PATCH 5/5] [sanitizer_common] Add tests for remaining *putc and *getc variants Add tests for the remaining character-oriented functions, that

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350157: [CodeGen] Replace @ characters in block descriptors symbol names with (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r350157 - [CodeGen] Replace '@' characters in block descriptors' symbol names with

Author: ahatanak Date: Sat Dec 29 09:28:30 2018 New Revision: 350157 URL: http://llvm.org/viewvc/llvm-project?rev=350157=rev Log: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1'. '@' can't be used in block descriptors' symbol names since it is reserved on ELF

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

krytarowski added a comment. Looks fine, but according to newer style of newer interceptors we prefer: `DEVNAME_R_RETTYPE res = REAL(devname_r)(dev, type, path, len);` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

mgorny updated this revision to Diff 179696. mgorny added a comment. Fixed lint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc Index:

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek, emaste. Update the interceptor for devname_r() to account for correct return types on different platforms. This function returns int on NetBSD but char*

[PATCH] D56149: [sanitizer_common] Rewrite more Posix tests to use asserts

krytarowski added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/devname_r.cc:21 #if defined(__NetBSD__) - if (devname_r(st.st_rdev, type, name, sizeof(name))) -exit(1); + assert(!devname_r(st.st_rdev, type, name, sizeof(name))); #else

[PATCH] D56149: [sanitizer_common] Rewrite more Posix tests to use asserts

mgorny updated this revision to Diff 179693. mgorny retitled this revision from "[sanitizer_common] Rewrite fgets/fputs/puts tests to use asserts" to "[sanitizer_common] Rewrite more Posix tests to use asserts". mgorny edited the summary of this revision. mgorny added a comment. Updated to

[PATCH] D56149: [sanitizer_common] Rewrite fgets/fputs/puts tests to use asserts

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Rewrite the tests for fgets and for fputs/puts to verify results using assert instead of silently returning non-zero exit status. This is based on

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny updated this revision to Diff 179691. mgorny added a comment. Added asserts for `fclose()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56136/new/ https://reviews.llvm.org/D56136 Files: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

krytarowski added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:38 + + fclose(fp); + return 0; mgorny wrote: > krytarowski wrote: > > krytarowski wrote: > > > `assert(!fclose(fp));` > > alternatively `!= EOF` > It

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. Looks like a much cleaner change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54539/new/ https://reviews.llvm.org/D54539

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

ahatanak updated this revision to Diff 179676. ahatanak added a comment. Sorry for the delay. The updated patch replaces '@' with '\1' on all targets. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54539/new/ https://reviews.llvm.org/D54539 Files:

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny added a comment. (Do you have another idea how to reliably trigger `ferror`?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56136/new/ https://reviews.llvm.org/D56136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:38 + + fclose(fp); + return 0; krytarowski wrote: > krytarowski wrote: > > `assert(!fclose(fp));` > alternatively `!= EOF` It will fail most likely, due to us

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

krytarowski added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:38 + + fclose(fp); + return 0; krytarowski wrote: > `assert(!fclose(fp));` alternatively `!= EOF` CHANGES SINCE LAST ACTION

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

krytarowski accepted this revision. krytarowski added inline comments. This revision is now accepted and ready to land. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:38 + + fclose(fp); + return 0; `assert(!fclose(fp));`

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179681. mgorny added a comment. Implemented `fileno_unlocked` as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny updated this revision to Diff 179679. mgorny marked an inline comment as done. mgorny added a comment. Moved variable definitions, and added asserts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56136/new/ https://reviews.llvm.org/D56136 Files:

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:49 + + fclose(fp); + return 0; vitalybuka wrote: > why does this close file only on success? > I assume normal test