[PATCH] D57220: Test fix for isViableInline remark message

yrouban created this revision. yrouban added reviewers: xbolva00, anemet. Herald added a subscriber: cfe-commits. yrouban added a parent revision: D57089: Provide reason messages for unviable inlining. This patch adjusts the test remark message that is changed by D57089

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added a comment. To me, modulo the `"IgnoredExceptions"` change, this seems like a straight-forward refactoring. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:25 +/// give the possibility of an exception. +class ExceptionAnalyzer { +public: What

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

mstorsjo added a comment. In D57209#1370608 , @rnk wrote: > and I don't think anyone has set up a continuous Windows ARM64 build with ToT > clang anywhere in the world yet. Not sure if it qualifies as a proper continuous Windows ARM64 build, but I buil

r352173 - [X86] Remove mask and passthru arguments from vpconflict builtins. Use select in IR instead.

Author: ctopper Date: Thu Jan 24 23:08:22 2019 New Revision: 352173 URL: http://llvm.org/viewvc/llvm-project?rev=352173&view=rev Log: [X86] Remove mask and passthru arguments from vpconflict builtins. Use select in IR instead. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/t

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan created this revision. leonardchan added reviewers: rjmccall, bjope, ebevhan. leonardchan added a project: clang. leonardchan added a parent revision: D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types. This patch implements fixed point comparisons

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. In D56624#1370607 , @yln wrote: > In D56624#1370579 , @eugenis wrote: > > > Maybe the frontend should insert __asan_handle_noreturn whenever ASan is > > enabled, and then ASan would not care ab

[PATCH] D57135: [ExprConstant] Unify handling of array init with lvalues.

efriedma abandoned this revision. efriedma added a comment. I'm now convinced this is the wrong approach. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57135/new/ https://reviews.llvm.org/D57135 ___ cfe-commits maili

[PATCH] D56792: Rename getTypeQualifiers to getMethodQualifiers

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. There isn't really a standard name for this; in the absence of such a name, this seems as good as anything. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56792/new/ https://reviews.l

r352156 - [AArch64] Make the test for rsr and rsr64 stricter

Author: phosek Date: Thu Jan 24 18:42:30 2019 New Revision: 352156 URL: http://llvm.org/viewvc/llvm-project?rev=352156&view=rev Log: [AArch64] Make the test for rsr and rsr64 stricter ACLE specifies that return type for rsr and rsr64 is uint32_t and uint64_t respectively. D56852 change the return

[PATCH] D57210: [AArch64] Make the test for rsr and rsr64 stricter

This revision was automatically updated to reflect the committed changes. Closed by commit rL352156: [AArch64] Make the test for rsr and rsr64 stricter (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57210?vs=18344

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC352153: Revert "[AArch64] Use LL for 64-bit intrinsic arguments" (authored by phosek, committed by ). Changed prior to co

r352153 - Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

Author: phosek Date: Thu Jan 24 18:16:29 2019 New Revision: 352153 URL: http://llvm.org/viewvc/llvm-project?rev=352153&view=rev Log: Revert "[AArch64] Use LL for 64-bit intrinsic arguments" This reverts commit r351740: this broke on platforms where unsigned long long isn't the same as uint64_t wh

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

rnk added a comment. I'd say go for it, it's basically already EOD Pacific time, and I don't think anyone has set up a continuous Windows ARM64 build with ToT clang anywhere in the world yet. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57209/new/ https://revi

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln added a comment. In D56624#1370579 , @eugenis wrote: > Maybe the frontend should insert __asan_handle_noreturn whenever ASan is > enabled, and then ASan would not care about the attribute? I'd like to avoid > having this logic in two places. +1 for

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

phosek added a comment. Is it OK with you to land this revert, followed by D57210 , and then reland this with the appropriate fix? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57209/new/ https://reviews.llvm.org/D57209 _

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai added a comment. I've added a test case with typedef and think it should be emitting a warning. I.e., the behaviour with typedef should be the same as without it, modulo different pretty-printing in diagnostic. The interesting part is that this test is failing even without my change. I'

[PATCH] D57204: [AST] Add a method to get a call type from an ObjCMessageExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC352147: [AST] Add a method to get a call type from an ObjCMessageExpr (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D57210: [AArch64] Make the test for rsr and rsr64 stricter

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57210/new/ https://reviews.llvm.org/D57210 ___ cfe-commit

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

eugenis added a comment. Maybe the frontend should insert __asan_handle_noreturn whenever ASan is enabled, and then ASan would not care about the attribute? I'd like to avoid having this logic in two places. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56624/new

r352148 - [analysis] Introduce an AnyCall helper class, for abstraction over different callables

Author: george.karpenkov Date: Thu Jan 24 17:23:51 2019 New Revision: 352148 URL: http://llvm.org/viewvc/llvm-project?rev=352148&view=rev Log: [analysis] Introduce an AnyCall helper class, for abstraction over different callables A lot of code, particularly in the analyzer, has to perform a lot

r352147 - [AST] Add a method to get a call type from an ObjCMessageExpr

Author: george.karpenkov Date: Thu Jan 24 17:23:37 2019 New Revision: 352147 URL: http://llvm.org/viewvc/llvm-project?rev=352147&view=rev Log: [AST] Add a method to get a call type from an ObjCMessageExpr Due to references, expression type does not always correspond to an expected method return t

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

efriedma added a comment. Oh, rsr and wsr are macros, not functions... I was confused how it would break. The correct signature for __builtin_arm_rsr64 is "WUicC*", I think. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57209/new/ https://reviews.llvm.org/D57209

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai updated this revision to Diff 183450. vsapsai added a comment. - Add a failing test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57075/new/ https://reviews.llvm.org/D57075 Files: clang/lib/AST/Type.cpp clang/test/SemaObjC/parameterized_classes_subst.m Index: clang/t

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

phosek added a comment. This broke our kernel build which uses `PRIx64` to print the return value of `__builtin_arm_rsr64`. This is correct because according to ACLE, the return type of that builtin should be `uint64_t`. Problem is that on AArch64, `unsigned long` is equivalent to `uint64_t`, n

[PATCH] D57210: [AArch64] Make the test for rsr and rsr64 stricter

phosek created this revision. phosek added reviewers: samparker, efriedma, t.p.northover, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. ACLE specifies that return type for rsr and rsr64 is uint32_t and uint64_t respectively. D56852 change

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln added a comment. Seems as if we reached consensus! :) I will change the revision to use an intrinsic. Before I start doing that, just one more quick idea: Would it work if UBsan directly inserts calls to `__asan_handle_no_return` (of course only when ASan is requested). Similar to how it i

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

phosek created this revision. phosek added reviewers: samparker, efriedma, t.p.northover, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. This reverts commit r351740: this broke on platforms where unsigned long long isn't the same as uint64_t which is what ACLE specifies fo

[PATCH] D57208: Replace two RecursiveASTVisitor insantiations with StmtVisitor

rnk created this revision. rnk added reviewers: arphaman, rsmith. RecursiveASTVisitor is very expensive to instantiate and results in needlessly slow compilation. For these availability check fixits, we don't need to instantiate the full complexity of the declaration walking machinery, we can use

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Implicit functions are outside the control of source authors and should be exempt from style restrictions. Tested via running clang tools tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/lib/AST/Type.cpp:1295 + + QualType VisitObjCObjectType(const ObjCObjectType *objType) { +if (!objType->isKindOfType()) erik.pilkington wrote: > Does this works with ty

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker updated this revision to Diff 183437. karepker added a comment. Rebasing against master. Not sure if re-arc diffing this is necessary, but I hope it doesn't hurt. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/ https://reviews.llv

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. In D56624#1370280 , @eugenis wrote: > > Wouldn’t it be preferable to unpoison the stack inside of maybe_longjmp, > > once the opaque condition can be checked? > > Sure, but that's not always possible. That's why we have interceptors.

Re: r351579 - [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

Merged to 8.0 in r352139. On Fri, Jan 18, 2019 at 11:58 AM Vladimir Stefanovic via cfe-commits wrote: > > Author: vstefanovic > Date: Fri Jan 18 11:54:51 2019 > New Revision: 351579 > > URL: http://llvm.org/viewvc/llvm-project?rev=351579&view=rev > Log: > [mips] Add '-mrelax-pic-calls', '-mno-rel

[PATCH] D57064: [Sema] Improve a -Warray-bounds diagnostic

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2092 + Optional getTypeSizeInCharsIfKnown(QualType Ty) const { +if (Ty->isIncompleteType() || Ty->isDependentType()) + return None;

Re: r352102 - Add a triple to this test so it passes for targets where alignof(double)

Merged to 8.0 in r352132. On Thu, Jan 24, 2019 at 12:52 PM Richard Smith via cfe-commits wrote: > > Author: rsmith > Date: Thu Jan 24 12:52:56 2019 > New Revision: 352102 > > URL: http://llvm.org/viewvc/llvm-project?rev=352102&view=rev > Log: > Add a triple to this test so it passes for targets w

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added inline comments. Comment at: docs/LanguageExtensions.rst:497 defined by the C standards committee, so using ``_Float16`` will not prevent -code from being ported to architectures other than Arm. Also, ``_Float16`` -arithmetic and operations will directly map on h

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. In D57104#1370275 , @steveire wrote: > In D57104#1370081 , @riccibruno > wrote: > > > > I highly recommend this 9 minute video if this is new to you or you > > > haven't seen it before:

[PATCH] D56581: [ASTImporter] Set the described template if not set

shafik added a comment. @martong Unfortunately this causes a regression on one of the lldb tests `TestDataFormatterLibcxxVector.py` e.g. lldb-dotest -p TestDataFormatterLibcxxVector.py -t -G gmodules --no-multiprocess So this is specific to modules. If you can't reproduce this I can provide

[PATCH] D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends

This revision was automatically updated to reflect the committed changes. Closed by commit rC352125: [clang-format] square parens with one token are not Objective-C message sends (authored by arphaman, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

r352125 - [clang-format] square parens with one token are not Objective-C message sends

Author: arphaman Date: Thu Jan 24 15:07:58 2019 New Revision: 352125 URL: http://llvm.org/viewvc/llvm-project?rev=352125&view=rev Log: [clang-format] square parens with one token are not Objective-C message sends The commit r322690 introduced support for ObjC detection in header files. Unfortunat

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

eugenis added a comment. > Wouldn’t it be preferable to unpoison the stack inside of maybe_longjmp, once > the opaque condition can be checked? Sure, but that's not always possible. That's why we have interceptors. >> One possible optimization that I can think of is splitting code after the >>

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1370081 , @riccibruno wrote: > > I highly recommend this 9 minute video if this is new to you or you haven't > > seen it before: https://youtu.be/qpdYRPL3SVE?t=103 > > I would like to add an additional meta-comment here

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. In D56624#1370243 , @eugenis wrote: > > Because "expect_noreturn" calls are allowed to return, the compiler must > > behave as they could. In particular, this means that unpoisoning the stack > > before expect_noreturn calls (given t

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

dblaikie added inline comments. Comment at: include/clang/AST/Expr.h:5103 +using reference = AssociationTy; +using pointer = AssociationTy; +AssociationIteratorTy() = default; aaron.ballman wrote: > riccibruno wrote: > > aaron.ballman wrote: > > > Car

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik updated this revision to Diff 183406. shafik marked 3 inline comments as done. shafik added a comment. Changes based on comments - Refactoring ImportFunctionDeclBody to return Error - Refactoring test/Analysis/ctu-main.cpp based on Gabor's patch - Removing merging of function body for late

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik added a comment. @martong so I just tested your `lit-tests.patch` and it looks good! Comment at: lib/AST/ASTImporter.cpp:2959 +} + ExpectedDecl ASTNodeImporter::VisitFunctionDecl(FunctionDecl *D) { balazske wrote: > Code formatting is not OK in this fun

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

eugenis added a comment. > Because "expect_noreturn" calls are allowed to return, the compiler must > behave as they could. In particular, this means that unpoisoning the stack > before expect_noreturn calls (given the current semantics) is premature. I don't think that's true. A hypothetical f

Re: [clang-tools-extra] r352040 - [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

Merged in r352118 (cfe) and r352120 (clang-tools-extra). Please let me know if there are any follow-ups. Thanks, Hans On Thu, Jan 24, 2019 at 5:11 AM Ilya Biryukov wrote: > > +Hans Wennborg, could you please merge this fix into the release branch? > > On Thu, Jan 24, 2019 at 1:41 PM Ilya Biryuko

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added a comment. Oh I forgot to submit the comments. Comment at: clang/lib/AST/ExprConstant.cpp:9825 +if (Result.isSigned() && !DstSigned) { + Overflow = Result < 0 || Result.ugt(DstMax); +} else if (Result.isUnsigned() && DstSigned) {

[PATCH] D57189: Fix compatibility with the msvc AI compiler option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL352119: [clang-cl] Ignore space-separated /AI arguments (authored by rnk, committed by ). Herald added a subscriber: llvm-

r352119 - [clang-cl] Ignore space-separated /AI arguments

Author: rnk Date: Thu Jan 24 14:26:51 2019 New Revision: 352119 URL: http://llvm.org/viewvc/llvm-project?rev=352119&view=rev Log: [clang-cl] Ignore space-separated /AI arguments The /AI flag is for #using directives, which I don't think we support. This is consistent with how the /I flag is handl

[PATCH] D57189: Fix compatibility with the msvc AI compiler option

rnk updated this revision to Diff 183398. rnk added a comment. - add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57189/new/ https://reviews.llvm.org/D57189 Files: clang/include/clang/Driver/CLCompatOptions.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-optio

[PATCH] D57189: Fix compatibility with the msvc AI compiler option

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, I'll go ahead and commit this soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57189/new/ https://reviews.llvm.org/D57189 ___

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > lildmh wrote: > > > >

[PATCH] D53199: Fix the behavior of clang's -w flag.

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/DiagnosticIDs.cpp:460-463 + // Honor -w: this disables all messages mapped to Warning severity, and

[PATCH] D57189: Fix compatibility with the msvc AI compiler option

zahen created this revision. zahen added reviewers: rnk, zturner. Herald added a subscriber: cfe-commits. The unsupported /AI option accepts directory paths in a manner similar to the supported /I option and allows spaces between the flag and the directory. An example snippet from our productio

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:76 +- New :doc:`abseil-duration-addition + ` check. Please use alphabetical order for new checks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

erichkeane created this revision. erichkeane added reviewers: rjmccall, andrew.w.kaylor. Herald added subscribers: kristof.beyls, javed.absar. As Discussed here: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129543.html There are problems exposing the _Float16 type on architectures that h

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. > I highly recommend this 9 minute video if this is new to you or you haven't > seen it before: https://youtu.be/qpdYRPL3SVE?t=103 I would like to add an additional meta-comment here, but please don't take this in a bad way. I am wondering about the usefulness and th

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

hwright created this revision. hwright added reviewers: hokein, aaron.ballman, JonasToth. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This is an analog to the existing `abseil-duration-subtraction` check. Repository: rCTE Clang Tools Ex

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. In D57104#1370025 , @aaron.ballman wrote: > In D57104#1369985 , @steveire wrote: > > > There's definitely a better possible ordering in two commits: > > > > 1. Introduce `::Create` and p

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > >

[PATCH] D57104: [AST] Pack GenericSelectionExpr

aaron.ballman added a comment. In D57104#1369985 , @steveire wrote: > There's definitely a better possible ordering in two commits: > > 1. Introduce `::Create` and port to it > 2. Use trailing objects, taking advantage of the fact that `::Create` exists. >

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. In D57104#1369985 , @steveire wrote: > There's definitely a better possible ordering in two commits: > > 1. Introduce `::Create` and port to it > 2. Use trailing objects, taking advantage of the fact that `::Create` exists. > >

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

dextero created this revision. dextero added reviewers: Typz, krasimir, djasper. Herald added a subscriber: cfe-commits. Adds a `TypenameMacros` configuration option that causes certain identifiers to be handled in a way similar to `typeof()`. This is enough to: - Prevent misinterpreting declar

r352108 - [WebAssembly] Add WebAssemblyImportModule to pragma-attribute-supported-attributes-list.test

Author: djg Date: Thu Jan 24 13:20:03 2019 New Revision: 352108 URL: http://llvm.org/viewvc/llvm-project?rev=352108&view=rev Log: [WebAssembly] Add WebAssemblyImportModule to pragma-attribute-supported-attributes-list.test Modified: cfe/trunk/test/Misc/pragma-attribute-supported-attributes-l

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1369985 , @steveire wrote: > There's definitely a better possible ordering in two commits: > > 1. Introduce `::Create` and port to it > 2. Use trailing objects, taking advantage of the fact that `::Create` exists. > >

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

aaron.ballman added a comment. In D56160#1367811 , @JonasToth wrote: > In D56160#1367074 , @bernhardmgruber > wrote: > > > Thank you again @JonasToth for all your valueable input! I could almost > > successfully r

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. There's definitely a better possible ordering in two commits: 1. Introduce `::Create` and port to it 2. Use trailing objects, taking advantage of the fact that `::Create` exists. That would make it clear in the future to other people because both commits would be clean

[PATCH] D57160: [WebAssembly] Add an import_module function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rC352106: [WebAssembly] Add an import_module function attribute (authored by djg, committed by ). Changed prior to commit: https://reviews.llvm.org/D57160?vs=183322&id=183378#toc Repository: rC Clang

r352106 - [WebAssembly] Add an import_module function attribute

Author: djg Date: Thu Jan 24 13:08:30 2019 New Revision: 352106 URL: http://llvm.org/viewvc/llvm-project?rev=352106&view=rev Log: [WebAssembly] Add an import_module function attribute This adds a C/C++ attribute which corresponds to the LLVM IR wasm-import-module attribute. It allows code to spec

[PATCH] D57155: [WebAssembly] Add a __wasi__ target macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL352105: [WebAssembly] Add a __wasi__ target macro (authored by djg, committed by ). Changed prior to commit: https://reviews.llvm.org/D57155?vs=183306&id=183375#toc Repository: rL LLVM CHANGES SINCE

r352105 - [WebAssembly] Add a __wasi__ target macro

Author: djg Date: Thu Jan 24 13:05:11 2019 New Revision: 352105 URL: http://llvm.org/viewvc/llvm-project?rev=352105&view=rev Log: [WebAssembly] Add a __wasi__ target macro This adds a `__wasi__` macro for the wasi OS, similar to `__linux__` etc. for other OS's. Differential Revision: https://rev

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. In D56624#1369940 , @yln wrote: > Note that all of this currently only matters when compiling with > `-fsanitize=unreachable`. The following discussion is within the context of > the current implementation: UBSan removes the `noretur

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/Sema/SemaTemplate.cpp:6311 if (isa(E)) { - Converted = TemplateArgument(ArgResult.get()); + Converted = Templat

r352102 - Add a triple to this test so it passes for targets where alignof(double)

Author: rsmith Date: Thu Jan 24 12:52:56 2019 New Revision: 352102 URL: http://llvm.org/viewvc/llvm-project?rev=352102&view=rev Log: Add a triple to this test so it passes for targets where alignof(double) really should be equal to alignof(float). Modified: cfe/trunk/test/CXX/dcl.dcl/dcl.attr

[PATCH] D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends

arphaman updated this revision to Diff 183372. arphaman marked 3 inline comments as done. arphaman added a comment. Update for Ben's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56226/new/ https://reviews.llvm.org/D56226 Files: lib/Format/TokenAnnot

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. In D56411#1369906 , @yaxunl wrote: > In D56411#1365745 , @rjmccall wrote: > > > In D56411#1365727 , @yaxunl wrote: > > > > > In D56411#1360010

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

erik.pilkington added inline comments. Comment at: clang/lib/AST/Type.cpp:1295 + + QualType VisitObjCObjectType(const ObjCObjectType *objType) { +if (!objType->isKindOfType()) Does this works with type sugar? i.e. previously calling `Ty->getAs()` would have

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln added a comment. Note that all of this currently only matters when compiling with `-fsanitize=unreachable`. The following discussion is within the context of the current implementation: UBSan removes the `noreturn` so it can instrument `unreachable` without the added instrumentation being o

[PATCH] D57104: [AST] Pack GenericSelectionExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D57104#1369885 , @riccibruno wrote: > In D57104#1369864 , @steveire wrote: > > > Thanks, but I

[PATCH] D57057: [clangd] Log clang-tidy configuration, NFC

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57057/new/ https://reviews.llvm.org/D57057 __

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1365745 , @rjmccall wrote: > In D56411#1365727 , @yaxunl wrote: > > > In D56411#1360010 , @rjmccall > > wrote: > > > > > I think the diagno

[PATCH] D57154: [WebAssembly] Support __float128

This revision was automatically updated to reflect the committed changes. Closed by commit rC352100: [WebAssembly] Support __float128 (authored by djg, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D57154?vs=183302&id=183369#toc Repos

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM with nits about doxygen annotations. Comment at: clang/include/clang/Lex/DirectoryLookup.h:175 + /// \param [out] IsFrameworkFound For a framework directory set to tr

r352100 - [WebAssembly] Support __float128

Author: djg Date: Thu Jan 24 12:33:28 2019 New Revision: 352100 URL: http://llvm.org/viewvc/llvm-project?rev=352100&view=rev Log: [WebAssembly] Support __float128 This enables support for the "__float128" keyword. Differential Revision: https://reviews.llvm.org/D57154 Modified: cfe/trunk/li

r352099 - [WebAssembly] Factor commonality between wasm32 and wasm64 in test/Preprocessor/init.c

Author: djg Date: Thu Jan 24 12:31:11 2019 New Revision: 352099 URL: http://llvm.org/viewvc/llvm-project?rev=352099&view=rev Log: [WebAssembly] Factor commonality between wasm32 and wasm64 in test/Preprocessor/init.c Use the -check-prefixes= feature to merge most of the WEBASSEMBLY32 and WEBASSE

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. In D57104#1369864 , @steveire wrote: > Thanks, but I don't see the factored out changes in the repo. Are you going > to commit those first? > > Also, please factor out the introduction and use of `::Create`. It seems to > be u

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. Thanks, but I don't see the factored out changes in the repo. Are you going to commit those first? Also, please factor out the introduction and use of `::Create`. It seems to be unrelated to the trailing objects change. Repository: rC Clang CHANGES SINCE LAST ACTI

r352090 - [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

Author: lebedevri Date: Thu Jan 24 11:32:49 2019 New Revision: 352090 URL: http://llvm.org/viewvc/llvm-project?rev=352090&view=rev Log: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653 Differential Revision: https://reviews.llvm.org/D57175 Modified: cfe/trunk/test/

[PATCH] D57175: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

This revision was automatically updated to reflect the committed changes. Closed by commit rL352090: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653 (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D57155: [WebAssembly] Add a __wasi__ target macro

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. LGTM; don't forget to include all the context in the future Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57155/new/ https://reviews.llvm.org/D57155 __

[clang-tools-extra] r352088 - [clang-tidy] Rename the absl duration helper functions; NFC

Author: hwright Date: Thu Jan 24 11:23:50 2019 New Revision: 352088 URL: http://llvm.org/viewvc/llvm-project?rev=352088&view=rev Log: [clang-tidy] Rename the absl duration helper functions; NFC Modified: clang-tools-extra/trunk/clang-tidy/abseil/DurationComparisonCheck.cpp clang-tools-ext

[PATCH] D14686: Protect against overloaded comma in random_shuffle and improve tests

mclow.lists closed this revision. mclow.lists added a comment. Herald added a subscriber: llvm-commits. (Finally) committed this as revision 352087. I cut out most of the random_shuffle_rand.pass.cpp test, because it relied on C++11 features, and didn't work for C++03. If you want to re-submit th

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. In D56624#1369767 , @yln wrote: > In D56624#1369635 , @vsk wrote: > > > What are the advantages of a generalized expect_noreturn attribute, vs. a > > narrower attribute or intrinsic? The expect

[PATCH] D50452: [WIP] clangd XPC adapter

jkorous added a comment. Abandonned in favor of https://reviews.llvm.org/D54428 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50452/new/ https://reviews.llvm.org/D50452 ___ cfe-commits mailing list cfe-

[PATCH] D57175: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Self-accepting since D54653 got reviewed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57175/new/ https://reviews.ll

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

This revision was automatically updated to reflect the committed changes. Closed by commit rL352084: Add a priority field to availability attributes to prioritize explicit (authored by arphaman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r352084 - Add a priority field to availability attributes to prioritize explicit

Author: arphaman Date: Thu Jan 24 11:14:39 2019 New Revision: 352084 URL: http://llvm.org/viewvc/llvm-project?rev=352084&view=rev Log: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute' Before this comm

  1   2   >