[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353142: [X86] Change MS inline asm clobber list filter to check for 'fpsr' instead of… (authored by ctopper, committed by ). Herald added a project: LLVM. Repository: rL LLVM CHANGES SINCE LAST ACTION

r353142 - [X86] Change MS inline asm clobber list filter to check for 'fpsr' instead of 'fpsw' after D57641.

Author: ctopper Date: Mon Feb 4 22:13:14 2019 New Revision: 353142 URL: http://llvm.org/viewvc/llvm-project?rev=353142&view=rev Log: [X86] Change MS inline asm clobber list filter to check for 'fpsr' instead of 'fpsw' after D57641. Summary: The backend used to print the x87 FPSW register as 'fp

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: clang. implements llvm intrinsics and clang intrinsics for memory.init and data.drop. Repository: rG LLVM Git

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 185233. Quuxplusone added a subscriber: AlisdairM. Quuxplusone added a comment. Rebased on master. @EricWF (cc @AlisdairM) ping! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 185229. Quuxplusone added a subscriber: AlisdairM. Quuxplusone added a comment. Rebased on master. @ericwf (cc @AlisdairM) ping! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47111/new/ https://reviews.llvm.org/D47111

[libunwind] r353137 - [CMake] Update lit test configuration

Author: phosek Date: Mon Feb 4 20:44:03 2019 New Revision: 353137 URL: http://llvm.org/viewvc/llvm-project?rev=353137&view=rev Log: [CMake] Update lit test configuration There are several changes: - Don't stringify Pythonized bools (that's why we're Pythonizing them) - Support specifying target

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone updated this revision to Diff 185225. Quuxplusone added a comment. Rebased on master. @EricWF ping! It's been quite a few months... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47344/new/ https://reviews.llvm.org/D47344 Files: src/experimental/

[PATCH] D57732: Correct inf typo

gaul created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D57732 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: clang/include/clang/Format/Forma

[PATCH] D57668: [opaque pointer types] Pass function types for runtime function calls.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Great - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57668/new/ https://reviews.llvm.org/D57668

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

glandium updated this revision to Diff 185218. glandium edited the summary of this revision. glandium added a comment. Updated EmitAArch64BuiltinExpr per https://reviews.llvm.org/D57636#1383751 and the testcase per https://reviews.llvm.org/D57636#1384348 Repository: rC Clang CHANGES SINCE LA

[PATCH] D57640: [NewPM][MSan] Add Options Handling

chandlerc added a comment. Minor past-commit nit. Comment at: lib/CodeGen/BackendUtil.cpp:1039 [](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) { - FPM.addPass(MemorySanitizerPass()); + FPM.addPass(MemorySanitizerPass({}

[PATCH] D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases.

jyknight marked an inline comment as done. jyknight added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3837 +// having pointee types). +llvm::FunctionType *IRFuncTyFromInfo = getTypes().GetFunctionType(CallInfo); +assert(IRFuncTy == IRFuncTyFromInfo); --

[PATCH] D57668: [opaque pointer types] Pass function types for runtime function calls.

jyknight marked an inline comment as done. jyknight added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1028-1030 +llvm::Constant *getPropertyFn = cast( +CGM.getObjCRuntime().GetPropertyGetFunction().getCallee()); if (!getPropertyFn) { ---

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: lib/AST/Stmt.cpp:457-460 this->NumOutputs = NumOutputs; this->NumInputs = NumInputs; this->NumClobbers = NumClobbers; + this->NumLabels = NumLabels; jyu2 wrote: > rsmith wrote: > > Please assert that you don't h

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:457-460 this->NumOutputs = NumOutputs; this->NumInputs = NumInputs; this->NumClobbers = NumClobbers; + this->NumLabels = NumLabels; rsmith wrote: > Please assert that you don't have both outputs a

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185206. jyu2 marked 8 inline comments as done. jyu2 added a comment. More review comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h include/clang/Basic/Diagn

[PATCH] D57722: [Clang][NCF] Sanitizer options: helpers to check if {Kernel, Hardware}ASan is enabled

eugenis added a comment. I find the current code more readable than with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57722/new/ https://reviews.llvm.org/D57722 ___ cfe-commits mailing li

[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57642/new/ https://reviews.llvm.org/D57642 ___ cfe-commits maili

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

NoQ added a comment. Dunno but made a random guess in the inline comment. Comment at: docs/analyzer/checkers.rst:1946 +Checkers used for debugging the analyzer. +:doc:`DebugChecks` page contains a detailed description. + The error is on this line. It might be t

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added a comment. I'm getting a single buildbot failure, but I'm a little unsure how to fix it. Could you help? http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/36985 24.610 [1/1/1] Generating html Sphinx documentation for clang into "/home/buildbot/llvm-build-dir/clang-sp

[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

craig.topper updated this revision to Diff 185201. craig.topper added a comment. Keep the filter on fpsw, but change the string to fpsr Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57642/new/ https://reviews.llvm.org/D57642 Files: lib/Parse/ParseStmtAsm.cpp

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 185196. domdom added a comment. Switched getIndexOfLastNonNullStmt to return Optional instead of Stmt* as per comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 Files: clang/include/clang/AST/Stmt.

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

efriedma added a comment. In test/CodeGen/arm64-microsoft-status-reg.cpp, you can write something like `// CHECK-IR: %[[VAR:.*]] = call i64 @llvm.read_register.i64(metadata ![[MD2:.*]])`, then `// CHECK-IR-NEXT: store i64 %[[VAR]]` on the next line. See also http://llvm.org/docs/CommandGuide/Fi

[PATCH] D57722: [Clang][NCF] Sanitizer options: helpers to check if {Kernel, Hardware}ASan is enabled

vsk added reviewers: eugenis, kcc. vsk added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.h:89 + /// * Hardware Kernel ASan + bool hasASanOrKASanOrHWASanOrHWKASan() const { +return hasASanOrKASan() || hasHWASanOrHWKASan(); Sorry to bike

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

glandium added a comment. In D57636#1383566 , @efriedma wrote: > (It should be possible to check that we aren't inserting incorrect > truncation/extension operations in the IR.) I don't know how to do that. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D57722: [Clang][NCF] Sanitizer options: helpers to check if {Kernel, Hardware}ASan is enabled

yln created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Kernel ASan is basically ASan with a few specific settings, but has a seperate front-end flag. Provide a helper that checks for both, so new comitters like myself are less likely to forget the Kernel

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added inline comments. Comment at: lib/Sema/JumpDiagnostics.cpp:347 + LabelAndGotoScopes[S] = ParentScope; + Jumps.push_back(S); +} jyu2 wrote: > efriedma wrote: > > This doesn't look right; I think we need to add it to IndirectJumps > > i

[PATCH] D57711: [Sanitizers] UBSan unreachable incompatible with Kernel ASan

This revision was automatically updated to reflect the committed changes. Closed by commit rC353120: [Sanitizers] UBSan unreachable incompatible with Kernel ASan (authored by yln, committed by ). Changed prior to commit: https://reviews.llvm.org/D57711?vs=185153&id=185178#toc Repository: rC

r353120 - [Sanitizers] UBSan unreachable incompatible with Kernel ASan

Author: yln Date: Mon Feb 4 15:37:50 2019 New Revision: 353120 URL: http://llvm.org/viewvc/llvm-project?rev=353120&view=rev Log: [Sanitizers] UBSan unreachable incompatible with Kernel ASan Summary: This is a follow up for https://reviews.llvm.org/D57278. The previous revision should have also i

[PATCH] D56555: Add Attribute to define nonlazy objc classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL353116: [OBJC] Add attribute to mark Objective C class as non-lazy (authored by joseph_daniels, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D57712: [SemaObjC] Don't infer the availabilty of messages to +new from -init if the receiver has Class type

This revision was automatically updated to reflect the committed changes. Closed by commit rC353115: [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has… (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D57712?vs=185150&id=185175#to

r353115 - [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has Class type

Author: epilk Date: Mon Feb 4 15:30:57 2019 New Revision: 353115 URL: http://llvm.org/viewvc/llvm-project?rev=353115&view=rev Log: [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has Class type rdar://47713266 Differential revision: https://reviews.llvm.org/D57712 Mo

[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

rnk added inline comments. Comment at: lib/Parse/ParseStmtAsm.cpp:637-639 // constraints. Clang always adds fpsr to the clobber list anyway. llvm::erase_if(Clobbers, [](const std::string &C) { +return C == "mxcsr"; In light of this comment about "clang

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

rsmith added a comment. In D57626#1382391 , @Quuxplusone wrote: > I admit that this `lock_guard` example is contrived and generally ill-advised > , > but its ill-advisedne

[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: test/CodeGen/ms-inline-asm.c:574 // CHECK: fistp dword ptr $0 -// CHECK: "=*m,*m,~{dirflag},~{fpsr},~{flags}"(i32* %{{.*}}, float* %{{.*}}) +// CHECK: "=*m,*m,~{fpsr},~{dirflag},~{fpsr

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

Quuxplusone added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2953 + "have bases of non-trivial class types|have virtual bases|" + "have __weak fields under ARC|have fields of non-trivial class types}0">; nit: "of non-trivial class

[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

rnk added inline comments. Comment at: test/CodeGen/ms-inline-asm.c:574 // CHECK: fistp dword ptr $0 -// CHECK: "=*m,*m,~{dirflag},~{fpsr},~{flags}"(i32* %{{.*}}, float* %{{.*}}) +// CHECK: "=*m,*m,~{fpsr},~{dirflag},~{fpsr},~{flags}"(i32* %{{.*}}, float* %{{.*}}) } --

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak updated this revision to Diff 185157. ahatanak added a comment. Add a note diagnostic to inform the user of the reason for not allowing annotating a class with `trivial_abi`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57626/new/ https://reviews.llvm.

[PATCH] D57716: Let AMDGPU compile MSVC headers containing vectorcall

yaxunl created this revision. yaxunl added a reviewer: rjmccall. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. MSVC header files using vectorcall to differentiate overloaded functions, which causes failure for AMDGPU target. Let AMDGPU target recognize vector

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: leonardchan wrote: > rjmccall wrote: > > leonardchan wrote: > > > rjmccall wrote: > > > > Are pa

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added a comment. I'll do the honors. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54429/new/ https://reviews.llvm.org/D54429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: lib/AST/Stmt.cpp:457-460 this->NumOutputs = NumOutputs; this->NumInputs = NumInputs; this->NumClobbers = NumClobbers; + this->NumLabels = NumLabels; Please assert that you don't have both outputs and labels here

[PATCH] D57711: [Sanitizers] UBSan unreachable incompatible with Kernel ASan

eugenis accepted this revision. eugenis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57711/new/ https://reviews.llvm.org/D57711 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Bump! Thanks for the consideration CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked 2 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/JumpDiagnostics.cpp:347 + LabelAndGotoScopes[S] = ParentScope; + Jumps.push_back(S); +} efriedma wrote: > This doesn't look right; I think we need to add it to I

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Thanks for the consideration. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D57711: [Sanitizers] UBSan unreachable incompatible with Kernel ASan

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, thanks. It might make sense to add a predicate to SanitizerSet to make it easier to check when ASan is enabled, either pre-commit or as a follow-up. Repository: rG LLVM Github Monorepo CHA

[PATCH] D57712: [SemaObjC] Don't infer the availabilty of messages to +new from -init if the receiver has Class type

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57712/new/ https://reviews.llvm.org/D57712 ___ c

[PATCH] D57712: [SemaObjC] Don't infer the availabilty of messages to +new from -init if the receiver has Class type

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Fixes rdar://47713266 Thanks for taking a look! Erik Repository: rC Clang https://reviews.llvm.org/D57712 Files: clang/lib/Sema/

[PATCH] D57711: [Sanitizers] UBSan unreachable incompatible with Kernel ASan

yln created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow up for https://reviews.llvm.org/D57278. The previous revision should have also included Kernel ASan. rdar://problem/40723397 Repository: rG LLVM Github Monorepo https://reviews.

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185148. MyDeveloperDay edited the summary of this revision. MyDeveloperDay added a comment. Address review comments Add support for additional StringLiterals,CharacterLiterals,UserDefinedLiterals and NullPtrs Simplify the Options names from "AddCommen

[PATCH] D57668: [opaque pointer types] Pass function types for runtime function calls.

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1028-1030 +llvm::Constant *getPropertyFn = cast( +CGM.getObjCRuntime().GetPropertyGetFunction().getCallee()); if (!getPropertyFn) { This code looks like it implies that the

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added inline comments. Comment at: lib/Sema/JumpDiagnostics.cpp:347 + LabelAndGotoScopes[S] = ParentScope; + Jumps.push_back(S); +} This doesn't look right; I think we need to add it to IndirectJumps instead. This probably impacts a testc

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

efriedma added a comment. Yes, we should fix CodeGenFunction::EmitAArch64BuiltinExpr to eliminated the unnecessary calls to CreateZext/CreateTrunc. (With this patch, they're no-ops, but better to clean up the code.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D57665: [clang-tidy] Handle unions with existing default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353092: [clang-tidy] Handle unions with existing default-member-init (authored by malcolm.parsons, committed by ). Changed prior to commit: https://reviews.llvm.org/D57665?vs=184976&id=185141#toc Rep

[clang-tools-extra] r353092 - [clang-tidy] Handle unions with existing default-member-init

Author: malcolm.parsons Date: Mon Feb 4 13:09:31 2019 New Revision: 353092 URL: http://llvm.org/viewvc/llvm-project?rev=353092&view=rev Log: [clang-tidy] Handle unions with existing default-member-init Summary: clang-tidy's modernize-use-default-member-init was crashing for unions with an existi

[PATCH] D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems reasonable to me - but if you like you can wait for Richard who might have a more nuanced understanding of the code. (but I'm OK signing off on this if you are & Richard can provide

r353090 - [NewPM][MSan] Add Options Handling

Author: pfaffe Date: Mon Feb 4 13:02:49 2019 New Revision: 353090 URL: http://llvm.org/viewvc/llvm-project?rev=353090&view=rev Log: [NewPM][MSan] Add Options Handling Summary: This patch enables passing options to msan via the passes pipeline, e.e., -passes=msan. Reviewers: chandlerc, fedor.se

[PATCH] D57640: [NewPM][MSan] Add Options Handling

This revision was automatically updated to reflect the committed changes. Closed by commit rC353090: [NewPM][MSan] Add Options Handling (authored by pfaffe, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D

Re: r351629 - Emit !callback metadata and introduce the callback attribute

Should be fixed in r353088 (git c3707cc5d91). Can you verify it now is as you expect it? From: Eli Friedman Sent: Thursday, January 31, 2019 18:17 To: Doerfert, Johannes; Chandler Carruth; cfe-commits@lists.llvm.org Cc: Raja Venkateswaran Subject: RE: r351629 - Em

r353088 - Generalize pthread callback test case

Author: jdoerfert Date: Mon Feb 4 12:42:38 2019 New Revision: 353088 URL: http://llvm.org/viewvc/llvm-project?rev=353088&view=rev Log: Generalize pthread callback test case Changes suggested by Eli Friedman Modified: cfe/trunk/test/CodeGen/callback_pthread_create.c Modified: cfe/trunk/tes

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57690/new/ https://reviews.llvm.org/D57690 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 updated this revision to Diff 185125. kkwli0 marked an inline comment as done. kkwli0 added a comment. Update based on review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57690/new/ https://reviews.llvm.org/D57690 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/Ope

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7070 const auto *OED = dyn_cast(*I); -if (!OED || !isOpenMPTeamsDirective(OED->getDirectiveKind())) { +if (!OED || !isOpenMPTeamsDirective(OED

[PATCH] D40815: [libcxxabi] Use the correct variable name for target triple in lit

phosek abandoned this revision. phosek added a comment. Herald added subscribers: libcxx-commits, ldionne. This is no longer needed after D57670 landed. Repository: rCXXA libc++abi CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40815/new/ https://revi

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek abandoned this revision. phosek added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This is no longer needed after D57670 landed. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40816/new/

[PATCH] D40814: [libcxx] Use the correct variable name for target triple in lit

phosek abandoned this revision. phosek added a comment. Herald added subscribers: libcxx-commits, ldionne. This is no longer needed after D57670 landed. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40814/new/ https://reviews.

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

TomTan added a comment. Thanks for finding out and fixing this. Seems there is also issue in expanding `_WriteStatusReg` in `CodeGenFunction::EmitAArch64BuiltinExpr`. The last argument for `_WriteStatusReg` is __zero extended__ to `__in64`, which is not expected (see below link). https://githu

[PATCH] D57631: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

TomTan added a comment. In D57631#1381806 , @efriedma wrote: > LGTM Thanks Eli. Could you please help commit this change when it is ready? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57631/new/ https://reviews.llvm.or

[libunwind] r353084 - [CMake] Support CMake variables for setting target, sysroot and toolchain

Author: phosek Date: Mon Feb 4 12:02:26 2019 New Revision: 353084 URL: http://llvm.org/viewvc/llvm-project?rev=353084&view=rev Log: [CMake] Support CMake variables for setting target, sysroot and toolchain CMake has a standard way of setting target triple, sysroot and external toolchain through

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

rjmccall added a comment. Richard felt that this was an odd special case, and I was happy to use the old language-designer's dodge of banning something today so that we can decide to allow it tomorrow. This isn't SFINAE-able. ...of course, if it's just a *warning* that this isn't allowed, that

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57524/new/ https://reviews.llvm.org/D57524 ___ cfe-commits mailing list cfe-comm

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

aaron.ballman added a comment. Can you drop the file mode changes that are in this review? Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:292-293 +// If the argument comments are missing for literals add them. +if (Comments.empty()) { + if (((isa(Args[I])

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:82 +- The :doc:`bugprone-argument-comment + ` now supports Please move changes in existing checks after list of new checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57674/n

[PATCH] D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353079: [clang-tidy] Add the abseil-duration-unnecessary-conversion check (authored by hwright, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D57353

[clang-tools-extra] r353079 - [clang-tidy] Add the abseil-duration-unnecessary-conversion check

Author: hwright Date: Mon Feb 4 11:28:20 2019 New Revision: 353079 URL: http://llvm.org/viewvc/llvm-project?rev=353079&view=rev Log: [clang-tidy] Add the abseil-duration-unnecessary-conversion check Differential Revision: https://reviews.llvm.org/D57353 Added: clang-tools-extra/trunk/clang

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. In D56935#1382156 , @philip.pfaffe wrote: > Landed it for you in r352972. Thanks! Great, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 _

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked 12 inline comments as done. jyu2 added inline comments. Comment at: include/clang/AST/Stmt.h:1008 + (*iterator_adaptor_base::I)->getStmtClass() <= lastExprConstant); + return *reinterpret_cast(iterator_adaptor_base::I); } rsmith

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

efriedma added a comment. How do we actually want this to work for LTO? Would it make sense to encode this on global variables somehow, to allow different thresholds for different source files? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://r

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185094. jyu2 added a comment. 1> Add code for scope checking 2> Using CastInterator 3> CFG change to remove duplicate Block list CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

efriedma added a subscriber: TomTan. efriedma added a comment. Missing testcase changes. (It should be possible to check that we aren't inserting incorrect truncation/extension operations in the IR.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57636/new/ http

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

nemanjai updated this revision to Diff 185093. nemanjai added a comment. Changed the option to standard C++ rather than GNU extensions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57581/new/ https://reviews.llvm.org/D57581 Files: test/CodeCompletion/crash-sk

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai updated this revision to Diff 185088. nemanjai added a comment. As mentioned in a comment, the WASM tests weren't really meant to indicate that WASM supports the type. Removed the changes to the WASM target. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 commandeered this revision. jyu2 edited reviewers, added: craig.topper; removed: jyu2. jyu2 added inline comments. Comment at: lib/Analysis/CFG.cpp:2126 + if (cast(S)->isGCCAsmGoto()) +return VisitGCCAsmStmt(cast(S)); + return VisitStmt(S, asc); ---

[PATCH] D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp:50 + + diag(OuterCall->getBeginLoc(), "remove double conversion of absl::Duration") + << FixIt

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis updated this revision to Diff 185087. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 Files: clang-tidy/tool/clang-tidy-diff.py Index: clang-tidy/tool/clang-tidy-diff.py ===

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis updated this revision to Diff 185085. zinovy.nis added a comment. Fixed minor typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 Files: clang-tidy/tool/clang-tidy-diff.py Index: clang-tidy/tool/clang-tidy-diff.py ==

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } ebevhan wrote: > Anastasia wrote: > > ebevhan wrote: > > > Anastasia wrote: > > > > Anastasia wrote: > > > > > ebevhan wrote: >

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7070 const auto *OED = dyn_cast(*I); -if (!OED || !isOpenMPTeamsDirective(OED->getDirectiveKind())) { +if (!OED || !isOpenMPTeamsDirective(OED->getDirectiveKind()) || +(i

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

This revision was automatically updated to reflect the committed changes. Closed by commit rL353054: [clangd] Enable include insertion for static index (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[clang-tools-extra] r353054 - [clangd] Enable include insertion for static index

Author: kadircet Date: Mon Feb 4 08:19:57 2019 New Revision: 353054 URL: http://llvm.org/viewvc/llvm-project?rev=353054&view=rev Log: [clangd] Enable include insertion for static index Summary: This enables include insertion by adding canonical includes into preambledata. Reviewers: ioeric, ily

[PATCH] D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check

hwright added a comment. @hokein Thanks for the suggestion on the name, I was looking for something a little less confusing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57353/new/ https://reviews.llvm.org/D57353 ___ cfe-commits mailing l

[PATCH] D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check

hwright updated this revision to Diff 185057. hwright marked 4 inline comments as done. hwright retitled this revision from "[clang-tidy] Add the abseil-duration-double-conversion check" to "[clang-tidy] Add the abseil-duration-unnecessary-conversion check". hwright added a comment. Renamed to `

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 created this revision. kkwli0 added a reviewer: ABataev. Herald added a subscriber: guansong. The compiler does not generate any error messages if there are more than one teams construct inside a target constructs. #pragma omp target { #pragma omp teams { ... } #pragm

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

kadircet updated this revision to Diff 185052. kadircet added a comment. - Delete unnecessary include Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57508/new/ https://reviews.llvm.org/D57508 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

kadircet marked an inline comment as done. kadircet added a comment. I don't think so, since the only reason this already wasn't enabled was because there was a fixme ? Also we want people to use -background-index by default in future so I think it should be OK Repository: rCTE Clang Tools E

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler created this revision. rdwampler added reviewers: djasper, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option `AllowShortLambdasOnASingleLine` similar to the other `AllowShort*` options, but applied to C++ lambdas. I considered making this depend

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11748 +/// The expressions corresponding to each usage kind. +Expr *UsageExprs[UK_Count]{}; + aaron.ballman wrote: > You can drop the `{}`

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm. Note that this will enable include insertions for everyone (even without index switched on). Not sure if we should provide options. Comment at: clangd/ClangdServer.cp

[PATCH] D57660: [Sema] SequenceChecker: Handle references and members

riccibruno updated this revision to Diff 185048. riccibruno added a comment. Added tests for nested/anonymous unions and local structs. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files: include/clang/Basic/Diagnost

  1   2   >