[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

lebedev.ri added a comment. In D54399#1391935 , @shuaiwang wrote: > Hi @rsmith what do you think of just get this in since Eric is not > responding? Or do you think I should run certain test to verify? I'm having a déjà vu. Wasn't there already an attem

r353635 - Use llvm::is_contained. NFC

Author: maskray Date: Sat Feb 9 21:54:57 2019 New Revision: 353635 URL: http://llvm.org/viewvc/llvm-project?rev=353635&view=rev Log: Use llvm::is_contained. NFC Modified: cfe/trunk/lib/ARCMigrate/ARCMT.cpp cfe/trunk/lib/AST/RecordLayoutBuilder.cpp cfe/trunk/lib/Basic/TargetInfo.cpp

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initializer

phosek updated this revision to Diff 186142. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58010/new/ https://reviews.llvm.org/D58010 Files: clang/lib/CodeGen/CGVTables.cpp clang/test/CodeGen/construction-vtable-visibility.cpp Index: clang/t

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initializer

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm with a comment (and perhaps an assertion). Comment at: clang/lib/CodeGen/CGVTables.cpp:777 + CGM.setGVProperties(VTable, RD); + Give it a comment

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initialize

phosek created this revision. phosek added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We must only set the construction vtable visibility after we create the vtable initializer, otherwise the global value will be treated as declaration rather than de

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added a comment. In D56370#1390359 , @sammccall wrote: > - in 'XRefs.h', I think the API to introduce is `findTypeAt(Position) -> > Decl*` + `typeAncestors(Decl*)` and later `typeDescendants(Decl*)`, rather > than a single more complex `typeHiera

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. Herald added a project: clang. Hi @rsmith what do you think of just get this in since Eric is not responding? Or do you think I should run certain test to verify? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54399/new/ https://reviews

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 186139. nridge added a comment. Introduce and use findRecordTypeAt() and typeAncestors() helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 Files: clang-tools-ext

[PATCH] D57896: Variable names rule

hubert.reinterpretcast added a comment. In D57896#1391611 , @zturner wrote: > Is this actually any better? Whereas before we can’t differentiate type > names and variable names, under this proposal we can’t differentiate type > names and function names.

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added a comment. In D56370#1390359 , @sammccall wrote: > So on a concrete but still high-level: > > - I don't think we should implement the `resolve` operation, or resolution > bounds, at this point - this patch doesn't do anything slow. Returning

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 186137. nridge marked 4 inline comments as done. nridge added a comment. Address Kadir's review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 Files: clang-t

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge marked 19 inline comments as done. nridge added a comment. Thank you for the reviews! Comment at: clang-tools-extra/clangd/Protocol.h:1026 + /// When not defined, it is treated as `0`. + llvm::Optional resolve; + kadircet wrote: > why not just use an i

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added a comment. In D56370#1391904 , @nridge wrote: > Add tests for scenarios involving class template specializations > > Also improve support for dependent bases (This update is unrelated to the review comments, it's just improvements I had in

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 186136. nridge added a comment. Add tests for scenarios involving class template specializations Also improve support for dependent bases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews

[PATCH] D54978: Move the SMT API to LLVM

Szelethus added a comment. In D54978#1391785 , @thakis wrote: > In D54978#1391436 , @mikhail.ramalho > wrote: > > > Hi everyone, I just saw your messages and reverted the commits. > > > > Sorry for the inconvenienc

[PATCH] D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353629: [opaque pointer types] Cleanup CGBuilder's Create*GEP. (authored by jyknight, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

r353629 - [opaque pointer types] Cleanup CGBuilder's Create*GEP.

Author: jyknight Date: Sat Feb 9 14:22:28 2019 New Revision: 353629 URL: http://llvm.org/viewvc/llvm-project?rev=353629&view=rev Log: [opaque pointer types] Cleanup CGBuilder's Create*GEP. The various EltSize, Offset, DataLayout, and StructLayout arguments are all computable from the Address's e

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus accepted this revision. Szelethus added a comment. This looks great, thanks! I'll commit sometime tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 ___ cfe-commits mailing list cfe-

[PATCH] D33841: [clang-tidy] redundant keyword check

Eugene.Zelenko added a comment. Please mention new check in Release Notes. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:55 +} // namespace clang \ No newline at end of file Please add new line. Comment at: clang-tidy/readabili

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel updated this revision to Diff 186132. koldaniel added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33841 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/re

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel updated this revision to Diff 186131. koldaniel added a comment. Rebased. Documentation added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checkers/Checkers.td li

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

jfb added a comment. In D44248#1391798 , @matthewbauer wrote: > This appears to be adding atomic on macOS builds, which shouldn't be > happening: > > https://hydra.nixos.org/build/88290234/ > > HAVE_CXX_ATOMICS64_WITHOUT_LIB is never being set. Odd. ma

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

matthewbauer added a comment. Herald added subscribers: kadircet, jfb, arphaman, atanasyan, jkorous. Herald added a project: LLVM. This appears to be adding atomic on macOS builds, which shouldn't be happening: https://hydra.nixos.org/build/88290234/ HAVE_CXX_ATOMICS64_WITHOUT_LIB is never being

[PATCH] D54978: Move the SMT API to LLVM

thakis added a comment. In D54978#1391436 , @mikhail.ramalho wrote: > Hi everyone, I just saw your messages and reverted the commits. > > Sorry for the inconvenience, but for some reason I didn't get any email from > the bots. Could you send me the link

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel added a comment. In D35068#1391758 , @Szelethus wrote: > Hmmm, `DescFile` was removed months ago from `Checkers.td`, are you sure you > uploaded the correct diff? No, you are absolutely right, an earlier diff had been uploaded, I will correct

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus added a comment. Hmmm, `DescFile` was removed months ago from `Checkers.td`, are you sure you uploaded the correct diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 ___ cfe-commits mai

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel updated this revision to Diff 186115. koldaniel added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

mgorny added a comment. Submitted a fix as D57996 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57063/new/ https://reviews.llvm.org/D57063 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin added a comment. @hfinkel There are changes in this patch, as well as its LLVM counterpart D53927 . Please, re-review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/ https://reviews.llvm.org/D53928 _

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin requested changes to this revision. rengolin added a comment. This revision now requires changes to proceed. Since the previous version was approved already, I'm "requesting changes" so that we can look at it again, together with D53927 to make sure it'

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

MyDeveloperDay added inline comments. Herald added a project: clang. Comment at: clang-tidy/cppcoreguidelines/MixedIntArithmeticCheck.h:1 +//===--- MixedIntArithmeticCheck.h - clang-tidy--*- C++ -*-===// +// I guess the license has to be updated